2 Commits (2edd9f4e10faf38e65d5fc5ce4e29c3c4e3b59b0)

Author	SHA1	Message	Date
Martin Atkins	aa414f3ab3	refactoring: First round of ValidateMoves rules ... This is a first pass at implementing refactoring.ValidateMoves, covering the main validation rules. This is not yet complete. A couple situations not yet covered are represented by commented test cases in TestValidateMoves, although that isn't necessarily comprehensive. We'll do a further pass of filling this out with any other subtleties before we ship this feature.	5 years ago
Martin Atkins	51346f0d87	instances: Expander.AllInstances ... In order to precisely implement the validation rules for "moved" statements we need to be able to test whether particular instances were declared in the configuration. The instance expander is the source of record for which instances we decided while creating a plan, but it's API is far more involved than what our validation rules need, so this new AllInstances method returns a wrapper object with a more straightforward API that provides read-only access to just the question of whether particular instances got registered in the expander already. This API covers all three of the kinds of objects that move statements can refer to. It includes module calls and resources, even though they aren't _themselves_ "instances" in the sense we usually mean, because the module instance addresses they are contained within _are_ instances and so we need to take their dynamic instance keys into account when answering these queries.	5 years ago