247 Commits (2cbb6bf92fce17e8de5e681dcc47ed85f32e9b23)

Author	SHA1	Message	Date
Martin Atkins	49d7c879ac	Fix problems caught by staticcheck v0.3.0 ... This will allow us to upgrade to this version in a later commit without causing the our build checks to fail.	4 years ago
Sebastian Rivera	a52c87cb5a	Fix a flaky test manipulating environment variables ... This test resolves an issue where variables were going unset causing leaks into other test cases and therefore resulting in failures.	4 years ago
Sebastian Rivera	232d48fe00	Add support for TF_HOSTNAME env var	4 years ago
Sebastian Rivera	b1c22d333e	Fix error formatting for missing env and config value ... We previously used to throw an error denoting where in the configuration the attribute was missing or invalid. Considering that organization can be now be omitted from the configuration, our previous error message will be improperly formatted. This commit also updates the message to mention `TF_ORGANIZATION` as a valid substitute if organization is missing or invalid in the configuration.	4 years ago
Sebastian Rivera	45357f5004	Add TF_ORGANIZATION env var support ... TF_ORGANIZATION will serve as a fallback for configuring the organization in the `cloud` block. This is the first step to make it easier for users wanting to configure Terraform programmatically.	4 years ago
Luces Huayhuaca	bdc7d8c0a1	Upgrade go-tfe dependency to use 1.0 version. It contains breaking changes, so we are updating method signatures, method names and the type of optional parameters, as needed. (#30626)	4 years ago
Theo Chupp	d15a2bc024	fix: local variables should not be overridden by remote variables during `terraform import` (#29972) ... * fix: local variables should not be overridden by remote variables during `terraform import` * chore: applied the same fix in the 'internal/cloud' package * backport changes from cloud package to remote package Co-authored-by: Alisdair McDiarmid <alisdair@users.noreply.github.com> Co-authored-by: uturunku1 <luces.huayhuaca@gmail.com>	4 years ago
Sebastian Rivera	52c5f9f6b7	Updated for latest go-tfe run task changes	4 years ago
Sebastian Rivera	126d6df088	Added run task support for post plan run stage, removed pre apply ... This commit stems from the change to make post plan the default run task stage, at the time of this commit's writing! Since pre apply is under internal revision, we have removed the block that polls the pre apply stage until the team decides to re-add support for pre apply run tasks.	4 years ago
uturunku1	383da4893b	use new enum string for task stages	4 years ago
Brandon Croft	aa0dda81b4	Fall back to reading latest run without task_stages ... Older versions of TFE will not allow "task_stages" as an include parameter. In this case, fall back to reading the Run without additional options.	4 years ago
uturunku1	a9da859ee5	rename variables to something more descriptive	4 years ago
uturunku1	77946af472	pull latest changes from go-tfe branch and use use new field name that previously was incorrectly named TaskStage	4 years ago
uturunku1	8090b23db7	delete unused function	4 years ago
Brandon Croft	0b8bb29a61	[cloud] refactor integration context and add code documentation	4 years ago
Brandon Croft	791c36c504	[cloud] report run tasks by name instead of assuming pre_apply	4 years ago
uturunku1	6b5da4d43c	[cloud] run tasks output formatting	4 years ago
Brandon Croft	2938ec43fa	[cloud] handle unreachable run tasks	4 years ago
uturunku1	3e9ae69a12	[cloud] run tasks integration ... This change will await the completion of pre-apply run tasks if they exist on a run and then report the results. It also adds an abstraction when interacting with cloud integrations such as policy checking and cost estimation that simplify and unify output, although I did not go so far as to refactor those callers to use it yet.	4 years ago
Barrett Clark	d196d2870a	Refactor cloud table test runs ... As the cloud e2e tests evolved some common patters became apparent. This standardizes and consolidates the patterns into a common test runner that takes the table tests and runs them in parallel. Some tests also needed to be converted to utilize table tests.	4 years ago
Barrett Clark	c647b41d65	Add parallelism back into the tests ... Running tests in parallel can help speed up overall test execution. Go blocks parent tests while child tests run, so it does not fully fan out as you might expect. It is noticably faster, though. Running 4 or more concurrent processes knocks over a minute off the total execution time.	4 years ago
Barrett Clark	7aeaec9b48	Update tests for new prompts ... * Remove double question to migrate * Remove parallelism (it has been flaky) * Add subtests to apply_auto_approve_test (it was overlooked before)	4 years ago
Barrett Clark	27aa51687e	Fix cloud e2e tests for updated migration flow	4 years ago
Martin Atkins	bac59d2480	command/init: Be explicit that some options are not relevant for Cloud ... There are a few command line options for "terraform init" which are only relevant when working with traditional backends, with the Cloud integration previously just mostly ignoring them, or sometimes misbehaving slightly due to them creating an unreasonable situation. Now we'll catch these and return explicit errors, in order to be clear that these options are not needed nor supported in Cloud mode.	4 years ago
Martin Atkins	c28b57b4d6	cloud/e2e: Additional context for failing to find expected output ... This just gives a little extra information to work with when trying to understand why a test failed. It doesn't change what any of the tests are actually trying to test.	4 years ago
Martin Atkins	e5172fea95	cloud: DetectConfigChangeType helper ... This aims to encapsulate the somewhat-weird logic we currently use to distinguish between the various "terraform init" situations involving Terraform Cloud mode, in the hope of making codepaths that branch based on this slightly easier to read. This isn't yet used, but uses of it will follow in subsequent commits.	4 years ago
Barrett Clark	a146a2746e	Add clarifying commend and e2e test ... This pull request focuses on removing the prompt to rename the default workspace when it is empty. Functionality already exists to not migrate an empty workspace. This commit adds some clarifying language in the comment where we do the evaluation to know whether to ask for a new name or not. I also added an end to end test, which I should have added to begin with.	4 years ago
Omar Ismail	9b675f8b70	Add skip for cloud e2e tests when env vars missing	5 years ago
Omar Ismail	57a4b51e87	remove build tags for cloud e2e	5 years ago
Barrett Clark	5ef82ddd2f	Cloud: fix e2e tests ... - Fix tests and remove commented code - Remove parallel for some flaky tests - Add README	5 years ago
Brandon Croft	1f01ba4dbc	fix(run variables): support all variable types (map, list, bool, number, null, string) ... All run variables remain encoded as strings in the API but will now be expressed as an HCL value to be evaluated correctly by the remote terraform. Previously, only strings were supported. Examples: string: `"quoted literal"` (strings must be quoted) map: `{ foo = "bar" }` list: `["foo", "bar"]` bool: `true` null: `null` number: `0.0001` This requires the API to anticipate that all run variables will be HCL values	5 years ago
Brandon Croft	9441666d9a	Merge pull request #29903 from hashicorp/pull-mock-gotfe-changes ... Pull changes made to mocks in go-tfe	5 years ago
Chris Arcand	21750037d5	cloud: Help output typos	5 years ago
uturunku1	58304b678c	import path to go mocks in tfe	5 years ago
Luces Huayhuaca	4e3218b4d5	cloud: convert uses of worspaces.operations into workspaces.executionMode (#29844) ... * convert uses of worspaces.operations into workspaces.executionMode The cloud package currently uses a deprecated API on workspaces to determine a workspace's execution mode. Deprecated: Operations (boolean) New hotness: Execution mode (string - "local", "remote", or "agent") More details: https://www.terraform.io/docs/cloud/api/workspaces.html#request-body All uses of Operations field coming from the client (within the cloud package) should be converted to the appropriate ExecutionMode equivalent. Also, we need to update all acknowledgment of operations field on the tests that are testing the behavior of workspaces. Co-authored-by: Nick Fagerlund <nick.fagerlund@gmail.com> Co-authored-by: Nick Fagerlund <nick.fagerlund@gmail.com>	5 years ago
Omar Ismail	1da7031855	cloud: Add tags to workspace if necessary when fetching state	5 years ago
Barrett Clark	9c13521d76	Allow cloud tests to be run in parallel ... Add the `-parallel N` switch to tell the tests to run in N processes: ``` TFE_TOKEN=$TFE_TOKEN TFE_HOSTNAME=$TFE_HOSTNAME TF_ACC=1 go test -v \ -tags=e2e ./internal/cloud/e2e/... -parallel 4 ```	5 years ago
Nick Fagerlund	02e62c9851	Cloud: Init without erroring when no workspaces match the `tags` (#29835) ... Previously, `terraform init` was throwing an error if you configured the cloud block with `tags` and there weren't any tagged workspaces yet. Confusing and alienating, since that that's a fairly normal situation! Basically TFC was handling an empty list of workspaces worse than other backends, because it doesn't support an unnamed default workspace. This commit catches that condition during `Meta.selectBackend()` and asks the user to pick a name for their first tagged workspace. If they cancel out, we still error, but if we know what name they want, we can handle it the same way as a nonexistent workspace specified in `name` -- just pass it to `Meta.SetWorkspace()`, and let the workspace get implicitly created when `InitCommand.Run()` eventually calls `StateMgr()`.	5 years ago
Alisdair McDiarmid	a61bd8a96b	cloud: Fix prerelease version constraint checks	5 years ago
Chris Arcand	14260a5b4c	Adjust default workspace naming prompt ... The previous version is a little overdramatic and somewhat accusatory. Just lay it out how it is: TFC needs workspaces to be named.	5 years ago
Brandon Croft	6d9c919f55	adds X-Terraform-Integration header ... This can help differentiate cloud integration API requests from normal remote backend requests	5 years ago
Chris Arcand	3d23a8e062	cloud: Fix version check regression ... When the 'select the exact version if possible' behavior was added, the version check below it was never updated to take the newly updated version in to account, resulting in a failed version check even as the remote workspace updated to the correct version necessary.	5 years ago
Chris Arcand	652a68715f	cloud/e2e: Misc test fixes	5 years ago
Chris Arcand	f881c2d794	cloud: Skip E2E tests without an exact version	5 years ago
Chris Arcand	e364ef2905	cloud/e2e: Disable cost estimation ... E2E tests including cost estimation should indeed be added, but the default case should be disabled; lots of cycles lost to pointless cost estimates on null and random resources.	5 years ago
Omar Ismail	fc5863844c	Cloud migration: ignore backend version check when empty worksapces	5 years ago
Nick Fagerlund	fabd8eb0b6	Fix broken rename behavior in tfe_client_mock.go ... The delete + assign at the end of `Update` and `UpdateByID` are meant to handle renaming a workspace — (remove old name), (insert new name). However, `UpdateByID` was doing (remove new name), (insert new name) and leaving the old name in place. This commit changes it to match `Update` by grabbing the original name off the workspace object _before_ potentially renaming it.	5 years ago
Chris Arcand	50997d9a32	Restore API version checking, with internal usage accounted for	5 years ago
Nick Fagerlund	cb26cbba22	Add tests for cloud.StateMgr() when TFC lacks local tf version ... Alas, there's not a very good way to test the message we're supposed to print to the console in this situation; we just don't appear to have a mock terminal that the test can read from. But we can at least test that the function returns without erroring under the exact conditions where it was erroring before. Note that the behaviors of mc.Workspaces.Update and UpdateByID were already starting to drift, so I consolidated their actual attribute update logic into a helper function before they drifted much further.	5 years ago
Nick Fagerlund	c99f5972de	cloud.StateMgr(): Set terraform version AFTER creating workspace ... Previously, if the remote TFC/TFE instance doesn't happen to have a tool_version record whose name exactly matches the value of `tfversion.String()`, Terraform would be completely blocked from using the `terraform workspace new` command (when configured with the tags strategy) — the API would give a 422 to the whole create request. This commit changes the StateMgr() function to do the work in two passes; first create the workspace (which should work fine regardless), THEN update the Terraform version and print a warning to the terminal if it fails (which 99% of the time is a benign failure with little impact on your future CLI usage).	5 years ago
Chris Arcand	aace0015c2	cloud: Fix E2E variables test	5 years ago
Brandon Croft	64fbb0b613	remove reference to AccessInternalTools	5 years ago
Chris Arcand	12a4af3e72	Temporarily skip API version checking	5 years ago
Barrett Clark	ab304d831f	Found another path to backend init error ... There are actually a few different ways to get to this message. 1. Blank state — no previous terraform applied. Start with a cloud block. 1. Implicit local — start with no backend specified. This actually goes through the same code execution path as the first scenario. 1. Explicit local — start with a backend local block that has been applied, then change from the local backend to a cloud block. This will recognize the state, and is a different path through the code in the meta backend. This commit handles the last case. The messaging has also been tweaked. End to end test included as well.	5 years ago
Omar Ismail	5ff2495ffa	Update HasResource to HasManagedResourceInstanceObjects	5 years ago
Omar Ismail	86f93a2cbc	Cloud UX test fixes	5 years ago
Omar Ismail	dfb4609be2	Backend State Migration from cloud to cloud. ... * Add test for tfc to tfc mgiration * Fix old tests, and remove unused code.	5 years ago
Barrett Clark	93bfcff61a	More Terraform Cloud UX changes ... * Update e2e tests to specify Terraform Cloud * Update more of the terraform command flow to specify Terraform Cloud	5 years ago
Barrett Clark	d04c01573c	Fix iterator in a couple of e2e tests	5 years ago
Omar Ismail	dc76bbee73	Backend State Migration: Add remote backend test	5 years ago
Omar Ismail	3fedd6898c	Backend State Migration to `cloud`: Multiple Workspaces ... * Handle when there are multiple workspaces migrating to cloud, using both the cloud name strategy and cloud tags strategy. * Add e2e tests	5 years ago
Nick Fagerlund	baa72ce235	Simplify logic flow: everything is a constraint ... Explicit version strings are actually also version constraints! And the special comparisons we were doing to allow a range of compatible versions can also be expressed as version constraints. Bonus: also simplify the way we handle version check errors, by composing the messages inline and only extracting the repetitive parts into a function.	5 years ago
Barrett Clark	83538fdd6b	Shift errors to error file, improve error text	5 years ago
Nick Fagerlund	9857097b34	Add tests for version constraints in workspace terraform-versions	5 years ago
Nick Fagerlund	b43daeaa8d	Cloud backend: accept version constraints from workspaces ... The cloud backend (and remote before it) previously expected a TFC workspace's `terraform-version` attribute to be either the magic string `"latest"` or an explicit semver value. But a workspace might have a version constraint instead (like `~> 1.1.0`), in which case the version check would blow up. This commit checks whether `terraform-version` is a valid version constraint before erroring out, and if so, returns success if the local version meets the constraint. Because it's not practical to deeply introspect the slice of version space defined by a constraint, this check is slightly less robust than the version comparisons below it: - It can give a false OK on open-ended constraints like `>= 1.1.0`. Say you're running 1.3.0, it changed the state format, and the TFE instance admin has not yet added any 1.3.x Terraform versions; your workspace will now break. - It will give a false not-OK when using different minor versions within a range that we know to be compatible, e.g. remote constraint of `~> 0.15.0` and local version of 1.1.0. - This would be totally useless with the pre-0.14 versions of Terraform, where patch releases could change state format... but we're not going back in time to add this feature to them anyway. Still, in the most common likely case (`~> x.y.z`), it'll complain at you (with an error you can choose to override) if you're not using the same minor version, and that seems proportionate, useful, and expected.	5 years ago
Barrett Clark	83337de654	Remove prefix from the cloud backend config ... Now that we have tags we no longer need prefix.	5 years ago
Barrett Clark	edbc84420c	Run apply -refresh-state instead of refresh ... When a user runs `terraform refresh` we give them an error message that tells them to run `terraform apply -refresh-state`. We could just run that command for them, though. That is what this PR does.	5 years ago
Brandon Croft	bf02b5cb53	e2e test for cloud run variables	5 years ago
Brandon Croft	9963bf940a	refactor: only fetch variables if unset variables are not allowed	5 years ago
Omar Ismail	dd856f8a1b	Add run variables to cloud plan operations from non-file sources ... Run variables allow the run API to accept input variables not found in the configuration slug (the file-based ones plus workspace vars)	5 years ago
Omar Ismail	55fc590904	Teraform Cloud Backend State Migration ... * determining source or destination to cloud * handling single to single state migrations to cloud, using a name strategy or a tags strategy * Add end-to-end tests for state migration.	5 years ago
Chris Arcand	7cc53fe163	cloud: Set minimum TFE version ... These changes remove all of the preexisting version checking for individual features, wiping the slate clean with an overall minimum requirement of a future TFP-API-Version 2.5, which at the time of this writing is expected to be TFE v202112-1. It also actually provides that expected TFE version as an actionable error message, rather than generically saying that it isn't supported or using the somewhat opaque API version header.	5 years ago
Chris Arcand	46e47ed379	Use the 'tfe' service for everything. ... The 'tfe' service was appended to with various versions to denote a new 'feature' implemented by a new 'service'. This quickly proved to not be scalable, as adding an entry to the discovery document from every feature is bad. The new mechanism added was checking the TFP-API-Version header on requests for a version, instead. So we'll remove the separation here between different tfe service 'versions' and the separate 'state' service and Just Use TFE, as well as the TFP-API-Version header for all feature versioning., as well as the TFP-API-Version header for all feature versioning.	5 years ago
Chris Arcand	412679522d	Remove all constraint checking ... This is an outdated mechanism that isn't used anymore.	5 years ago
Chris Arcand	a4e196d067	Port backend/local: Check dependency lock consistency before any operations ... This is a port of the changes made in #29683	5 years ago
Omar Ismail	d5567b479c	Fix terraform version in cloud e2e tests to ignore prerelease. (#29)	5 years ago
Omar Ismail	a387af6c61	Add auto-approve logic, e2e tests	5 years ago
Chris Arcand	ee384e8716	Attempt to set current Terraform version on new workspaces, always	5 years ago
Chris Arcand	aba7d96596	cloud: Support interop from 0.14 to 1.1 ... The previous conservative guarantee that we would not make backwards incompatible changes to the state file format until at least Terraform 1.1 can now be extended. Terraform 0.14 through 1.1 will be able to interoperably use state files, so we can update the remote backend version compatibility check accordingly. This is a port of https://github.com/hashicorp/terraform/pull/29645	5 years ago
Chris Arcand	74e087dc29	Rename cloud.testBackendDefault -> cloud.testBackendWithName	5 years ago
Chris Arcand	d2b6b5f2b3	cloud: Align local and remote workspace name with 'name' strategy ... This changes the 'name' strategy to always align the local configured workspace name and the remote Terraform Cloud workspace, rather than the implicit use of the 'default' unnamed workspace being used instead. What this essentially means is that the Cloud integration does not fully support workspaces when configured for a single TFC workspace (as was the case with the 'remote' backend), but *does* use the backend.Workspaces() interface to allow for normal local behaviors like terraform.workspace to resolve to the correct name. It does this by always setting the local workspace name when the 'name' strategy is used, as a part of initialization. Part of the diff here is exporting all the previously unexported types for mapping workspaces. The command package (and init in particular) needs to be able to handle setting the local workspace in this particular scenario.	5 years ago
Omar Ismail	a94b2405b1	static checker	5 years ago
Omar Ismail	594a390f84	Use context parallelism	5 years ago
Chris Arcand	1791b71196	cloud: TestCloud_backendWithTags ... Implementing this test was quite a rabbithole, as in order to satisfy backendTestBackendStates() the workspaces returned from backend.Workspaces() must match exactly, and the shortcut taken to test pagination in 3cc58813f0 created an impossible circumstance that got plastered over with the fact that prefix filtering is done clientside, not by the API as it should be. Tagging does not rely on clientside filtering, and expects that the request made to the TFC API returns exactly those workspaces with the given tags. These changes include a better way to test pagination, wherein we actually create over a page worth of valid workspaces in the mock client and implement a simplified pagination behavior to match how the TFC API actually works.	5 years ago
Chris Arcand	a97a1c8f66	cloud.MockClient: Use Contains() to implement Search ... The TFC API doesn't behave this way; a search term just signals the substring was found within the name.	5 years ago
Chris Arcand	9bdf1d2579	Rename testBackendNoDefault ... "NoDefault" is now ambiguous with tags, and it does not imply using a prefix.	5 years ago
Chris Arcand	6dcd0db265	Map CLI workspaces by TFC tags	5 years ago
Chris Arcand	7a243379fb	cloud: Refactor workspaceMapping concerns into strategy()	5 years ago
Chris Arcand	922a8e4488	Refactor private workspace fields into workspaceMapping ... A mostly cosemetic change; The fields 'workspace' and 'prefix' don't really describe well what they are from a caller, so change these to use a workspaceMapping struct to convey they are for implementing workspace mapping strategies from CLI -> TFC	5 years ago
Omar Ismail	0a125c0400	Cloud: refactor setting attributes, add tests	5 years ago
Omar Ismail	8f49757f89	Add testing for Cloud PrepareConfig	5 years ago
Chris Arcand	471dd479e8	Update go-tfe to 26689e ... These changes include additions to fulfill the interface for the client mock, plus moving all that logic (which needn't be duplicated across both the remote and cloud packages) over to the cloud package under a dedicated mock client file.	5 years ago
Chris Arcand	34597c237f	cloud: Don't ignore .log golden files	5 years ago
Chris Arcand	85f37f1aa5	Add missing log mocks ... I missed adding these in the original porting commit from the remote backend, because *.log is added to gitignore.	5 years ago
Martin Atkins	f4758803fe	cloud: Backend implements new version of the backend.Local interface ... This makes the new backend compatible with the new terraform.Context API, which has changed in main.	5 years ago
Chris Arcand	a5f063625a	Replace generic host error messages for feature support	5 years ago
Chris Arcand	ea8ad0b15a	Initial commit of 'cloud' package ... The cloud package intends to implement a new integration for Terraform Cloud/Enterprise. The purpose of this integration is to better support TFC users; it will shed some overly generic UX and architecture, behavior changes that are otherwise backwards incompatible in the remote backend, and technical debt - all of which are vestiges from before Terraform Cloud existed. This initial commit is largely a porting of the existing 'remote' backend, which will serve as an underlying implementation detail and not be a typical user-level backend. This is because to re-implement the literal backend interface is orthogonal to the purpose of this integration, and can always be migrated away from later. As this backend is considered an implementation detail, it will not be registered as a declarable backend. Within these changes it is, for easy of initial development and a clean diff.	5 years ago