52 Commits (2cbb6bf92fce17e8de5e681dcc47ed85f32e9b23)

Author	SHA1	Message	Date
Sebastian Rivera	015f795ff0	Rebrand Terraform Cloud to HCP Terraform	2 years ago
Martin Atkins	88cb4aeea3	backendrun: Separate the types/etc for backends that support operations ... We previously had all of the types and helpers for all kinds of backends together in package backend. That kept things relatively simple, but it also meant that the majority of backends that only deal with remote state storage ended up still indirectly depending on the entire Terraform modules runtime, configuration loader, etc, etc, which brings into scope a bunch of external dependencies that the remote state backends don't really need. Since backends that support operations are a rare exception, we'll move the types and helpers for those into a separate package "backendrun", and then the main package backend can have a much more modest set of types and, more importantly, a modest set of dependencies on other packages in this codebase. This is part of an ongoing effort to reduce the exposure of Terraform Core and CLI code to the remote backends and vice-versa, so that in the long run we can more often treat them as separate for dependency maintenance purposes.	2 years ago
Nick Fagerlund	054fdf93cf	Publicize Cloud's token and organization fields ... Sorry... I need them.	2 years ago
Nick Fagerlund	438e47659b	Remove some redundant test cases for resolveCloudConfig	3 years ago
Nick Fagerlund	26dac26fd1	fix configWithEnvVars tests ... Actually I don't think these _ever_ worked.	3 years ago
Nick Fagerlund	1f9c3eb405	Fix TestCloud_config ... That error happens after PrepareConfig, now.	3 years ago
Nick Fagerlund	d7dadca40f	Re-enable disabled cloud configure tests ... These got turned off in d7e07e66fc by accident	3 years ago
Nick Fagerlund	59c99b1231	Steal most test cases from setConfigurationFields and PrepareConfig ... These tests were rather chaotic, because the basic job of validating the finalized config was split across a bunch of different places. Now they're in (mostly) one spot, testing `resolveCloudConfig`. They might be somewhat excessive or redundant, and can be revised later. In a few cases, I revised test cases that had incorrect expectations, to match the fixed implementation. Also, note that the new implementation is less loosey-goosey around cty values, and expects something that definitely matches the schema (though any amount of it might be null). This commit also splits the TF_FORCE_LOCAL_BACKEND test case into a separate test function.	3 years ago
Nick Fagerlund	be71ab06a8	Add a first test for resolveCloudConfig	3 years ago
Brandon Croft	6500b7c740	change visibility of cloud.Backend Hostname field	3 years ago
hashicorp-copywrite[bot]	53c34ff49c	Update copyright file headers to BUSL-1.1	3 years ago
Karl Kirch	d7e07e66fc	Add ability to specify Terraform Cloud Project in cloud block (#33489) ... * Add ability to specify Terraform Cloud Project in cloud block Adds project configuration to the workspaces section of the cloud block. Also configurable via the `TF_CLOUD_PROJECT` environment variable. When a project is configured, the following behaviors will occur: - `terraform init` with workspaces.name configured will create the workspace in the given project - `terraform workspace new <name>` with workspaces.tags configured will create workspaces in the given project - `terraform workspace list` will list workspaces only from the given project The following behaviors are NOT affected by project configuration - `terraform workspace delete <name>` does not validate the workspace's inclusion in the given project - When initializing a workspace that already exists in Terraform Cloud, the workspace's parent project is NOT validated against the given project Adds tests for cloud block configuration of project Update changelog * Update cloud block docs * Fix typos and changelog entry * Add speculative project lookup early in the cloud initialize process to capture inability to find a configured project * Add project config for alias test	3 years ago
Nick Fagerlund	7f6b827987	Modify tfe client mocks to meet some new requirements ... - Add plausible unredacted plan json for `plan-json-{basic,full}` testdata -- Created by just running the relevant terraform commands locally. - Add plan-json-no-changes testdata -- The unredacted json was organically grown, but I edited the log and redacted json by hand to match what I observed from a real but unrelated planned-and-finished run in TFC. - Add plan-json-basic-no-unredacted testdata -- This mimics a lack of admin permissions, resulting in a 404. - Hook up `MockPlans.ReadJSONOutput` to test fixtures, when present. This method has been implemented for ages, and has had a backing store for unredacted plan json, but has been effectively a no-op since nothing ever fills that backing store. So, when creating a mock plan, make an attempt to read unredacted json and stow it in the mocks on success. - Make it possible to get the entire MockClient for a test backend In order to test some things, I'm going to need to mess with the internal state of runs and plans beyond what the go-tfe client API allows. I could add magic special-casing to the mock API methods, or I could locate the shenanigans next to the test that actually exploits it. The latter seems more comprehensible, but I need access to the full mock client struct in order to mess with its interior. - Fill in some missing expectations around HasChanges when retrieving a run + plan.	3 years ago
Brandon Croft	c1a730314d	Relocate localterraform.com aliasing to backend configurators ... Previously, remote and cloud backends would automatically alias localterraform.com as the configured hostname during configuration. This turned out to be an issue with how backends could potentially be used within the builtin terraform_remote_state data source. Those data sources each configure the same service discovery with different targets for localterraform.com, and do so simultaneously, creating an occasional concurrent map read & write panic when multiple data sources are defined. localterraform.com is obviously not useful for every backend configuration. Therefore, I relocated the alias configuration to the callers, so they may specify when to use it. The modified design adds a new method to backend.Enhanced to allow configurators to ask which aliases should be defined.	3 years ago
hashicorp-copywrite[bot]	325d18262e	[COMPLIANCE] Add Copyright and License Headers	3 years ago
Sebastian Rivera	5634ae3e18	Unit tests to ensure renderer is appropriately called	3 years ago
Alisdair McDiarmid	ca53ca00f4	Remove failing DNS query in cloud tests ... This test case was making a real DNS call in a non-acceptance test, and since it was intended to fail it would introduce a several second delay. This commit replaces the test with a similar one which uses the mocked disco services for a non-TFE host. Also restructure the test to use t.Run for clarity.	3 years ago
Nick Fagerlund	acf7314587	Fix typo in cloud backend's `TestCloud_setConfigurationFields` ... This was clearly wrong, but it was also harmless -- in the event of a failing test due to missing tags, they would get double-reported as both missing and unexpected. This commit separates out the reporting as intended.	3 years ago
Jarrett Spiker	c16d726f2c	Succeed cloud workspace deletion if the workspace does not exist	3 years ago
Jarrett Spiker	060255a9d5	Use safe or force workspace delete for cloud backend	3 years ago
Anna Winkler	22c121df86	Bump compatibility version to 1.3.0 for terraform core release (#30988) ... * Bump compatibility version to 1.3.0 for terraform core release Co-authored-by: Brandon Croft <brandon.croft@gmail.com>	4 years ago
Sebastian Rivera	f63ef2b5ef	Rename cloud env vars to use TF_CLOUD prefix	4 years ago
Brandon Croft	0dc26a9585	test(cloud): nonexisting org not a valid test when using mocks	4 years ago
Brandon Croft	a38a0ee8a8	test(cloud): ensure mocks are used for backend configure tests ... Also adds a few new tests for cloud configuration using environment variables	4 years ago
Sebastian Rivera	dd864b1bac	Add TF_WORKSPACE validation method	4 years ago
Sebastian Rivera	995ef15ab9	Add cloud configuration support for TF_WORKSPACE ... TF_WORKSPACE can now be used for your cloud configuration, effectively serving as an alternative to setting the name attribute in your workspaces configuration.	4 years ago
Sebastian Rivera	a52c87cb5a	Fix a flaky test manipulating environment variables ... This test resolves an issue where variables were going unset causing leaks into other test cases and therefore resulting in failures.	4 years ago
Sebastian Rivera	232d48fe00	Add support for TF_HOSTNAME env var	4 years ago
Sebastian Rivera	b1c22d333e	Fix error formatting for missing env and config value ... We previously used to throw an error denoting where in the configuration the attribute was missing or invalid. Considering that organization can be now be omitted from the configuration, our previous error message will be improperly formatted. This commit also updates the message to mention `TF_ORGANIZATION` as a valid substitute if organization is missing or invalid in the configuration.	4 years ago
Sebastian Rivera	45357f5004	Add TF_ORGANIZATION env var support ... TF_ORGANIZATION will serve as a fallback for configuring the organization in the `cloud` block. This is the first step to make it easier for users wanting to configure Terraform programmatically.	4 years ago
Luces Huayhuaca	4e3218b4d5	cloud: convert uses of worspaces.operations into workspaces.executionMode (#29844) ... * convert uses of worspaces.operations into workspaces.executionMode The cloud package currently uses a deprecated API on workspaces to determine a workspace's execution mode. Deprecated: Operations (boolean) New hotness: Execution mode (string - "local", "remote", or "agent") More details: https://www.terraform.io/docs/cloud/api/workspaces.html#request-body All uses of Operations field coming from the client (within the cloud package) should be converted to the appropriate ExecutionMode equivalent. Also, we need to update all acknowledgment of operations field on the tests that are testing the behavior of workspaces. Co-authored-by: Nick Fagerlund <nick.fagerlund@gmail.com> Co-authored-by: Nick Fagerlund <nick.fagerlund@gmail.com>	5 years ago
Alisdair McDiarmid	a61bd8a96b	cloud: Fix prerelease version constraint checks	5 years ago
Chris Arcand	50997d9a32	Restore API version checking, with internal usage accounted for	5 years ago
Nick Fagerlund	cb26cbba22	Add tests for cloud.StateMgr() when TFC lacks local tf version ... Alas, there's not a very good way to test the message we're supposed to print to the console in this situation; we just don't appear to have a mock terminal that the test can read from. But we can at least test that the function returns without erroring under the exact conditions where it was erroring before. Note that the behaviors of mc.Workspaces.Update and UpdateByID were already starting to drift, so I consolidated their actual attribute update logic into a helper function before they drifted much further.	5 years ago
Chris Arcand	12a4af3e72	Temporarily skip API version checking	5 years ago
Nick Fagerlund	baa72ce235	Simplify logic flow: everything is a constraint ... Explicit version strings are actually also version constraints! And the special comparisons we were doing to allow a range of compatible versions can also be expressed as version constraints. Bonus: also simplify the way we handle version check errors, by composing the messages inline and only extracting the repetitive parts into a function.	5 years ago
Barrett Clark	83538fdd6b	Shift errors to error file, improve error text	5 years ago
Nick Fagerlund	9857097b34	Add tests for version constraints in workspace terraform-versions	5 years ago
Barrett Clark	83337de654	Remove prefix from the cloud backend config ... Now that we have tags we no longer need prefix.	5 years ago
Chris Arcand	7cc53fe163	cloud: Set minimum TFE version ... These changes remove all of the preexisting version checking for individual features, wiping the slate clean with an overall minimum requirement of a future TFP-API-Version 2.5, which at the time of this writing is expected to be TFE v202112-1. It also actually provides that expected TFE version as an actionable error message, rather than generically saying that it isn't supported or using the somewhat opaque API version header.	5 years ago
Chris Arcand	412679522d	Remove all constraint checking ... This is an outdated mechanism that isn't used anymore.	5 years ago
Chris Arcand	aba7d96596	cloud: Support interop from 0.14 to 1.1 ... The previous conservative guarantee that we would not make backwards incompatible changes to the state file format until at least Terraform 1.1 can now be extended. Terraform 0.14 through 1.1 will be able to interoperably use state files, so we can update the remote backend version compatibility check accordingly. This is a port of https://github.com/hashicorp/terraform/pull/29645	5 years ago
Chris Arcand	74e087dc29	Rename cloud.testBackendDefault -> cloud.testBackendWithName	5 years ago
Chris Arcand	d2b6b5f2b3	cloud: Align local and remote workspace name with 'name' strategy ... This changes the 'name' strategy to always align the local configured workspace name and the remote Terraform Cloud workspace, rather than the implicit use of the 'default' unnamed workspace being used instead. What this essentially means is that the Cloud integration does not fully support workspaces when configured for a single TFC workspace (as was the case with the 'remote' backend), but *does* use the backend.Workspaces() interface to allow for normal local behaviors like terraform.workspace to resolve to the correct name. It does this by always setting the local workspace name when the 'name' strategy is used, as a part of initialization. Part of the diff here is exporting all the previously unexported types for mapping workspaces. The command package (and init in particular) needs to be able to handle setting the local workspace in this particular scenario.	5 years ago
Chris Arcand	1791b71196	cloud: TestCloud_backendWithTags ... Implementing this test was quite a rabbithole, as in order to satisfy backendTestBackendStates() the workspaces returned from backend.Workspaces() must match exactly, and the shortcut taken to test pagination in 3cc58813f0 created an impossible circumstance that got plastered over with the fact that prefix filtering is done clientside, not by the API as it should be. Tagging does not rely on clientside filtering, and expects that the request made to the TFC API returns exactly those workspaces with the given tags. These changes include a better way to test pagination, wherein we actually create over a page worth of valid workspaces in the mock client and implement a simplified pagination behavior to match how the TFC API actually works.	5 years ago
Chris Arcand	9bdf1d2579	Rename testBackendNoDefault ... "NoDefault" is now ambiguous with tags, and it does not imply using a prefix.	5 years ago
Chris Arcand	6dcd0db265	Map CLI workspaces by TFC tags	5 years ago
Chris Arcand	7a243379fb	cloud: Refactor workspaceMapping concerns into strategy()	5 years ago
Chris Arcand	922a8e4488	Refactor private workspace fields into workspaceMapping ... A mostly cosemetic change; The fields 'workspace' and 'prefix' don't really describe well what they are from a caller, so change these to use a workspaceMapping struct to convey they are for implementing workspace mapping strategies from CLI -> TFC	5 years ago
Omar Ismail	0a125c0400	Cloud: refactor setting attributes, add tests	5 years ago