109 Commits (28543694de6333696f07e1008153a6c0d2811983)

Author	SHA1	Message	Date
Paul Hinze	3b732131d2	Merge pull request #7446 from hashicorp/b-jit-resource-validate ... core: rerun resource validation before plan and apply	10 years ago
Paul Hinze	ad27190852	Merge pull request #7448 from dtolnay/timeout ... Timing out is not success	10 years ago
Paul Hinze	4a1b36ac0d	core: rerun resource validation before plan and apply ... In #7170 we found two scenarios where the type checking done during the `context.Validate()` graph walk was circumvented, and the subsequent assumption of type safety in the provider's `Diff()` implementation caused panics. Both scenarios have to do with interpolations that reference Computed values. The sentinel we use to indicate that a value is Computed does not carry any type information with it yet. That means that an incorrect reference to a list or a map in a string attribute can "sneak through" validation only to crop up... 1. ...during Plan for Data Source References 2. ...during Apply for Resource references In order to address this, we: * add high-level tests for each of these two scenarios in `provider/test` * add context-level tests for the same two scenarios in `terraform` (these tests proved _really_ tricky to write!) * place an `EvalValidateResource` just before `EvalDiff` and `EvalApply` to catch these errors * add some plumbing to `Plan()` and `Apply()` to return validation errors, which were previously only generated during `Validate()` * wrap unit-tests around `EvalValidateResource` * add an `IgnoreWarnings` option to `EvalValidateResource` to prevent active warnings from halting execution on the second-pass validation Eventually, we might be able to attach type information to Computed values, which would allow for these errors to be caught earlier. For now, this solution keeps us safe from panics and raises the proper errors to the user. Fixes #7170	10 years ago
Paul Hinze	5656d7388c	helper/resource: Consolidate unit test override ... I noticed we had two mechanisms for unit test override. One that dropped a sentinel into the env var, and another with a struct member on TestCase. This consolidates the two, using the cleaner struct member internal mechanism and the nicer `resource.UnitTest()` entry point.	10 years ago
David Tolnay	7e1cd34819	Timing out is not success	10 years ago
Patrick Sodré	80936e3562	provider/triton: add machine domain names (#7149) ... * vendor joyent/gosdc/cloudapi * provider/triton: Add machine domain names - Includes acceptance test.	10 years ago
James Nugent	9c7cf639b3	testing: Allow acceptance test to run as unit test ... This commit adds a flag to acceptance tests in order to make appropriately named tests work during `make test` irrespective of the TF_ACC environment variable. This should only be used on tests which are known to be fast.	10 years ago
Radek Simko	1ea5cff9b3	Merge pull request #6946 from TimeIncOSS/f-aws-s3-object-data-source ... provider/aws: Add aws_s3_bucket_object data source	10 years ago
Radek Simko	bf8931b1ab	provider/aws: Mark Lambda function as gone when it's gone (#6924) ... * helper/error: Introduce TimeoutError & UnexpectedStateError * provider/aws: Mark Lambda function as gone when it's gone	10 years ago
Radek Simko	84ab00d92e	helper/resource: Add TestStep.PreventPostDestroyRefresh ... - This is to allow easier testing of data sources which read data from resources created in the same scope	10 years ago
Martin Atkins	031b561ef0	helper/resource: ignore data resource diffs during destroy ... When testing destroy, the test harness calls Refresh followed by Plan, with the expectation that the resulting diff will be empty. Data resources challenge this expectation, because they will always be instantiated during refresh if their configuration isn't computed, and so the subsequent diff will want to destroy what was instantiated. To work around this, we make an exception that data resource destroy diffs may appear in the plan but nothing else. This fixes #6713.	10 years ago
Mitchell Hashimoto	55583baa7e	Merge branch 'f-aws-import'	10 years ago
James Nugent	3ea3c657b5	core: Use OutputState in JSON instead of map ... This commit forward ports the changes made for 0.6.17, in order to store the type and sensitive flag against outputs. It also refactors the logic of the import for V0 to V1 state, and fixes up the call sites of the new format for outputs in V2 state. Finally we fix up tests which did not previously set a state version where one is required.	10 years ago
Mitchell Hashimoto	884980da1a	providers/aws: instance, nat, internet gateway	10 years ago
Mitchell Hashimoto	6a675b4a15	helper/resource: ImportState test can verify states	10 years ago
Mitchell Hashimoto	ec02c8c0e2	helper/resource: testing of almost all aspects of ImportState tests	10 years ago
Mitchell Hashimoto	2d99c451fb	helper/resource: basic ImportState acceptance testing ... Still some TODOs, and more test cases to write, but the basics are all here.	10 years ago
Mitchell Hashimoto	9bd1c9e7ca	helper/resource: reshuffling to prepare for importstate testing	10 years ago
Mitchell Hashimoto	35c87836b4	core: Add terraform_version to state ... This adds a field terraform_version to the state that represents the Terraform version that wrote that state. If Terraform encounters a state written by a future version, it will error. You must use at least the version that wrote that state. Internally we have fields to override this behavior (StateFutureAllowed), but I chose not to expose them as CLI flags, since the user can just modify the state directly. This is tricky, but should be tricky to represent the horrible disaster that can happen by enabling it. We didn't have to bump the state format version since the absense of the field means it was written by version "0.0.0" which will always be older. In effect though this change will always apply to version 2 of the state since it appears in 0.7 which bumped the version for other purposes.	10 years ago
Mitchell Hashimoto	d85df63526	providers/aws: aws_instance id-only	10 years ago
Mitchell Hashimoto	e0da21d381	helper/resource: make id-only check opt-in ... As I've been working through the resources, I'm finding that a lot are going to need some serious work. Given we have hundreds, I think it might be prudent to make this opt-in for now and we can revisit automatic/opt-out at some future point. Importability will likely be opt-in it appears so this will match up with that.	10 years ago
Mitchell Hashimoto	ff7b58f032	providers/aws: peering connection id-only test settings	10 years ago
Mitchell Hashimoto	0ef1b3b84a	providers/aws: response value for DescribeVpcAttribute needs to be ... .Value	10 years ago
Mitchell Hashimoto	1db1bf6639	helper/resource: use the full config for id-only checks ... Originally I used an empty config module. This caused problems since important provider configurations weren't available. Instead, I now set it to use the full config. This isn't an issue since the attributes themselves aren't available to Refresh anyways.	10 years ago
Mitchell Hashimoto	0c8b0bff2c	helper/resource: can specify specific name to id refresh test	10 years ago
Mitchell Hashimoto	1a9fae6b2e	helper/resource: can disable ID refresh check	10 years ago
Mitchell Hashimoto	35f4201b9e	providers/aws: instance_tenancy is computed, set	10 years ago
Mitchell Hashimoto	f2c4f8e9ba	helper/resource: fix tests	10 years ago
Mitchell Hashimoto	5c4f78796b	helper/resource: don't need to id-only check if no test steps	10 years ago
Mitchell Hashimoto	a285c04dc9	helper/resource: only verify id-only run if no error	10 years ago
Mitchell Hashimoto	baac14aaeb	helper/resource: guard id-only by acc var	10 years ago
Mitchell Hashimoto	cb32cb8947	helper/resource: error if id-only check didn't run	10 years ago
Mitchell Hashimoto	86e0c853db	helper/resource: test for failing id-only refresh check	10 years ago
Mitchell Hashimoto	060b43fbd9	helper/resource: remove debug	10 years ago
Mitchell Hashimoto	4f6edf4fe4	helper/resource: id-only refresh testing	10 years ago
James Nugent	cb8a0549e1	Merge pull request #5757 from hashicorp/f-output-testing ... Add TestCheckOutput helper to resource testing	10 years ago
James Nugent	35f9d2e081	Add TestCheckOutput helper to resource testing ... This allows outputs in test configuration to have test functions written conveniently. Useful for azurerm_template_deployment.	10 years ago
Radek Simko	bf9f5879ca	helper/resource: Remove NotFoundError function	10 years ago
James Nugent	f946695187	Merge pull request #5444 from TimeIncOSS/f-aws-logs-metric-filter ... provider/aws: Add support for CloudWatch Log Metric Filter	10 years ago
Paul Hinze	c3e27b3e0a	provider/test: a test provider ... Here we also introduce a `test` provider meant as an aid to exposing via automated tests issues involving interactions between `helper/schema` and Terraform core. This has been helpful so far in diagnosing `ignore_changes` problems, and I imagine it will be helpful in other contexts as well. We'll have to be careful to prevent the `test` provider from becoming a dumping ground for poorly specified tests that have a clear home elsewhere. But for bug exposure I think it's useful to have.	10 years ago
Radek Simko	fd2fcaf1d5	helper/resource: Implement resource-wide NotFoundError	10 years ago
Radek Simko	034287fdc2	helper/resource: Error shouldn't be returned in case of success	10 years ago
Radek Simko	8582f4df9f	helper/resource: Fix TestRetry	10 years ago
Paul Hinze	108ccf0007	builtin: Refactor resource.Retry to clarify return ... Change the `RetryFunc` from a plain `error` return type to a specialized `RetryError` which must decide whether it is retryable or not. Add `RetryableError` / `NonRetryableError` factory functions that callers are meant to use to build up these errors. This makes it eminently clear whether or not a given error is retryable from inside the client code. Goal here is to _not_ change any behavior, simply reflect the existing behavior with the new, clearer, API.	10 years ago
Paul Hinze	5160578e18	helper/resource: restore retval of resource.Retry on timeout ... In #4700 while fixing a data race I made an incorrect assumption about the return value of StateChangeConf, and ended up changing the behavior in the timeout case to always return: > timeout while waiting for state to become '[success]' When it used to capture the "most recent error" from the function itself. It's much more useful to see that error bubbling up, so here we revert to pulling it out of the function as we did before, and we protect against the data race with a good old fashioned mutex.	10 years ago
Paul Hinze	bba8a79a52	acctests: log a line w/ the non-empty plan ... Helpful when iterating on a drift test. Eventually I think this assertion could be fanned out to something much more targeted like: ExpectAttributeDiff(resource, attr, oldval, newval) But this is a step in the right direction.	10 years ago
Radek Simko	ab73f2b762	helper: Add StateChangeConf.ContinuousTargetOccurence (int)	10 years ago
Paul Hinze	24048b4dca	providers: Mention check number when acctest fails	10 years ago
Ian Duffy	47ac10d66b	Change resource.StateChangeConf to use an array for target states ... Signed-off-by: Ian Duffy <ian@ianduffy.ie>	10 years ago
Paul Hinze	d59db52f06	helper/resource: Fix data race in resource.Retry ... The implementation was attempting to capture the error using a scoped variable reference, but the error value is already exposed via the return value of `WaitForState()`. Using that instead fixes the data race. Fixes the following data race: ``` ================== WARNING: DATA RACE Read by goroutine 74: github.com/hashicorp/terraform/helper/resource.Retry() /Users/phinze/go/src/github.com/hashicorp/terraform/helper/resource/wait.go:35 +0x284 github.com/hashicorp/terraform/helper/resource.TestRetry_timeout() /Users/phinze/go/src/github.com/hashicorp/terraform/helper/resource/wait_test.go:35 +0x60 testing.tRunner() /private/var/folders/vd/7l9ys5k57l91x63sh28wl_kc0000gn/T/workdir/go/src/testing/testing.go:456 +0xdc Previous write by goroutine 90: github.com/hashicorp/terraform/helper/resource.Retry.func1() /Users/phinze/go/src/github.com/hashicorp/terraform/helper/resource/wait.go:20 +0x87 github.com/hashicorp/terraform/helper/resource.(*StateChangeConf).WaitForState.func1() /Users/phinze/go/src/github.com/hashicorp/terraform/helper/resource/state.go:83 +0x284 Goroutine 74 (running) created at: testing.RunTests() /private/var/folders/vd/7l9ys5k57l91x63sh28wl_kc0000gn/T/workdir/go/src/testing/testing.go:561 +0xaa3 testing.(*M).Run() /private/var/folders/vd/7l9ys5k57l91x63sh28wl_kc0000gn/T/workdir/go/src/testing/testing.go:494 +0xe4 main.main() github.com/hashicorp/terraform/helper/resource/_test/_testmain.go:84 +0x20f Goroutine 90 (running) created at: github.com/hashicorp/terraform/helper/resource.(*StateChangeConf).WaitForState() /Users/phinze/go/src/github.com/hashicorp/terraform/helper/resource/state.go:127 +0x283 github.com/hashicorp/terraform/helper/resource.Retry() /Users/phinze/go/src/github.com/hashicorp/terraform/helper/resource/wait.go:34 +0x276 github.com/hashicorp/terraform/helper/resource.TestRetry_timeout() /Users/phinze/go/src/github.com/hashicorp/terraform/helper/resource/wait_test.go:35 +0x60 testing.tRunner() /private/var/folders/vd/7l9ys5k57l91x63sh28wl_kc0000gn/T/workdir/go/src/testing/testing.go:456 +0xdc ================== ```	10 years ago