490 Commits (28543694de6333696f07e1008153a6c0d2811983)

Author	SHA1	Message	Date
James Nugent	c6e03cba96	core: Fix slice element keys on interpolateWalk ... Part of the interpolation walk is to detect keys which involve computed values and therefore cannot be resolved at this time. The interplation walker keeps sufficient state to be able to populate the ResourceConfig with a slice of such keys. Previously they didn't take slice indexes into account, so in the following case: ``` "services": []interface{}{ map[string]interface{}{ "elb": "___something computed___", }, map[string]interface{}{ "elb": "___something else computed___", }, map[string]interface{}{ "elb": "not computed", }, } ``` Unknown keys would be populated as follows: ``` services.elb services.elb ``` This is not sufficient information to be useful, as it is impossible to distinguish which of the `services.elb`s are unknown vs not. This commit therefore retains the slice indexes as part of the key for unknown keys - producing for the example above: ``` services.0.elb services.1.elb ```	10 years ago
James Bardin	e78dc291af	Add test to ensure key/values interp order ... Test that interpolated values are returned in the order of the sorted keys.	10 years ago
James Nugent	8284b79957	Merge pull request #7298 from hashicorp/jbardin/GH-7273-fixup ... code: Add proper build constraints for GH-7273	10 years ago
James Nugent	8403a465bc	core: Add test and fix for element with empty list ... The incldued test previously caused a panic, it now returns an error message explaining the issue.	10 years ago
James Bardin	525485c213	Add proper build constraints for GH-7273 ... The syscall.Stat_t type doesn't exist on windows, so the inode lookup needs to be in a file with proper build constraints.	10 years ago
James Bardin	558e023e26	Don't try to copy files over themselves ... When copying a config module, make sure the full path for src and dst files don't match, and also check the inode in case we resolved a different path to the same file. Make a note about the unsafe usage of reusing a tempDir path.	10 years ago
James Nugent	9d6c629689	config: Update test to reflect new behaviour ... Escaped quotes are no longer supported as HIL syntax (as of the last update to HIL), so this commit changes the Terraform config-layer test to verify the non-presence of this behaviour for 0.7.	10 years ago
James Nugent	4b6a632246	core: Rename uniq -> distinct and add docs	10 years ago
Jan Schumann	df3e017f6c	fix #7106	10 years ago
Paul Hinze	9bc980f569	core: Fix panic on concat() w/ list of nonprimitives ... The `concat()` interpolation function does not yet support types other than strings / lists of strings. Make it an error message instead of a panic when a list of non-primitives is supplied. Fixes the panic in #7030	10 years ago
Paul Hinze	ffa29090ec	core: Better error for dot indexing on user vars ... Dot indexing worked in the "regexps and strings" world of 0.6.x, but it no longer works on the 0.7 series w/ proper List / Map types. There is plenty of dot-indexed config out in the wild, so we need to do what we can to point users to the new syntax. Here is one place we can do it for user variables (`var.somemap`). We'll also need to address Resource Variables and Module Variables in a separate PR. This fixes the panic in #7103 - a proper error message is now returned.	10 years ago
James Nugent	01cd596c60	core: Fix detection of empty list/map defaults ... This commit changes config parsing from weak decoding lists and maps into []string and map[string]string respectively to decode into []interface{} and map[string]interface{} respectively. This is in order to take advantage of the work integrated in #7082 to defeat the backward compatibility features of the mapstructure library. Test coverage of loading empty variables and validating their default types against expectation.	10 years ago
James Nugent	578ff9569e	core: Add sort() interpolation function	10 years ago
James Nugent	cb9ef298f3	core: Defeat backward compatibilty in mapstructure ... The mapstructure library has a regrettable backward compatibility concern whereby a WeakDecode of []interface{}{} into a target of map[string]interface{} yields an empty map rather than an error. One possibility is to switch to using Decode instead of WeakDecode, but this loses the nice handling of type conversion, requiring a large volume of code to be added to Terraform or HIL in order to retain that behaviour. Instead we add a DecodeHook to our usage of the mapstructure library which checks for decoding []interface{}{} or []string{} into a map and returns an error instead. This has the effect of defeating the code added to retain backwards compatibility in mapstructure, giving us the correct (for our circumstances) behaviour of Decode for empty structures and the type conversion of WeakDecode. The code is identical to that in the HIL library, and packaged into a helper.	10 years ago
David Adams	b5d1279107	Allow specifying a default value to lookup() ... Fixes #4474, where lookup() calls fail out the entire interpolation when the provided key value is not found in the map. This will allow using coalesce() along with lookup() to greatly improve module flexibility.	10 years ago
David Glasser	594ea105d8	config: support lists and maps in jsonencode ... For now we only support lists and maps whose values are strings, not deeply nested data.	10 years ago
Martin Atkins	60c24e3319	command: Prevent data resources from being tainted ... Since the data resource lifecycle contains no steps to deal with tainted instances, we must make sure that they never get created. Doing this out in the command layer is not the best, but this is currently the only layer that has enough information to make this decision and so this simple solution was preferred over a more disruptive refactoring, under the assumption that this taint functionality eventually gets reworked in terms of StateFilter anyway.	10 years ago
Martin Atkins	718cdda77b	config: Parsing of data.TYPE.NAME.FIELD variables ... This allows ${data.TYPE.NAME.FIELD} interpolation syntax at the configuration level, though since there is no special handling of them in the core package this currently just acts as an alias for ${TYPE.NAME.FIELD}.	10 years ago
Martin Atkins	860140074f	config: Data source loading ... This allows the config loader to read "data" blocks from the config and turn them into DataSource objects. This just reads the data from the config file. It doesn't validate the data nor do anything useful with it.	10 years ago
Martin Atkins	fc4fa10981	config: "ResourceMode" concept for resources ... Previously resources were assumed to always support the full set of create, read, update and delete operations, and Terraform's resource management lifecycle. Data sources introduce a new kind of resource that only supports the "read" operation. To support this, a new "Mode" field is added to the Resource concept within the config layer, which can be set to ManagedResourceMode (to indicate the only mode previously possible) or DataResourceMode (to indicate that only "read" is supported). To support both managed and data resources in the tests, the stringification of resources in config_string.go is adjusted slightly to use the Id() method rather than the unusual type[name] serialization from before, causing a simple mechanical adjustment to the loader tests' expected result strings.	10 years ago
Mitchell Hashimoto	27452f0043	terraform: Module option to Import to add module to graph	10 years ago
Mitchell Hashimoto	3c9a92e04a	command: Context buliding allows empty module trees	10 years ago
James Nugent	f1d0fc46aa	core: Fix go vet issues shown by Travis	10 years ago
James Nugent	244da895cd	core: Remove StringList ... Much celebration may now ensue! ♪┏(°.°)┛┗(°.°)┓┗(°.°)┛┏(°.°)┓ ♪	10 years ago
James Nugent	f49583d25a	core: support native list variables in config ... This commit adds support for native list variables and outputs, building up on the previous change to state. Interpolation functions now return native lists in preference to StringList. List variables are defined like this: variable "test" { # This can also be inferred type = "list" default = ["Hello", "World"] } output "test_out" { value = "${var.a_list}" } This results in the following state: ``` ... "outputs": { "test_out": [ "hello", "world" ] }, ... ``` And the result of terraform output is as follows: ``` $ terraform output test_out = [ hello world ] ``` Using the output name, an xargs-friendly representation is output: ``` $ terraform output test_out hello world ``` The output command also supports indexing into the list (with appropriate range checking and no wrapping): ``` $ terraform output test_out 1 world ``` Along with maps, list outputs from one module may be passed as variables into another, removing the need for the `join(",", var.list_as_string)` and `split(",", var.list_as_string)` which was previously necessary in Terraform configuration. This commit also updates the tests and implementations of built-in interpolation functions to take and return native lists where appropriate. A backwards compatibility note: previously the concat interpolation function was capable of concatenating either strings or lists. The strings use case was deprectated a long time ago but still remained. Because we cannot return `ast.TypeAny` from an interpolation function, this use case is no longer supported for strings - `concat` is only capable of concatenating lists. This should not be a huge issue - the type checker picks up incorrect parameters, and the native HIL string concatenation - or the `join` function - can be used to replicate the missing behaviour.	10 years ago
James Nugent	e57a399d71	core: Use native HIL maps instead of flatmaps ... This changes the representation of maps in the interpolator from the dotted flatmap form of a string variable named "var.variablename.key" per map element to use native HIL maps instead. This involves porting some of the interpolation functions in order to keep the tests green, and adding support for map outputs. There is one backwards incompatibility: as a result of an implementation detail of maps, one could access an indexed map variable using the syntax "${var.variablename.key}". This is no longer possible - instead HIL native syntax - "${var.variablename["key"]}" must be used. This was previously documented, (though not heavily used) so it must be noted as a backward compatibility issue for Terraform 0.7.	10 years ago
James Nugent	b62f6af158	core: Add support for marking outputs as sensitive (#6559) ... * core: Add support for marking outputs as sensitive This commit allows an output to be marked "sensitive", in which case the value is redacted in the post-refresh and post-apply list of outputs. For example, the configuration: ``` variable "input" { default = "Hello world" } output "notsensitive" { value = "${var.input}" } output "sensitive" { sensitive = true value = "${var.input}" } ``` Would result in the output: ``` terraform apply Apply complete! Resources: 0 added, 0 changed, 0 destroyed. Outputs: notsensitive = Hello world sensitive = <sensitive> ``` The `terraform output` command continues to display the value as before. Limitations: Note that sensitivity is not tracked internally, so if the output is interpolated in another module into a resource, the value will be displayed. The value is still present in the state.	10 years ago
James Nugent	a0cc7115b3	deps: Update call sites of hil.Eval from update ... hil.Eval() now returns (hil.EvaluationResult, error) instead of (value, type, error). This commit updates the call sites, but retains all previous behaviour. Tests are also updated.	10 years ago
James Nugent	d7d39702c0	Type check variables between modules (#6185) ... These tests demonstrates a problem where the types to a module input are not checked. For example, if a module - inner - defines a variable "should_be_a_map" as a map, or with a default variable of map, we do not fail if the user sets the variable value in the outer module to a string value. This is also a problem in nested modules. The implementation changes add a type checking step into the graph evaluation process to ensure invalid types are not passed.	10 years ago
David Glasser	6cf06bb3ab	config: new interpolation function jsonencode	10 years ago
Paul Hinze	293c6ca68c	Revert "Revert "core: Add uuid() interpolate function."" ... This reverts commit 661be01d9b.	10 years ago
Paul Hinze	567a9b9e06	config: remove missing equals test to fix build ... This is behavior that's covered in the parser now - and the error message is nicer to boot!	10 years ago
James Nugent	87550b2b72	Merge pull request #5263 from uber/b-element-negative ... Error out on negative indices in element()	10 years ago
Paul Hinze	661be01d9b	Revert "core: Add uuid() interpolate function."	10 years ago
Paul Hinze	1e0b8ea478	core: Add uuid() interpolate function. ... Utilizes hashicorp's go-uuid library for proper random seeding setup.	10 years ago
Radek Simko	664ba5f5a6	config: Add new interpolation function - md5	10 years ago
Radek Simko	573d3bd7ab	config: Sort functions mapping alphabetically	10 years ago
Bill Fumerola	c0034e672b	Error out on negative indices in element()	10 years ago
Jeff Zohrab	33d30761dd	Add hint to download modules for new users.	10 years ago
Paul Hinze	9a00675262	Merge pull request #5026 from hashicorp/phinze/destroy-node-copies ... core: Make copies when creating destroy nodes	10 years ago
Paul Hinze	3f72837f4b	core: Make copies when creating destroy nodes ... Fixes an interpolation race that was occurring when a tainted destroy node and a primary destroy node both tried to interpolate a computed count in their config. Since they were sharing a pointer to the _same_ config, depending on how the race played out one of them could catch the config uninterpolated and would then throw a syntax error. The `Copy()` tree implemented for this fix can probably be used elsewhere - basically we should copy the config whenever we drop nodes into the graph - but for now I'm just applying it to the place that fixes this bug. Fixes #4982 - Includes a test covering that race condition.	10 years ago
Radek Simko	4edf782260	Merge pull request #4854 from jfromaniello/add_signum_interpolation ... Add signum interpolation function	10 years ago
Mitchell Hashimoto	5f3de02fa9	remove config/lang, use hashicorp/hil	10 years ago
Radek Simko	ecedcd0032	config: Add base64sha256() function	10 years ago
Colin Hebert	61a40dce13	Update the test file	10 years ago
Colin Hebert	d92d205dd9	rename trim to trimspace	10 years ago
Colin Hebert	d45b7b2ddc	Fix name from strip to trim	10 years ago
Colin Hebert	f5074cd521	Add the trim() interpolation function	10 years ago
José F. Romaniello	c8795b8565	Add signum interpolation function ... This function returns -1 for negative numbers, 0 for 0 and 1 for positive numbers. Useful when you need to set a value for the first resource and a different value for the rest of the resources. Example: `${element(split(",", var.r53_failover_policy), signum(count.index))}`	10 years ago
James Nugent	3bdd1ac8b3	core: Display invalid type in error message ... If a variable type which is invalid (e.g. "stringg") is declared, we now include the invalid type description in the error message to make it easier to track down the source of the error in the source file.	10 years ago