312 Commits (2597ef9da271fb89e09152cfe09ee7a8a4cd3415)

Author	SHA1	Message	Date
Kristin Laemmert	3f5e147ab7	backend/local: adding some informative comments to commented-out tests	8 years ago
Kristin Laemmert	a88fe95ffc	plans/objchange: further harden ProposedNewObject against ~weird~ ... incoming values Addresses an odd state where the priorV of an object to be changed is known but null. While this situation should not happen, it seemed prudent to ensure that core is resilient to providers sending incorrect values (which might also occur with manually edited state).	8 years ago
Kristin Laemmert	256d7b9c1a	backend/local WIP commit - fixing tests	8 years ago
Kristin Laemmert	760d342cb5	backend/local: fix panic in tests ... update the function names in testDelegateBackend to match what was being called in TestLocal_multiStateBackend (matching the test behavior in master)	8 years ago
Martin Atkins	a1962ea156	core: Handle forced-create_before_destroy during the plan walk ... Previously we used a single plan action "Replace" to represent both the destroy-before-create and the create-before-destroy variants of replacing. However, this forces the apply graph builder to jump through a lot of hoops to figure out which nodes need it forced on and rebuild parts of the graph to represent that. If we instead decide between these two cases at plan time, the actual determination of it is more straightforward because each resource is represented by only one node in the plan graph, and then we can ensure we put the right nodes in the graph during DiffTransformer and thus avoid the logic for dealing with deposed instances being spread across various different transformers and node types. As a nice side-effect, this also allows us to show the difference between destroy-then-create and create-then-destroy in the rendered diff in the CLI, although this change doesn't fully implement that yet.	8 years ago
Martin Atkins	d3df77823f	backend/local: Don't count outputs for choosing diff action symbols ... We're not yet showing outputs in the rendered diff, so it doesn't make sense to count them for the purpose of deciding which change action symbols to include in the legend.	8 years ago
Martin Atkins	67ffe4cb59	backend/local: Sort planned resource changes before rendering them ... As in the old plan renderer, they are ordered by the natural ordering of the resource addresses.	8 years ago
Martin Atkins	86e8885bd1	command: initial structural diff rendering ... This is a light adaptation of our earlier prototype of structural diff rendering, as a starting point for what we'll actually ship. This is not consistent with the latest mocks, so will need some additional work before it is ready, but integrating this allows us to at least see the plan contents while fixing up remaining issues elsewhere.	8 years ago
Martin Atkins	2e758a26a1	backend/local: Bail immediately if terraform.Context can't be created	8 years ago
Martin Atkins	23c17cdc7b	terraform: More wiring in of new provider types ... This doesn't actually work yet, but it builds and then panics in a pretty satisfying way.	8 years ago
Martin Atkins	ade3b4575e	terraform: Ugly huge change to weave in new State and Plan types ... Due to how often the state and plan types are referenced throughout Terraform, there isn't a great way to switch them out gradually. As a consequence, this huge commit gets us from the old world to a _compilable_ new world, but still has a large number of known test failures due to key functionality being stubbed out. The stubs here are for anything that interacts with providers, since we now need to do the follow-up work to similarly replace the old terraform.ResourceProvider interface with its replacement in the new "providers" package. That work, along with work to fix the remaining failing tests, will follow in subsequent commits. The aim here was to replace all references to terraform.State and its downstream types with states.State, terraform.Plan with plans.Plan, state.State with statemgr.State, and switch to the new implementations of the state and plan file formats. However, due to the number of times those types are used, this also ended up affecting numerous other parts of core such as terraform.Hook, the backend.Backend interface, and most of the CLI commands. Just as with 5861dbf3fc before, I apologize in advance to the person who inevitably just found this huge commit while spelunking through the commit history.	8 years ago
Martin Atkins	a98d25f41d	move "configschema" from "config" to "configs" ... The "config" package is no longer used and will be removed as part of the 0.12 release cleanup. Since configschema is part of the "new world" of configuration modelling, it makes more sense for it to live as a subdirectory of the newer "configs" package.	8 years ago
Martin Atkins	0bdeee73ea	backend/local: Update tests for changes in "terraform" package ... This mainly consists of adding schema information to the mock providers.	8 years ago
Martin Atkins	5861dbf3fc	terraform: ugly huge change to weave in new HCL2-oriented types ... Due to how deeply the configuration types go into Terraform Core, there isn't a great way to switch out to HCL2 gradually. As a consequence, this huge commit gets us from the old state to a _compilable_ new state, but does not yet attempt to fix any tests and has a number of known missing parts and bugs. We will continue to iterate on this in forthcoming commits, heading back towards passing tests and making Terraform fully-functional again. The three main goals here are: - Use the configuration models from the "configs" package instead of the older models in the "config" package, which is now deprecated and preserved only to help us write our migration tool. - Do expression inspection and evaluation using the functionality of the new "lang" package, instead of the Interpolator type and related functionality in the main "terraform" package. - Represent addresses of various objects using types in the addrs package, rather than hand-constructed strings. This is not critical to support the above, but was a big help during the implementation of these other points since it made it much more explicit what kind of address is expected in each context. Since our new packages are built to accommodate some future planned features that are not yet implemented (e.g. the "for_each" argument on resources, "count"/"for_each" on modules), and since there's still a fair amount of functionality still using old-style APIs, there is a moderate amount of shimming here to connect new assumptions with old, hopefully in a way that makes it easier to find and eliminate these shims later. I apologize in advance to the person who inevitably just found this huge commit while spelunking through the commit history.	8 years ago
Martin Atkins	8edfe2a84f	command: Various updates for the new backend package API ... This is a rather-messy, complex change to get the "command" package building again against the new backend API that was updated for the new configuration loader. A lot of this is mechanical rewriting to the new API, but meta_config.go and meta_backend.go in particular saw some major changes to interface with the new loader APIs and to deal with the change in order of steps in the backend API.	8 years ago
Martin Atkins	6a9f710b12	backend: Update interface and implementations for new config loader ... The new config loader requires some steps to happen in a different order, particularly in regard to knowing the schema in order to decode the configuration. Here we lean directly on the configschema package, rather than on helper/schema.Backend as before, because it's generally sufficient for our needs here and this prepares us for the helper/schema package later moving out into its own repository to seed a "plugin SDK".	8 years ago
James Bardin	f8321b8d79	remove legacy remote state code	8 years ago
James Bardin	979f80e18d	move artifactory remote state to backend	8 years ago
James Bardin	bfc6b4fc25	move legacy http remote state to a backend	8 years ago
James Bardin	2df130edec	move legacy etcd remote state to a backend	8 years ago
Martin Atkins	cc43a0f2f8	command/format: include source snippets in diagnostics ... If we get a diagnostic message that references a source range, and if the source code for the referenced file is available, we'll show a snippet of the source code with the source range highlighted. At the moment we have no cache of source code, so in practice this codepath can never be visited. Callers to format.Diagnostic will be gradually updated in subsequent commits.	8 years ago
Kristin Laemmert	85be12d783	cli: show workspace name in destroy confirmation (#18253) ... * cli: show workspace name in destroy confirmation If the workspace name is not "default", include it in the confirmation message for `terraform destroy`. Fixes #15480	8 years ago
stack72	df9b2913ae	backend/manta: Add support for manta backend tiered path structure ... This was already added to triton-go and is now making its way to the manta backend ``` % acctests backend/remote-state/manta === RUN TestBackend_impl --- PASS: TestBackend_impl (0.00s) === RUN TestBackend --- PASS: TestBackend (27.36s) === RUN TestBackendLocked --- PASS: TestBackendLocked (16.24s) === RUN TestRemoteClient_impl --- PASS: TestRemoteClient_impl (0.00s) === RUN TestRemoteClient --- PASS: TestRemoteClient (3.40s) === RUN TestRemoteClientLocks --- PASS: TestRemoteClientLocks (7.17s) PASS ok github.com/hashicorp/terraform/backend/remote-state/manta ```	8 years ago
James Bardin	28c46d1a90	cleanup temp files from backend tests	8 years ago
stack72	a6f76aa0af	backend/manta: Manta Backend was not dealing with a ResourceNotFound ... Fixes: #17314 We now deal correctly with the creation of the state file - we were not dealing well with a ResourceNotFound error Now that this has been changed around, we try and create the statefile and if there is an error, we look for an existing statefile - previously this was not the order of operations	8 years ago
Martin Atkins	6aefa5835c	Merge #17218: Add -auto-approve to "terraform destroy" for consistency	8 years ago
Paul Tyng	c868092d2d	Standardize http.Client creation with User-Agent	8 years ago
James Bardin	e9a76808df	create clistate.Locker interface ... Simplify the use of clistate.Lock by creating a clistate.Locker instance, which stores the context of locking a state, to allow unlock to be called without knowledge of how the state was locked. This alows the backend code to bring the needed UI methods to the point where the state is locked, and still unlock the state from an outer scope. Provide a NoopLocker as well, so that callers can always call Unlock without verifying the status of the lock. Add the StateLocker field to the backend.Operation, so that the state lock can be carried between the different function scopes of the backend code. This will allow the backend context to lock the state before it's read, while allowing the different operations to unlock the state when they complete.	8 years ago
James Bardin	8242c773b8	missed the local state backend	8 years ago
James Bardin	57cbcbe99d	update remote state tests to use new test helpers	8 years ago
James Bardin	112c37458f	report the proper lock id from a state lock error ... Fix the now failing state unlock test by reporting the correct ID. The ID used by GCS is the generation number of the info object, which isn't known until the info is already written out. While we can't get the correct ID from the info data for the error rmessage, we can update it with the generation number after it's read.	8 years ago
James Bardin	1fee5ae172	update gcs to use the new backend tests	8 years ago
James Bardin	85d6b1d9cc	add test for lock error and force-unlock ... This adds a general test to verify that a remote state backend returns the expected error type when it cannot lock a state. It then extracts the ID reported in the error, and attempts to unlock the state using that ID, which simulated the force-unlock scenario. This is a separate test, since not all backends have persistent locks that can be unlocked later. We also split out the backend test to be called individually as needed.	8 years ago
James Bardin	ef8ed1e275	coalesce the backened interrupt code ... Moves the nested select statements for backend operations into a single function. The only difference in this part was that apply called PersistState, which should be harmless regardless of the type of operation being run.	8 years ago
James Bardin	7cba68326a	always wait for a RunningOperation to return ... If the user wishes to interrupt the running operation, only the first interrupt was communicated to the operation by canceling the provided context. A second interrupt would start the shutdown process, but not communicate this to the running operation. This order of event could cause partial writes of state. What would happen is that once the command returns, the plugin system would stop the provider processes. Once the provider processes dies, all pending Eval operations would return return with an error, and quickly cause the operation to complete. Since the backend code didn't know that the process was shutting down imminently, it would continue by attempting to write out the last known state. Under the right conditions, the process would exit part way through the writing of the state file. Add Stop and Cancel CancelFuncs to the RunningOperation, to allow it to easily differentiate between the two signals. The backend will then be able to detect a shutdown and abort more gracefully. In order to ensure that the backend is not in the process of writing the state out, the command will always attempt to wait for the process to complete after cancellation.	8 years ago
Laura Martin	6e1e614a56	Change -force to -auto-approve when destroying ... Since an early version of Terraform, the `destroy` command has always had the `-force` flag to allow an auto approval of the interactive prompt. 0.11 introduced `-auto-approve` as default to `false` when using the `apply` command. The `-auto-approve` flag was introduced to reduce ambiguity of it's function, but the `-force` flag was never updated for a destroy. People often use wrappers when automating commands in Terraform, and the inconsistency between `apply` and `destroy` means that additional logic must be added to the wrappers to do similar functions. Both commands are more or less able to run with similar syntax, and also heavily share their code. This commit updates the command in `destroy` to use the `-auto-approve` flag making working with the Terraform CLI a more consistent experience. We leave in `-force` in `destroy` for the time-being and flag it as deprecated to ensure a safe switchover period.	8 years ago
James Bardin	a5ed7d0ae4	Merge pull request #17086 from hashicorp/jbardin/GH-17083 ... only split the prefix string once from the s3 key	8 years ago
stack72	e9476c6765	backend/manta: Update manta dependencies ... Internally, triton-go has changed how it handles errors. We can now get rid of checking strings for errors, and we have introduced an errors library that wraps some of the major errors we encounter and test for	8 years ago
Masayuki Morita	f440dba137	Standardize on log level "WARN" rather than "WARNING"	8 years ago
James Bardin	43d000625d	only split the prefix string once from the s3 key ... Ensure that the prefix is only split off a single time when the workspace_key_prefix is a substring of the workspace or key name.	8 years ago
Stefan Schmidt	c200c170ad	Handle refresh errors.	8 years ago
Paddy	e4cdbd6c9f	Merge pull request #16936 from negz/gcskeys ... Support 'customer supplied encryption keys' in the GCS backend	8 years ago
James Bardin	7c703f2ab2	Merge pull request #16932 from rv-jmaggio/master ... Fixing issues with workspace_key_prefix for s3 backend	9 years ago
James Bardin	dd5882e5b2	Merge pull request #16992 from hashicorp/jbardin/go1.10-prep ... go1.10 prep	9 years ago
goraxe	fb6b349e58	backend/s3: Allow forcing use of the S3 path-style API ... This is useful when the underlying API is an S3-workalike service, rather than official S3.	9 years ago
Paul Stack	191cf283d5	backend/manta: Support Triton RBAC ... Triton Manta allows an account other than the main triton account to be used via RBAC. Here we expose the SDC_USER / TRITON_USER options to the backend so that a user can be specified.	9 years ago
James Bardin	4b49a323c3	go fmt ... slight change to go fmt coming in 0.10	9 years ago
rv-jmaggio	b313ce80c4	Changing prefix for empty workspace prefix	9 years ago
Henry Bell	56357c0ab7	Fix typo ('depracted' -> 'deprecated')	9 years ago
rv-jmaggio	bef64cfe91	Fixing implementation for empty string and making acceptance test work	9 years ago