13 Commits (1e2da4f776bdf74058154ed31c4cd62b052d3f2d)

Author	SHA1	Message	Date
Radek Simko	95cbf1c282	Fix copy-paste errors in test data	7 years ago
Martin Atkins	d41fc8d517	states/statefile: additional context for some v3 upgrade error messages ... Some of our errors returned here were lacking context about what part of the file was problematic, which led to some useless error reporting for some real-world situations that this upgrade process doesn't seem to be catching. Here we add additional context to those error cases, as a step towards tracking down exactly which upgrade cases are missing here so that we can potentially fix them in a subsequent release.	7 years ago
Masayuki Morita	ac83827c90	states/statefile: decode backend hash as uint64 ... Fixes #21478 In #19688, `terraform.BackendState.Hash` was fixed. We also need to fix `states/statefile.backendStateV2.Hash`	7 years ago
James Bardin	1e1dcfd95a	always write the current state terraform_version ... Any time a new state is written, the current terraform version should be recorded.	7 years ago
Kristin Laemmert	d7dda4e436	states/statefile: upgrade legacy dependency syntax (#21159) ... We used to allow "foo.1" etc as a reference, but now it's "foo[1]".	7 years ago
Sander van Harmelen	634430ebb2	Fix wildcard dependencies when upgrading states ... Fixes #19347	8 years ago
Martin Atkins	9ba399bca8	command: Fix TestInit_getProvider ... After all of the refactoring we were no longer checking the Terraform version field in a state file, causing this test to fail. This restores that check, though with a slightly different error message.	8 years ago
Martin Atkins	331cb07a05	states/statefile: Tolerate nil state in statefile.New ... For historical reasons sometimes we have nil state in situations where we'd still like to persist state snapshots to a store. To make life easier for those callers, we'll substitute an empty state if we are given a nil one, thus allowing us to still generate a valid serialization that will load back in as an empty state.	8 years ago
Martin Atkins	b0016e9cf6	command: Allow tests to run to completion without panics or hangs ... There are still 160 test failures as of this commit, but at least the test program can run to completion and list out all the failures.	8 years ago
Martin Atkins	fb57801dfe	states: object Private data is []byte, not cty.Value ... We're going to allow the provider to encode whatever it wants in here, so a provider can use whatever is most convenient for its implementation language and to avoid some of the bugs we saw with the prior model where the forced round-trip through JSON and back into interface{} would cause some loss of fidelity, leading to bugs.	8 years ago
Martin Atkins	a3403f2766	terraform: Ugly huge change to weave in new State and Plan types ... Due to how often the state and plan types are referenced throughout Terraform, there isn't a great way to switch them out gradually. As a consequence, this huge commit gets us from the old world to a _compilable_ new world, but still has a large number of known test failures due to key functionality being stubbed out. The stubs here are for anything that interacts with providers, since we now need to do the follow-up work to similarly replace the old terraform.ResourceProvider interface with its replacement in the new "providers" package. That work, along with work to fix the remaining failing tests, will follow in subsequent commits. The aim here was to replace all references to terraform.State and its downstream types with states.State, terraform.Plan with plans.Plan, state.State with statemgr.State, and switch to the new implementations of the state and plan file formats. However, due to the number of times those types are used, this also ended up affecting numerous other parts of core such as terraform.Hook, the backend.Backend interface, and most of the CLI commands. Just as with 5861dbf3fc before, I apologize in advance to the person who inevitably just found this huge commit while spelunking through the commit history.	8 years ago
Martin Atkins	424afe0ace	states: separate types for encoded and decoded state objects ... The types here were originally written to allow us to defer decoding of object values until schemas are available, but it turns out that this was forcing us to defer decoding longer than necessary and potentially decode the same value multiple times. To avoid this, we create pairs of types to represent the encoded and decoded versions and methods for moving between them. These types are identical to one another apart from how the dynamic values are represented.	8 years ago
Martin Atkins	5c1c6e9d9c	statefile: New package for loading and saving state files ... Whereas the parent directory "states" contains the models that represent state in memory, this package's responsibility is in serializing a subset of that data to a JSON-based file format and then reloading that data back into memory later. For reading, this package supports state file formats going back to version 1, using lightly-adapted versions of the migration code previously used in the "terraform" package. State data is upgraded to the latest version step by step and then transformed into the in-memory state representation, which is distinct from any of the file format structs in this package to enable these to evolve separately. For writing, only the latest version (4) is supported, which is a new format that is a slightly-flattened version of the new in-memory state models introduced in the prior commit. This format retains the outputs from only the root module and it flattens out the module and instance parts of the hierarchy by including the identifiers for these inside the child object. The loader then reconstructs the multi-layer structure we use for more convenient access in memory. For now, the only testing in this package is of round-tripping different versions of state through a read and a write, ensuring the output is as desired. This exercises all of the reading, upgrading, and writing functions but should be augmented in later commits to improve coverage and introduce more focused tests for specific parts of the functionality.	8 years ago