115 Commits (1e2da4f776bdf74058154ed31c4cd62b052d3f2d)

Author	SHA1	Message	Date
Alex Pilon	c2bc88fc23	prune ResourceProviderFullName and its callers	7 years ago
Radek Simko	5b9f2fafc8	Standardise directory name for test data	7 years ago
Martin Atkins	87e1fb4d66	config: a nicer error message for invalid provider constraints ... Previously our error message here was confusing and redundant: Error starting operation: provider.null: invalid version constraint "not valid": Malformed constraint: not valid Instead, we'll generate a full HCL2 diagnostic here, which results in something (subjectively) nicer: Error: Invalid provider version constraint The value "@ 1.0.0" given for provider.null is not a valid version constraint. At the moment this message is an outlier in that the other validation errors are all still just plain Go errors, but over time we'll want to adjust all of these to be full diagnostics so that we can embed source range information in them to help the user find the offending configuration.	9 years ago
James Bardin	048af6e237	Add test fixture to check for warnings	9 years ago
Martin Atkins	ba0514106a	return tfdiags.Diagnostics from validation methods ... Validation is the best time to return detailed diagnostics to the user since we're much more likely to have source location information, etc than we are in later operations. This change doesn't actually add any detail to the messages yet, but it changes the interface so that we can gradually introduce more detailed diagnostics over time. While here there are some minor adjustments to some of the messages to improve their consistency with terminology we use elsewhere.	9 years ago
James Bardin	8619f566bb	validate providers passed to a module exist ... This validation was lost in the migration of inheritance back to core. Make sure a module configuraton doesn't specifiy a provider that doesn't exist.	9 years ago
James Bardin	29e5a355b9	add "version" and "provider" to module config ... Add the Version and Providers fields to the module config. Add ProviderConfig.Scope, which will be used to record the original path of a ProviderConfig for interpolation.	9 years ago
Martin Atkins	bbf9725134	config: Validate resource "count" for HCL2-specified resources ... This early validation uses interpolation of a placeholder value to achieve some "best effort" validation of the validity of the count attribute. Since HCL2-specified resources can't be interpolated using the main interpolator, here we branch and use the HCL2 API to do a largely-equivalent (though slightly less accurate) check. In the long run we don't really need this extra check at all, since the validation walk does a more accurate version of the same thing. However, we're preserving this for now in the interests of minimizing the amount of change for the main codepath during our experiment.	9 years ago
Martin Atkins	71e68f06c4	config: allow tests to force using the HCL2 loader ... Currently the default for tests is to use the old HCL loader, but we need to be able to test aspects of the new loader as we work through the experimental phase. This new function testConfigHCL2 is the same as testConfig except that it forces the use of HCL2 even if the opt-in comment isn't present, thus allowing us to implement tests that ensure that the exact same file works in both the old and new cases. Once the HCL2 loader becomes the default this function will be removed and callers will start calling into the normal testConfig function.	9 years ago
Martin Atkins	0a342e8dc2	config: allow local value interpolations in count ... There is some additional, early validation on the "count" meta-argument that verifies that only suitable variable types are used, and adding local values to this whitelist was missed in the initial implementation.	9 years ago
Martin Atkins	8cd0ee80e5	config: merge/append for local values ... It seems that this somehow got lost in the commit/rebase shuffle and wasn't caught by the tests that _did_ make it because they were all using just one file. As a result of this bug, locals would fail to work correctly in any configuration with more than one .tf file. Along with restoring the append/merge behavior, this also reworks some of the tests to exercise the multi-file case as better insurance against regressions of this sort in future. This fixes #15969.	9 years ago
Martin Atkins	f70318097a	config: fix provider version constraint validation ... Previously we were using the "semver" library to parse version constraints, but we switched over to go-version and encapsulated it inside our own plugin/discovery package to reduce dependency sprawl in the code. This particular situation was missed when updating references to the new path, which meant that our validation code disagreed with the rest of the code about what is considered a valid version constraint string. By using the correct function, we ensure that we catch early any invalid versions.	9 years ago
Martin Atkins	0b14c2cdb3	Resolve resource provider types in config package ... Previously the logic for inferring a provider type from a resource name was buried a utility function in the 'terraform' package. Instead here we lift it up into the 'config' package where we can make broader use of it and where it's easier to discover.	9 years ago
Martin Atkins	7e7d4c70df	config: allow version constraints on providers, but validate them ... We now accept syntactically-valid version constraints on provider blocks, though we still don't actually do anything with them.	9 years ago
Martin Atkins	73fc9985b2	config: add "version" argument to provider blocks, disabled ... In future we will support version constraints on providers, so we're reserving this attribute name that is currently not used by any builtin providers. For now using this will produce an error, since the rest of Terraform (outside of the config parser) doesn't currently have this notion and we don't want people to start trying to use it until its behavior is fully defined and implemented. It may be used by third-party providers, so this is a breaking change worth warning about in CHANGELOG but one whose impact should be small. Any third-party providers using this name should migrate to using a new attribute name instead moving forward.	9 years ago
Martin Atkins	410b60cb7f	Stop requiring multi-vars (splats) to be in array brackets ... Prior to Terraform 0.7, lists in Terraform were just a shallow abstraction on top of strings with a magic delimiter between items. Wrapping a single string in brackets in the configuration was Terraform's prompt that it needed to split the string on that delimiter during interpolation. In 0.7, when first-class lists were added, this convention was preserved by flattening lists-of-lists by one level when they were encountered in configuration. However, there was an oversight in that change where it did not correctly handle the case where the inner list was unknown. In #14135 we removed some code that was flattening partially-unknown lists into fully-unknown (untyped) values. This inadvertently exposed the missed case from the previous paragraph, causing issues for list-wrapped splat expressions with unknown members. While this worked fine for resources, due to some fixup done inside helper/schema, this did not work for other interpolation contexts such as module blocks. Various attempts to fix this up and restore the flattening behavior selectively were unsuccessful, due to a proliferation of assumptions all over the core code that would be too risky to change just to fix this bug. This change, then, takes the different approach of removing the requirement that splats be presented inside list brackets. This requirement didn't make much sense anymore anyway, since no other list-returning expression had this constraint and so the rest of Terraform was already successfully dealing with both cases. This leaves us with two different scenarios: - For resource arguments, existing normalization code in helper/schema does its own flattening that preserves compatibility with the common practice of using bracketed splats. This change proves this with a test within the "test" provider that exercises the whole Terraform core and helper/schema stack that assigns bracketed splats to list and set attributes. - For arguments in other blocks, such as in module callsites, the interpolator's own flattening behavior applies to known lists, preserving compatibility with configurations from before partially-computed splats were possible, but those wishing to use partially-computed splats are required to drop the surrounding brackets. This is less concerning because this scenario was introduced only in 0.9.5, so the scope for breakage is limited to those who adopted this new feature quickly after upgrading. As of this commit, the recommendation is to stop using brackets around splats but the old form continues to be supported for backward compatibility. In a future _major_ version of Terraform we will probably phase out this legacy form to improve consistency, but for now both forms are acceptable at the expense of some (pre-existing) weird behavior when _actual_ lists-of-lists are used. This addresses #14521 by officially adopting the suggested workaround of dropping the brackets around the splat. However, it doesn't yet allow passing of a partially-unknown list between modules: that still violates assumptions in Terraform's core, so for the moment partially-unknown lists work only within a _single_ interpolation expression, and cannot be passed around between expressions. Until more holistic work is done to improve Terraform's type handling, passing a partially-unknown splat through to a module will result in a fully-unknown list emerging on the other side, just as was the case before #14135; this change just addresses the fact that this was failing with an error in 0.9.5.	9 years ago
Martin Atkins	76dca009e0	Allow escaped interpolation-like sequences in variable defaults ... The variable validator assumes that any AST node it gets from an interpolation walk is an indicator of an interpolation. Unfortunately, back in f223be15 we changed the interpolation walker to emit a LiteralNode as a way to signal that the result is a literal but not identical to the input due to escapes. The existence of this issue suggests a bit of a design smell in that the interpolation walker interface at first glance appears to skip over all literals, but it actually emits them in this one situation. In the long run we should perhaps think about whether the abstraction is right here, but this is a shallow, tactical change that fixes #13001.	9 years ago
James Bardin	a111635908	Fix panic in interpolate_walk ... Verify that we have enough containers in the stack to look for a map in replaceCurrent.	9 years ago
James Bardin	3c41a7ca1e	Add test for Validate crash ... Crash during Validate walk with nested variable default.	9 years ago
Mitchell Hashimoto	6b4c007894	config: validate backend configuration can't contain interpolations	9 years ago
Mitchell Hashimoto	b6bfc4798d	config: Resource.Count should type check ... Fixes #11800 Type check the value of count so we don't panic on the conversion. I wondered "why didn't we do this before?" There is no excuse for NOT doing it at all but the reasoning was beacuse prior to the list/map work in 0.7, the value couldn't be anything other than a string since any primitive can turn into a string. Regardless, we should've always done this.	9 years ago
Mitchell Hashimoto	cf46e1c3e0	terraform: don't validate computed values in validate ... This disables the computed value check for `count` during the validation pass. This enables partial support for #3888 or #1497: as long as the value is non-computed during the plan, complex values will work in counts. **Notably, this allows data source values to be present in counts!** The "count" value can be disabled during validation safely because we can treat it as if any field that uses `count.index` is computed for validation. We then validate a single instance (as if `count = 1`) just to make sure all required fields are set.	9 years ago
Mitchell Hashimoto	928fce71f7	config: parse "when" and "on_failure" on provisioners	9 years ago
Mitchell Hashimoto	0c30caec7d	config: smarter provider alias usage validation ... Fixes #4789 This improves the validation that valid provider aliases are used. Previously, we required that provider aliases be defined in every module they're used. This isn't correct because the alias may be used in a parent module and inherited. This removes that validation and creates the validation that a provider alias must be defined in the used module or _any parent_. This allows inheritance to work properly. We've always had this type of validation for aliases because we believe its a good UX tradeoff: typo-ing an alias is really painful, so we require declaration of alias usage. It may add a small burden to declare, but since relatively few aliases are used, it improves the scenario where a user fat-fingers an alias name.	9 years ago
Mitchell Hashimoto	3665fea2db	config: validate that data sources don't have provisioners	10 years ago
Martin Atkins	399542a168	core: allow outputs to have descriptions (#9722) ... We allow variables to have descriptions specified, as additional context for a module user as to what should be provided for a given variable. We previously lacked a similar mechanism for outputs. Since they too are part of a module's public interface, it makes sense to be able to add descriptions for these for symmetry's sake. This change makes a "description" attribute valid within an "output" configuration block and stores it within the configuration data structure, but doesn't yet do anything further with it. For now this is useful only for third-party tools that might parse a module's config to generate user documentation; later we could expose the descriptions as part of the "apply" output, but that is left for a separate change.	10 years ago
Mitchell Hashimoto	25d19ef3d0	Merge pull request #10080 from hashicorp/f-tf-version ... terraform: support version requirement in configuration	10 years ago
Mitchell Hashimoto	85d3439fa0	config: parse and validate terraform.required_version	10 years ago
Mitchell Hashimoto	576b61a21d	config: validate depends_on with module values	10 years ago
Mitchell Hashimoto	694b16de5d	config: ignore_changes cannot have interpolations ... This is the limitation of all lifecycle attributes currently. Right now, interpolations are allowed through and the user ends up thinking it should work. We should give an error. In the future it should be possible to support some minimal set of interpolations (static variables, data sources even perhaps) but for now let's validate that this doesn't work.	10 years ago
Mitchell Hashimoto	609219fc65	command/meta: validate config immediately ... * config: test for validating multi-vars (passes) * command/plan: test invalid run * command/meta: validate module on load	10 years ago
James Bardin	94674fe93c	Add a test load of a data source with count	10 years ago
Sander van Harmelen	47dd1ad153	Add wildcard (match all) support to ignore_changes (#8599)	10 years ago
Mitchell Hashimoto	fbf06e2a59	config: vars must be unique	10 years ago
Mitchell Hashimoto	099293b690	config: outputs must be unique	10 years ago
Mitchell Hashimoto	f4faf2274b	config: count can't be a SimpleVariable	10 years ago
James Bardin	1af7ee87a2	Silence log output when not verbose ... Set the default log package output to iotuil.Discard during tests if the `-v` flag isn't set. If we are verbose, then apply the filter according to the TF_LOG env variable.	10 years ago
James Nugent	01cd596c60	core: Fix detection of empty list/map defaults ... This commit changes config parsing from weak decoding lists and maps into []string and map[string]string respectively to decode into []interface{} and map[string]interface{} respectively. This is in order to take advantage of the work integrated in #7082 to defeat the backward compatibility features of the mapstructure library. Test coverage of loading empty variables and validating their default types against expectation.	10 years ago
James Nugent	f1d0fc46aa	core: Fix go vet issues shown by Travis	10 years ago
James Nugent	f49583d25a	core: support native list variables in config ... This commit adds support for native list variables and outputs, building up on the previous change to state. Interpolation functions now return native lists in preference to StringList. List variables are defined like this: variable "test" { # This can also be inferred type = "list" default = ["Hello", "World"] } output "test_out" { value = "${var.a_list}" } This results in the following state: ``` ... "outputs": { "test_out": [ "hello", "world" ] }, ... ``` And the result of terraform output is as follows: ``` $ terraform output test_out = [ hello world ] ``` Using the output name, an xargs-friendly representation is output: ``` $ terraform output test_out hello world ``` The output command also supports indexing into the list (with appropriate range checking and no wrapping): ``` $ terraform output test_out 1 world ``` Along with maps, list outputs from one module may be passed as variables into another, removing the need for the `join(",", var.list_as_string)` and `split(",", var.list_as_string)` which was previously necessary in Terraform configuration. This commit also updates the tests and implementations of built-in interpolation functions to take and return native lists where appropriate. A backwards compatibility note: previously the concat interpolation function was capable of concatenating either strings or lists. The strings use case was deprectated a long time ago but still remained. Because we cannot return `ast.TypeAny` from an interpolation function, this use case is no longer supported for strings - `concat` is only capable of concatenating lists. This should not be a huge issue - the type checker picks up incorrect parameters, and the native HIL string concatenation - or the `join` function - can be used to replicate the missing behaviour.	10 years ago
James Nugent	e57a399d71	core: Use native HIL maps instead of flatmaps ... This changes the representation of maps in the interpolator from the dotted flatmap form of a string variable named "var.variablename.key" per map element to use native HIL maps instead. This involves porting some of the interpolation functions in order to keep the tests green, and adding support for map outputs. There is one backwards incompatibility: as a result of an implementation detail of maps, one could access an indexed map variable using the syntax "${var.variablename.key}". This is no longer possible - instead HIL native syntax - "${var.variablename["key"]}" must be used. This was previously documented, (though not heavily used) so it must be noted as a backward compatibility issue for Terraform 0.7.	10 years ago
Paul Hinze	567a9b9e06	config: remove missing equals test to fix build ... This is behavior that's covered in the parser now - and the error message is nicer to boot!	10 years ago
Paul Hinze	3f72837f4b	core: Make copies when creating destroy nodes ... Fixes an interpolation race that was occurring when a tainted destroy node and a primary destroy node both tried to interpolate a computed count in their config. Since they were sharing a pointer to the _same_ config, depending on how the race played out one of them could catch the config uninterpolated and would then throw a syntax error. The `Copy()` tree implemented for this fix can probably be used elsewhere - basically we should copy the config whenever we drop nodes into the graph - but for now I'm just applying it to the place that fixes this bug. Fixes #4982 - Includes a test covering that race condition.	10 years ago
Paul Hinze	87a9701f91	config: validation error when output is missing value field ... Also lists out invalid keys in errmsg when they are present Closes #4398	10 years ago
Sander van Harmelen	c62370f9e9	Add a function to load JSON directly ... Without this 12 line function it’s impossible to use any of the Terraform code without the need for having the files on disk. As more and more people are using (parts of) Terraform in other software, this seems to be a very welcome addition. It has no negative impact on Terraform itself whatsoever (the function is never called), but it opens up a lot of other use cases. Next to the single new function, I renamed the existing function (and related tests) to better reflect what the function does. So now there is a `LoadDir` function which calls `LoadFile` for each file, which kind of made sense to me, especially when now adding a `LoadJSON` function as well. But of course if the rename is a problem, I can revert that part as it’s not related to the added `LoadJSON` function. Thanks!	11 years ago
Mitchell Hashimoto	cca4964552	config: error in validation if module has self variable	11 years ago
Mitchell Hashimoto	d0a6d78b97	config: test that resources reference good providers	11 years ago
Mitchell Hashimoto	8ee18e2e14	config: happy case test for multiple providers	11 years ago
Mitchell Hashimoto	a599d5f224	config: validate that a multi provider is only configured once each	11 years ago
Paul Hinze	975a96f271	core: protect against count.index in modules ... Modules should get a validation error just like outputs do. refs #1528	11 years ago