68 Commits (15abbe21c00b341c4034da035b4fa1a885083bfc)

Author	SHA1	Message	Date
clint shryock	61355c33c5	testing: Add option to run only a plan on a TestStep configuration	9 years ago
James Bardin	6fcb55d09e	reword TestProvider doc	9 years ago
James Bardin	1eb9a2d083	Reset ResourceProviders ... Call all ResourceProviderFactories and reset the providers before tests. Store the provider and/or the error in a fixed factory function to be returned again later.	9 years ago
Kit Ewbank	64fda44b00	Add 'aws_vpn_gateway' data source. (#11886)	9 years ago
Kit Ewbank	87d98b1ff1	Correct aws_s3_bucket_object data source acceptance tests. (#11346)	9 years ago
Sean Chittenden	7862e5b499	Differentiate between lookup failure and value inequality. ... Before this patch it was not possible to test for a key in a map where the value is an empty string. With this patch, however, it is now possible to write a check like: ``` resource.TestCheckResourceAttr("res.name", "mymap.KeyWithEmptyValue", ""), ``` To test that `KeyWithEmptyValue` is a valid key in `mymap`.	9 years ago
James Nugent	b551981cc7	testing: Add ComposeAggregateTestFunc ... This commit adds a function which composes a series of TestFuncs, but will run all tests before returning an error, unlike ComposeTestFunc. This is useful when verifying contents of state in acceptance tests and it is desirable to see all the failing cases in one run for slow resources.	10 years ago
James Nugent	b681ab23d3	testing: Add TestCheckResourceAttrSet helper ... This commit adds a TestCheckFunc which ensures that a value is set for a given name/key combination. It is primarily useful for ensuring that computed values are set where it is not possible to know the expected value ahead of time.	10 years ago
Paul Hinze	3b732131d2	Merge pull request #7446 from hashicorp/b-jit-resource-validate ... core: rerun resource validation before plan and apply	10 years ago
Paul Hinze	4a1b36ac0d	core: rerun resource validation before plan and apply ... In #7170 we found two scenarios where the type checking done during the `context.Validate()` graph walk was circumvented, and the subsequent assumption of type safety in the provider's `Diff()` implementation caused panics. Both scenarios have to do with interpolations that reference Computed values. The sentinel we use to indicate that a value is Computed does not carry any type information with it yet. That means that an incorrect reference to a list or a map in a string attribute can "sneak through" validation only to crop up... 1. ...during Plan for Data Source References 2. ...during Apply for Resource references In order to address this, we: * add high-level tests for each of these two scenarios in `provider/test` * add context-level tests for the same two scenarios in `terraform` (these tests proved _really_ tricky to write!) * place an `EvalValidateResource` just before `EvalDiff` and `EvalApply` to catch these errors * add some plumbing to `Plan()` and `Apply()` to return validation errors, which were previously only generated during `Validate()` * wrap unit-tests around `EvalValidateResource` * add an `IgnoreWarnings` option to `EvalValidateResource` to prevent active warnings from halting execution on the second-pass validation Eventually, we might be able to attach type information to Computed values, which would allow for these errors to be caught earlier. For now, this solution keeps us safe from panics and raises the proper errors to the user. Fixes #7170	10 years ago
Paul Hinze	5656d7388c	helper/resource: Consolidate unit test override ... I noticed we had two mechanisms for unit test override. One that dropped a sentinel into the env var, and another with a struct member on TestCase. This consolidates the two, using the cleaner struct member internal mechanism and the nicer `resource.UnitTest()` entry point.	10 years ago
Patrick Sodré	80936e3562	provider/triton: add machine domain names (#7149) ... * vendor joyent/gosdc/cloudapi * provider/triton: Add machine domain names - Includes acceptance test.	10 years ago
James Nugent	9c7cf639b3	testing: Allow acceptance test to run as unit test ... This commit adds a flag to acceptance tests in order to make appropriately named tests work during `make test` irrespective of the TF_ACC environment variable. This should only be used on tests which are known to be fast.	10 years ago
Radek Simko	84ab00d92e	helper/resource: Add TestStep.PreventPostDestroyRefresh ... - This is to allow easier testing of data sources which read data from resources created in the same scope	10 years ago
Mitchell Hashimoto	55583baa7e	Merge branch 'f-aws-import'	10 years ago
James Nugent	3ea3c657b5	core: Use OutputState in JSON instead of map ... This commit forward ports the changes made for 0.6.17, in order to store the type and sensitive flag against outputs. It also refactors the logic of the import for V0 to V1 state, and fixes up the call sites of the new format for outputs in V2 state. Finally we fix up tests which did not previously set a state version where one is required.	10 years ago
Mitchell Hashimoto	884980da1a	providers/aws: instance, nat, internet gateway	10 years ago
Mitchell Hashimoto	6a675b4a15	helper/resource: ImportState test can verify states	10 years ago
Mitchell Hashimoto	2d99c451fb	helper/resource: basic ImportState acceptance testing ... Still some TODOs, and more test cases to write, but the basics are all here.	10 years ago
Mitchell Hashimoto	9bd1c9e7ca	helper/resource: reshuffling to prepare for importstate testing	10 years ago
Mitchell Hashimoto	35c87836b4	core: Add terraform_version to state ... This adds a field terraform_version to the state that represents the Terraform version that wrote that state. If Terraform encounters a state written by a future version, it will error. You must use at least the version that wrote that state. Internally we have fields to override this behavior (StateFutureAllowed), but I chose not to expose them as CLI flags, since the user can just modify the state directly. This is tricky, but should be tricky to represent the horrible disaster that can happen by enabling it. We didn't have to bump the state format version since the absense of the field means it was written by version "0.0.0" which will always be older. In effect though this change will always apply to version 2 of the state since it appears in 0.7 which bumped the version for other purposes.	10 years ago
Mitchell Hashimoto	d85df63526	providers/aws: aws_instance id-only	10 years ago
Mitchell Hashimoto	e0da21d381	helper/resource: make id-only check opt-in ... As I've been working through the resources, I'm finding that a lot are going to need some serious work. Given we have hundreds, I think it might be prudent to make this opt-in for now and we can revisit automatic/opt-out at some future point. Importability will likely be opt-in it appears so this will match up with that.	10 years ago
Mitchell Hashimoto	ff7b58f032	providers/aws: peering connection id-only test settings	10 years ago
Mitchell Hashimoto	0ef1b3b84a	providers/aws: response value for DescribeVpcAttribute needs to be ... .Value	10 years ago
Mitchell Hashimoto	1db1bf6639	helper/resource: use the full config for id-only checks ... Originally I used an empty config module. This caused problems since important provider configurations weren't available. Instead, I now set it to use the full config. This isn't an issue since the attributes themselves aren't available to Refresh anyways.	10 years ago
Mitchell Hashimoto	0c8b0bff2c	helper/resource: can specify specific name to id refresh test	10 years ago
Mitchell Hashimoto	1a9fae6b2e	helper/resource: can disable ID refresh check	10 years ago
Mitchell Hashimoto	35f4201b9e	providers/aws: instance_tenancy is computed, set	10 years ago
Mitchell Hashimoto	5c4f78796b	helper/resource: don't need to id-only check if no test steps	10 years ago
Mitchell Hashimoto	a285c04dc9	helper/resource: only verify id-only run if no error	10 years ago
Mitchell Hashimoto	baac14aaeb	helper/resource: guard id-only by acc var	10 years ago
Mitchell Hashimoto	cb32cb8947	helper/resource: error if id-only check didn't run	10 years ago
Mitchell Hashimoto	060b43fbd9	helper/resource: remove debug	10 years ago
Mitchell Hashimoto	4f6edf4fe4	helper/resource: id-only refresh testing	10 years ago
James Nugent	35f9d2e081	Add TestCheckOutput helper to resource testing ... This allows outputs in test configuration to have test functions written conveniently. Useful for azurerm_template_deployment.	10 years ago
Paul Hinze	c3e27b3e0a	provider/test: a test provider ... Here we also introduce a `test` provider meant as an aid to exposing via automated tests issues involving interactions between `helper/schema` and Terraform core. This has been helpful so far in diagnosing `ignore_changes` problems, and I imagine it will be helpful in other contexts as well. We'll have to be careful to prevent the `test` provider from becoming a dumping ground for poorly specified tests that have a clear home elsewhere. But for bug exposure I think it's useful to have.	10 years ago
Paul Hinze	bba8a79a52	acctests: log a line w/ the non-empty plan ... Helpful when iterating on a drift test. Eventually I think this assertion could be fanned out to something much more targeted like: ExpectAttributeDiff(resource, attr, oldval, newval) But this is a step in the right direction.	10 years ago
Paul Hinze	24048b4dca	providers: Mention check number when acctest fails	10 years ago
Paul Hinze	a8d2ad3ebe	refactor s3 bucket test to expect non-empty plan ... pushing to master but paging @catsby for post-hoc review	10 years ago
James Nugent	e976d6e787	testing: Use a copy of pre-destroy state in destroy check ... In the acceptance testing framework, it is neccessary to provide a copy of the state _before_ the destroy is applied to the check in order that it can loop over resources to verify their destruction. This patch makes a deep copy of the state prior to applying test steps which have the Destroy option set and then passes that to the destroy check.	11 years ago
Paul Hinze	4bd4e18def	core: use same logging setup for acctests ... We weren't doing any log setup for acceptance tests, which made it difficult to wrangle log output in CI. This moves the log setup functions we use in `main` over into a helper package so we can use them for acceptance tests as well. This means that acceptance tests will by default be a _lot_ quieter, only printing out actual test output. Setting `TF_LOG=trace` will restore the full prior noise level. Only minor behavior change is to make `ioutil.Discard` the default return value rather than a `nil` that needs to be checked for.	11 years ago
Mitchell Hashimoto	344e7c26b5	fix a bunch of tests from go-getter import	11 years ago
Radek Simko	9882cc59d8	aws: Add regression test for renaming ecs_cluster	11 years ago
Paul Hinze	385b17d679	provider/template: don't error when rendering fails in Exists ... The Exists function can run in a context where the contents of the template have changed, but it uses the old set of variables from the state. This means that when the set of variables changes, rendering will fail in Exists. This was returning an error, but really it just needs to be treated as a scenario where the template needs re-rendering. fixes #2344 and possibly a few other template issues floating around	11 years ago
Paul Hinze	a96a3372c6	provider/template: don't diff when there's no diff ... This reworks the template lifecycle a bit such that we get nicer diff behavior. First, we tick ForceNew on for both filename and vars, so that the diff indicates that the template will be "replaced" on change. This is mostly cosmetic, but it also tracks conceptually with the fact that the identifier we use is a hash of the contents, so any change essentially makes a "new resource". Second, we change the Exists implementation to only return `false` when there has been a change in the rendered template. This lets descendent resources see the computed value changing so that they'll properly trigger in the plan. Fixes #1898 Refs #1866 (but does not fix, there's another deeper issue there)	11 years ago
Paul Hinze	fbce3a3caa	helper/resource: don't fail test on config warnings ... AccTests like TestAccComputeInstance_basic_deprecated_network were failing early on "invalid config" when we are explictly testing behavior that we know generates warnings.	11 years ago
Josh Bleecher Snyder	76bcac3031	providers/template: add tests, address review comments ... Do directory expansion on filenames. Add basic acceptance tests. Code coverage is 72.5%. Uncovered code is uninteresting and/or impossible error cases. Note that this required adding a knob to helper/resource.TestStep to allow transient resources.	11 years ago
Paul Hinze	88744d569f	helper/resource/testing: unit tests to cover #1770 ... Also clarified that final return value of testStep is now only for the happy path.	11 years ago
Paul Hinze	dbf6d1bd00	helper/resource: fix accidentaly swallowing of acctest step errors ... With #1757 I unwittingly reused an err variable, causing all test check errors to be swallowed. -_-	11 years ago