2605 Commits (148b19b0d7e36b6f2b8a169d2cb7b6069ab5d00a)

Author	SHA1	Message	Date
Mutahhir Hayat	148b19b0d7	return validate value instead of dynamic value	2 years ago
Mutahhir Hayat	d398fa50c6	handle overlooked error in test	2 years ago
Mutahhir Hayat	cb28bf3379	remove unused test	2 years ago
Mutahhir Hayat	e20891ac1d	add tests for local values through data sources	2 years ago
Mutahhir Hayat	6bbc8cdc76	Add more tests for local values	2 years ago
Mutahhir Hayat	2667a0f2c3	cleanup comments	2 years ago
Mutahhir Hayat	5e12bdf048	Stack evaluation should also visit local values when walking the stack	2 years ago
Mutahhir Hayat	be317d4d3a	Make Stack and Stack config aware of local values	2 years ago
Mutahhir Hayat	6554ce6bfd	Add planning test to test for locals usage	2 years ago
Mutahhir Hayat	129d58fed3	Create local value structs, including config and tests	2 years ago
Mutahhir Hayat	d695f8197c	Add local values test	2 years ago
Daniel Schmidt	f3764ead4c	Merge pull request #35118 from hashicorp/consistency-provider-deferred ... stacks: error if provider emits deferred action when it's not supported	2 years ago
James Bardin	147186c84b	Merge pull request #35090 from hashicorp/jbardin/plan-valid-nested-null ... core: prevent panics with null objects in nested attrs	2 years ago
James Bardin	e08b269e15	Merge pull request #35110 from hashicorp/jbardin/module-override-legacy-provider ... Don't evaluate providers within overridden modules	2 years ago
Daniel Schmidt	4dd4511871	stacks: add tests for forbidden deferrals ... I only added them sporadically since I felt like there would be too much clutter if I added them in general. If we feel like this does not give us enough security we can run every tests once with deferral allowed and once without to check this is handled consistently	2 years ago
Daniel Schmidt	f684df82f6	stack: improve wording ... Co-authored-by: Brian Flad <bflad417@gmail.com>	2 years ago
Daniel Schmidt	08917d1628	stacks: error if provider emits deferred action when it's not supported	2 years ago
kmoe	b74715e5fb	stacks: fix invalid filename (#35111)	2 years ago
James Bardin	582c7298d3	don't evaluate providers in overridden modules ... While we don't normally encounter providers within modules, they are technically still supported, and could exist within a module which has been overridden for testing. Since the module is not being evaluated, we cannot safely evaluate the provider config as variables will not exist within that module.	2 years ago
Daniel Schmidt	5af49eb9ce	Merge pull request #35016 from hashicorp/TF-13963 ... stacks: handle unknown values in component for_each	2 years ago
Daniel Schmidt	35f44b01f0	stacks: fix comment and add assertion for diagnostics	2 years ago
James Bardin	e7831d4e5d	use ResourceByAddr to lookup resource config ... The format of the resource keys in a `configs.Module` is an internal implementation detail, and should not be compared outside of the configs package. A module config already has a ResourceByAddr method we can use here which looks up a resource config by address.	2 years ago
Daniel Schmidt	aeb5b47723	stacks: remove unused test case	2 years ago
Nick Fagerlund	f2906a1bfc	Merge pull request #35088 from alexott/attach-config-performance ... Improve performance of AttachResourceConfigTransformer on big graphs	2 years ago
Martin Atkins	edf335e7eb	lang/funcs: Experimental "templatestring" function ... This function complements the existing "templatefile" to deal with the unusual situation of rendering a template that comes from somewhere outside of the current module's source code, such as from a data resource result. We have some historical experience with the now-deprecated hashicorp/template provider and its template_file data source, where we found that new authors would find it via web search and assume it was "the way" to render templates in Terraform, and then get frustrated dealing with the confusing situation of writing a string template that generates another string template for a second round of template rendering. To try to support those who have this unusual need without creating another attractive nuisance that would derail new authors, this function imposes the artificial extra rule that its template argument may only be populated using a single reference to a symbol defined elsewhere in the same module. This is intended to entice folks trying to use this function for something other than its intended purpose to refer to its documentation (once written) and then hopefully learn what other Terraform language feature they ought to have used instead. The syntax restriction only goes one level deep, so particularly-determined authors can still intentionally misuse this function by adding one level of indirection, such as by building template source code in a local value and then passing that local value as the template argument. The restriction is in place only to reduce the chances of someone _misunderstanding_ the purpose of this function; we don't intend to prevent someone from actively deciding to misuse it, if they have a good reason to do so. This new function inherits the same restriction as templatefile where it does not allow recursively calling other template-rendering functions. This is to dissuade from trying to use Terraform templates "at large", since Terraform's template language is not designed for such uses. It would be better to build a Terraform provider that wraps a more featureful template system like Gonja if someone really does need advanced templating, beyond Terraform's basic goals of being able to build small configuration files, etc. Because this function's intended purpose is rendering templates obtained from elsewhere, this function also blocks calls to any of Terraform's functions that would read from the filesystem of the computer where Terraform is running. This is a small additional measure of isolation to reduce the risk of an attacker somehow modifying a dynamically-fetched template to inspire Terraform to write sensitive data from the host computer into a location accessible to the same attacker, or similar. This is currently only a language experiment and so will not yet be available in stable releases of Terraform. Before stabilizing this and committing to supporting it indefinitely we'll want to gather feedback on whether this function actually meets the intended narrow set of use-cases around dynamic template rendering.	2 years ago
Martin Atkins	2ac2f4096f	collections: NewSetCmp takes optional initial elements ... We previously updated the other two constructors to work this way, but missed this one. NewSetCmp is now consistent with NewSet and NewSetFunc.	2 years ago
Martin Atkins	847925b531	experiments: template_string_func experiment keyword ... This doesn't actually do anything yet, but we'll make it do something in a future commit.	2 years ago
Daniel Schmidt	f847360a40	stacks: component.CheckInstances now reports on for each value diagnostics ... So there is no need for checkValid to do this during th walkDynamicObjects phase	2 years ago
Daniel Schmidt	c370e5e71d	stacks: use more precise name for variable	2 years ago
Daniel Schmidt	1afc9789ef	stacks: use UnknownForEachRepetitionData for instance map repetition data in for_each	2 years ago
Daniel Schmidt	91a18a6b30	stacks: fix typo ... Co-authored-by: Liam Cervante <liam.cervante@hashicorp.com>	2 years ago
Daniel Schmidt	7d0c4cfc4d	stacks: early exit on invalid for_each values for components	2 years ago
Daniel Schmidt	d1168ffa62	stacks: return instance value for wildcard component instances	2 years ago
Daniel Schmidt	6f95225a91	stacks: handle unknown dynamic values	2 years ago
Daniel Schmidt	3cbfd39721	stacks: validate unknown component for_each type	2 years ago
Daniel Schmidt	3a7150b27e	stacks: handle unknown values in component for_each	2 years ago
James Bardin	2562420d16	prevent panics with null objects in nested attrs ... When descending into nested structural attributes, don't try to extract attributes from null objects. Unlike with blocks, nested attributes allow the possibility of assigning null values. While these technically aren't allowed to be altered, we need to accept these for compatibility.	2 years ago
Alex Ott	f0e2861c1e	Improve performance of AttachResourceConfigTransformer on big graphs ... The current implementation of `AttachResourceConfigTransformer` has performance of `O(N^2)` to the number of vertices in the graph, and this leads to significant performance degradation on huge graphs. The given implementation decreases the complexity to `O(N)` by performing direct lookup of a resource in the `ManagedResources` or `DataResources` depending on the object type. Signed-off-by: Alex Ott <alexott@gmail.com>	2 years ago
Liam Cervante	b3d653afb6	stacks: track deferrals on top-level graph methods ... This makes it easier to identify when deferals happen in the workflow.	2 years ago
Daniel Schmidt	aed6f7586c	stacks: use deferral allowed flag	2 years ago
Daniel Schmidt	4338787f5b	stacks: allow provider to return empty list of imported resources	2 years ago
Daniel Schmidt	fd81a7111a	stacks: continue read and update if import is deferred	2 years ago
Daniel Schmidt	b236d28bcf	stacks: forbid deferral in cases where we return diagnostics on deferral	2 years ago
Daniel Schmidt	928657b0ab	stacks: handle deferred import on import blocks	2 years ago
Daniel Schmidt	efdcc7a711	stacks: return diags on deferred cli import	2 years ago
Daniel Schmidt	ce721b8e9c	stacks: add deferred to grpc calls	2 years ago
Martin Atkins	660ff86c4c	backendbase: Preserve unset arguments as null when not set by env ... Previously we tried a simplification where any attribute with an "SDK-like default" was guaranteed to never be null, because that seemed like a plausible mimic of the legacy SDK's general aversion to nulls. However, the SDK does still respect the absense of an argument as different to its zero value in one narrow case: when the argument isn't set in the configuration, also isn't set by any environment variables, and has no static fallback default. In that case, the SDK's built-in validation rules such as "ConflictsWith" _do_ treat absent as different from zero-value. To allow backends to continue making such distinctions themselves where that's useful, SDKLikeDefaults now leaves an attribute set to null if it wasn't present in the configuration and none of the environment variables or fallback value cause it to end up being a non-empty string. The backend can then choose to bypass the SDKLikeData API and check the cty.Value directly if it wants to distinguish set from zero even though SDKLikeData is designed to avoid the need to do that. This also updates the gcs backend to make use of the new facility, since it wants to raise an error if two arguments are both set even if they are both set to the empty string. Restoring that original error case is the main motivation for this change.	2 years ago
Martin Atkins	c77898c90d	logging: Remove import github.com/coreos/pkg/capnslog ... We were importing this to resolve an init-time conflict with this library when it was indirectly loaded by the etcd libraries. We removed the etcd backends a while back and so we no longer use any of the etcd modules in Terraform, and so this tricky import was our only remaining reference to github.com/coreos/pkg/capnslog. Dropping this eliminates two unnecessary dependencies.	2 years ago
James Bardin	9e47b42722	Merge pull request #35020 from hashicorp/jbardin/update-go-cty ... update go-cty v1.14.4	2 years ago
Martin Atkins	ef185ee6a0	collections: Don't panic when Has called on uninitialized Set ... The convention for Go maps is that read operations treat an uninitialized map as if empty, and collections.Set is intended to behave in a map-like way, so Set.Has should return false when called on a totally-uninitialized set. Previously this would panic because an uninitialized set has a nil key function.	2 years ago