terraform

Commit Graph

Author	SHA1	Message	Date
Graham Davison	58a7f3dffb	Moves assume role tests with inline parameters into separate test	3 years ago
Graham Davison	de055b0ede	Adds nested `assume_role` attribute and deprecates inline fields related to assume role	3 years ago
Graham Davison	84edaaed57	Merge pull request #33571 from hashicorp/s3/add-legacy-acceptance-tests S3 Backend: Add legacy authentication flow tests	3 years ago
Sebastian Rivera	dceb8453af	Merge pull request #33492 from hashicorp/cli-team/saved-cloud-plans Implement saved cloud plans	3 years ago
Sebastian Rivera	08e58fd484	Fix saved plan test regressions, fixtures	3 years ago
Graham Davison	5588603822	Merge pull request #33534 from hashicorp/s3/update-configschema S3 Backend: Converts from `legacy/helper/schema` to `configschema`	3 years ago
Graham Davison	8564a5bf0e	Fixes type of parameter `skip_credentials_validation`	3 years ago
Graham Davison	47fc769da9	Adds tests for region	3 years ago
Graham Davison	f3ce646756	Adds authentication tests	3 years ago
Sebastian Rivera	31cf55fe12	Reword error message when using local exec	3 years ago
Nick Fagerlund	f9d937a4dd	Apply a confirmable run when given a saved cloud plan (#33270 ) It displays a run header with link to web UI, like starting a new plan does, then confirms the run and streams the apply logs. If you can't apply the run (it's from a different workspace, is in an unconfirmable state, etc. etc.), it displays an error instead. Notable points along the way: * Implement `WrappedPlanFile` sum type, and update planfile consumers to use it instead of a plain `planfile.Reader`. * Enable applying a saved cloud plan * Update TFC mocks — add org name to workspace, and minimal support for includes on MockRuns.ReadWithOptions.	3 years ago
Brandon Croft	c1a730314d	Relocate localterraform.com aliasing to backend configurators Previously, remote and cloud backends would automatically alias localterraform.com as the configured hostname during configuration. This turned out to be an issue with how backends could potentially be used within the builtin terraform_remote_state data source. Those data sources each configure the same service discovery with different targets for localterraform.com, and do so simultaneously, creating an occasional concurrent map read & write panic when multiple data sources are defined. localterraform.com is obviously not useful for every backend configuration. Therefore, I relocated the alias configuration to the callers, so they may specify when to use it. The modified design adds a new method to backend.Enhanced to allow configurators to ask which aliases should be defined.	3 years ago
Liam Cervante	6882dd9530	testing framework: introduce test command optional flags (#33504 ) * testing framework: introduce test command optional flags * address consistency checks	3 years ago
Graham Davison	344e9de6b9	Linting fixes	3 years ago
Liam Cervante	f74a8d16cf	[testing framework] implement expect_failures functionality (#33443 )	3 years ago
Graham Davison	d179b686d9	Consolidates endpoint tests	3 years ago
Graham Davison	2f00c86255	Adds endpoint tests when configured in configuration	3 years ago
Graham Davison	90c10ebbe9	Removes redundant ARN parsing	3 years ago
Graham Davison	29e14d148b	Reorders `skip_...` parameters	3 years ago
Graham Davison	c3f4f9cedd	Fixes region validation	3 years ago
Graham Davison	454eed63e7	Adds KMS Key validation	3 years ago
Graham Davison	2fda09aab2	Updates attribute validation messages	3 years ago
Graham Davison	e8c7722d3e	Restores conflict between `kms_key_id` and envvar `AWS_SSE_CUSTOMER_KEY`	3 years ago
Graham Davison	827d7bd384	Combines `sse_customer_key` and `AWS_SSE_CUSTOMER_KEY` validation	3 years ago
Graham Davison	4eaa44c5a5	Adds functions for clearing all envvars	3 years ago
Graham Davison	2d12f242c7	Adds checks for not getting validation errors when they are expected	3 years ago
Graham Davison	95eb523c02	Sets service endpoints from envvar and adds tests	3 years ago
Graham Davison	8d018cfef3	Adds test for setting region from envvars	3 years ago
Graham Davison	9bea21e8b2	Moves schema to `ConfigSchema` and removes references to legacy schema	3 years ago
Graham Davison	467e6256da	Moves configuration to `Configure`	3 years ago
Graham Davison	381006742b	Moves validation to `PrepareConfig`	3 years ago
Graham Davison	b5de540643	Fully populates schema values	3 years ago
Graham Davison	9257dfa8a7	S3 backend: Adds tests for defaults and validation	3 years ago
James Bardin	cf5ebaf685	s/Schemas/ProviderSchema/	3 years ago
James Bardin	36d34135ad	replace remaining types in tests	3 years ago
James Bardin	4e8dd5866c	update schemas type	3 years ago
James Bardin	53901a7e62	Add basic global schema cache Add a single global schema cache for providers. This allows multiple provider instances to share a single copy of the schema, and prevents loading the schema multiple times for a given provider type during a single command. This does not currently work with some provider releases, which are using GetProviderSchema to trigger certain initializations. A new server capability will be introduced to trigger reloading their schemas, but not store duplicate results.	3 years ago
Alisdair McDiarmid	ad2298b114	Merge pull request #33108 from unRob/patch-1 Return debuggable CAS errors on consul state put	3 years ago
Roberto Hidalgo	8e5a66b2f5	use multierror.Append instead of `append` Co-authored-by: Chris Thain <32781396+cthain@users.noreply.github.com>	3 years ago
Roberto Hidalgo	787cc693cd	use go-multierror instead of manually joining error reasons Co-authored-by: Chris Thain <32781396+cthain@users.noreply.github.com>	3 years ago
Brandon Croft	19b17ad0a2	remote: when saving state, create a pending state version then upload	3 years ago
guimin.hgm	ce8790c939	backend/oss: Removes the deprecated warning for configuraion variable assume_role	3 years ago
CJ Horton	8a3f4e903b	generating configuration is not allowed with the remote backend	3 years ago
CJ Horton	cdce4c4a6d	write generated config when using the cloud integration	3 years ago
Liam Cervante	07aa7ee1d5	Propagate generated config filename into the Terraform graph (#33255 )	3 years ago
Martin Atkins	efdc6e52bc	cloud: Skip intermediate state snapshots in Terraform Cloud/Enterprise We've seen some concern about the additional storage usage implied by creating intermediate state snapshots for particularly long apply phases that can arise when managing a large number of resource instances together in a single workspace. This is an initial coarse approach to solving that concern, just restoring the original behavior when running inside Terraform Cloud or Enterprise for now and not creating snapshots at all. This is here as a solution of last resort in case we cannot find a better compromise before the v1.5.0 final release. Hopefully a future commit will implement a more subtle take on this which still gets some of the benefits when running in a Terraform Enterprise environment but in a way that will hopefully be less concerning for Terraform Enterprise administrators. This does not affect any other state storage implementation except the Terraform Cloud integration and the "remote" backend's state storage when running inside a TFC/TFE-driven remote execution environment.	3 years ago
Martin Atkins	8884bef59d	backend/local: Allow storage impls to customize intermediate persistence Previously we just always used the same intermediate state persistence behavior for all state storages. However, some storages might have access to additional information that allows them to tailor when they persist, such as reacting to API rate limit status headers in responses, or just knowing that a particular storage isn't suited to intermediate snapshots at all for some reason. This commit doesn't actually change any observable behavior yet, but it introduces an optional means for a state storage to customize the behavior which we may make use of in certain storage implementations in future commits.	3 years ago
kmoe	b4d1146f58	plannable import: improve gen config human plan output (#33194 ) * renderer: remove hard-coded config gen path * mention config gen file in plan next steps	3 years ago
Liam Cervante	d5fed58fc5	plannable import: write generated config to out flag (#33186 ) * plannable import: write generated config to out flag * Add example command to diagnostic	3 years ago
hashicorp-copywrite[bot]	325d18262e	[COMPLIANCE] Add Copyright and License Headers	3 years ago
Roberto Hidalgo	1b7f772f8b	fix breaking code this is what i get for submitting PRs late at night	3 years ago
Roberto Hidalgo	0dda1d5c61	Return debuggeble CAS errors on consul state put ran into this error while running terraform on a container and saving state to Consul. I suspect my policy needs tweaking but it's impossible to tell with an error like this: ``` ╷ │ Error: Failed to save state │ │ Error saving state: consul CAS failed with transaction errors: │ [0xc0006e93c8] ╵ ``` This PR makes the will include the error messaage in the details so I can continue debugging	3 years ago
Alisdair McDiarmid	0ffdd07980	Fix goimports discrepancies	3 years ago
Rémi Lapeyre	af571b2642	Improve environment variable support for the pg backend (#33045 ) * Improve environment variable support for the pg backend This patch does two things: - it adds environment variable support to the parameters that did not have it (and uses `PG_CONN_STR` instead of `PGDATABASE` which is actually more appropriate to match the behavior of other PostgreSQL utilities) - better documents how to give the connection parameters as environment variables for the ones that were already supported based on the recommendation of @bsouth00 I will prepare a backport of the documentation part of this once it is merged. Closes https://github.com/hashicorp/terraform/issues/33024 * Remove global variable in test of the PG backend	3 years ago
Glenn Sarti	7e2e834aff	Emit warnings for certain run events in cloud backend (#33020 ) The cloud backend, which communicates with TFC like APIs, can create runs which may have one more configuration parameters altered. These alterations are emitted as run-events on the run so that API clients can consume and display them to users. This commit adds a step in plan operation to query the run-events once a run is created and then emit specific run-event descriptions to the console as warnings for the user.	3 years ago
Liam Cervante	9c87006c34	checks: hide check diagnostics during plans that will not wait for approval (#32938 ) * checks: filter out check diagnostics during certain plans * wrap diagnostics produced by check blocks in a dedicated check block diagnostic * address comments	3 years ago
janaurka	1f603b1a7f	backend/pg: Accept connection string in PGDATABASE environment variable	3 years ago
James Bardin	c02e7e8754	return early from opPlan when the plan is nil While the returned plan is checked for nil in most cases, there was a single point where the plan was dereferenced which could panic. Rather than always guarding the dereferences, return early when the plan is nil.	3 years ago
Martin Atkins	f0de9b60c1	backend/local: Periodically persist intermediate state snapshots Terraform Core emits a hook event every time it writes a change into the in-memory state. Previously the local backend would just copy that into the transient storage of the state manager, but for most state storage implementations that doesn't really do anything useful because it just makes another copy of the state in memory. We originally added this hook mechanism with the intent of making Terraform _persist_ the state each time, but we backed that out after finding that it was a bit too aggressive and was making the state snapshot history much harder to use in storage systems that can preserve historical snapshots. However, sometimes Terraform gets killed mid-apply for whatever reason and in our previous implementation that meant always losing that transient state, forcing the user to edit the state manually (or use "import") to recover a useful state. In an attempt at finding a sweet spot between these extremes, here we change the rule so that if an apply runs for longer than 20 seconds then we'll try to persist the state to the backend in an update that arrives at least 20 seconds after the first update, and then again for each additional 20 second period as long as Terraform keeps announcing new state snapshots. This also introduces a special interruption mode where if the apply phase gets interrupted by SIGINT (or equivalent) then the local backend will try to persist the state immediately in anticipation of a possibly-imminent SIGKILL, and will then immediately persist any subsequent state update that arrives until the apply phase is complete. After interruption Terraform will not start any new operations and will instead just let any already-running operations run to completion, and so this will persist the state once per resource instance that is able to complete before being killed. This does mean that now long-running applies will generate intermediate state snapshots where they wouldn't before, but there should still be considerably fewer snapshots than were created when we were persisting for each individual state change. We can adjust the 20 second interval in future commits if we find that this spot isn't as sweet as first assumed.	3 years ago
Yin Luo	e9b066f514	Support assume role for cos backend (#32631 ) * go get github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/sts/v20180813@v1.0.588 * feat:support assume_role for COS backend * update go.mod and go.sum * change secret_id and secret_key from required to optional * update cos doc * update logic by comments * rm sensitive info in log	3 years ago
megan07	d7d8a2262c	Merge pull request #32557 from bharathkkb/gcs-backend-impersonate-envvar Add a GCS backend specific env var for impersonation	3 years ago
James Bardin	1307317457	Merge pull request #32614 from yardbirdsax/fix/30670 make remote state initial behavior the same as local state	3 years ago
Joshua Feierman	d45ebfbdef	chore: clean-up tests & logging	3 years ago
Joshua Feierman	2576544db8	fix: remote state behavior This makes the behavior of remote state consistent with local state in regards to the initial serial number of the generated / pushed state. Previously remote state's initial push would have a serial number of 0, whereas local state had a serial of > 0. This causes issues with the logic around, for example, ensuring that a plan file cannot be applied if state is stale (see https://github.com/hashicorp/terraform/issues/30670 for example).	3 years ago
Brandon Croft	81a4e5ae44	Backport support for generic hostname to backend/remote	3 years ago
Sheridan C Rawlins	75e5ae27a2	[fixes 31700] Add mTLS support for http backend by way of client cert & key, as well as enterprise cacert. (#31699 ) * Add mTLS support for http backend by way of client cert & key, as well as enterprise cacert. * Fix style. * Skip cert validation to be sure error is related to missing client cert; not untrusted server cert. * Remove misplaced err check. * Fix the size of test using http backend. * Just for correctness, include all certs in the pem encoded cert - sometimes certs come with a chain of their signers. * Adjusted names as recommended in PR comments. * Adjusted names to be full-length and more descriptive. * Added full-fledged testing with mTLS http server * Fix goimports. * Fix the names of the backend config. * Exclusive lock for write and delete. * Revert "Fix goimports." This reverts commit 7d40f6099fbbb675fb2e25e35ee40aeafe3d0a22. * goimports just for server test. * Added the go:generation for the mock. * Move the TLS configuration out to make it more readable - don't replace the HTTPClient as the retryablehttp already creates one - just configure its TLS. * Just switch the client/data params - felt more natural this way. * Update internal/backend/remote-state/http/backend.go Co-authored-by: kmoe <5575356+kmoe@users.noreply.github.com> * Update internal/backend/remote-state/http/testdata/gencerts.sh Co-authored-by: kmoe <5575356+kmoe@users.noreply.github.com> * Update internal/backend/remote-state/http/backend.go Co-authored-by: kmoe <5575356+kmoe@users.noreply.github.com> * Update internal/backend/remote-state/http/backend.go Co-authored-by: kmoe <5575356+kmoe@users.noreply.github.com> * Update internal/backend/remote-state/http/backend.go Co-authored-by: kmoe <5575356+kmoe@users.noreply.github.com> * Update internal/backend/remote-state/http/backend.go Co-authored-by: kmoe <5575356+kmoe@users.noreply.github.com> * the location of the file name is not sensitive. * Added error if only one of client_certificate_pem and client_private_key_pem are set. * Remove testify from test cases; use t.Error* for assert and t.Fatal* for require. * Fixed import consistency * Just use default openssl. * Since file(...) is so trivial to use, changed the client cert, key, and ca cert to be the data. See also https://github.com/hashicorp/terraform-provider-http/pull/211 Co-authored-by: Sheridan C Rawlins <scr@ouryahoo.com> Co-authored-by: kmoe <5575356+kmoe@users.noreply.github.com>	3 years ago
bharathkkb	05ff3c3278	Add a GCS backend specific env var for impersonation	3 years ago
James Bardin	721df0e68d	Merge pull request #32395 from hashicorp/jbardin/plan-output-on-error Always show and store planned actions and checks even when planning fails	3 years ago
James Bardin	3cda7a0269	Merge pull request #29520 from ComBin/main Don't show symbols while input if variable marked as sensitive	3 years ago
James Bardin	5aa088e385	remove -always-out Make writing a plan file the default. We already create plans which have no changes so the plan result would need to be checked in automation, so having plans with errors should not pose a problem. If we find workflows which cannot handle a plan that can't be applied, we can reevaluate the need for a specialized flag. In the meantime, it feels more logical that the plan output would always describe the result of the plan, even if that included errors.	3 years ago
Martin Atkins	4660dacd59	command: Prototype of handling errored plans This is a prototype of how the CLI layer might make use of Terraform Core's ability to produce a partial plan if it encounters an error during planning, with two new situations: - When using local CLI workflow, Terraform will show the partial plan before showing any errors. - "terraform plan" has a new option -always-out=..., which is similar to the existing -out=... but additionally instructs Terraform to produce a plan file even if the plan is incomplete due to errors. This means that the plan can still be inspected by external UI implementations. This is just a prototype to explore how these parts might fit together. It's not a complete implementation and so should not be shipped. In particular, it doesn't include any mention of a plan being incomplete in the "terraform show -json" output or in the "terraform plan -json" output, both of which would be required for a complete solution.	3 years ago
xiaozhu36	ec62ca1b70	backend/oss: Ignore the getting oss endpoint error and using string concat instead; Improves the error message level	3 years ago
James Bardin	79175b29f3	Merge pull request #32261 from sivchari/fix-prealloc fix: pre allocate for composite literal	3 years ago
Jarrett Spiker	1dafd7c0b1	Fix test compilation errors caused by interface change	3 years ago
Jarrett Spiker	060255a9d5	Use safe or force workspace delete for cloud backend	3 years ago
sivchari	ef4798de8e	fix: pre allocate for composite literal	3 years ago
Paschalis Tsilias	4cb355f3d6	S3 Backend : Bucket key should not contain trailing slash	4 years ago
Tom Bamford	ff68c8d129	Merge pull request #31966 from kschu91/feature/azure-generic-oidc backend/azurerm: add support for generic OIDC authentication	4 years ago
Tom Bamford	82c0b440dc	Fix default values	4 years ago
Sarah French	89ef27d3b4	Add Private Service Connect endpoint support to GCS backend (#31967 ) * Add support for `storage_custom_endpoint` in `gcs` backend * Add documentation for new `storage_custom_endpoint` endpoint * Empty commit to trigger Vercel deployment	4 years ago
Kevin Schu	5842950291	Added support for generic OIDC authentication (eg. Gitlab) and ensure documentation is more clear about it´s usage. oidc_request_url and oidc_request_token are meant to be used for Github Actions only.	4 years ago
Sarah French	d43ec0f30f	Add customer-managed encryption key (KMS) support to GCS backend (#31786 ) * Add ability to use customer-managed KMS key to encrypt state, add acceptance tests * Change test names for different encrpytion methods * Commit files updated by `go mod tidy` * Add guard against missing ENVs to `setupKmsKey` func * Update KMS setup function to get credentials from ENVs * Update tests to not include zero-values in config This means that default values are supplied later by TF instead of supplied as config from the user This also avoids issues related to making field conflicts explicit with `ConflictsWith` * Make `encryption_key` & `kms_encryption_key` conflicting fields Removing the Default from `encryption_key` does not appear to be a breaking change when tested manually * Add ability to set `kms_encryption_key` via ENV * Refactor `encryption_key` to use `DefaultFunc` to access ENV, if set * Remove comments * Update `gcs` backend docs & descriptions in schema * Update `gcs` backend docs to include information on encryption methods * Apply technical writing suggestions from code review Co-authored-by: Matthew Garrell <69917312+mgarrell777@users.noreply.github.com> * Update documentation to remove passive voice * Change use of context in tests, add inline comment, update logs * Remove use of `ReadPathOrContents` for new field Co-authored-by: Matthew Garrell <69917312+mgarrell777@users.noreply.github.com>	4 years ago
James Bardin	522556534d	remove deprecated backends (#31711 ) * remove deprecated backends * remove backend docs Remove references to deprecated backends from docs.	4 years ago
Megan Bang	bddf6a9b34	updating to use the latest version of cloud/state.go and just pass schemas along to PersistState in the remote state	4 years ago
Megan Bang	4fab46749a	update persist state	4 years ago
Brandon Croft	e1fa690879	style: goimports fixes	4 years ago
Brandon Croft	c33c8b013f	fix: have `terraform output` adhere to authorization w/ cloud Normally, `terraform output` refreshes and reads the entire state in the command package before pulling output values out of it. This doesn't give Terraform Cloud the opportunity to apply the read state outputs org permission and instead applies the read state versions permission. I decided to expand the state manager interface to provide a separate GetRootOutputValues function in order to give the cloud backend a more nuanced opportunity to fetch just the outputs. This required moving state Refresh/Read code that was previously in the command into the shared backend state as well as the filesystem state packages.	4 years ago
Anna Winkler	d72911a640	Save detailed type outputs to JSONStateOutputs	4 years ago
hellertang	0dbf0711a0	cos backend support accelerate (#31425 )	4 years ago
Tom Bamford	dc1f5bccf8	Merge pull request #31070 from hashicorp/f/removing-adal-auth backend/azurerm: exclusively using Microsoft Graph/MSAL and removing Azure Active Directory Graph/ADAL	4 years ago
James Bardin	96c720517f	fixup broken test fixtures some of the minimal test provider implementations didn't check for null values.	4 years ago
James Bardin	d61d3e9fd8	remove deprecated etcdv3 backend	4 years ago
James Bardin	953c448f9a	add simple error indicating backend removal There are no good options for inserting diagnostics into the backend lookup, or creating a backend which reports it's removal because none of the init or GetSchema functions return any errors. Keep a registry of the removed backend so that we can at least notify users that a backend was removed vs an invalid name.	4 years ago
James Bardin	799ab6c951	remove deprecated etcd backend This allows us to remove the manual replace directives github.com/dgrijalva/jwt-go and google.golang.org/grpc, so that we can remove the CVE warnings and update the grpc packages. While the etcdv3 backend is also marked as deprecated, the changes here are done in a manner to keep that backend working for the time being.	4 years ago
Nicolas Vanheuverzwijn	bb1c134b94	http-backend: http backend lock error return LockError instead of generic error	4 years ago
Kagashino	cab6cee385	fix: backend/cos - remove cos object write lock either when unlock state file	4 years ago
James Bardin	0c7d39aca5	deprecate unmaintained backends	4 years ago
tombuildsstuff	05528e8c8a	backend/azurerm: removing ADAL support	4 years ago
Anna Winkler	22c121df86	Bump compatibility version to 1.3.0 for terraform core release (#30988 ) * Bump compatibility version to 1.3.0 for terraform core release Co-authored-by: Brandon Croft <brandon.croft@gmail.com>	4 years ago
James Bardin	df0a70bfb6	check for cancellation before apply confirmation When executing an apply with no plan, it's possible for a cancellation to arrive during the final batch of provider operations, resulting in no errors in the plan. The run context was next checked during the confirmation for apply, but in the case of -auto-approve that confirmation is skipped, resulting in the canceled plan being applied. Make sure we directly check for cancellation before confirming the plan.	4 years ago
Tom Bamford	d08bc4463d	Azure Backend: support OIDC authentication	4 years ago
Keith Clawson	23dffee568	Always use token in backend config when provided	4 years ago
Tom Harvey	2eb9118cd1	backend/remote-state/azure: defaulting the Azure Backend to use MSAL (#30891 ) * backend/remote-state/azure: defaulting the Azure Backend to use MSAL Fixes #30881 * backend/remote-state/azurerm: deprecating `use_microsoft_graph`	4 years ago
Eng Zer Jun	fedd315275	test: use `T.TempDir` to create temporary test directory (#30803 ) This commit replaces `ioutil.TempDir` with `t.TempDir` in tests. The directory created by `t.TempDir` is automatically removed when the test and all its subtests complete. Prior to this commit, temporary directory created using `ioutil.TempDir` needs to be removed manually by calling `os.RemoveAll`, which is omitted in some tests. The error handling boilerplate e.g. defer func() { if err := os.RemoveAll(dir); err != nil { t.Fatal(err) } } is also tedious, but `t.TempDir` handles this for us nicely. Reference: https://pkg.go.dev/testing#T.TempDir Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>	4 years ago
Lars Lehtonen	88c9b90c93	internal/backend/remote-state/oss: fix dropped error (#30352 )	4 years ago
Luces Huayhuaca	bdc7d8c0a1	Upgrade go-tfe dependency to use 1.0 version. It contains breaking changes, so we are updating method signatures, method names and the type of optional parameters, as needed. (#30626 )	4 years ago
Theo Chupp	d15a2bc024	fix: local variables should not be overridden by remote variables during `terraform import` (#29972 ) * fix: local variables should not be overridden by remote variables during `terraform import` * chore: applied the same fix in the 'internal/cloud' package * backport changes from cloud package to remote package Co-authored-by: Alisdair McDiarmid <alisdair@users.noreply.github.com> Co-authored-by: uturunku1 <luces.huayhuaca@gmail.com>	4 years ago
Krista LaFentres (she/her)	6dcf00aefc	Merge pull request #30344 from hashicorp/lafentres/refactor-show-command cli: Refactor show command & migrate to command arguments and views	4 years ago
Krista LaFentres	64e1241ae3	backend/local: Remove unused DisablePlanFileStateLineageChecks flag Now that show command has been refactored to remove its dependence on a local backend and local run, this flag is no longer needed to fix #30195.	4 years ago
Martin Atkins	36c4d4c241	core and backend: remove redundant handling of default variable values Previously we had three different layers all thinking they were responsible for substituting a default value for an unset root module variable: - the local backend, via logic in backend.ParseVariableValues - the context.Plan function (and other similar functions) trying to preprocess the input variables using terraform.mergeDefaultInputVariableValues . - the newer prepareFinalInputVariableValue, which aims to centralize all of the variable preparation logic so it can be common to both root and child module variables. The second of these was also trying to handle type constraint checking, which is also the responsibility of the central function and not something we need to handle so early. Only the last of these consistently handles both root and child module variables, and so is the one we ought to keep. The others are now redundant and are causing prepareFinalInputVariableValue to get a slightly corrupted view of the caller's chosen variable values. To rectify that, here we remove the two redundant layers altogether and have unset root variables pass through as cty.NilVal all the way to the central prepareFinalInputVariableValue function, which will then handle them in a suitable way which properly respects the "nullable" setting. This commit includes some test changes in the terraform package to make those tests no longer rely on the mergeDefaultInputVariableValues logic we've removed, and to instead explicitly set cty.NilVal for all unset variables to comply with our intended contract for PlanOpts.SetVariables, and similar. (This is so that we can more easily catch bugs in callers where they _don't_ correctly handle input variables; it allows us to distinguish between the caller explicitly marking a variable as unset vs. not describing it at all, where the latter is a bug in the caller.)	4 years ago
Alisdair McDiarmid	768741c0f7	command/show: Disable plan state lineage checks When showing a saved plan, we do not need to check the state lineage against current state, because the plan cannot be applied. This is relevant when plan and apply specify a `-state` argument to choose a non-default state file. In this case, the stored prior state in the plan will not match the default state file, so a lineage check will always error.	4 years ago
James Bardin	8c4031ef15	don't persist a nil state from Apply Apply should not return a nil state to be persisted.	4 years ago
Chris Arcand	f521ba6cd7	Remove 'enhanced' backend type distinction As explained in the changes: The 'enhanced' backend terminology, which only truly pertains to the 'remote' backend with a single API (Terraform Cloud/Enterprise's), has been found to be a confusing vestige which need only be explained in the context of the 'remote' backend. These changes reorient the explanation(s) of backends to pertain more directly to their primary purpose, which is storage of state snapshots (and not implementing operations). That Terraform operations are still _implemented_ by the literal `Backend` and `Enhanced` interfaces is inconsequential a user of Terraform, an internal detail.	4 years ago
Katy Moe	b1c071bb57	pass hclog logger to retryable client	4 years ago
Tom Harvey	a1c7c0dfa4	Update internal/backend/remote-state/azure/backend.go Co-authored-by: Tom Bamford <tbamford@hashicorp.com>	4 years ago
tombuildsstuff	ffe9a41468	internal/backend/remote-state/azure: adding tests covering MSAL	4 years ago
tombuildsstuff	a2cad7d579	internal/backend/remote-state/azure: prefixing the existing tests with ADAL	4 years ago
tombuildsstuff	9f710558ce	internal/backend/remote-state/azure: adding a feature-toggle to use MSAL	4 years ago
tombuildsstuff	27a34d6c2c	internal/backend/remote-state/azure: updating the link to the client secret This redirects to the registry so we should point there directly	4 years ago
tombuildsstuff	5133d30b71	internal/backend/remote-state/azure: code changes for go-azure-helpers v0.18.0	4 years ago
Jared Ledvina	61a5808680	k8s-backend - Initial context support for library update Signed-off-by: Jared Ledvina <jared.ledvina@datadoghq.com>	4 years ago
Chris Arcand	779c958fbf	cloud: Add streamlined 'remote' backend state migration path For Terraform Cloud users using the 'remote' backend, the existing 'pattern' prompt should work just fine - but because their workspaces are already present in TFC, the 'migration' here is really just realigning their local workspaces with Terraform Cloud. Instead of forcing users to do the mental gymnastics of what it means to migrate from 'prefix' - and because their remote workspaces probably already exist and already conform to Terraform Cloud's naming concerns - streamline the process for them and calculate the necessary pattern to migrate as-is, without any user intervention necessary.	5 years ago
xiaozhu36	e0a2716601	backend/oss: Removes the ConflictWith tag which on the attributes assume_role* to fix the incompatible error	5 years ago
xiaozhu36	5d19a34f88	backend/oss: Supports the new attribute sts_endpoint	5 years ago
James Bardin	2ebdc099ac	Merge pull request #29307 from hayorov/main Flatten `assume_role` block for OSS backend	5 years ago
James Bardin	81e709d185	Merge pull request #29825 from hashicorp/jbardin/no-panicwrap Remove the use of panicwrap in the Terraform CLI	5 years ago
Brandon Croft	dbbfae5a1c	refactor ParseVariableValues into separate operations 1. ParseDeclaredValues: parses unparsed variables into terraform.InputValues 2. ProbeUndeclaredVariableValues: compares variable declarations with unparsed values to warn/error about undeclared variables	5 years ago
Chris Arcand	1791b71196	cloud: TestCloud_backendWithTags Implementing this test was quite a rabbithole, as in order to satisfy backendTestBackendStates() the workspaces returned from backend.Workspaces() must match exactly, and the shortcut taken to test pagination in `3cc58813f0` created an impossible circumstance that got plastered over with the fact that prefix filtering is done clientside, not by the API as it should be. Tagging does not rely on clientside filtering, and expects that the request made to the TFC API returns exactly those workspaces with the given tags. These changes include a better way to test pagination, wherein we actually create over a page worth of valid workspaces in the mock client and implement a simplified pagination behavior to match how the TFC API actually works.	5 years ago
Chris Arcand	471dd479e8	Update go-tfe to 26689e These changes include additions to fulfill the interface for the client mock, plus moving all that logic (which needn't be duplicated across both the remote and cloud packages) over to the cloud package under a dedicated mock client file.	5 years ago
Chris Arcand	ea8ad0b15a	Initial commit of 'cloud' package The cloud package intends to implement a new integration for Terraform Cloud/Enterprise. The purpose of this integration is to better support TFC users; it will shed some overly generic UX and architecture, behavior changes that are otherwise backwards incompatible in the remote backend, and technical debt - all of which are vestiges from before Terraform Cloud existed. This initial commit is largely a porting of the existing 'remote' backend, which will serve as an underlying implementation detail and not be a typical user-level backend. This is because to re-implement the literal backend interface is orthogonal to the purpose of this integration, and can always be migrated away from later. As this backend is considered an implementation detail, it will not be registered as a declarable backend. Within these changes it is, for easy of initial development and a clean diff.	5 years ago
James Bardin	d03a037567	insert panic handlers	5 years ago
Alex Khaerov	6f1eceb0e2	Revert autoupdate	5 years ago
xiaozhu36	7afaea4cf2	backend/oss: Fixes the nil pointer panic error when missing access key or secret key	5 years ago
Alex Khaerov	14f366dbf4	Update documentation	5 years ago
Alex Khaerov	f32702c5c2	Support deprecated assume_role block	5 years ago
Alex Khaerov	de8810cdd9	Merge branch 'hashicorp:main' into main	5 years ago
Martin Atkins	39779e7021	backend/remote-state/cos: Don't use github.com/likexian/gokit We don't use this library anywhere else in Terraform, and this backend was using it only for trivial helpers that are easy to express inline anyway. The new direct code is also type-checkable, whereas these helper functions seem to be written using reflection. This gives us one fewer dependency to worry about and makes the test code for this backend follow a similar assertions style as the rest of this codebase.	5 years ago
James Bardin	ef3c98466d	Merge pull request #29755 from hashicorp/jbardin/first-plan-lineage Check for stale plan with no state metadata	5 years ago
James Bardin	5ffa0839f9	only check serial when applying the first plan Ensure that we still check for a stale plan even when it was created with no previous state. Create separate errors for incorrect lineage vs incorrect serial. To prevent confusion when applying a first plan multiple times, only report it as a stale plan rather than different lineage.	5 years ago
Martin Atkins	bee7403f3e	command/workspace_delete: Allow deleting a workspace with empty husks Previously we would reject attempts to delete a workspace if its state contained any resources at all, even if none of the resources had any resource instance objects associated with it. Nowadays there isn't any situation where the normal Terraform workflow will leave behind resource husks, and so this isn't as problematic as it might've been in the v0.12 era, but nonetheless what we actually care about for this check is whether there might be any remote objects that this state is tracking, and for that it's more precise to look for non-nil resource instance objects, rather than whole resources. This also includes some adjustments to our error messaging to give more information about the problem and to use terminology more consistent with how we currently talk about this situation in our documentation and elsewhere in the UI. We were also using the old State.HasResources method as part of some of our tests. I considered preserving it to avoid changing the behavior of those tests, but the new check seemed close enough to the intent of those tests that it wasn't worth maintaining this method that wouldn't be used in any main code anymore. I've therefore updated those tests to use the new HasResourceInstanceObjects method instead.	5 years ago
Megan Bang	9b9b26a3cd	update error message for invalid json	5 years ago
megan07	7dda3366a6	Update internal/backend/remote-state/gcs/backend.go Co-authored-by: appilon <apilon@hashicorp.com>	5 years ago
Megan Bang	81201d69a3	check valid json	5 years ago
Megan Bang	348c761bea	add better error if credentials are invalid	5 years ago
Martin Atkins	df578afd7e	backend/local: Check dependency lock consistency before any operations In historical versions of Terraform the responsibility to check this was inside the terraform.NewContext function, along with various other assorted concerns that made that function particularly complicated. More recently, we reduced the responsibility of the "terraform" package only to instantiating particular named plugins, assuming that its caller is responsible for selecting appropriate versions of any providers that _are_ external. However, until this commit we were just assuming that "terraform init" had correctly selected appropriate plugins and recorded them in the lock file, and so nothing was dealing with the problem of ensuring that there haven't been any changes to the lock file or config since the most recent "terraform init" which would cause us to need to re-evaluate those decisions. Part of the game here is to slightly extend the role of the dependency locks object to also carry information about a subset of provider addresses whose lock entries we're intentionally disregarding as part of the various little edge-case features we have for overridding providers: dev_overrides, "unmanaged providers", and the testing overrides in our own unit tests. This is an in-memory-only annotation, never included in the serialized plan files on disk. I had originally intended to create a new package to encapsulate all of this plugin-selection logic, including both the version constraint checking here and also the handling of the provider factory functions, but as an interim step I've just made version constraint consistency checks the responsibility of the backend/local package, which means that we'll always catch problems as part of preparing for local operations, while not imposing these additional checks on commands that _don't_ run local operations, such as "terraform apply" when in remote operations mode.	5 years ago
Martin Atkins	6a98e4720c	plans/planfile: Create takes most arguments via a struct type Previously the planfile.Create function had accumulated probably already too many positional arguments, and I'm intending to add another one in a subsequent commit and so this is preparation to make the callsites more readable (subjectively) and make it clearer how we can extend this function's arguments to include further components in a plan file. There's no difference in observable functionality here. This is just passing the same set of arguments in a slightly different way.	5 years ago
Martin Atkins	8d193ad268	core: Simplify and centralize plugin availability checks Historically the responsibility for making sure that all of the available providers are of suitable versions and match the appropriate checksums has been split rather inexplicably over multiple different layers, with some of the checks happening as late as creating a terraform.Context. We're gradually iterating towards making that all be handled in one place, but in this step we're just cleaning up some old remnants from the main "terraform" package, which is now no longer responsible for any version or checksum verification and instead just assumes it's been provided with suitable factory functions by its caller. We do still have a pre-check here to make sure that we at least have a factory function for each plugin the configuration seems to depend on, because if we don't do that up front then it ends up getting caught instead deep inside the Terraform runtime, often inside a concurrent graph walk and thus it's not deterministic which codepath will happen to catch it on a particular run. As of this commit, this actually does leave some holes in our checks: the command package is using the dependency lock file to make sure we have exactly the provider packages we expect (exact versions and checksums), which is the most crucial part, but we don't yet have any spot where we make sure that the lock file is consistent with the current configuration, and we are no longer preserving the provider checksums as part of a saved plan. Both of those will come in subsequent commits. While it's unusual to have a series of commits that briefly subtracts functionality and then adds back in equivalent functionality later, the lock file checking is the only part that's crucial for security reasons, with everything else mainly just being to give better feedback when folks seem to be using Terraform incorrectly. The other bits are therefore mostly cosmetic and okay to be absent briefly as we work towards a better design that is clearer about where that responsibility belongs.	5 years ago
James Bardin	8ce2254ad6	Merge pull request #29647 from hashicorp/jbardin/test-temp-cleanup temp path clean for some backend tests	5 years ago
Alisdair McDiarmid	57318ef561	backend/remote: Support interop from 0.14 to 1.1 The previous conservative guarantee that we would not make backwards incompatible changes to the state file format until at least Terraform 1.1 can now be extended. Terraform 0.14 through 1.1 will be able to interoperably use state files, so we can update the remote backend version compatibility check accordingly.	5 years ago
James Bardin	9c078c27cf	temp path clean for some backend tests	5 years ago
Martin Atkins	f0034beb33	core: refactoring.ImpliedMoveStatements replaces NodeCountBoundary Going back a long time we've had a special magic behavior which tries to recognize a situation where a module author either added or removed the "count" argument from a resource that already has instances, and to silently rename the zeroth or no-key instance so that we don't plan to destroy and recreate the associated object. Now we have a more general idea of "move statements", and specifically the idea of "implied" move statements which replicates the same heuristic we used to use for this behavior, we can treat this magic renaming rule as just another "move statement", special only in that Terraform generates it automatically rather than it being written out explicitly in the configuration. In return for wiring that in, we can now remove altogether the NodeCountBoundary graph node type and its associated graph transformer, CountBoundaryTransformer. We handle moves as a preprocessing step before building the plan graph, so we no longer need to include any special nodes in the graph to deal with that situation. The test updates here are mainly for the graph builders themselves, to acknowledge that indeed we're no longer inserting the NodeCountBoundary vertices. The vertices that NodeCountBoundary previously depended on now become dependencies of the special "root" vertex, although in many cases here we don't see that explicitly because of the transitive reduction algorithm, which notices when there's already an equivalent indirect dependency chain and removes the redundant edge. We already have plenty of test coverage for these "count boundary" cases in the context tests whose names start with TestContext2Plan_count and TestContext2Apply_resourceCount, all of which continued to pass here without any modification and so are not visible in the diff. The test functions particularly relevant to this situation are: - TestContext2Plan_countIncreaseFromNotSet - TestContext2Plan_countDecreaseToOne - TestContext2Plan_countOneIndex - TestContext2Apply_countDecreaseToOneCorrupted The last of those in particular deals with the situation where we have both a no-key instance _and_ a zero-key instance in the prior state, which is interesting here because to exercises an intentional interaction between refactoring.ImpliedMoveStatements and refactoring.ApplyMoves, where we intentionally generate an implied move statement that produces a collision and then expect ApplyMoves to deal with it in the same way as it would deal with all other collisions, and thus ensure we handle both the explicit and implied collisions in the same way. This does affect some UI-level tests, because a nice side-effect of this new treatment of this old feature is that we can now report explicitly in the UI that we're assigning new addresses to these objects, whereas before we just said nothing and hoped the user would just guess what had happened and why they therefore weren't seeing a diff. The backend/local plan tests actually had a pre-existing bug where they were using a state with a different instance key than the config called for but getting away with it because we'd previously silently fix it up. That's still fixed up, but now done with an explicit mention in the UI and so I made the state consistent with the configuration here so that the tests would be able to recognize _real_ differences where present, as opposed to the errant difference caused by that inconsistency.	5 years ago
Martin Atkins	332ea1f233	backend/local: TestLocal_plan_context_error to fail terraform.NewContext The original intent of this test was to verify that we properly release the state lock if terraform.NewContext fails. This was in response to a bug in an earlier version of Terraform where that wasn't true. In the recent refactoring that made terraform.NewContext no longer responsible for provider constraint/checksum verification, this test began testing a failed plan operation instead, which left the error return path from terraform.NewContext untested. An invalid parallelism value is the one remaining case where terraform.NewContext can return an error, so as a localized fix for this test I've switched it to just intentionally set an invalid parallelism value. This is still not ideal because it's still testing an implementation detail, but I've at least left a comment inline to try to be clearer about what the goal is here so that we can respond in a more appropriate way if future changes cause this test to fail again. In the long run I'd like to move this last remaining check out to be the responsibility of the CLI layer, with terraform.NewContext either just assuming the value correct or panicking when it isn't, but the handling of this CLI option is currently rather awkwardly spread across the command and backend packages so we'll save that refactoring for a later date.	5 years ago
Martin Atkins	718fa3895f	backend: Remove Operation.Parallelism field The presence of this field was confusing because in practice the local backend doesn't use it for anything and the remote backend was using it only to return an error if it's set to anything other than the default, under the assumption that it would always match ContextOpts.Parallelism. The "command" package is the one actually responsible for handling this option, and it does so by placing it into the partial ContextOpts which it passes into the backend when preparing for a local operation. To make that clearer, here we remove Operation.Parallelism and change the few uses of it to refer to ContextOpts.Parallelism instead, so that everyone is reading and writing this value from the same place.	5 years ago
James Bardin	d0993b0e80	fix temp directory handling in some tests Cleanup some more test fixtures to use t.TempDir Use EvalSymlinks with temp dir paths to help with MacOS errors from various terraform components.	5 years ago
James Bardin	8ed9a270e5	Merge pull request #29559 from hashicorp/jbardin/optional-attrs Prevent `ObjectWithOptionalAttrs` from escaping	5 years ago
James Bardin	53a73a8ab6	configs: add ConstraintType to config.Variable In order to handle optional attributes, the Variable type needs to keep track of the type constraint for decoding and conversion, as well as the concrete type for creating values and type comparison. Since the Type field is referenced throughout the codebase, and for future refactoring if the handling of optional attributes changes significantly, the constraint is now loaded into an entirely new field called ConstraintType. This prevents types containing ObjectWithOptionalAttrs from escaping the decode/conversion codepaths into the rest of the codebase.	5 years ago
Martin Atkins	343279110a	core: Graph walk loads plugin schemas opportunistically Previously our graph walker expected to recieve a data structure containing schemas for all of the provider and provisioner plugins used in the configuration and state. That made sense back when terraform.NewContext was responsible for loading all of the schemas before taking any other action, but it no longer has that responsiblity. Instead, we'll now make sure that the "contextPlugins" object reaches all of the locations where we need schema -- many of which already had access to that object anyway -- and then load the needed schemas just in time. The contextPlugins object memoizes schema lookups, so we can safely call it many times with the same provider address or provisioner type name and know that it'll still only load each distinct plugin once per Context object. As of this commit, the Context.Schemas method is now a public interface only and not used by logic in the "terraform" package at all. However, that does leave us in a rather tenuous situation of relying on the fact that all practical users of terraform.Context end up calling "Schemas" at some point in order to verify that we have all of the expected versions of plugins. That's a non-obvious implicit dependency, and so in subsequent commits we'll gradually move all responsibility for verifying plugin versions into the caller of terraform.NewContext, which'll heal a long-standing architectural wart whereby the caller is responsible for installing and locating the plugin executables but not for verifying that what's installed is conforming to the current configuration and dependency lock file.	5 years ago
Valeriy Pastushenko	7c7e5d8f0a	Don't show data while input if sensitive	5 years ago
James Bardin	863963e7a6	de-linting	5 years ago
Martin Atkins	89b05050ec	core: Functional-style API for terraform.Context Previously terraform.Context was built in an unfortunate way where all of the data was provided up front in terraform.NewContext and then mutated directly by subsequent operations. That made the data flow hard to follow, commonly leading to bugs, and also meant that we were forced to take various actions too early in terraform.NewContext, rather than waiting until a more appropriate time during an operation. This (enormous) commit changes terraform.Context so that its fields are broadly just unchanging data about the execution context (current workspace name, available plugins, etc) whereas the main data Terraform works with arrives via individual method arguments and is returned in return values. Specifically, this means that terraform.Context no longer "has-a" config, state, and "planned changes", instead holding on to those only temporarily during an operation. The caller is responsible for propagating the outcome of one step into the next step so that the data flow between operations is actually visible. However, since that's a change to the main entry points in the "terraform" package, this commit also touches every file in the codebase which interacted with those APIs. Most of the noise here is in updating tests to take the same actions using the new API style, but this also affects the main-code callers in the backends and in the command package. My goal here was to refactor without changing observable behavior, but in practice there are a couple externally-visible behavior variations here that seemed okay in service of the broader goal: - The "terraform graph" command is no longer hooked directly into the core graph builders, because that's no longer part of the public API. However, I did include a couple new Context functions whose contract is to produce a UI-oriented graph, and _for now_ those continue to return the physical graph we use for those operations. There's no exported API for generating the "validate" and "eval" graphs, because neither is particularly interesting in its own right, and so "terraform graph" no longer supports those graph types. - terraform.NewContext no longer has the responsibility for collecting all of the provider schemas up front. Instead, we wait until we need them. However, that means that some of our error messages now have a slightly different shape due to unwinding through a differently-shaped call stack. As of this commit we also end up reloading the schemas multiple times in some cases, which is functionally acceptable but likely represents a performance regression. I intend to rework this to use caching, but I'm saving that for a later commit because this one is big enough already. The proximal reason for this change is to resolve the chicken/egg problem whereby there was previously no single point where we could apply "moved" statements to the previous run state before creating a plan. With this change in place, we can now do that as part of Context.Plan, prior to forking the input state into the three separate state artifacts we use during planning. However, this is at least the third project in a row where the previous API design led to piling more functionality into terraform.NewContext and then working around the incorrect order of operations that produces, so I intend that by paying the cost/risk of this large diff now we can in turn reduce the cost/risk of future projects that relate to our main workflow actions.	5 years ago
Alex Khaerov	9d5f1752c8	oss backend: flattern assume_role block	5 years ago
James Bardin	97a2694528	Merge pull request #28838 from remilapeyre/consul-size-limit Fix handling large states in the Consul backend	5 years ago
Rémi Lapeyre	da6717761e	Merge remote-tracking branch 'origin/main' into update-consul	5 years ago
James Bardin	570b70b02f	Merge pull request #28078 from jasons42/configure-etcdv3-client-max-request-size Expose etcd client MaxCallSendMsgSize config	5 years ago
James Bardin	8dd722ece0	Merge pull request #29167 from xiaozhu36/xiaozhu backend/oss: Changes the DescribeEndpoint to DescribeEndpoints to fixes the unsupported sts bug	5 years ago
James Bardin	431aa0280e	Merge pull request #29157 from remilapeyre/unique-constraint Add uniqueness constraint on workspaces name for the pg backend	5 years ago
Jason Smith	d1608d7a7f	Expose etcd client MaxCallSendMsgSize config The etcdv3 client has a default request send limit of 2.0 MiB. This change exposes the configuration option to increase that limit enabling larger state using the etcdv3 backend. This also requires that the corresponding --max-request-bytes flag be increased on the server side. The default there is 1.5 MiB. Fixes https://github.com/hashicorp/terraform/issues/25745	5 years ago
James Bardin	dd330e5194	Merge pull request #29200 from hashicorp/jbardin/rebase-25554 manual rebase of #25554	5 years ago
Kevin Burke	c047958b57	go.mod,backend: update coreos/etcd dependency to release-3.4 branch etcd rewrote its import path from coreos/etcd to go.etcd.io/etcd. Changed the imports path in this commit, which also updates the code version. This lets us remove the github.com/ugorji/go/codec dependency, which was pinned to a fairly old version. The net change is a loss of 30,000 lines of code in the vendor directory. (I first noticed this problem because the outdated go/codec dependency was causing a dependency failure when I tried to put Terraform and another project in the same vendor directory.) Note the version shows up funkily in go.mod, but I verified visually it's the same commit as the "release-3.4" tag in github.com/coreos/etcd. The etcd team plans to fix the release version tagging in v3.5, which should be released soon.	5 years ago
James Bardin	9c20ed6185	StateMgr must be able to return with locked state The current usage of internal remote state backends requires that `StateMgr` be able to return an instance of `statemgr.Full` even if the state is currently locked.	5 years ago
xiaozhu36	c495caafeb	backend/oss: Changes the DescribeEndpoint to DescribeEndpoints to fixes the unsupported sts bug	5 years ago
Rémi Lapeyre	3c34e15d40	Update the Consul API client Some users would want to use Consul namespaces when using the Consul backend but the version of the Consul API client we use is too old and don't support them. In preparation for this change this patch just update it the client and replace testutil.NewTestServerConfig() by testutil.NewTestServerConfigT() in the tests.	5 years ago
Rémi Lapeyre	b8e0d6f418	Add UNIQUE constraint in the states table for the pg backend	5 years ago
Rémi Lapeyre	3bf053a5fc	Add a test to ensure that workspaces must have a unique name in pg backend	5 years ago
Nick Fagerlund	ab70879b9b	Remote backend: Stop setting message when creating runs Historically, we've used TFC's default run messages as a sort of dumping ground for metadata about the run. We've recently decided to mostly stop doing that, in favor of: - Only specifying the run's source in the default message. - Letting TFC itself handle the default messages. Today, the remote backend explicitly sets a run message, overriding any default that TFC might set. This commit removes that explicit message so we can allow TFC to sort it out. This shouldn't have any bad effect on TFE out in the wild, because it's known how to set a default message for remote backend runs since late 2018.	5 years ago
Rémi Lapeyre	5f444a6862	Fix handling large states in the Consul backend	5 years ago
Rémi Lapeyre	e5fb84a01a	Add test for storing state just under the size limit of the Consul backend Storing a state just a bit smaller than the limit of the KV API fails because we are using the Transaction API which has an overhead.	5 years ago
CJ Horton	2f980f1dfe	Merge pull request #28820 from hashicorp/radditude/refresh-error-message backend/remote: point refresh users towards -refresh-only	5 years ago
CJ Horton	314d322b59	backend/remote: encourage use of -refresh-only	5 years ago
Alisdair McDiarmid	a3b1764fd7	backend/local: Fix lock when applying stale plan When returning from the context method, a deferred function call checked for error diagnostics in the `diags` variable, and unlocked the state if any exist. This means that we need to be extra careful to mutate that variable when returning errors, rather than returning a different set of diags in the same position. Previously this would result in an invalid plan file causing a lock to become stuck.	5 years ago
CJ Horton	ab5fec9aec	backend/remote: test new options and modes Tests for -refresh=false, -refresh-only, and -replace, as well as tests to ensure we error appropriately on mismatched API versions.	5 years ago
CJ Horton	eb1f113693	backend/remote: validate API version for refresh and replace	5 years ago
Chris Arcand	2171f8a1a6	backend/remote: Support replacements in plans	5 years ago
Chris Arcand	a436c7fa2f	backend/remote: Support refresh-only plans	5 years ago
Chris Arcand	cb49a4c8d6	backend/remote: Remove the -refresh=false restriction	5 years ago
James Bardin	4d55e2604f	save apply diagnostics on backend failure Make sure to collect apply diagnostics before persisting the backend state so runtime errors are not lost.	5 years ago
Martin Atkins	36d0a50427	Move terraform/ to internal/terraform/ This is part of a general effort to move all of Terraform's non-library package surface under internal in order to reinforce that these are for internal use within Terraform only. If you were previously importing packages under this prefix into an external codebase, you could pin to an earlier release tag as an interim solution until you've make a plan to achieve the same functionality some other way.	5 years ago
Martin Atkins	f40800b3a4	Move states/ to internal/states/ This is part of a general effort to move all of Terraform's non-library package surface under internal in order to reinforce that these are for internal use within Terraform only. If you were previously importing packages under this prefix into an external codebase, you could pin to an earlier release tag as an interim solution until you've make a plan to achieve the same functionality some other way.	5 years ago
Martin Atkins	034e944070	Move plans/ to internal/plans/ This is part of a general effort to move all of Terraform's non-library package surface under internal in order to reinforce that these are for internal use within Terraform only. If you were previously importing packages under this prefix into an external codebase, you could pin to an earlier release tag as an interim solution until you've make a plan to achieve the same functionality some other way.	5 years ago
Martin Atkins	31349a9c3a	Move configs/ to internal/configs/ This is part of a general effort to move all of Terraform's non-library package surface under internal in order to reinforce that these are for internal use within Terraform only. If you were previously importing packages under this prefix into an external codebase, you could pin to an earlier release tag as an interim solution until you've make a plan to achieve the same functionality some other way.	5 years ago
Martin Atkins	ffe056bacb	Move command/ to internal/command/ This is part of a general effort to move all of Terraform's non-library package surface under internal in order to reinforce that these are for internal use within Terraform only. If you were previously importing packages under this prefix into an external codebase, you could pin to an earlier release tag as an interim solution until you've make a plan to achieve the same functionality some other way.	5 years ago
Martin Atkins	b9a93a0fe7	Move addrs/ to internal/addrs/ This is part of a general effort to move all of Terraform's non-library package surface under internal in order to reinforce that these are for internal use within Terraform only. If you were previously importing packages under this prefix into an external codebase, you could pin to an earlier release tag as an interim solution until you've make a plan to achieve the same functionality some other way.	5 years ago
Martin Atkins	1409f30f9c	Move providers/ to internal/providers/ This is part of a general effort to move all of Terraform's non-library package surface under internal in order to reinforce that these are for internal use within Terraform only. If you were previously importing packages under this prefix into an external codebase, you could pin to an earlier release tag as an interim solution until you've make a plan to achieve the same functionality some other way.	5 years ago
Martin Atkins	05caff2ca3	Move tfdiags/ to internal/tfdiags/ This is part of a general effort to move all of Terraform's non-library package surface under internal in order to reinforce that these are for internal use within Terraform only. If you were previously importing packages under this prefix into an external codebase, you could pin to an earlier release tag as an interim solution until you've make a plan to achieve the same functionality some other way.	5 years ago
Martin Atkins	4c254cc2be	Move httpclient/ to internal/httpclient/ This is part of a general effort to move all of Terraform's non-library package surface under internal in order to reinforce that these are for internal use within Terraform only. If you were previously importing packages under this prefix into an external codebase, you could pin to an earlier release tag as an interim solution until you've make a plan to achieve the same functionality some other way.	5 years ago
Martin Atkins	73dda868cc	Move backend/ to internal/backend/ This is part of a general effort to move all of Terraform's non-library package surface under internal in order to reinforce that these are for internal use within Terraform only. If you were previously importing packages under this prefix into an external codebase, you could pin to an earlier release tag as an interim solution until you've make a plan to achieve the same functionality some other way.	5 years ago

... 2 3 4 5 6 ...

346 Commits (1298fcd41259c2cf66306cce2453efd2c19f445d)