609 Commits (073fd0d183a6fa68965bdfcedbf459e2fbc78f8d)

Author	SHA1	Message	Date
Mikhail Mazurskiy	c9ce1f0c1f	Fix typos (#24531)	6 years ago
Paddy	e6592dc710	Add support for provider metadata to modules. (#22583) ... Implement a new provider_meta block in the terraform block of modules, allowing provider-keyed metadata to be communicated from HCL to provider binaries. Bundled in this change for minimal protocol version bumping is the addition of markdown support for attribute descriptions and the ability to indicate when an attribute is deprecated, so this information can be shown in the schema dump. Co-authored-by: Paul Tyng <paul@paultyng.net>	6 years ago
Radek Simko	7860f55e4f	Version tools per Go convention under tools.go	7 years ago
appilon	d3dc1263bf	Merge pull request #22382 from hashicorp/appilon/delete-files ... [CLEANUP] Prune internal usage of config package (with 1 exception)	7 years ago
Radek Simko	ecbfc365a0	Merge pull request #20157 from shinmog/conflictswith ... helper/schema: Add "part" to ConflictsWith validation error	7 years ago
Radek Simko	7861cc6141	Merge pull request #20309 from chanzuckerberg/ryanking/remove_lifecycle_comment ... helper/schema: Remove comment about nested schema.Resources having their own lifecycle	7 years ago
Radek Simko	350395d804	Add better comment	7 years ago
Alex Pilon	77757d9f5b	prune references to config/module ... delete config/module prune references to config except in terraform/resource.go move, cleanup, and delete inert code	7 years ago
Alex Pilon	4bf43efcfd	move hcl2shim package to configs	7 years ago
Alex Pilon	ec0402a238	add case to decoder to assert to slice, then each item to a map	7 years ago
Alex Pilon	6ae281b34f	set Err to true for test ... This was likely meant to be set to Err true but the old parser mistakenly didn't raise an error	7 years ago
Alex Pilon	6de3c32652	comment out failing test	7 years ago
Alex Pilon	83aa07f907	prune NewResourceConfig and update tests	7 years ago
The Terraform Team	176f790323	Merge pull request #22262 from hashicorp/mildwonkey/b-deprecation-warnings ... helper/schema: don't skip deprecation check during validation	7 years ago
Kristin Laemmert	bfd66083de	helper/schema: don't skip deprecation check during validation ... If an attribute was not wholly known, helper/schema was skipping the `validateType` function which (among other things) returned deprecation messages. This PR checks for deprecation before returning when skipping validateType.	7 years ago
Paul Tyng	e400c25358	Minor typo	7 years ago
Paul Tyng	366f70a71e	Update copy for Exists ... You can signal the same information in `Read` with an empty ID if the object does not exist, Implementing `Exists` is not the only way to do so and in some providers is also not the preferred way.	7 years ago
James Bardin	7648f99bca	Merge pull request #22236 from hashicorp/jbardin/nil-in-config ... don't reflect nil in schema validation	7 years ago
James Bardin	016c4f782d	don't reflect nil in schema validation ... Nil values were not previously expected during validation, but they can appear in some situations with the new protocol. Add checks to prevent using zero reflect.Values.	7 years ago
James Bardin	4bed030d40	don't validate MinItems with unknowns in a block ... If there are unknowns, the block may have come from a dynamic declaration, and we can't validate MinItems. Once the blocks are expanded, we will get the full config for validation without any unknown values.	7 years ago
Alex Pilon	7f8f198719	remove UnknownVariabeValue from config and update references to shim	7 years ago
James Bardin	cd3ac50ddb	prevent sdk panics in 2 specific cases ... Fix 2 specific panics in the sdk when reading nil or computed maps from various configurations. The legacy sdk code is too dependent on undefined behavior to attempt to find and fix the root cause at this point. Since the code is essentially frozen for future development, these changes are specifically targeted to only prevent panics from within providers. Because any code effected by these changes would have panicked, there cannot be anything depending on the behavior, and these should be safe to fix.	7 years ago
James Bardin	2448d1d38b	move timeout handling to grpc_provider ... simpleDiff is only called from the grpc_provider, and we always need to make sure the timeouts are encoded in the private data.	7 years ago
James Bardin	6055cb632e	filter unknowns from simple lists and maps in sdk ... While there was already a check in the sdk to filter unknowns from validation, it missed the case where those were in simple lists and maps.	7 years ago
James Bardin	c8a2f3840b	remove SkipCoreTypeCheck ... This experiment is no longer needed for handling computed blocks, since the legacy SDK can't reasonably handle Dynamic types, we need to remove this before the final release. Remove LegacySchema functions as well, since handling SkipCoreTypeCheck was the only thing left they were handling.	7 years ago
Radek Simko	8a6d1d62b6	stringer: Regenerate files with latest version	7 years ago
James Bardin	6bc36d3321	validate integers when using protoV5 ... The new type system only has a Number type, but helper schema differentiates between Int and Float values. Verify that a new config value is an integer during Validate, because the existing WeakDecode validation will decode a float value into an integer while the config FieldReader will attempt to parse the float exactly. Since we're limiting this to protoV5, we can be certain that any valid config value will be converted to an `int` type by the shims. The only case where an integral float value will appear is if the integer is out of range for the systems `int` type, but we also need to prevent that anyway since it would fail to read in the same manner.	7 years ago
James Bardin	7075bc9a4d	restrict the ComputedKeys usage to containers ... Computed primitive values must see the UnknownConfigValue or they are assumed to be unchanged. Restrict the usage of the protov5 ComputedKeys to containers.	7 years ago
James Bardin	133d3d7971	check for computed values in the config ... First check the ComputedValues field in the config when reading config field, so that we can detect if there is an unknown value in a container. Since maps, lists and sets are verified to exist by looking for a "length" first, an unknown config value in the config is ignored.	7 years ago
James Bardin	67395306e1	delete unknown values from apply config altogether ... removeConfigUnknowns need to remove the value completely from the config map. Removing this value allows GetOk and GetOkExists to indicate if the value was set in the config in the case of an Optional+Computed attribute.	7 years ago
Alex Somesan	275e0a53f2	Merge pull request #20851 from hashicorp/doc-validatefunc-maps ... Document that ValidateFunc works on maps.	7 years ago
Alex Somesan	01a169c66f	make fmt	7 years ago
Alex Somesan	0395c3ac58	Re-phrase docs to enumerate types which support ValidateFunc	7 years ago
Martin Atkins	861a2ebf26	helper/schema: Use a more targeted shim for nested set diff applying ... We previously attempted to make the special diff apply behavior for nested sets of objects work with attribute mode by totally discarding attribute mode for all shims. In practice, that is too broad a solution: there are lots of other shimming behaviors that we _don't_ want when attribute mode is enabled. In particular, we need to make sure that the difference between null and empty can be seen in configuration. As a compromise then, we will give all of the shims access to the real ConfigMode and then do a more specialized fixup within the diff-apply logic: we'll construct a synthetic nested block schema and then use that to run our existing logic to deal with nested sets of objects, while using the previous behavior in all other cases. In effect, this means that the special new behavior only applies when the provider uses the opt-in ConfigMode setting on a particular attribute, and thus this change has much less risk of causing broad, unintended regressions elsewhere.	7 years ago
Martin Atkins	bd1a215580	helper/resource: Ignore Removed attributes for ImportStateVerify ... Due to the lossiness of our legacy models for diff and state, shimming a diff and then creating a state from it produces a different result than shimming a state directly. That means that ImportStateVerify no longer works as expected if there are any Computed attributes in the schema where d.Set isn't called during Read. Fixing that for every case would require some risky changes to the shim behavior, so we're instead going to ask provider developers to address it by adding `d.Set` calls where needed, since that is the contract for "Computed" anyway -- a default value should be produced during Create, and thus by extension during Import. However, since a common situation where this occurs is attributes marked as "Removed", since all of the code that deals with them has generally been deleted, we'll avoid problems in that case here by treating Removed attributes as ignored for the purposes of ImportStateVerify. This required exporting some functionality that was formerly unexported in helper/schema, but it's a relatively harmless schema introspection function so shouldn't be a big deal to export it.	7 years ago
James Bardin	5f52aba3ae	Remove unknown value strings from apply diffs ... The synthetic config value used to create the Apply diff should contain no unknown config values. Any remaining UnknownConfigValues were due to that being used as a placeholder for values yet to be computed, and these should be marked NewComputed in the diff.	7 years ago
James Bardin	3ec93710fc	PromoteSingle is used in 0.11 mode	7 years ago
James Bardin	8730d99309	LegacyResourceSchema to remove 0.12 features ... This allows us to call CoreConfigSchema and return something that looks like the original schema.	7 years ago
James Bardin	c5023c7702	cleanup after AsSingle removal	7 years ago
James Bardin	1a9c06d0f5	Revert "helper/schema: Implementation of the AsSingle mechanism" ... This reverts commit 1987a92386.	7 years ago
James Bardin	4dbe6add77	Revert "helper/schema: Schema.AsSingle flag" ... This reverts commit 4c0c74571d.	7 years ago
Brian Flad	a8e3787afc	helper/schema: Prevent setSet() panic with typed nil ... References: * https://github.com/hashicorp/terraform/issues/14418 * v0.9.5 (original bug report): a59ee0b30e/helper/schema/field_writer_map.go (L311) * v0.11.12 (Terraform AWS Provider discovery): 057286e522/helper/schema/field_writer_map.go (L343) When creating flatten functions in Terraform Providers that return *schema.Set, its possible to return a typed `nil`, e.g. ```go func flattenHeaders(h *cloudfront.Headers) *schema.Set { if h.Items != nil { return schema.NewSet(schema.HashString, flattenStringList(h.Items)) } return nil } ``` This previously could cause a panic, e.g. ``` panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x1881911] goroutine 1325 [running]: github.com/hashicorp/terraform/helper/schema.(*MapFieldWriter).setSet(0xc00054bf00, 0xc00073efa0, 0x5, 0x5, 0x5828140, 0x0, 0xc0002cea50, 0xc000e996a8, 0xc001026e40) /Users/bflad/go/pkg/mod/github.com/hashicorp/terraform@v0.11.12/helper/schema/field_writer_map.go:343 +0x211 ``` Here we catch the typed `nil` and return an empty list flatmap result instead. Unit testing result prior to code update: ``` --- FAIL: TestMapFieldWriter (0.00s) panic: runtime error: invalid memory address or nil pointer dereference [recovered] panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x1777cdc] goroutine 913 [running]: testing.tRunner.func1(0xc00045b800) /usr/local/Cellar/go/1.12.1/libexec/src/testing/testing.go:830 +0x392 panic(0x192cf20, 0x2267ca0) /usr/local/Cellar/go/1.12.1/libexec/src/runtime/panic.go:522 +0x1b5 github.com/hashicorp/terraform/helper/schema.(*MapFieldWriter).setSet(0xc0004648a0, 0xc0004408d0, 0x1, 0x1, 0x19e3de0, 0x0, 0xc00045c600, 0x30, 0x19e0080) /Users/bflad/src/github.com/hashicorp/terraform/helper/schema/field_writer_map.go:344 +0x68c github.com/hashicorp/terraform/helper/schema.(*MapFieldWriter).set(0xc0004648a0, 0xc0004408d0, 0x1, 0x1, 0x19e3de0, 0x0, 0x1, 0x18) /Users/bflad/src/github.com/hashicorp/terraform/helper/schema/field_writer_map.go:107 +0x28b github.com/hashicorp/terraform/helper/schema.(*MapFieldWriter).WriteField(0xc0004648a0, 0xc0004408d0, 0x1, 0x1, 0x19e3de0, 0x0, 0x0, 0x0) /Users/bflad/src/github.com/hashicorp/terraform/helper/schema/field_writer_map.go:89 +0x504 github.com/hashicorp/terraform/helper/schema.TestMapFieldWriter(0xc00045b800) /Users/bflad/src/github.com/hashicorp/terraform/helper/schema/field_writer_map_test.go:337 +0x2ddd testing.tRunner(0xc00045b800, 0x1a44f90) /usr/local/Cellar/go/1.12.1/libexec/src/testing/testing.go:865 +0xc0 created by testing.(*T).Run /usr/local/Cellar/go/1.12.1/libexec/src/testing/testing.go:916 +0x35a ```	7 years ago
Alex Somesan	ef681e527d	Rephrase for clarity	7 years ago
Alex Somesan	adebc65d95	Document that ValidateFunc works on maps.	7 years ago
Martin Atkins	135121562e	helper/plugin: Implement Schema.SkipCoreTypeCheck ... The previous commit added this flag but did not implement it. Here we implement it by adjusting the shape of schema we return to Terraform Core to mark the attribute as untyped and then ensure that gets handled correctly on the SDK side.	7 years ago
Martin Atkins	7f860dc83e	helper/schema: Schema.SkipCoreTypeCheck flag ... When running in v0.12-and-higher mode, this will cause the SDK to report the type of the attribute as "any", effectively skipping type checking on the Core side altogether and checking only in the SDK and provider code. The practical impact of this is to restore the v0.11-style checking behavior of allowing object values to be missing certain attributes as long as they are marked as optional in the schema. The SDK can do this because it uses a unified schema model for both object values and nested blocks, while Terraform Core only supports the idea of "optional" when talking about attributes in nested blocks. This is a continuation of the pile of workarounds that also includes the ConfigMode and AsSingle fields, allowing providers to selectively opt out of new v0.12 behaviors in situations where they conflict with decisions made in the design of the providers in our old world where Terraform Core delegated _all_ validation to providers. This is designed as an opt-in so that we can limit its impact only to specific cases where it's needed and minimize the risk of regressions elsewhere. Providers should use this sparingly only in situations where prevailing usage disagrees with the new expectations of Terraform Core in v0.12. This commit only adds the flag, and does not implement any behavior for it yet. That means this commit can exist in both the v0.11 and v0.12 codebases, allowing for API compatibility. A subsequent commit for v0.12 (not included in v0.11) will then implement this behavior.	7 years ago
Justin Downing	1e32ae243c	grammatical updates to comments and docs (#20195)	7 years ago
Paul Tyng	ea7e922007	oxford comma	7 years ago
Paul Tyng	ec9450a262	Fix limitations on Elem for TypeMap	7 years ago
Martin Atkins	1987a92386	helper/schema: Implementation of the AsSingle mechanism ... The previous commit added a new flag to schema.Schema which is documented to make a list with MaxItems: 1 be presented to Terraform Core as a single value instead, giving a way to switch to non-list nested resources without it being a breaking change for Terraform v0.11 users as long as it's done prior to a provider's first v0.12-compatible release. This is the implementation of that mechanism. It's intentionally implemented as a suite of extra fixups rather than direct modifications to existing shim code because we want to ensure that this has no effect whatsoever on the result of a resource type that _isn't_ using AsSingle. Although there is some small unit test coverage of the fixup steps here, the primary testing for this is in the test provider since the integration of all of these fixup steps in the correct order is the more important result than any of the intermediate fixup steps.	7 years ago