706 Commits (070e4317b49e4b3fc4dca992eb0c59e9eb825b71)

Author	SHA1	Message	Date
James Bardin	b0094dbf36	Merge pull request #27678 from GreenHedgehog/master ... Fix possible nil pointer dereference in azure sdk	5 years ago
Matthew Frahry	81dc028689	backend/azurerm: updating the dependencies for the Azure Backend #26721	5 years ago
Alisdair McDiarmid	6375c6ce6b	Merge pull request #27787 from hashicorp/alisdair/command-views-state-locker ... clistate: Update clistate.Locker for command views	5 years ago
Alisdair McDiarmid	1ae3d30383	Merge pull request #27760 from hashicorp/alisdair/command-views-ui-hook ... cli: Migrate Terraform UI hook to command views	5 years ago
Alisdair McDiarmid	3257f31aa7	backend/local: Return diag for refresh empty state ... The warning diag added when refreshing an empty state file was never rendered, and instead a custom (and incorrect) warning was output to the UI. This commit fixes the dropped diag and removes the custom warning.	5 years ago
Alisdair McDiarmid	2d1976bbda	clistate: Update clistate.Locker for command views ... The clistate package includes a Locker interface which provides a simple way for the local backend to lock and unlock state, while providing feedback to the user if there is a delay while waiting for the lock. Prior to this commit, the backend was responsible for initializing the Locker, passing through direct access to the cli.Ui instance. This structure prevented commands from implementing different implementations of the state locker UI. In this commit, we: - Move the responsibility of creating the appropriate Locker to the source of the Operation; - Add the ability to set the context for a Locker via a WithContext method; - Replace the Locker's cli.Ui and Colorize members with a StateLocker view; - Implement views.StateLocker for human-readable UI; - Update the Locker interface to return detailed diagnostics instead of errors, reducing its direct interactions with UI; - Add a Timeout() method on Locker to allow the remote backend to continue to misuse the -lock-timeout flag to cancel pending runs. When an Operation is created, the StateLocker field must now be populated with an implementation of Locker. For situations where locking is disabled, this can be a no-op locker. This change has no significant effect on the operation of Terraform, with the exception of slightly different formatting of errors when state locking or unlocking fails.	5 years ago
Alisdair McDiarmid	a7b7cd29fc	cli: Migrate Terraform UI hook to command views ... Move the code which renders Terraform hook callbacks as UI into the views package, backed by a views.View instead of a cli.Ui. Update test setup accordingly. To allow commands to control this hook, we add a hooks member on the backend Operation struct. This supersedes the hooks in the Terraform context, which is not directly controlled by the command logic. This commit should not change how Terraform works, and is refactoring in preparation for more changes which move UI code out of the backend.	5 years ago
Matthew Frahry	cb041053e9	Merge with master	5 years ago
Matthew Frahry	2b42445454	Update client.go	5 years ago
Matthew Frahry	f52a18b134	Update backend/remote-state/azure/client.go ... Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>	5 years ago
Alisdair McDiarmid	536c80da23	backend: Add per-operation diagnostic rendering ... The enhanced backends (local and remote) need to be able to render diagnostics during operations. Prior to this commit, this functionality was supported with a per-backend `ShowDiagnostics` function pointer. In order to allow users of these backends to control how diagnostics are rendered, this commit moves that function pointer to the `Operation` type. This means that a diagnostic renderer is configured for each operation, rather than once per backend initialization. Some secondary consequences of this change: - The `ReportResult` method on the backend is now moved to the `Operation` type, as it needs to access the `ShowDiagnostics` callback (and nothing else from the backend); - Tests which assumed that diagnostics would be written to the backend's `cli.Ui` instance are migrated to using a new record/playback diags helper function; - Apply, plan, and refresh commands now pass a pointer to the `Meta` struct's `showDiagnostics` method. This commit should not change how Terraform works, and is refactoring in preparation for more changes which move UI code out of the backend.	5 years ago
Omar Ismail	4ac095b63f	only print horizontal rule at first attempt	5 years ago
Omar Ismail	d96c90b6af	Cost Estimation CLI output unnecessary	5 years ago
Alisdair McDiarmid	b2ba650c21	cli: Remove deprecated destroy -force flag ... This dramatically simplifies the logic around auto-approve, which is nice. Also add test coverage for the manual approve step, for both apply and destroy, answering both yes and no.	5 years ago
GreenHedgehog	d4db1d1342	fix possible nil pointer dereference in azure sdk	5 years ago
Alisdair McDiarmid	5ca118b4e6	cli: Move resource count code to command package ... CountHook is an implementation of terraform.Hook which is used to calculate how many resources were added, changed, or destroyed during an apply. This hook was previously injected in the local backend code, which means that the apply command code has no access to these counts. This commit moves the CountHook code into the command package, and removes an unused instance of the hook in the plan code path. The goal here is moving UI code into the command package.	5 years ago
Jonathan Hall	49ee3d3ef8	Grammar nit: "setup" as a verb should be spelled "set up"	5 years ago
Nick Fagerlund	ed7f97c34f	Update language docs URLs in code and tests	5 years ago
James Bardin	9f2a6d33be	move remaining helper packages to internal	5 years ago
Martin Atkins	e6a516d87e	backend/local: Use terminal properties to tweak the plan output ... We now require the output to accept UTF-8 and we can determine how wide the terminal (if any) is, so here we begin to make use of that for the "terraform plan" command. The horizontal rule is now made of box drawing characters instead of hyphens and fills the whole terminal width. The paragraphs of text in the output are now also wrapped to fill the terminal width, instead of the hard-wrapping we did before. This is just a start down the road of making better use of the terminal capabilities. Lots of other commands could benefit from updates like these too.	5 years ago
Martin Atkins	d2c3403ab6	command: Use the new terminal.Streams object ... Here we propagate in the initialized terminal.Streams from package main, and then onwards to backends running in CLI mode. This also replaces our use of helper/wrappedstreams to determine whether stdin is a terminal or a pipe. helper/wrappedstreams returns incorrect file descriptors on Windows, causing StdinPiped to always return false on that platform and thus causing one of the odd behaviors discussed in Finally, this includes some wrappers around the ability to look up the number of columns in the terminal in preparation for use elsewhere. These wrappers deal with the fact that our unit tests typically won't populate meta.Streams.	5 years ago
James Bardin	3bc7d77230	update MockProvider usage	5 years ago
James Bardin	e614fb9aed	refresh is expected for destroy ... These tests were not previously running a refresh, and hence did not expect the resources to be read.	5 years ago
Pam Selle	c9f372a62b	Merge pull request #24896 from bendrucker/validate-ignore-empty-provider ... validate: ignore providers with no configuration	5 years ago
Alisdair McDiarmid	7e09cd1228	backend/remote: No version check for local ops ... If the remote backend is connected to a Terraform Cloud workspace in local operations mode, we disable the version check, as the remote Terraform version is meaningless.	5 years ago
Alisdair McDiarmid	619c6727ef	backend/remote: No version check for operations ... Terraform remote version conflicts are not a concern for operations. We are in one of three states: - Running remotely, in which case the local version is irrelevant; - Workspace configured for local operations, in which case the remote version is meaningless; - Forcing local operations with a remote backend, which should only happen in the Terraform Cloud worker, in which case the Terraform versions by definition match. This commit therefore disables the version check for operations (plan and apply), which has the consequence of disabling it in Terraform Cloud and Enterprise runs. In turn this enables Terraform Enterprise runs with bundles which have a version that doesn't exactly match the bundled Terraform version.	6 years ago
Ben Drucker	a39273cfa3	Merge remote-tracking branch 'origin/master' into validate-ignore-empty-provider	6 years ago
James Bardin	7eac9e1d89	set SkipRefresh for plan and apply ... The option is set in the same place for plan and apply.	6 years ago
Alisdair McDiarmid	6e0d8cde91	backend/remote: Fix for "latest" workspace version ... Terraform Cloud/Enterprise support a pseudo-version of "latest" for the configured workspace Terraform version. If this is chosen, we abandon the attempt to verify the versions are compatible, as the meaning of "latest" cannot be predicted. This affects both the StateMgr check (used for commands which execute remotely) and the full version check (for local commands).	6 years ago
Ben Drucker	2549e53aed	add backend refresh test with provider config	6 years ago
Ben Drucker	7e11b97923	Merge remote-tracking branch 'origin/master' into validate-ignore-empty-provider	6 years ago
James Bardin	96436f526a	unused err value and nil context ... Incorrect err assignment had no effect. Never use a nil context.	6 years ago
James Bardin	d2c2d58f09	unused	6 years ago
James Bardin	de5b022a3b	legacy types in backend/local	6 years ago
James Bardin	2635b3b023	update remote state to use legacy types	6 years ago
Alisdair McDiarmid	c5c1f31db3	backend: Validate remote backend Terraform version ... When using the enhanced remote backend, a subset of all Terraform operations are supported. Of these, only plan and apply can be executed on the remote infrastructure (e.g. Terraform Cloud). Other operations run locally and use the remote backend for state storage. This causes problems when the local version of Terraform does not match the configured version from the remote workspace. If the two versions are incompatible, an `import` or `state mv` operation can cause the remote workspace to be unusable until a manual fix is applied. To prevent this from happening accidentally, this commit introduces a check that the local Terraform version and the configured remote workspace Terraform version are compatible. This check is skipped for commands which do not write state, and can also be disabled by the use of a new command-line flag, `-ignore-remote-version`. Terraform version compatibility is defined as: - For all releases before 0.14.0, local must exactly equal remote, as two different versions cannot share state; - 0.14.0 to 1.0.x are compatible, as we will not change the state version number until at least Terraform 1.1.0; - Versions after 1.1.0 must have the same major and minor versions, as we will not change the state version number in a patch release. If the two versions are incompatible, a diagnostic is displayed, advising that the error can be suppressed with `-ignore-remote-version`. When this flag is used, the diagnostic is still displayed, but as a warning instead of an error. Commands which will not write state can assert this fact by calling the helper `meta.ignoreRemoteBackendVersionConflict`, which will disable the checks. Those which can write state should instead call the helper `meta.remoteBackendVersionCheck`, which will return diagnostics for display. In addition to these explicit paths for managing the version check, we have an implicit check in the remote backend's state manager initialization method. Both of the above helpers will disable this check. This fallback is in place to ensure that future code paths which access state cannot accidentally skip the remote version check.	6 years ago
Alisdair McDiarmid	eee57280f6	backend: Faster remote backend tests ... The remote backend tests spent most of their execution time sleeping in various polling and backoff waits. This is unnecessary when testing against a mock server, so reduce all of these delays when under test to much lower values. Only one remaining test has an artificial delay: verifying the discovery of services against an unknown hostname. This times out at DNS resolution, which is more difficult to fix than seems worth it at this time.	6 years ago
James Bardin	8e7a9b6312	output test for plan with no root output changes ... Module outputs do not show up in the plan, and are not rendered in the UI.	6 years ago
Ben Drucker	afe8b67b95	Merge remote-tracking branch 'origin/master' into validate-ignore-empty-provider ... # Conflicts: # terraform/eval_validate.go	6 years ago
Upo	3b9c5e5bbb	backend/gcs: remove deprecated "path" config argument (#26841)	6 years ago
Upo	4ccc63d79d	backend: Add service account impersonation to GCS Backend and update the docs (#26700)	6 years ago
Alisdair McDiarmid	b335918c3c	backend: Only show root module output changes ... When rendering planned output changes, we need to filter the plan's output changes to ensure that only root module outputs which have changed are rendered. Otherwise we will render changes for submodule outputs, and (with concise diff disabled) render unchanged outputs also.	6 years ago
Paul Thrasher	fc8a76a2a3	Stop printing tfce error message log	6 years ago
tombuildsstuff	6f244f97d1	backend/azurerm: updating to handle the field rename	6 years ago
Kristin Laemmert	b8e3b8036a	backend: remove deprecated atlas backend	6 years ago
Paul Thrasher	960042ad42	Merge pull request #26618 from hashicorp/pault/tfce-continue-on-error ... Allow runs to continue on tfce error	6 years ago
James Bardin	0b31ffa587	use a single log writer ... Use a single log writer instance for all std library logging. Setup the std log writer in the logging package, and remove boilerplate from test packages.	6 years ago
James Bardin	6ca477f042	move helper/logging to internal ... remove a dead code file too	6 years ago
Paul Thrasher	d380f5873c	Allow runs to continue on tfce error ... A cost estimation error does not actually stop a run, so the run was continuing in the background after the cli exits, causing confusion. This change matches the UI behavior.	6 years ago
James Bardin	5e9425b562	unreachable	6 years ago