138 Commits (03dc37fda284bc328a04af0d19db077bcfe6ba65)

Author	SHA1	Message	Date
Martin Atkins	31299e688d	core: Allow legacy SDK to opt out of plan-time safety checks ... Due to the inprecision of our shimming from the legacy SDK type system to the new Terraform Core type system, the legacy SDK produces a number of inconsistencies that produce only minor quirky behavior or broken edge-cases. To retain compatibility with those existing weird behaviors, the legacy SDK opts out of our safety checks. The intent here is to allow existing providers to continue to do their previous unsafe behaviors for now, accepting that this will allow certain quirky bugs from previous releases to persist, and then gradually migrate away from the legacy SDK and remove this opt-out on a per-resource basis over time. As with the apply-time safety check opt-out, this is reserved only for the legacy SDK and must not be used in any new SDK implementations. We still include any inconsistencies as warnings in the logs as an aid to anyone debugging weird behavior, so that they can see situations where blame may be misplaced in the user-visible error messages.	7 years ago
Martin Atkins	1530fe52f7	core: Legacy SDK providers opt out of our new apply result check ... The shim layer for the legacy SDK type system is not precise enough to guarantee it will produce identical results between plan and apply. In particular, values that are null during plan will often become zero-valued during apply. To avoid breaking those existing providers while still allowing us to introduce this check in the future, we'll introduce a rather-hacky new flag that allows the legacy SDK to signal that it is the legacy SDK and thus disable the check. Once we start phasing out the legacy SDK in favor of one that natively understands our new type system, we can stop setting this flag and thus get the additional safety of this check without breaking any previously-released providers. No other SDK is permitted to set this flag, and we will remove it if we ever introduce protocol version 6 in future, assuming that any provider supporting that protocol will always produce consistent results.	7 years ago
Martin Atkins	a9274beaca	build: Run "go generate" in modules mode ... It seems that all of the tools we run here are now sufficiently modules-aware to run without problems in modules mode, and indeed running _not_ in modules mode was causing problems with locating packages in mockgen.	7 years ago
Martin Atkins	bdcac8792d	plugin: Use correct schema when marshaling imported resource objects ... Previously we were using the type name requested in the import to select the schema, but a provider is free to return additional objects of other types as part of an import result, and so it's important that we perform schema selection separately for each returned object. If we don't do this, we get confusing downstream errors where the resulting object decodes to the wrong type and breaks various invariants expected by Terraform Core. The testResourceImportOther test in the test provider didn't catch this previously because it happened to have an identical schema to the other resource type being imported. Now the schema is changed and also there's a computed attribute we can set as part of the refresh phase to make sure we're completing the Read call properly during import. Refresh was working correctly, but we didn't have any tests for it as part of the import flow.	7 years ago
findkim	7816e61614	Bump installer protocol version to 5 and separate client and server protocol references	7 years ago
findkim	abeb86072b	Remove duplicate logging	7 years ago
findkim	6e0de3e3f5	Nest incompatible provider protocol error to include dynamic custom msg	7 years ago
findkim	f75d83c1cd	Prerelease versions are filtered for plugin protocol mismatches	7 years ago
findkim	368ac85a26	Add provider protocol compatibility UI err msg during registry discovery	7 years ago
findkim	43b22d4e14	Fix plugin protocol test	7 years ago
James Bardin	6f54bfaa7c	send config during apply	7 years ago
James Bardin	e706f34794	generate new plugin proto mocks	7 years ago
Martin Atkins	53926ea581	plugin: Fix incorrect trace log message in provider Close ... Was incorrectly printing out "PlanResourceChange" instead of "Close".	7 years ago
James Bardin	1d4c8403a2	enable Auto mTLS in go-plugin	7 years ago
James Bardin	924b97238f	Handle StateFuncs in provider shim ... Any state modifying functions can only be run once during the plan-apply cycle. When regenerating the Diff during ApplyResourceChange, strip out all StateFunc and CustomizeDiff functions from the schema. Thew NewExtra diff field was where config data that was modified by a StateFunc was stored, and needs to be maintained between plan and apply. During PlanResourceChange, store any NewExtra data from the Diff in the PlannedPrivate data, and re-insert the NewExtra data into the Diff generated during ApplyResourceChange.	7 years ago
Martin Atkins	72e279e6b2	providers: Consistently use int64 for schema versions ... The rest of Terraform is still using uint64 for this in various spots, but we'll update that gradually later. We use int64 here because that matches what's used in our protobuf definition, and unsigned integers are not portable across all of the protobuf target languages anyway.	7 years ago
findkim	5e06e39fcc	Use registry alias to fetch providers	7 years ago
Justin Campbell	06825bf46d	plugin/discovery: Add friendly gpg err msg ... When GPG verification fails, display a helpful message to the user instead of the generic openpgp error.	7 years ago
Justin Campbell	9a8a74b9bb	plugin/discovery: Print name before verification ... This is so that any errors output from the checksum/signature verification show up in the expected place in the output.	7 years ago
Justin Campbell	495826444b	plugin/discovery: Use GPG keys from Registry ... When verifying the signature of the SHA256SUMS file, we have been hardcoding HashiCorp's public GPG key and using it as the keyring. Going forward, Terraform will get a list of valid public keys for a provider from the Terraform Registry (registry.terraform.io), and use them as the keyring for the openpgp verification func.	7 years ago
Martin Atkins	4fe9632f09	plugin: Establish our current plugin protocol as version 5 ... The main significant change here is that the package name for the proto definition is "tfplugin5", which is important because this name is part of the wire protocol for references to types defined in our package. Along with that, we also move the generated package into "internal" to make it explicit that importing the generated Go package from elsewhere is not the right approach for externally-implemented SDKs, which should instead vendor the proto definition they are using and generate their own stubs to ensure that the wire protocol is the only hard dependency between Terraform Core and plugins. After this is merged, any provider binaries built against our helper/schema package will need to be rebuilt so that they use the new "tfplugin5" package name instead of "proto". In a future commit we will include more elaborate and organized documentation on how an external codebase might make use of our RPC interface definition to implement an SDK, but the primary concern here is to ensure we have the right wire package name before release.	7 years ago
Martin Atkins	ec57927ea3	build: Take protoc out of the "go generate" path ... Since protoc is not go-gettable, and most development tasks in Terraform won't involve recompiling protoc files anyway, we'll use a separate mechanism for these. This way "go generate" only depends on things we can "go get" in the "make tools" target. In a later commit we should also in some way specify a particular version of protoc to use so that we don't get "flapping" regenerations as developers work with different versions, but the priority here is just to make "make generate" minimally usable again to restore the dev workflow documented in the README. This also includes some updates that resulted from running "make generate" and "make protobuf" after those Makefile changes were in place.	7 years ago
James Bardin	3bdd3b2a6e	update plugin client with PrepareProviderConfig	7 years ago
James Bardin	b173037eb3	update mock for PrepareProviderConfig	7 years ago
James Bardin	ba472c7059	Update proto with new PrepareProviderConfig method	7 years ago
James Bardin	3a0c2f1b67	close grpc TestListener	7 years ago
Martin Atkins	e25f79ed28	plugin/convert: Show approximate location context for all provider errors ... Even if a provider doesn't indicate a specific attribute as the cause of a resource operation error, we know the error relates to some aspect of the resource, so we'll include that approximate information in the result so that we don't produce user-hostile error messages with no context whatsoever. Later we can hopefully refine this to place the source range on the header of the configuration block rather than on an empty part of the body, but that'll require some more complex rework here and so for now we'll just accept this as an interim state so that the user can at least figure out which resource block the error is coming from.	7 years ago
Martin Atkins	3eaf2c308d	plugin/discovery: Use mockos_mockarch when testing installation ... If we don't override these then the tests can only pass on one platform.	7 years ago
James Bardin	0d4d572c39	start work on helper/resource test fixtures ... The helper resource tests won't pass for now, as they use a terraform.MockProvider which can't be used in the schema.Provider shims.	7 years ago
James Bardin	52c0032aed	update provisioners for multiple processes ... The "internal" provisioners are still run in a separate process, and need to be updated to restart on each walk.	7 years ago
James Bardin	a14fe7ae0c	missing diagnostics in pugin protocol ... Some call diagnostics were being missed	7 years ago
James Bardin	795161f615	update to start a new process for each plugin ... Modify the plugin factories to create a new plugin process for each individual plugin.	7 years ago
James Bardin	35b375d3ee	check responses for nil values ... While providers shouldn't return nil values, we need to protect against them. Always assign valid null cty values when the response contains a nil.	7 years ago
Martin Atkins	88551181d5	plugin: Fix tests ... An earlier change made the tests not compile here. We now need to use the legacyPluginMap function, since pluginMap has now been replaced with helpers to produce new-style plugin _sets_.	7 years ago
Martin Atkins	a7342de274	core: Properly handle no-op changes in plan ... Previously we just left these out of the plan altogether, but in the new plan types we intentionally include change information for every resource instance, even if no changes are actually planned, to allow alternative plan file viewers to show what isn't changing as well as what is.	7 years ago
Martin Atkins	9ec00468f8	plugin/convert: Convert cty.PathError to diagnostics with attribute path	7 years ago
Martin Atkins	5d744e6824	plugin: TRACE log for each GRPC-remoted plugin call	7 years ago
Martin Atkins	4bf19797f3	plugin: Fix deadlock in getSchema where mutex is never unlocked ... On the second call here this would fail to release the lock.	7 years ago
Martin Atkins	5559d21855	plugin: Register v5 plugins only if present ... Previously we would construct both provisioner and the provider objects if either callback was set, but this is incorrect because a plugin should actually set only one of these at a time, depending on what kind of plugin it is.	7 years ago
Martin Atkins	44bc7519a6	terraform: More wiring in of new provider types ... This doesn't actually work yet, but it builds and then panics in a pretty satisfying way.	7 years ago
James Bardin	c07ce1cd4b	move conversion functions into separate package ... Managing which function need to be shared between the terraform plugin and the helper plugin without creating cycles was becoming difficult. Move all functions related to converting between terraform and proto type into plugin/convert.	7 years ago
James Bardin	88bfbeb9c5	schema version changed type	7 years ago
James Bardin	b403023841	serve the new version 5 grpc plugins ... Use the new go-plugin version negotiation to server th appropriate plugin type when the client requests protocol version 5.	7 years ago
James Bardin	ff7d51a9b4	update tests to match new test func signature	7 years ago
Kristin Laemmert	5e7956f440	registry/response: rename Collection to ProviderVersionCollection for clarity	7 years ago
James Bardin	c9d91dc64e	remove old comment	7 years ago
Kristin Laemmert	bdaf8290b4	registry/client: added a specific error if the registry client does not ... support the requested service.	7 years ago
James Bardin	c1d4a63fae	GRPCProvider and GRPCProvisioner clients ... Here we add the GRPCProvisioner and GRPCProvider which implement the core provisioners.Interface and providers.Interface, and translate betweeen the core types and the grpc protocol.	7 years ago
James Bardin	81bd3b09d6	generate mocks for some of the grpc interfaces ... These will allow easier testing of the grpc endpoints in isolation. Mocks are generated for ProviderClient, ProvisionerClient, Provisioner_ProvisionResourceClient, and Provisioner_ProvisionResourceServer using `go generate`	7 years ago
James Bardin	e29053432e	grpc proto fixes ... Add missing connection field for ProvisionResource. Add diagnostics to the ProvisionResource stream.	7 years ago