654 Commits (02c2aae12dbcf76b5e2a65e67d1fcc625f79eab8)

Author	SHA1	Message	Date
Liam Cervante	5bbdc4c3b6	terraform test: allow providers in test files to reference variables (#34069) ... * Process only relevant variables in the testing framework * add support for variables within test provider configurations * remove unused function * fix consistency checks	3 years ago
Liam Cervante	5294c2bb47	Process only relevant variables in the testing framework (#34072)	3 years ago
Liam Cervante	01c0480e77	Test framework will produce regular updates in -json mode (#33953) ... * Test framework will produce regular updates in -json mode * add tests * docs * docs tweaking	3 years ago
James Bardin	2664c062c9	Merge pull request #33932 from hashicorp/jbardin/import-for-each ... Import block expansion with for_each	3 years ago
Liam Cervante	8ecda5f708	Increase timeout length after fatal interrupts for test cloud runs (#33956)	3 years ago
Liam Cervante	fba5dad097	Test files should be marked as skipped if all their run blocks were skipped (#33950)	3 years ago
James Bardin	2c4608fe9e	update import validate test ... The diagnostics have been made more accurate, pointing to the problematic line rather than just the import block name.	3 years ago
James Bardin	e1a8270bde	expose ImportTarget.IDString for legacy import ... Let the legacy import path set IDString directly, simplifying the handling slightly. This also uncovered a long broken test which used an invalid import target.	3 years ago
James Bardin	5f13eecc38	remove ImportTarget.ID field	3 years ago
James Bardin	df23c703ce	import block decode ... Update the import configuration block to decode for_each and to into raw expressions, so that we can later evaluate those during expansion.	3 years ago
Liam Cervante	f8d4664bcd	Add additional validation around unknown and null values in test variables (#33861) ... * Add additional validation around unknown values in test variables * address comments	3 years ago
Liam Cervante	ffbcaf8bef	Implement TFC integration for private module registry test runs (#33710) ... * implement module testing via TFC * ready for review * fix static checks * licence headers	3 years ago
Liam Cervante	1c7dfa22b7	Add warning when testing and combining expect_failures with apply operations	3 years ago
Liam Cervante	84e2ebc225	apply defaults when processing variables for assertions	3 years ago
Liam Cervante	041b54fb4b	explicitely disallow duplicate run block names in test files (#33836)	3 years ago
Liam Cervante	a560730376	Make the test command fail if resources could not be cleaned up (#33809) ... * Make the test command fail if resources could not be cleaned up * remove redundant return statement	3 years ago
Liam Cervante	91d26b6ea6	Refactor file and run block feedback frequency (#33840) ... * Refactor file and run block feedback frequency * fix consistency checks * make generate	3 years ago
Liam Cervante	802d49a9ca	Handle null outputs in Terraform test files (#33781)	3 years ago
Brandon Croft	5867c4124e	Ignore remote version conflict when running force-unlock	3 years ago
Liam Cervante	487eeda94e	[testing framework] Add documentation (#33454) ... * [terraform test] add docs * Apply suggestions from code review Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * polish remaining comments * Apply suggestions from code review Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * address remaining comments * typo * update verbose machine readable docs * standardise new JSON field names --------- Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com>	3 years ago
CJ Horton	1706d643d6	more missing headers	3 years ago
Liam Cervante	4c83e2d524	Terraform test directory must be local to the config directory (#33760)	3 years ago
Liam Cervante	edcc35c96c	testing framework: move local implementation into local directory (#33734)	3 years ago
Liam Cervante	2ea141b3f4	Embed the schemas directly in the testing framework JSON verbose outputs (#33755)	3 years ago
Jared Baker	c566bcd6f7	Merge pull request #33730 from hashicorp/s3/modernization ... backend/s3: Update S3 client to AWS SDK Go V2	3 years ago
Liam Cervante	5e63aa01c7	Allow referencing higher level variables from run blocks (#33722)	3 years ago
Liam Cervante	9bc5c7afbb	Include run block for JSON fatal interrupt test summaries (#33720)	3 years ago
Jared Baker	de02f3461b	internal/command: fix slices.SortFunc signature	3 years ago
Brandon Croft	114f876f81	Merge pull request #33602 from hashicorp/TF-8071-download-and-verify-the-plugin-in-terraform ... Download and authenticate the cloudplugin	3 years ago
Brandon Croft	3d1e07dcf3	Write command output to Meta.Streams, more plugin err handling	3 years ago
Brandon Croft	8f4a430e41	refactor: cloudplugin VersionManager -> BinaryManager	3 years ago
CJ Horton	98b81d3c50	add missing copyright headers	3 years ago
Liam Cervante	9742f22c4e	Introduce 'run' keyword for referencing outputs from earlier run blocks (#33683) ... * introduce 'run' keyword for referencing outputs from earlier run blocks * fix code consistency	3 years ago
Liam Cervante	836c64f172	simplify test_context evaluation (#33677)	3 years ago
Brandon Croft	63e017b81b	cloudplugin: download and verify plugin ... Adds a client that encapsulates the process of downloading a cloudplugin manifest from a Terraform Cloud, downloads the appropriate binary to the specified location, and validates that it was distributed by HashiCorp	3 years ago
hashicorp-copywrite[bot]	53c34ff49c	Update copyright file headers to BUSL-1.1	3 years ago
Liam Cervante	126f34e4e8	Implement updates to testing framework based on recent feedback	3 years ago
Liam Cervante	3cce200d0e	Fix root cause of race condition in testing framework tests	3 years ago
Liam Cervante	f1ca74f09f	Update JSON_UI_VERSION after test framework changes	3 years ago
Liam Cervante	f8b1fe47dd	Make config errors more important during init operations (#33628) ... * make config errors more important during init operations * address comments	3 years ago
James Bardin	e26d07dda4	Merge pull request #33634 from hashicorp/jbardin/init-from-module-warnings ... Allow `get` and `init -from-module` to complete when there are configuration validation errors	3 years ago
James Bardin	ea1144995f	update callers of InstallModules ... Update callers of InstallModules and have `get` return only install errors.	3 years ago
kmoe	765c25d2ed	allow interpolation in import block id (#33618) ... The import block id field can now reference variables, attributes, and module outputs, as long as the result is a known non-empty string at plan time. A null or unknown value will result in an error. This commit slightly modifies the legacy CLI terraform import code path to construct a synthetic hcl.Expression from the import id passed in from the command line, with no intended change of functionality.	3 years ago
Liam Cervante	8b764f2e1b	fix race condition in no_provides_in_main test (#33616)	3 years ago
Liam Cervante	3bea1171af	test framework: expand variables available to test assertions (#33611)	3 years ago
Liam Cervante	4560a83721	test framework: include transformed config before validating config (#33608)	3 years ago
Liam Cervante	f397954c52	testing framework: allow users to specify deeply nested testing directories (#33584)	3 years ago
Liam Cervante	4122ba86fc	terraform test: fix crash when using nested modules from test run blocks (#33589)	3 years ago
Liam Cervante	e1019b3641	testing framework: validate the configuration before terraform test (#33559) ... * testing framework: call validate on the configuration before running terraform test * address comments * make tests pass after merge * fix tests	3 years ago
Liam Cervante	55792309eb	test framework: add support for testing files to fmt command (#33576)	3 years ago
Liam Cervante	080ddead6e	testing framework: perform a plan before starting any tests (#33561)	3 years ago
Liam Cervante	083c9afd5b	testing framework: add trace and debug statements during test executions (#33554)	3 years ago
Brandon Croft	e5ce25099c	Apply suggestions from code review ... Co-authored-by: Sebastian Rivera <sebastian.rivera@hashicorp.com>	3 years ago
Brandon Croft	9bb566dcdb	Update cloudplugin type casting to simplify adding future versions	3 years ago
Brandon Croft	2c3d134705	Adds `cloud` subcommand with some toy options	3 years ago
Brandon Croft	fec1ca69ac	Fix console godoc	3 years ago
Sebastian Rivera	08e58fd484	Fix saved plan test regressions, fixtures	3 years ago
Nick Fagerlund	1cbc95ce56	Use wrapped types to clean up error reporting in show command ... Since terraform show can accept three different kinds of file to act on, its error messages were starting to become untidy and unhelpful. The main issue was that if we successfully identified the file type but then ran into some problem while reading or processing it, the "real" error would be obscured by some other useless errors (since a file of one type is necessarily invalid as the other types). This commit tries to winnow it down to just one best error message, in the "happy path" case where we know what we're dealing with but hit a snag. (If we still have no idea, then we fall back to dumping everything.)	3 years ago
Nick Fagerlund	ed27fa096e	command/views/show_test: Update method arguments, add test cases	3 years ago
Nick Fagerlund	12af8518ff	command/show_test: Update expected error text	3 years ago
Nick Fagerlund	3a9ce2afb1	Update show command and view to support inspecting cloud plans ... One funny bit: We need to know the ViewType at the point where we ask the Cloud backend for the plan JSON, because we need to switch between two distinctly different formats for human show vs. `show -json`. I chose to pass that by stashing it on the command struct; passing it as an argument would also work, but one, the argument lists in these nested method calls were getting a little unwieldy, and two, many of these functions had to be receiver methods anyway in order to call methods on Meta.	3 years ago
Nick Fagerlund	0df3c143bb	New plans.Quality type for display-relevant facts about a plan ... This commit replaces the existing jsonformat.PlanRendererOpt type with a new type with identical semantics, located in the plans package. We needed to be able to exchange the facts represented by `jsonformat.PlanRendererOpt` across some package boundaries, but the jsonformat package is implicated in too many dependency chains to be safe for that purpose! So, we had to make a new one. The plans package seems safe to import from all the places that must emit or accept this info, and already contains plans.Mode, which is effectively a sibling of this type.	3 years ago
Nick Fagerlund	f9d937a4dd	Apply a confirmable run when given a saved cloud plan (#33270) ... It displays a run header with link to web UI, like starting a new plan does, then confirms the run and streams the apply logs. If you can't apply the run (it's from a different workspace, is in an unconfirmable state, etc. etc.), it displays an error instead. Notable points along the way: * Implement `WrappedPlanFile` sum type, and update planfile consumers to use it instead of a plain `planfile.Reader`. * Enable applying a saved cloud plan * Update TFC mocks — add org name to workspace, and minimal support for includes on MockRuns.ReadWithOptions.	3 years ago
Brandon Croft	c1a730314d	Relocate localterraform.com aliasing to backend configurators ... Previously, remote and cloud backends would automatically alias localterraform.com as the configured hostname during configuration. This turned out to be an issue with how backends could potentially be used within the builtin terraform_remote_state data source. Those data sources each configure the same service discovery with different targets for localterraform.com, and do so simultaneously, creating an occasional concurrent map read & write panic when multiple data sources are defined. localterraform.com is obviously not useful for every backend configuration. Therefore, I relocated the alias configuration to the callers, so they may specify when to use it. The modified design adds a new method to backend.Enhanced to allow configurators to ask which aliases should be defined.	3 years ago
Liam Cervante	ad26644578	Fix flaky test in views package (#33560)	3 years ago
Liam Cervante	c91f91cc9e	testing framework: change test file extension to .tftest.hcl (#33553)	3 years ago
Liam Cervante	ca85d3bf85	Implement word wrapping in the terraform test view functions (#33547) ... * Implement word wrapping in the terraform test view functions * Update internal/command/views/test.go Co-authored-by: CJ Horton <17039873+radditude@users.noreply.github.com> --------- Co-authored-by: CJ Horton <17039873+radditude@users.noreply.github.com>	3 years ago
Liam Cervante	6c7db16566	testing framework: refactor interrupt logic for immediate exits (#33532) ... * testing framework: refactor interrupt logic * fix formatting	3 years ago
Liam Cervante	6882dd9530	testing framework: introduce test command optional flags (#33504) ... * testing framework: introduce test command optional flags * address consistency checks	3 years ago
Liam Cervante	2cc81cfec6	testing framework: implement panic handling (#33525)	3 years ago
Liam Cervante	837716a703	testing framework: finalise expect_failures functionality (#33506)	3 years ago
Martin Atkins	7bee77bdd3	command: Start of propagating OpenTelemetry context ... Several times over the years we've considered adding tracing instrumentation to Terraform, since even when running in isolation as a CLI program it has a "distributed system-like" structure, with lots of concurrent internal work and also some work delegated to provider plugins that are essentially temporarily-running microservices. However, it's always felt a bit overwhelming to do it because much of Terraform predates the Go context.Context idiom and so it's tough to get a clean chain of context.Context values all the way down the stack without disturbing a lot of existing APIs. This commit aims to just get that process started by establishing how a context can propagate from "package main" into the command package, focusing initially on "terraform init" and some other commands that share some underlying functions with that command. OpenTelemetry has emerged as a de-facto industry standard and so this uses its API directly, without any attempt to hide it behind an abstraction. The OpenTelemetry API is itself already an adapter layer, so we should be able to swap in any backend that uses comparable concepts. For now we just discard the tracing reports by default, and allow users to opt in to delivering traces over OTLP by setting an environment variable when running Terraform (the environment variable was established in an earlier commit, so this commit builds on that.) When tracing collection is enabled, every Terraform CLI run will generate at least one overall span representing the command that was run. Some commands might also create child spans, but most currently do not.	3 years ago
Craig Wright	8f5064e6b4	Merge pull request #33433 from chaosaffe/fix-getcommand-helptext	3 years ago
Liam Cervante	87ed762619	Make flaky 'TestTest_DoubleInterrupt' test more robust (#33503)	3 years ago
Liam Cervante	4862812c94	testing framework: introduce interrupts for stopping tests (#33477) ... * [testing framework] prepare for beta phase of development * [Testing Framework] Add module block to test run blocks * [testing framework] allow tests to define and override providers * testing framework: introduce interrupts for stopping tests * remove panic handling, will do it properly later	3 years ago
Liam Cervante	4b34902fab	[testing framework] allow tests to define and override providers (#33466) ... * [testing framework] prepare for beta phase of development * [Testing Framework] Add module block to test run blocks * [testing framework] allow tests to define and override providers	3 years ago
Liam Cervante	5acc95dda7	[Testing Framework] Add module block to test run blocks (#33456) ... * [testing framework] prepare for beta phase of development * [Testing Framework] Add module block to test run blocks	3 years ago
Liam Cervante	c9bc7e8479	Add input validation into the 'checks' outputs and tracking (#33481)	3 years ago
CJ Horton	2622e89cfb	Merge pull request #33448 from agustinguayama/fix/small_typo ... fix typo in terraform/internal/command /init.go	3 years ago
James Bardin	6be6f69d61	Merge pull request #33482 from hashicorp/jbardin/schema-cache ... Refactor providers.Schemas and add a global schema cache	3 years ago
kmoe	d1a5dfa1ad	command: test plan -refresh= arg ordering (#33483) ... * main: disambiguate arg ordering test Make it extra clear what order of args we are asserting. * command: fix plan -refresh=false test The test for plan -refresh=false was not functioning, since ReadResource will not be called if the resource is not in prior state. Add a new fixture directory with state, and also test the converse, to prevent regression. * command: add test for refresh flag precedence A consumer relies on the fact that running terraform plan -refresh=false -refresh true gives the same result as terraform plan -refresh=true.	3 years ago
James Bardin	cf5ebaf685	s/Schemas/ProviderSchema/	3 years ago
James Bardin	36d34135ad	replace remaining types in tests	3 years ago
James Bardin	d487ce20e1	update jsonprovider to use new schema type	3 years ago
James Bardin	53901a7e62	Add basic global schema cache ... Add a single global schema cache for providers. This allows multiple provider instances to share a single copy of the schema, and prevents loading the schema multiple times for a given provider type during a single command. This does not currently work with some provider releases, which are using GetProviderSchema to trigger certain initializations. A new server capability will be introduced to trigger reloading their schemas, but not store duplicate results.	3 years ago
Liam Cervante	ea162f6ab5	[testing framework] prepare for beta phase of development (#33445)	3 years ago
Liam Cervante	3613e972c5	Plan renderer: Support users indexing integer paths with stringified numbers (#33475)	3 years ago
Agustin Guayama	db5b81d2c1	fix typo in terraform/internal/command /init.go	3 years ago
Liam Cervante	2eb99a0e44	Fix the Terraform build after recent merges (#33436)	3 years ago
Liam Cervante	212ae6c4ba	Introduce separate testing scope for reference validation (#33339)	3 years ago
Liam Cervante	dfc26c2ac4	[Testing Framework] Add test command to Terraform CLI (#33327) ... * Add test structure to views package for rendering test output * Add test file HCL configuration and parser functionality * Adds a TestContext structure for evaluating assertions against the state and plan * Add test command to Terraform CLI	3 years ago
Liam Cervante	ed822559e5	[Testing framework] Implement JSON view functionality for test command (#33400)	3 years ago
kmoe	fbff64ad45	configs: remove import block duplicate id check (#33434)	3 years ago
Jason Murray	79669df479	Remove PATH from GetCommand helpText	3 years ago
Andrew Hickman	49f99db1c2	`terraform show -json`: Add Errored field to output for plan (#33372) ... * Add Errored field to JSON output * Fix test error message	3 years ago
Liam Cervante	ce8fd2943d	[Testing Framework] Add test structure to views package for rendering test output (#33324) ... * Add test structure to views package for rendering test output * address comments	3 years ago
Liam Cervante	48c818927c	Remove old implementation of terraform test command	3 years ago
Katy Moe	7ce5503c7a	views: fix wordwrap	3 years ago
kmoe	5900d1177c	cloud: assert import block compatibility (#33282) ... * cloud: assert import block compatibility * check for import <> TFC compatibility during init * imports are not in alphabetical order 🙃 --------- Co-authored-by: CJ Horton <cjhorton@hashicorp.com>	3 years ago
kmoe	4386a15684	command: help text for generate-config-out (#33279)	3 years ago
Martin Atkins	696cd68913	command/views: Describe unknown collection bounds in diagnostics	3 years ago
kmoe	be2ad69eda	plannable import: safer config generation and schema filters (#33232) ... * genconfig: fix nil nested block panic * genconfig: null NestingSingle blocks should be absent A NestingSingle block that is null in state should be completely absent from config. * configschema: make FilterOr variadic * configschema: apply filters to nested types * configschema: filter helper/schema id attribute The legacy SDK adds an Optional+Computed "id" attribute to the resource schema even if not defined in provider code. During validation, however, the presence of an extraneous "id" attribute in config will cause an error. Remove this attribute so we do not generate an "id" attribute where there is a risk that it is not in the real resource schema. * configschema: filter test * terraform: do not pre-validate generated config Config generated from a resource's import state may fail validation in the case of schema behaviours such as ExactlyOneOf and ConflictsWith. We don't want to fail the plan now, because that would give the user no way to proceed and fix the config to make it valid. We allow the plan to complete and output the generated config. * generate config alongside import process Rather than waiting until we call `plan()`, generate the configuration at the point of the import call, so we have the necessary data to return in case planning fails later. The `plan` and `state` predeclared variables in the plan() method were obfuscating the actual return of nil throughout, so those identifiers were removed for clarity. * move generateHCLStringAttributes closer to caller * store generated config in plan on error * test for config gen with error * add simple warning when generating config --------- Co-authored-by: James Bardin <j.bardin@gmail.com>	3 years ago
kmoe	b4d1146f58	plannable import: improve gen config human plan output (#33194) ... * renderer: remove hard-coded config gen path * mention config gen file in plan next steps	3 years ago
CJ Horton	bd6ba6cf99	check for duplicate import blocks (#33190) ... Importing to the same target address twice or importing the same ID to multiple different resources of the same type is not allowed.	3 years ago
Liam Cervante	d5fed58fc5	plannable import: write generated config to out flag (#33186) ... * plannable import: write generated config to out flag * Add example command to diagnostic	3 years ago
CJ Horton	5d7864316e	Merge pull request #33160 from hashicorp/radditude/apply-counts ... Populate import counts during applies and clean up output	3 years ago
Liam Cervante	192cb255a6	checks: no longer experimental (#33184)	3 years ago
Liam Cervante	4d837df546	Plannable import: Add generated config to JSON and human-readable plan output (#33154) ... * command: keep our promises * remove some nil config checks Remove some of the safety checks that ensure plan nodes have config attached at the appropriate time. * add GeneratedConfig to plan changes objects Add a new GeneratedConfig field alongside Importing in plan changes. * add config generation package The genconfig package implements HCL config generation from provider state values. Thanks to @mildwonkey whose implementation of terraform add is the basis for this package. * generate config during plan If a resource is being imported and does not already have config, attempt to generate that config during planning. The config is generated from the state as an HCL string, and then parsed back into an hcl.Body to attach to the plan graph node. The generated config string is attached to the change emitted by the plan. * complete config generation prototype, and add tests * Plannable import: Add generated config to json and human-readable plan output --------- Co-authored-by: Katy Moe <katy@katy.moe>	3 years ago
Liam Cervante	79f7f59155	Plannable import: Generate config for imported resources during the plan. (#33153) ... * command: keep our promises * remove some nil config checks Remove some of the safety checks that ensure plan nodes have config attached at the appropriate time. * add GeneratedConfig to plan changes objects Add a new GeneratedConfig field alongside Importing in plan changes. * add config generation package The genconfig package implements HCL config generation from provider state values. Thanks to @mildwonkey whose implementation of terraform add is the basis for this package. * generate config during plan If a resource is being imported and does not already have config, attempt to generate that config during planning. The config is generated from the state as an HCL string, and then parsed back into an hcl.Body to attach to the plan graph node. The generated config string is attached to the change emitted by the plan. * complete config generation prototype, and add tests --------- Co-authored-by: Katy Moe <katy@katy.moe>	3 years ago
CJ Horton	bc084858b1	add import hooks for plan and apply ... Separate hooks used for the legacy import command for those used by the new import mechanism; also add apply output for imports.	3 years ago
Liam Cervante	2793af042c	Revert "Plannable import: Make the streamed logs more consistent during a plan operation (#33155)" ... This reverts commit 3c20f7b340.	3 years ago
Liam Cervante	3c20f7b340	Plannable import: Make the streamed logs more consistent during a plan operation (#33155)	3 years ago
hashicorp-copywrite[bot]	bb36298b21	[COMPLIANCE] Add Copyright and License Headers	3 years ago
Liam Cervante	77f10c4f68	Imports should come before Adds in change summaries (#33147)	3 years ago
Liam Cervante	81eb73731d	[Plannable Import] Implement streamed logs for plan (#33106) ... * [plannable import] embed the resource id within the changes * [Plannable Import] Implement streamed logs for -json plan * use latest structs * remove implementation plans from TODO	3 years ago
Liam Cervante	54c1c1162f	[Plannable Import] Implement human-readable plan rendering (#33113) ... * [plannable import] embed the resource id within the changes * add the plannable imports to the json and human plans * latest importing struct	3 years ago
hashicorp-copywrite[bot]	325d18262e	[COMPLIANCE] Add Copyright and License Headers	3 years ago
Liam Cervante	b5576159da	Migrate 'state show' command to new renderer (#33116) ... * Migrate 'state show' command to new renderer * handle error	3 years ago
Lauren	50c3f53595	add resource_drift logtype	3 years ago
Liam Cervante	b54668f44c	make the unknown attribute renderer consider the force replacement metadata (#33065)	3 years ago
Liam Cervante	14123e277c	Include sensitive metadata from the schema when building the json state output (#33059) ... * include sensitive metadata from the schema when building the json state output * found another test case	3 years ago
Liam Cervante	519a18aedf	Propagate unknown and sensitive metadata to dynamic attributes (#33057) ... * propagate unknown and sensitive metadata to dynamic attributes * update goimports and add some comments	3 years ago
Liam Cervante	357012a2f3	Refactor of differ to make code reuse easier (#33054) ... * refactor of differ to make code reuse easier * fix imports	3 years ago
Liam Cervante	aae6990d38	Add native `plantimestamp` function to Terraform (#32980) ... * add plantimestamp function * documentation * add missing links * fix typo	3 years ago
Sebastian Rivera	e6c3aab6c5	Merge pull request #33018 from hashicorp/tf-5529-sro-tfe-version-check	3 years ago
Liam Cervante	2c624acea1	Fix rendering unknown values in map and null string primitives (#33029) ... * fix rendering unknown values in map and null string primitives * Update map.go * fix code consistency checks	3 years ago
Sebastian Rivera	300a60f393	Fix typo in format version check	3 years ago
Liam Cervante	978263efe9	Checks: Introduce check blocks into the terraform node and transform graph (#32735) ... * Add support for scoped resources * refactor existing checks addrs and add check block addr * Add configuration for check blocks * introduce check blocks into the terraform node and transform graph * address comments * address comments * don't execute checks during destroy operations * don't even include check nodes for destroy operations	3 years ago
James Bardin	86c0c3bf80	Merge pull request #32846 from hashicorp/fix-32793 ... emit a warning msg if invalid CLI configuration file location	3 years ago
Reda Khaled	bf723bd65a	fix(init_test.go): in TestInitProvidersLocalOnly tst, set TF_CLI_CONFIG_FILE env var to an empty val	3 years ago
Reda Khaled	fa9d044c58	bugfix(cliconfig.go): emit a warning msg if bad CLI config file path	3 years ago
James Bardin	06f1ceb026	add some output values to the show state test	3 years ago
James Bardin	5ed7f2a798	always use the RenderHuman constructor	3 years ago
Liam Cervante	15ecdb66c8	Fix no-op outputs causing the plan renderer to skip the 'no changes' message (#32820) ... * Fix no-op outputs causing the plan renderer to skip the 'no changes' message * fix imports	3 years ago
Alisdair McDiarmid	8df065a2fe	initwd: Switch from earlyconfig to configs ... This is a mostly mechanical refactor with a handful of changes which are necessary due to the semantic difference between earlyconfig and configs. When parsing root and descendant modules in the module installer, we now check the core version requirements inline. If the Terraform version is incompatible, we drop any other module loader diagnostics. This ensures that future language additions don't clutter the output and confuse the user. We also add two new checks during the module load process: * Don't try to load a module with a `nil` source address. This is a necessary change due to the move away from earlyconfig. * Don't try to load a module with a blank name (i.e. `module ""`). Because our module loading manifest uses the stringified module path as its map key, this causes a collision with the root module, and a later panic. This is the bug which triggered this refactor in the first place.	3 years ago
Reda Khaled	100c44b6c3	bugfix: issue-28274, terraform providers mirror command should honor terraform lock file	3 years ago
Martin Atkins	a86cef4d50	cliconfig: Allow breaking the dependency lock file using the environment ... Since it's already possible to activate the dependency lock file using an environment variable, we should allow opting in to it having broken behavior using the environment too. It's kinda odd in retrospect that TF_PLUGIN_CACHE_DIR is the only setting we allow to be configured both in the environment and the CLI configuration. That means that the infrastructure for dealing with that situation was relatively immature here and so I did some light refactoring to make it unit-testable without actually modifying the test program's environment.	3 years ago
CJ Horton	3c54e42080	Merge pull request #32695 from hashicorp/radditude/init-config-warning ... keep errors friendly when init encounters syntax problems	3 years ago
kmoe	b435b4ccde	cliconfig: more provider_installation err detail (#32722)	3 years ago
Sebastian Rivera	6d0a191ec4	Handle provisioner log types in renderer	3 years ago
CJ Horton	30f8b014f8	keep the friendly error message whenever possible	3 years ago
CJ Horton	727e22e762	add tests for init syntax error handling ... With the demise of the early config loader, we want to show core version errors first, followed by backend errors, and only then show other errors with the configuration.	3 years ago
Daniel Banck	4fa77727b5	Introduce `metadata functions` command (#32487) ... * Add metadata functions command skeleton * Export functions as JSON via cli command * Add metadata command * Add tests to jsonfunction package * WIP: Add metadata functions test * Change return_type & type in JSON to json.RawMessage This enables easier deserialisation of types when parsing the JSON. * Skip is_nullable when false * Update cli docs with metadata command * Use tfdiags to report function marshal errors * Ignore map, list and type functions * Test Marshal function with diags * Test metadata functions command output * Simplify type marshaling by using cty.Type * Add static function signatures for can and try * Update internal/command/jsonfunction/function_test.go Co-authored-by: kmoe <5575356+kmoe@users.noreply.github.com> --------- Co-authored-by: kmoe <5575356+kmoe@users.noreply.github.com>	3 years ago
Liam Cervante	d212a72d1d	structured run output: impose canonical ordering on jsonstate and jsonplan packages (#32649)	3 years ago
Sebastian Rivera	de574ae6d4	Initial implementation of structured logging in cloud backend (#32504) ... * Implementation of structured logging. These are the changes that enable the cloud backend to consume structured logs and make use of the new plan renderer. This will enable CLI-driven runs to view the structured output in the Terraform Cloud UI. * Cloud structured logging unit tests * Remove deferred logs logic, fix minor issues Color formatting fixes, log type stop lists, default behavior for logs that are unknown * Use service disco path in redacted plan url	3 years ago
Liam Cervante	4fa7cd0a68	structured renderer: fix closing json tags when rendering with no symbols (#32642)	3 years ago
Liam Cervante	d818d7850d	Structured Renderer: use the new renderer when rendering the state in addition to the plan (#32629) ... * Use the new renderer when rendering the state * remove confusing and unneeded comment	3 years ago
zetHannes	c70244426a	Fix for no json output of state locking actions for --json flag (#32451) ... * Add viewType to Meta object and use it at the call sites * Assign viewType passed from flags to state-locking cli commands * Remove temp files * Set correct mode for statelocker depending on json flag passed to commands * Add StateLocker interface conformation check for StateLockerJSON * Remove empty line at end of comment * Pass correct ViewType to StateLocker from Backend call chain * Pass viewType to backend migration and initialization functions * Remove json processing info in process comment * Restore documentation style of backendMigrateOpts	3 years ago
Brandon Croft	9fd76e56cd	Factor out terraform-config-inspect/tfconfig during init ... As explained by the deleted comments, this package was used to identify situations where the `terraform 0.12upgrade` command can help migrate 0.11 syntax. Current versions of terraform don't include this command, and it's not likely that users are attempting upgrades from 0.11 to 1.4+ The replacement init swaps the order of the module and backend initialization in order to prepare for the next commit. Config initialization now takes the following approach: 1. Load the root module, but withhold diagnostic errors until after version check 2. Initialize the backend, but withhold diagnostic errors until after version check 3. Get modules 4. Load all config (root and modules) 5. Check terraform version requirements (this can be defined by nested modules) and display any errors. It's important to show these first because prior errors could be the result of a newer terraform version syntax 6. Finally, show any errors related to backed init or config loading	3 years ago
Sheridan C Rawlins	75e5ae27a2	[fixes 31700] Add mTLS support for http backend by way of client cert & key, as well as enterprise cacert. (#31699) ... * Add mTLS support for http backend by way of client cert & key, as well as enterprise cacert. * Fix style. * Skip cert validation to be sure error is related to missing client cert; not untrusted server cert. * Remove misplaced err check. * Fix the size of test using http backend. * Just for correctness, include all certs in the pem encoded cert - sometimes certs come with a chain of their signers. * Adjusted names as recommended in PR comments. * Adjusted names to be full-length and more descriptive. * Added full-fledged testing with mTLS http server * Fix goimports. * Fix the names of the backend config. * Exclusive lock for write and delete. * Revert "Fix goimports." This reverts commit 7d40f6099fbbb675fb2e25e35ee40aeafe3d0a22. * goimports just for server test. * Added the go:generation for the mock. * Move the TLS configuration out to make it more readable - don't replace the HTTPClient as the retryablehttp already creates one - just configure its TLS. * Just switch the client/data params - felt more natural this way. * Update internal/backend/remote-state/http/backend.go Co-authored-by: kmoe <5575356+kmoe@users.noreply.github.com> * Update internal/backend/remote-state/http/testdata/gencerts.sh Co-authored-by: kmoe <5575356+kmoe@users.noreply.github.com> * Update internal/backend/remote-state/http/backend.go Co-authored-by: kmoe <5575356+kmoe@users.noreply.github.com> * Update internal/backend/remote-state/http/backend.go Co-authored-by: kmoe <5575356+kmoe@users.noreply.github.com> * Update internal/backend/remote-state/http/backend.go Co-authored-by: kmoe <5575356+kmoe@users.noreply.github.com> * Update internal/backend/remote-state/http/backend.go Co-authored-by: kmoe <5575356+kmoe@users.noreply.github.com> * the location of the file name is not sensitive. * Added error if only one of client_certificate_pem and client_private_key_pem are set. * Remove testify from test cases; use t.Error* for assert and t.Fatal* for require. * Fixed import consistency * Just use default openssl. * Since file(...) is so trivial to use, changed the client cert, key, and ca cert to be the data. See also https://github.com/hashicorp/terraform-provider-http/pull/211 Co-authored-by: Sheridan C Rawlins <scr@ouryahoo.com> Co-authored-by: kmoe <5575356+kmoe@users.noreply.github.com>	3 years ago
Martin Atkins	e2380b1038	cliconfig: Allow forcing use of the plugin cache despite the lock file ... Currently Terraform will use an entry from the global plugin cache only if it matches a checksum already recorded in the dependency lock file. This allows Terraform to produce a complete lock file entry on the first encounter with a new provider, whereas using the cache in that case would cause the lock file to only cover the single package in the cache and thereefore be unusable on any other operating system or CPU architecture. This temporary CLI config option is a pragmatic exception to support those who cannot currently correctly use the dependency lock file but who still want to benefit from the plugin cache. With this setting enabled, Terraform has permission to produce a dependency lock file that is only suitable for the current system if that would allow use of an existing entry in the plugin cache. We are introducing this option to resolve a conflict between the needs of folks who are using the dependency lock file as expected and the needs of folks who cannot use the dependency lock file for some reason. The hope then is to give respite to those who need this exception in the meantime while we understand better why they cannot use the dependency lock file and improve its design so that everyone will be able to use it successfully in a future version of Terraform. This option will become a silent no-op in a future version of Terraform, once the dependency lock file behavior is sufficient for all supported Terraform development workflows.	3 years ago
Liam Cervante	7d1ea52077	Structured Plan Renderer: another round of fixes after more equivalence testing (#32537) ... * Structured Plan Renderer: another round of fixes after more equivalence testing * fix sort function * use new constants	3 years ago
Liam Cervante	6dc49150b7	Structured Plan Renderer: Read the data source schemas from the right place (#32532) ... * read the data source schemas from the right place * address comments and add test	3 years ago
Liam Cervante	8d61c5bfc4	Use the new structured renderer in place of the old diffs package (#32520) ... * Use the new structured renderer in place of the old diffs package * remove old plan tests * refresh only plans should show moved resources in the refresh section	3 years ago
Liam Cervante	99823e4a15	Structured Plan Renderer: Fix minor bugs causing diffs in the equivalence tests. (#32519) ... * remove attributes that do not match the relevant attributes filter * fix formatting * fix renderer function, don't drop irrelevant attributes just mark them as no-ops * fix imports * fix bugs in the renderer exposed by the equivalence tests * imports * gofmt	3 years ago
Liam Cervante	e015b15f12	Structured Plan Renderer: Remove attributes that do not match the relevant attributes filter (#32509) ... * remove attributes that do not match the relevant attributes filter * fix formatting * fix renderer function, don't drop irrelevant attributes just mark them as no-ops * fix imports	3 years ago
Liam Cervante	95782f2491	Structured plan renderer: Implement the main functionality for the renderer (#32496) ... * raw unmodified broken tests * tests execute, no panics * fix whitespace differences * fix all the tests * fix tests * actually fix tests * add missing plan metadata into the renderer * address comments * complete merge * remove TODO raising questions about outputs, they are fixed * missing bold on plan	3 years ago
Liam Cervante	af0ff90d6e	Remove outputs from the jsonplan that are not from the root module (#32503)	3 years ago
Liam Cervante	c125397da1	push the colorize actions as locally as possible (#32502)	3 years ago
James Bardin	96b1318167	remove deprecated condition_results from plan	3 years ago
Liam Cervante	f6d625103c	Structured plan renderer: refactor replace paths logic (#32489) ... * change -> diff, value -> change * also update readme# * structured plan renderer: refactor replace paths logic * goimports * goimports * address comments * fix compile error	3 years ago
Liam Cervante	38afb41787	Structured plan renderer: Introduce support for multiline and JSON strings (#32488) ... * pause implementation * change -> diff, value -> change * add support for json and multiline strings to the primitive renderer * goimports * remove unused function * go fmt * address comments	3 years ago
Liam Cervante	8330b7295b	Structured plan renderer: Add support for map blocks and sensitive blocks. (#32491) ... * change -> diff, value -> change * also update readme# * pause * Update internal/command/jsonformat/computed/diff.go Co-authored-by: Alisdair McDiarmid <alisdair@users.noreply.github.com> * add interface assertions for diff renderers * Add support for different kinds of blocks, and for sensitive blocks Co-authored-by: Alisdair McDiarmid <alisdair@users.noreply.github.com>	3 years ago
Liam Cervante	21bb677db7	Structured Plan Renderer: Naming and package structure refactor (#32486) ... * change -> diff, value -> change * also update readme# * Update internal/command/jsonformat/computed/diff.go Co-authored-by: Alisdair McDiarmid <alisdair@users.noreply.github.com> * add interface assertions for diff renderers Co-authored-by: Alisdair McDiarmid <alisdair@users.noreply.github.com>	3 years ago
Liam Cervante	a086453783	Structured Plan Renderer: Refactor Primitive and Sensitive value processing (#32476) ... * refactor sensitive and primitive values to match patterns used elsewhere * goimports * address comments * fix tests * also use %q for map keys	3 years ago
Liam Cervante	46ab53d651	Structured Plan Renderer: Escape object and block keys that don't match HCL syntax (#32483) ... * Escape object and block keys that don't match HCL syntax * address comments	3 years ago
Liam Cervante	7a3fc48b70	Structured Plan Renderer: Add tests validating behaviour of dynamic types (#32482) ... * add support for dynamic types into attribute processing * fix names * add tests	3 years ago
Liam Cervante	d31631675b	Add support for Tuples into the structured plan renderer (#32479) ... * add support for tuples to the structured plan renderer * update after latest main changes	3 years ago
Liam Cervante	2d66eee872	Structured Plan Renderer: Address comments raised in previous PRs (#32478) ... * Address comments raised in previous PRs * add doc comments for public types	3 years ago
Liam Cervante	1332d315b6	Structured Plan Renderer: Remove generic `interface{}` entry point (#32477) ... * Remove the single generic point of entry into the differ package * goimports * add comment explaining generic function	3 years ago
Liam Cervante	9bc5ded27a	Add support for outputs in the structured renderer (#32426) ... * prep for processing the structured run output * undo unwanted change to a json key * Add skeleton functions and API for refactored renderer * goimports * Fix documentation of the RenderOpts struct * Add rendering functionality for primitives to the structured renderer * add test case for override * Add support for parsing and rendering sensitive values in the renderer * Add support for unknown/computed values in the structured renderer * delete missing unit tests * Add support for object attributes in the structured renderer * goimports * Add support for the replace paths data in the structured renderer * Add support for maps in the structured renderer * Add support for lists in the structured renderer * goimports * Add support for sets in the structured renderer * goimports * Add support for blocks in the structured renderer * goimports * Add support for outputs in the structured renderer * fix ordering of blocks * remove unused test stub * fix typo	3 years ago
Liam Cervante	05f1764a0d	Add support for blocks in the structured renderer (#32422) ... * prep for processing the structured run output * undo unwanted change to a json key * Add skeleton functions and API for refactored renderer * goimports * Fix documentation of the RenderOpts struct * Add rendering functionality for primitives to the structured renderer * add test case for override * Add support for parsing and rendering sensitive values in the renderer * Add support for unknown/computed values in the structured renderer * delete missing unit tests * Add support for object attributes in the structured renderer * goimports * Add support for the replace paths data in the structured renderer * Add support for maps in the structured renderer * Add support for lists in the structured renderer * goimports * Add support for sets in the structured renderer * goimports * Add support for blocks in the structured renderer * goimports * fix ordering of blocks * remove unused test stub	3 years ago
Liam Cervante	69cce3597f	Add support for sets in the structured renderer (#32409) ... * prep for processing the structured run output * undo unwanted change to a json key * Add skeleton functions and API for refactored renderer * goimports * Fix documentation of the RenderOpts struct * Add rendering functionality for primitives to the structured renderer * add test case for override * Add support for parsing and rendering sensitive values in the renderer * Add support for unknown/computed values in the structured renderer * delete missing unit tests * Add support for object attributes in the structured renderer * goimports * Add support for the replace paths data in the structured renderer * Add support for maps in the structured renderer * Add support for lists in the structured renderer * goimports * Add support for sets in the structured renderer * goimports	3 years ago
Liam Cervante	aff94591c1	Add support for lists in the structured renderer (#32401) ... * prep for processing the structured run output * undo unwanted change to a json key * Add skeleton functions and API for refactored renderer * goimports * Fix documentation of the RenderOpts struct * Add rendering functionality for primitives to the structured renderer * add test case for override * Add support for parsing and rendering sensitive values in the renderer * Add support for unknown/computed values in the structured renderer * delete missing unit tests * Add support for object attributes in the structured renderer * goimports * Add support for the replace paths data in the structured renderer * Add support for maps in the structured renderer * Add support for lists in the structured renderer * goimports * add additional comments explaining	3 years ago
Liam Cervante	8975eebf84	Add support for maps in the structured renderer (#32397) ... * prep for processing the structured run output * undo unwanted change to a json key * Add skeleton functions and API for refactored renderer * goimports * Fix documentation of the RenderOpts struct * Add rendering functionality for primitives to the structured renderer * add test case for override * Add support for parsing and rendering sensitive values in the renderer * Add support for unknown/computed values in the structured renderer * delete missing unit tests * Add support for object attributes in the structured renderer * goimports * Add support for the replace paths data in the structured renderer * Add support for maps in the structured renderer	3 years ago
Liam Cervante	b097d8873d	Add support for the replace paths data in the structured renderer (#32392) ... * prep for processing the structured run output * undo unwanted change to a json key * Add skeleton functions and API for refactored renderer * goimports * Fix documentation of the RenderOpts struct * Add rendering functionality for primitives to the structured renderer * add test case for override * Add support for parsing and rendering sensitive values in the renderer * Add support for unknown/computed values in the structured renderer * delete missing unit tests * Add support for object attributes in the structured renderer * goimports * Add support for the replace paths data in the structured renderer	3 years ago
Liam Cervante	1eebcf875f	Add support for object attributes in the structured renderer (#32391) ... * prep for processing the structured run output * undo unwanted change to a json key * Add skeleton functions and API for refactored renderer * goimports * Fix documentation of the RenderOpts struct * Add rendering functionality for primitives to the structured renderer * add test case for override * Add support for parsing and rendering sensitive values in the renderer * Add support for unknown/computed values in the structured renderer * delete missing unit tests * Add support for object attributes in the structured renderer * goimports	3 years ago
Liam Cervante	b8b1a8d430	Add support for unknown/computed values in the structured renderer (#32378) ... * prep for processing the structured run output * undo unwanted change to a json key * Add skeleton functions and API for refactored renderer * goimports * Fix documentation of the RenderOpts struct * Add rendering functionality for primitives to the structured renderer * add test case for override * Add support for parsing and rendering sensitive values in the renderer * Add support for unknown/computed values in the structured renderer * delete missing unit tests	3 years ago
Liam Cervante	6ab277f6ba	Add support for sensitive values in the structured renderer (#32375) ... * prep for processing the structured run output * undo unwanted change to a json key * Add skeleton functions and API for refactored renderer * goimports * Fix documentation of the RenderOpts struct * Add rendering functionality for primitives to the structured renderer * add test case for override * Add support for parsing and rendering sensitive values in the renderer	3 years ago
Liam Cervante	71daef058f	Add rendering functionality for primitives to the structured renderer (#32373) ... * prep for processing the structured run output * undo unwanted change to a json key * Add skeleton functions and API for refactored renderer * goimports * Fix documentation of the RenderOpts struct * Add rendering functionality for primitives to the structured renderer * add test case for override * goimports	3 years ago
Liam Cervante	aff7d360e1	Add skeleton functions and API for refactored renderer (#32368) ... * prep for processing the structured run output * undo unwanted change to a json key * Add skeleton functions and API for refactored renderer * goimports * Fix documentation of the RenderOpts struct * Add README explaining implementation details for renderer and plans for future expansion * Update internal/command/jsonformat/README.md Co-authored-by: Alisdair McDiarmid <alisdair@users.noreply.github.com> * address comments Co-authored-by: Alisdair McDiarmid <alisdair@users.noreply.github.com>	3 years ago
Liam Cervante	b917154a97	Make required JSON structured output structures public for processing (#32367) ... * prep for processing the structured run output * undo unwanted change to a json key	3 years ago
James Bardin	721df0e68d	Merge pull request #32395 from hashicorp/jbardin/plan-output-on-error ... Always show and store planned actions and checks even when planning fails	3 years ago
James Bardin	a6098b67fa	fix test state	3 years ago
James Bardin	25ac4d33e4	Merge pull request #31633 from brittandeyoung/f-workspace-selectornew ... New Terraform Workspace select flag: `-or-create`	3 years ago
Brittan DeYoung	8881418c99	Update internal/command/workspace_select.go ... Co-authored-by: James Bardin <j.bardin@gmail.com>	3 years ago
James Bardin	d60d247e40	Merge pull request #31318 from twittyc/twittyc/terraformWorkspaceInvalidArgsReturnsNon0 ... Bug fix: Terraform workspace command returns zero exit code when given an invalid argument.	3 years ago
James Bardin	76d5e4a9cb	add command test for errored plan	3 years ago
James Bardin	5aa088e385	remove -always-out ... Make writing a plan file the default. We already create plans which have no changes so the plan result would need to be checked in automation, so having plans with errors should not pose a problem. If we find workflows which cannot handle a plan that can't be applied, we can reevaluate the need for a specialized flag. In the meantime, it feels more logical that the plan output would always describe the result of the plan, even if that included errors.	3 years ago
Martin Atkins	4660dacd59	command: Prototype of handling errored plans ... This is a prototype of how the CLI layer might make use of Terraform Core's ability to produce a partial plan if it encounters an error during planning, with two new situations: - When using local CLI workflow, Terraform will show the partial plan before showing any errors. - "terraform plan" has a new option -always-out=..., which is similar to the existing -out=... but additionally instructs Terraform to produce a plan file even if the plan is incomplete due to errors. This means that the plan can still be inspected by external UI implementations. This is just a prototype to explore how these parts might fit together. It's not a complete implementation and so should not be shipped. In particular, it doesn't include any mention of a plan being incomplete in the "terraform show -json" output or in the "terraform plan -json" output, both of which would be required for a complete solution.	3 years ago
James Bardin	404b284911	Merge pull request #31757 from hashicorp/jbardin/terraform-data ... New `terraform_data` managed resource to replace `null_resource`	3 years ago
Conor Evans	e206d4e83e	fix(unlock): amend force-unlock description (#32363) ... Signed-off-by: Conor Evans <coevans@tcd.ie> Signed-off-by: Conor Evans <coevans@tcd.ie>	3 years ago
James Bardin	d0d6501c1f	s/trigger/triggers_replace/ ... Rename `triggers` to be more descriptive, making it similar to `replace_triggered_by`.	3 years ago
James Bardin	58e15c7f0e	add terraform_data e2e test	3 years ago
alisdair	ec6451a82a	Merge pull request #31999 from JarrettSpiker/jspiker/workspace-delete-rum-docs ... Update workspace delete command docs to reference RUM vs empty state	3 years ago
Jarrett Spiker	21d98697cb	Add manual line breaks to workspace delete command help text	3 years ago
Jarrett Spiker	060255a9d5	Use safe or force workspace delete for cloud backend	3 years ago
Martin Atkins	d0a35c60a7	providercache: Ignore lock-mismatching global cache entries ... When we originally introduced the trust-on-first-use checksum locking mechanism in v0.14, we had to make some tricky decisions about how it should interact with the pre-existing optional read-through global cache of provider packages: The global cache essentially conflicts with the checksum locking because if the needed provider is already in the cache then Terraform skips installing the provider from upstream and therefore misses the opportunity to capture the signed checksums published by the provider developer. We can't use the signed checksums to verify a cache entry because the origin registry protocol is still using the legacy ziphash scheme and that is only usable for the original zipped provider packages and not for the unpacked-layout cache directory. Therefore we decided to prioritize the existing cache directory behavior at the expense of the lock file behavior, making Terraform produce an incomplete lock file in that case. Now that we've had some real-world experience with the lock file mechanism, we can see that the chosen compromise was not ideal because it causes "terraform init" to behave significantly differently in its lock file update behavior depending on whether or not a particular provider is already cached. By robbing Terraform of its opportunity to fetch the official checksums, Terraform must generate a lock file that is inherently non-portable, which is problematic for any team which works with the same Terraform configuration on multiple different platforms. This change addresses that problem by essentially flipping the decision so that we'll prioritize the lock file behavior over the provider cache behavior. Now a global cache entry is eligible for use if and only if the lock file already contains a checksum that matches the cache entry. This means that the first time a particular configuration sees a new provider it will always be fetched from the configured installation source (typically the origin registry) and record the checksums from that source. On subsequent installs of the same provider version already locked, Terraform will then consider the cache entry to be eligible and skip re-downloading the same package. This intentionally makes the global cache mechanism subordinate to the lock file mechanism: the lock file must be populated in order for the global cache to be effective. For those who have many separate configurations which all refer to the same provider version, they will need to re-download the provider once for each configuration in order to gather the information needed to populate the lock file, whereas before they would have only downloaded it for the _first_ configuration using that provider. This should therefore remove the most significant cause of folks ending up with incomplete lock files that don't work for colleagues using other platforms, and the expense of bypassing the cache for the first use of each new package with each new configuration. This tradeoff seems reasonable because otherwise such users would inevitably need to run "terraform providers lock" separately anyway, and that command _always_ bypasses the cache. Although this change does decrease the hit rate of the cache, if we subtract the never-cached downloads caused by "terraform providers lock" then this is a net benefit overall, and does the right thing by default without the need to run a separate command.	4 years ago
Brandon Croft	bd744ad4e9	Unify all sensitive value plan output as "(sensitive value)" ... Previously, there was mixed usage of "(sensitive)" and "(sensitive value)" and even though it was more common to see "(sensitive)", the thought is that it's a value we are hiding rather than describing something already shown.	4 years ago
Brandon Croft	076fccd8e7	fix: don't reveal nested attributes with sensitive schema	4 years ago