15 Commits (00a76d019a3e5b4d9d040a3e28c9e0b4e56ad951)

Author	SHA1	Message	Date
James Bardin	67395306e1	delete unknown values from apply config altogether ... removeConfigUnknowns need to remove the value completely from the config map. Removing this value allows GetOk and GetOkExists to indicate if the value was set in the config in the case of an Optional+Computed attribute.	7 years ago
Martin Atkins	861a2ebf26	helper/schema: Use a more targeted shim for nested set diff applying ... We previously attempted to make the special diff apply behavior for nested sets of objects work with attribute mode by totally discarding attribute mode for all shims. In practice, that is too broad a solution: there are lots of other shimming behaviors that we _don't_ want when attribute mode is enabled. In particular, we need to make sure that the difference between null and empty can be seen in configuration. As a compromise then, we will give all of the shims access to the real ConfigMode and then do a more specialized fixup within the diff-apply logic: we'll construct a synthetic nested block schema and then use that to run our existing logic to deal with nested sets of objects, while using the previous behavior in all other cases. In effect, this means that the special new behavior only applies when the provider uses the opt-in ConfigMode setting on a particular attribute, and thus this change has much less risk of causing broad, unintended regressions elsewhere.	7 years ago
James Bardin	5f52aba3ae	Remove unknown value strings from apply diffs ... The synthetic config value used to create the Apply diff should contain no unknown config values. Any remaining UnknownConfigValues were due to that being used as a placeholder for values yet to be computed, and these should be marked NewComputed in the diff.	7 years ago
James Bardin	3ec93710fc	PromoteSingle is used in 0.11 mode	7 years ago
James Bardin	8730d99309	LegacyResourceSchema to remove 0.12 features ... This allows us to call CoreConfigSchema and return something that looks like the original schema.	7 years ago
James Bardin	1a9c06d0f5	Revert "helper/schema: Implementation of the AsSingle mechanism" ... This reverts commit 1987a92386.	7 years ago
Martin Atkins	1987a92386	helper/schema: Implementation of the AsSingle mechanism ... The previous commit added a new flag to schema.Schema which is documented to make a list with MaxItems: 1 be presented to Terraform Core as a single value instead, giving a way to switch to non-list nested resources without it being a breaking change for Terraform v0.11 users as long as it's done prior to a provider's first v0.12-compatible release. This is the implementation of that mechanism. It's intentionally implemented as a suite of extra fixups rather than direct modifications to existing shim code because we want to ensure that this has no effect whatsoever on the result of a resource type that _isn't_ using AsSingle. Although there is some small unit test coverage of the fixup steps here, the primary testing for this is in the test provider since the integration of all of these fixup steps in the correct order is the more important result than any of the intermediate fixup steps.	7 years ago
James Bardin	21dfa56766	use ShimInstanceStateFromValue in DiffFromValues ... This makes sure the diff is generated with the matching set ids from helper/schema. Update the tests to add ID fields to the state, which will exists in practice, since any state traversing through the shims will have the ID inserted.	8 years ago
James Bardin	df04e2e7a6	move InstanceState shim into schema.Resource ... This was the resource can rebuild the flatmapped state using the schema and ResourceData, providing us the the correct set key values.	8 years ago
James Bardin	46b4c27dbe	create a SimpleDiff for the new provider shims ... Terraform now handles any actual "diffing" of resource, and the existing Diff functions are only used to shim the schema.Provider to the new methods. Since terraform is handling what used to be the Diff, the provider now should not modify the diff based on RequiresNew due to it interfering with the ignore_changes handling.	8 years ago
James Bardin	0d4d572c39	start work on helper/resource test fixtures ... The helper resource tests won't pass for now, as they use a terraform.MockProvider which can't be used in the schema.Provider shims.	8 years ago
Martin Atkins	33151f5011	core: Move StateValueFromInstanceState shim from helper/schema ... This one doesn't depend on any helper/schema specific bits and it'll also be useful for the shims in our mock provider in core.	8 years ago
Martin Atkins	76d11f44cc	core: Move some of the helper/schema shims so provider mock can use them ... The old names are now wrappers around these new functions.	8 years ago
James Bardin	a87470cc15	resource ids must always have a value ... The "id" field is assumed to always exist, and must have a valid value. Set "id" to unknown when planning new resource changes to indicate that it will be computed.	8 years ago
James Bardin	dcaf5aa262	add some of the shims used for the grpc provider ... This adds some of the required shim functions to the schema package. While this further bloats the already huge package, adding the helpers here was significantly less disruptive than refactoring types into separate packages to prevent import cycles. The majority of tests here are directly adapted from existing schema tests to provide as many known good values to the shims as possible.	8 years ago