121 Commits (pss/discovery-block-download-via-download-event-callbacks)

Author	SHA1	Message	Date
Daniel Schmidt	958a1ae1e7	variable and output deprecation ... Variables can be deprecated through the `deprecated` attribute. If set the variable will emit a diagnostic if a values is passed to it. This entails both root level and module variables. Outputs can be deprecated through the `deprecated` attribute as well. If set wherever the value is used a diagnostic will be emitted. Root level outputs can not be deprecated. The only acceptable usage of a deprecated output is another deprecated output (forwarding the deprecation to the module user). If modules not under your control have deprecation warnings you can add a `suppress_deprecations_warnigns` attribute to the module call in question to silence any deeply nested warnings.	2 weeks ago
Kristin Laemmert	7e37e518c4	actions test refactor	2 weeks ago
Sarah French	1dd8e60f15	chore: Bump golang.org/x/crypto dependency, ignore SA4003 linting errors globally (#37901) ... * chore: Upgrade golang.org/x/crypto - `go get golang.org/x/crypto@v0.44.0` * chore: Upgrade golang.org/x/crypto in submodules - `make syncdeps` * chore: Run `make generate` * chore: Ignore SA4003 linter error globally, as `golang.org/x/tools/cmd/stringer` generates code that breaks this rule when it's used with custom types that have unsigned integers or bytes as the underlying type.	3 months ago
Daniel Schmidt	ad4371342f	track partial expanded action invocations through deferred action invocation ... like we do it for resources just simpler because we don't have layered addrs maps	6 months ago
Daniel Schmidt	dffeeec81e	partially expand triggers as well	6 months ago
Daniel Schmidt	29b2ab15e2	support partial expansion in actions	6 months ago
Liam Cervante	4ed8668a8f	actions: make action address targetable (#37499) ... * actions: make action address targetable * add missing functions * copyright headers	6 months ago
Daniel Schmidt	be810aa80e	make AbsActionInstance not referencable	7 months ago
Daniel Schmidt	11f00e584b	fix action addrs test	7 months ago
Daniel Schmidt	834665e332	use better hook identity	7 months ago
Daniel Schmidt	812e5a9749	add helper to iterate over elements of an addrs map	7 months ago
Daniel Schmidt	114ce5a0e2	make abs action instances referencable	7 months ago
Kristin Laemmert	9256074c43	Actions in plan/changes (#37320) ... * Add actions to the plans and change * jsonplan - ignoring LinkedResources for now, those are not in the MVP * pausing here: we'll work on the plan rendering later	7 months ago
Daniel Schmidt	8649eae35d	rename ActionInvocation for clarity	8 months ago
Daniel Schmidt	016daf647e	add addrs for action invocation	8 months ago
Samsondeen	685ff9f192	Schema representation of list block config and results (#37209)	8 months ago
Samsondeen	a5434b421f	Build and Validate list resource nodes (#37011)	9 months ago
Samsondeen	44eb0c69ef	Recognize tf query files (#36929)	9 months ago
Kristin Laemmert	90357bccba	initial actions addrs (#37003) ... * initial actions addrs This adds the basic Action-related addresses and parsing Actions as references.	10 months ago
James Bardin	3b3e4bf003	update the rest of the go:generate calls	1 year ago
Daniel Schmidt	34bedeab0f	addrs: AbsModuleCallOutput to ConfigOutputValue translation ... The end-goal is to retrieve ConfigOutputValues from References. This ties in with the work on deprecated outputs.	1 year ago
Liam Cervante	eeacced8f0	Add go vet as a check to the Github commit actions (#31461) ... * Add go vet as a check to the Github commit actions * deliberately break to test * fix after successful test * Use directly * fix more errors	1 year ago
Liam Cervante	9be46420ce	moved: error if not targeting a resource address (#35850) ... * moved: error if not targeting a resource address * address comments	1 year ago
James Bardin	a5a8f4b16a	Ancestors cannot return an error ... Just like Descendants, Ancestors doesn't need to return an error.	1 year ago
James Bardin	38804946e7	Descendants should not return an error	1 year ago
James Bardin	3a1a9408d9	fix Descendants spelling ... this has proliferated everywhere	1 year ago
James Bardin	6e5ba099cb	generate stringer code	1 year ago
James Bardin	9c06a7e8d8	ephemeral resource mode ... Make addrs aware of ephemeral resource types	1 year ago
James Bardin	2cbb6bf92f	udpate code which was failing staticckeck ... Some updates to staticcheck were catching more errors. Most of these were format functions without a format string, but rather than adding more exceptions I just fixed them all. This did also catch some incorrectly wrapped errors.	1 year ago
Liam Cervante	0f0414d484	Fix partial address representation in plan for deferred actions (#34966) ... * Fix partial address representation in plan * reflect new type in stacks	2 years ago
Liam Cervante	55600d815e	Add support for partial addresses and targets that start with 'resource.' (#35333) ... * Add support for partial addresses and targets that start with 'resource.' * fix broken tests	2 years ago
Liam Cervante	5172cb5e27	deferred actions: allow unknown foreach attributes within import blocks (#35311) ... * deferred actions: allow unknown foreach attributes within import blocks * remember to fail tests when diags returned	2 years ago
Liam Cervante	765ec6e923	Complete implementation of targeting with deferred resources (#34971)	2 years ago
Liam Cervante	28797e7938	Add the deferred changes into the plan (#34946) ... * Add the deferred changes into the plan * add copywrite headers	2 years ago
Martin Atkins	5d87e32eb9	moduleaddrs: Split module source address parsing from package addrs ... Our package addrs ends up getting imported from just about ever other package in Terraform, because it contains the types we use to talk about various different kinds of objects. Therefore we typically try to keep its transitive dependency graph relatively small, because anything it depends on becomes an indirect dependency of nearly everything else. A while back we moved the module source address models into package addrs, which also brought with them the code for parsing strings to produce those addresses. Unfortunately, remote module source addresses are defined using the external dependency go-getter, which is pretty heavy itself and also brings with it numerous other external dependencies such as the AWS SDK, the Google Cloud Platform SDK, etc. Since only relatively few packages actually need to _parse_ source addresses -- with most either not caring about them at all or only consuming addresses that were already parsed by someone else -- we'll move the parser functions into their own package, while keeping the resulting address types in package addrs. This does still retain the package addrs dependency on external module github.com/hashicorp/terraform-registry-address, which is not ideal but that one at least has a relatively shallow dependency subgraph, so there's not so much urgency to tidy that one.	2 years ago
Martin Atkins	8e02f5dd21	addrs: PartialExpandedResource module address accessors ... This is kinda awkward because this address type represents both resources whose own instances are not expanded yet and resources belonging to whole modules whose instance keys haven't been expanded yet, and those two cases have different address types. However, in return for this awkward API only for the rare case where we need to isolate the module instance address, the rest of the system gets to not worry very much about this distinction: it can share most code between the two cases, since they both need similar evaluation treatment anyway.	2 years ago
Martin Atkins	d37436a39a	addrs: ModuleInstance.AbsCall ... This is just a variation of the pre-existing ModuleInstance.Call that returns its result as a single value of type AbsModuleCall. This should really have been the signature of ModuleInstance.Call in the first place, but it took us some time to realize that we would benefit from an absolute address type for module calls themselves as opposed to the instances they imply once expanded, and so AbsModuleCall didn't exist at the time we originally wrote ModuleInstance.Call. Perhaps one day we'll update all existing callers of ModuleInstance.Call to use ModuleInstance.AbsCall instead, but for now we'll be pragmatic and keep both to avoid causing unnecessary churn.	2 years ago
Martin Atkins	f3c48314ab	addrs: AbsModuleCall.StaticModule ... This new method calculates the static Module address corresponding to the receiver, effectively discarding any instance keys present in the containing module instance path.	2 years ago
Martin Atkins	869750da61	namedvals: A new package to encapsulate the tracking of named values ... Currently we have a slightly different treatment for each of the different kinds of named values, which makes it hard to generalize the implementations of their very similar behaviors. This package should over time take ownership of the problem of tracking all three kinds of named value during a graph walk, with result data structures that use this information (such as state and plan objects) copying the relevant values out of here only once the graph walk is complete. Nothing is using this yet, though. Some retrofitting of this into Terraform Core will follow in subsequent commits.	2 years ago
Martin Atkins	908c5fa44f	addrs: PartialExpandedModule.String correct for entirely-unexpanded ... This logic was previously incorrect for any case where the number of expanded steps was zero, causing the string representation to begin with a dot when it ought not to.	2 years ago
kmoe	a718f70f85	Add removed block (#34251) ... * terraform: remove redundant code NodeDestroyResourceInstance is never instantiated with a DeposedKey of anything other than states.NotDeposed, so the deleted code is never run. Deposed objects get a NodeDestroyDeposedResourceInstanceObject instead. * tfdiags: add helper func * configs: introduce removed block type * terraform: add forget action * renderer: render forget actions * terraform: deposed objects can be forgotten Deposed objects encountered during planning spawn NodePlanDeposedResourceInstanceObject, which previously generated a destroy change. Now it will generate a forget change if the deposed object is a forget target, and a destroy change otherwise. The apply graph gains a new node type, NodeForgetDeposedResourceInstanceObject, whose execution simply removes the object from the state. * configs: add RemoveTarget address type * terraform: modules can be forgotten * terraform: error if removed obj still in config * tests: better error on restore state fail * Update CHANGELOG.md	2 years ago
Martin Atkins	ce267925e6	addrs: Graph of addresses ... This is another contribution to our slowly-growing library of data structures of address types that implement UniqueKeyer. This is currently just a wrapper around *dag.AcyclicGraph which avoids the need for the caller to type-assert the results and which has hopefully less confusing method names for analyzing the edges. However, that's just an implementation detail and we should not expose that in the public API of this type.	2 years ago
Martin Atkins	d9a4f9a06b	instances: Methods for retrieving the instance keys of modules/resources ... These new methods both take into account the possibility of there being unknown keys, which will be useful for the expression evaluator to decide whether it can return a specific type or not.	2 years ago
Martin Atkins	4d0087e3ef	addrs: PartialExpandedModule and PartialExpandedResource ... In preparation for making it not an error to have unknown values in count or for_each arguments, we will need a way to talk about the as-yet-undetermined set of module or resource instance addresses that will result once we _do_ learn the instance keys in a later step. Unlike many of our address types these have unexported internals so that we can do some semi-uncool things with our address types that external callers are not normally supposed to do. This means they therefore need a bunch more methods than our address types typically need so that it's possible to access the relevant parts of the internal representation.	2 years ago
Martin Atkins	f1d68e89c0	addrs: AbsLocalValue is a UniqueKeyer	2 years ago
Martin Atkins	1c734048af	addrs: Add a missing copyright comment	2 years ago
Martin Atkins	7634f00f0f	addrs: AbsProviderConfig.Equal ... As with other Equal (or sometimes "Equals") methods in this package, this returns true if the two given provider configuration addresses represent the same object.	2 years ago
Martin Atkins	ac562eeb6f	states: State.AllResourceInstanceObjectAttrs returns a set ... Originally we had this function returning a slice of an anonymous struct type because we hadn't yet recognized "resource instance object" as a first-class address type. We do now have addrs.AbsResourceInstanceObject to represent that sort of thing, and so we'll use that here. This also means we can return a set of addresses rather than a slice, which is semantically better as this set of addresses is not inherently ordered. Some existing callers were depending on the sort.SliceStable we were originally doing to make the result dependable, and so now we have a generic helper for turning addrs.Set into a sorted slice of the same type using our address types' "Less" methods that describe their natural or preferred ordering.	2 years ago
Martin Atkins	5372d5eb98	stacks+rpcapi(stacks): Model deposed objects for resource instances ... Previously we incorrectly assumed that resource instances only have one "current" object each. However, resource instances can also have deposed objects which we must also keep track of. This is a breaking change to the rpcapi since we're now using a new message type for a resource instance _object_ address in several places. That breakage is intentional here because at the time of writing this commit the rpcapi is not yet in any stable release and we want to force updating our existing internal client to properly handle deposed objects too.	2 years ago
Martin Atkins	13e26b60dd	addrs: Adopt DeposedKey as an address type; remove states.Generation ... Previously we had states.DeposedKey as our representation of the unique keys used to differentiate between multiple deposed objects on the same resource instance. That type is useful in various places, but its presence in the "states" package made it troublesome to import for some callers. Since its purpose is as an identifier, this type is more at home in the "addrs" package. The states package retains a small number of aliases to preserve compatibility with a few existing callers for now, until we have the stomach for a more invasive change. This also removes the largely-redundant states.Generation interface type, which initially was intended as a way to distinguish between "current" objects and deposed objects, but didn't really add anything because we already have addrs.NotDeposed to represent that situation. Instead, we just ended up with various bits of boilerplate adapter code converting between the two representations. Everything now uses addrs.DeposedKey and uses addrs.NotDeposed to identify non-deposed objects.	2 years ago