92 Commits (main)

Author	SHA1	Message	Date
Radek Simko	0fe906fa8c	make copyrightfix	2 days ago
Austin Valle	a48e873790	PSS: Adjust `StateRange.End` logic in `ReadStateBytes` and `WriteStateBytes` (#38127) ... * fix usage of StateRange.End * add test for last chunk is single byte	2 weeks ago
stephybun	c9d024062a	Generate Resource Config: set state in proto req (#37895) ... * marshal state and set in the proto req for generate resource config * changelog * set state in the proto req for generate resource config in plugin6 * add GRPC tests for GenerateResourceConfig * remove changelog entry since this fix is backported to 1.14	2 months ago
Sarah French	cf047be4e4	PSS: Use interfaces to configure state stores (#37899) ... * refactor: Move chunk size limit constants to new `chunks` package * refactor: Make `NewPluggable` return a `Pluggable` concrete type, instead of an instance of the `backend.Backend` interface. * refactor: Configure state stores through the backend.Backend interface, instead of directly using methods related to RPCs. This requires changing where we call `SetStateStoreChunkSize`. * docs: Add godocs comment to `StateStoreChunkSizeSetter` interface To summarize, we don't really need the `SetStateStoreChunkSize` method, and instead methods like `(*GRPCProvider).ConfigureStateStore` in the `plugin6` package can directly inspect the negotiation process that passes through that code and pull out the chunk size. However that means that that code would also need to implement validation. And that's just `(*GRPCProvider).ConfigureStateStore`; what about all the test mocks that are used in different types of test? They would all need to be implemented similarly to GRPCProvider to be good, useful mocks, and then a lot of things that fulfil the provider.Interface interface are coupled to each other. Instead, it's easier to have validation in the `grpcClient` struct's methods in the `remote` package, as that code is common to all scenarios. That code needs a method to 'reach into' the provider.Interface value, so we use the `SetStateStoreChunkSize` method. * chore: Make it clearer that the v6 GRPCProvider implements `SetStateStoreChunkSize` * fix: Remove unnecessary assignment of chunk size I'm surprised that removing this doesn't break E2E tests of PSS that use grpcwrap, but I think there's `plugin6` code that runs in that situation, so maybe chunking is handled elsewhere. * chore: Add panic to try detect unexpected cases when setting chunk size. * feat: Add `providers.StateStoreChunkSizeSetter` implementation to provider-simple-v6 * docs: Update code comments for NewPluggable describing its intended use	3 months ago
Sarah French	4420c4dcc0	PSS: Update the `workspace new` subcommand to work with PSS, add E2E and integration tests for using `workspace` commands with PSS. (#37855) ... * feat: Update the `workspace new` subcommand to work with PSS, add E2E testing * refactor: Replace instances of `ioutil` with `os` while looking at the workspace command * docs: Update code comments in `workspace new` command * test: Update E2E test using PSS with workspace commands to assert state files are created by given commands * test: Include `workspace show` in happy path E2E test using PSS * fix: Allow DeleteState RPC to include the id of the state to delete * test: Include `workspace delete` in happy path E2E test using PSS * fix: Avoid assignment to nil map in mock provider during WriteStateBytes * test: Add integration test for workspace commands when using PSS We still need an E2E test for this, to ensure that the GRPC-related packages pass all the expected data between core and the provider. * test: Update test to reflect changes in the test fixture configuration * docs: Fix code comment * test: Change test to build its own Terraform binary with experiments enabled * refactor: Replace use of `newMeta` with reuse of Meta that we re-set the UI value on	3 months ago
Daniel Banck	6b038754f0	Fix list resource diagnostics check (#37863) ... * Fix list resource diagnostics check * Improve error message on missing identity schema * Add test case for list response diagnostics * Add changelog	4 months ago
Sarah French	2e5b5dee5d	Upgrade protoc and protoc-gen-go-grpc versions to matching terraform-plugin-go (#37647) ... * Update protoc version in downloader script * go get google.golang.org/grpc/cmd/protoc-gen-go-grpc v1.5.1 This matched terraform-plugin-go * make protobuf * Run `make protobuf` * Update generator to handle generic types from google.golang.org/grpc Looks like this was added in v1.69.3 in https://github.com/grpc/grpc-go/pull/7057 ? * Run `make generate` * Fix "cannot infer Res" compile error - more usage of generics * More fixing compile errors due to switching to use of a generic * Make putting `google.golang.org/grpc` import into generated files conditional * Run `make generate` * Update more places where generics now need to be used * Update generator to handle any types from google.golang.org/grpc in same switch case.	4 months ago
Radek Simko	922fdb2382	Implement LockState & UnlockState provider methods (#37711)	5 months ago
Radek Simko	51fc4c161f	PSS: Implement `ReadStateBytes` + `WriteStateBytes` (#37440) ... * Implement ReadStateBytes + WriteStateBytes * [WIP] - Testing ReadStateBytes and WriteStateBytes (#37464) * Fix nil pointer error * Add WIP test for ReadStateBytes * Move test mock to separate testing file * Update mock to send unexpected EOF when there's a problem returning data and it's not a true EOF * Add test case for when length != expected length * Add test for when trying to read state from a store type that doesn't exist * Change symbol names to lowercase * Add ability to force a diagnostic to be returned from `mockReadStateBytesClient`'s `Recv` method * Add test showing error diagnostics raised by the ReadStateBytes client are returned * Add missing header * Simplify mock by using an embedded type * Rename `mockOpts` to `mockReadStateBytesOpts` * Update existing tests to assert what arguments are passed to the RPC method call * Add mock WriteStateBytesClient which uses `go.uber.org/mock/gomock` to enable assertions about calls to Send * Add a test for WriteStateBytes that makes assertions about calls to the Send method * Update test case to explicitly test writing data smaller than the chunk size * Implement chunking in WriteStateBytes, add test case to assert expected chunking behaviour * Add generated mock for Provider_WriteStateBytesClient in protocol v6 * Update tests to use new `MockProvider_WriteStateBytesClient`, remove handwritten mock * Update code comments in test * Add tests for diagnostics and errors returned during WriteStateBytes * Add generated mock for Provider_ReadStateBytesClient in protocol v6, replace old mock * Add test case for grpc errors in ReadStateBytes, fix how error is returned * Typo in comment * Add missing warning test, rename some test cases * Update proto file definition of Read/WriteStateBytes RPCs (#37529) * Update Read/WriteStateBytes RPCs to match https://github.com/hashicorp/terraform-plugin-go/pull/531 * Run `make protobuf` * Run `make generate` * Update use of `proto.ReadStateBytes_ResponseChunk` in tests * Fix how diagnostics are handled alongside EOF error, update ReadStateBytes test * More fixes - test setup was incorrect I think? I assume that a response would be returned full of zero-values when EOF is encountered. * WIP - avoid crash if chunk is nil * Sarah's updates to radek/pss-read-write (#37642) * Update code to not expect a chunk when EOF encountered * Return early if any grpc errors are encountered during ReadStateBytes * Close the stream with CloseSend once everything's read without error. Add test case about handling grpc errors from CloseSend. * Fix test case about warnings: We would expect to receive a chunk with data alongside the warning and have a normal closing of the stream after EOF * Add log line, remove unneeded type info * Implement configurable state chunk size * handle metadata in WriteStateBytes correctly * validate chunk sizes received from provider * ReadStateBytes: avoid early return on warnings --------- Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>	5 months ago
Samsondeen	a7504719ef	list: send non-null "config" object to provider when not present in the list block (#37620)	5 months ago
Kristin Laemmert	df113486a1	actions: remove references to action types, linked resources (#37616) ... * action renaming * actions: remove references to action types * actions: remove references to linked_resources or action types from the plan proto	5 months ago
Daniel Schmidt	871451122f	actions: move schema to single action type and remove linked resources ... we want to leave the door open to evolve the design in the future based on feedback	5 months ago
Daniel Banck	1ac8497994	Add support for Terraform Search in the cloud backend (TF-25935) (#37479)	5 months ago
James Bardin	4e8717295e	grpc method impl	6 months ago
James Bardin	aa1babe5bb	plugin6 mock	6 months ago
Daniel Schmidt	176263d936	actions: remove future action types ... removing them for now, this gives us more flexibility in the future since the schema is not yet locked in	6 months ago
Sarah French	037ed81e9e	PSS: Implement first gRPC methods: config validation and usage, listing and deleting workspaces (#37418) ... * Implement first grpc methods: config validation and use, listing and deleting workspaces * Add a state store to the default provider schema used in protocol 6 GRPCProvider tests * Add `ValidateStateStoreConfig` test that shows diagnostics are returned as expected * Add `ValidateStateStoreConfig` test that shows schema-related errors are returned before the `ValidateStateStoreConfig` RPC takes place * Add similar tests for `ConfigureStateStore` - check errors are returned and schema errors are caught early * Refactor to avoid looping over cases * Update `GetStates` to check the store type is implemented before retrieving states. Add tests. * Fix defect in DeleteState, update it to check state store type is valid * Add tests for `DeleteState` method --------- Co-authored-by: Radek Simko <radek.simko@gmail.com>	6 months ago
Daniel Banck	2563b07813	Allow list events with only warnings (#37415) ... This updates the event processing logic. Terraform now allows error and warning diagnostics for list events with all other fields set to null. The combination of a warning with a valid result is still possible.	7 months ago
Daniel Schmidt	17e7338b0f	add client capabilites across the board	7 months ago
Kristin Laemmert	0374f04424	Add ValidateActionConfig to provider interface, protocol & internal implementations (#37345) ... * Add ValidateActionConfig to provider interface and protocol * Update internal/provider-simple-v6/provider.go Co-authored-by: Daniel Schmidt <danielmschmidt92@gmail.com> --------- Co-authored-by: Daniel Schmidt <danielmschmidt92@gmail.com>	7 months ago
Kristin Laemmert	9256074c43	Actions in plan/changes (#37320) ... * Add actions to the plans and change * jsonplan - ignoring LinkedResources for now, those are not in the MVP * pausing here: we'll work on the plan rendering later	7 months ago
Daniel Schmidt	a2ce38ce12	use gomock generated mocks for the action invoke stream API	7 months ago
Daniel Schmidt	ac132d1b15	add provider implementation for actions	7 months ago
Daniel Schmidt	e6b848d5ab	add actions protobuf definitions	7 months ago
Sarah French	0f8e77a50f	PSS: Add GetStates and DeleteState RPCs to plugin protocol v6 (#37288) ... * Add GetStates RPC method to Plugin Protocol v6 * Add DeleteState RPC method to Plugin Protocol v6 * Add methods to provider-simple * Fix error messages * Apply suggestions from code review Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com> * Change how GetStates RPC returns the list of state names * Change GetStates implementation to use new data type * `make protobuf` to accommodate new code comments --------- Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com>	8 months ago
Samsondeen	3d3439e00e	Testing list blocks with the gRPC Provider (#37236)	8 months ago
Daniel Banck	540512e27b	Add config to List response (#37237)	8 months ago
Samsondeen	e178088a5b	unwrap nested config (#37235)	8 months ago
Samsondeen	cacd7861e5	add nested config block to list block (#37229)	8 months ago
Samsondeen	685ff9f192	Schema representation of list block config and results (#37209)	8 months ago
Daniel Banck	cb58a15f3d	Implement ListResource RPC (TF-25509) (#37092) ... * Implement ListResource RPC via callbacks * Implement ListResource with iterators * Change `ListResourceResponse` to slice * Turn ListResourceResponse into a struct * Add a limit for ListResource * explicitly cancel stream when listing resources --------- Co-authored-by: Samsondeen Dare <samsondeen.dare@hashicorp.com>	9 months ago
Radek Simko	643266dc90	Add initial state store protocol skeleton (#37197) ... * Add initial state store protocol skeleton Introduce ValidateStateStoreConfig + ConfigureStateStore Update GetProviderSchema + GetMetadata (for mux) * address PR feedback	9 months ago
Daniel Banck	44ae7da18e	Update Plugin Protocol for List and Implement `ValidateListResourceConfig` (#37007) ... * Minor auto-formatting changes * Add list RPC and schema protobuf definitions * make protobuf * make generate * Add ValidateListResourceConfig implementation	9 months ago
Daniel Banck	421fe3580f	Check GetResourceIdentitySchemas diagnostics and return early (#36999)	9 months ago
Austin Valle	5c4c669882	Fix `ImportResourceState` RPC response decoding for identity data (#36806) ... * Fix `ImportResourceState` RPC response decoding for identity data * add tests for importy by identity * re-run action for flakey UI test	11 months ago
Austin Valle	2d08b5d0d1	match `internal/plugin6` implementation to `internal/plugin`	11 months ago
Daniel Schmidt	fec6e4b552	send resource identities to provider calls	11 months ago
Daniel Banck	b2b42c0fb4	Store resource identities in state (TF-23255) (#36464) ... * Persist resource identity in Terraform state * make syncdeps * Move identity schema merging closer to the protocol * mock GetResourceIdentitySchemas * Fix identity refresh tests * Add more tests * Change grcpwrap upgrade identity * Review feedback * Remove unnecessary version conversion * Check if GetResourceIdentitySchemas RPC call is implemented * Update function signature docs * Adapt protocol changes * Check unimplemented error for identities in GetSchema	11 months ago
Daniel Banck	10c9b64007	Rename schema.Block to Body (#36629)	12 months ago
James Bardin	3b3e4bf003	update the rest of the go:generate calls	1 year ago
Radek Simko	289a3568da	Address `go vet` 1.24 failures (#36485) ... * address go vet failures * avoid unnecessary .Error()	1 year ago
Daniel Banck	857d188308	Add resource identity message to protocol (TF-23178) (#36451) ... * protocol: create new 5.9 and 6.9 protocol versions * protocol: add resource identity messages to 5.9 & 6.9 * make protobuf * make generate * grpcwrap: Add RPC calls skeleton	1 year ago
James Bardin	337bf8e11b	Merge pull request #36236 from hashicorp/jbardin/write-only-structural-attrs ... convert write-only structural attrs to and from protobuf	1 year ago
James Bardin	345a931132	convert write-only structural attrs through proto ... Nested structural attributes were missing write-only flags when converted to and from the wire protocol.	1 year ago
Daniel Schmidt	e29708c4d9	ephemeral: add WriteOnlyAttributesAllowed client capability to validate resource	1 year ago
Daniel Schmidt	3a962e8e7e	ephemeral: add WriteOnlyAttributesAllowed client capability ... we allow it for all requests	1 year ago
Daniel Schmidt	0222b97692	ephemeral: add write-only attribute to proto to schema conversion	1 year ago
Daniel Schmidt	50b3732f72	write-only attributes: add to provider schema	1 year ago
James Bardin	6f5007efe7	grpc mock tests	1 year ago
James Bardin	94687676a3	add basic grpc wrapper implemenation	1 year ago