4385 Commits (main)

Author	SHA1	Message	Date
Sarah French	d174972029	test: Show warning when a `-filter` flag has an invalid value (#38603) ... * test: Show warning when a test file filter is not valid * Add change file	2 days ago
Sarah French	f6553bae93	fix: Stop discarding diagnostics in internal test providers (#38602)	2 days ago
Sarah French	be22624430	chore: Modernise some code in provisioners packages, add some code comments (#38588)	3 days ago
Kristin Laemmert	abbb650bae	refactor: remove readDiff (#38590) ... readDiff is no longer necessary now that we don't need a schema to read the change - all calls to readDiff were replaced with a single-line call to ctx.Changes, using the same inputs that readDiff used.	3 days ago
Kristin Laemmert	34935295e3	feat(import): support import blocks inside child modules (#38352) ... This PR adds support for import blocks inside child modules. Duplicate blocks will overwrite prior imports (I copied this behavior from the refactoring code, but we could instead return an error if multiple import blocks target the same abs config resource).	3 days ago
Sebastien Tardif	3c94ef65b3	Fix resource leaks in provisioners and commands (#38585) ... * Fix resource leaks in provisioners and commands Close file handles, HTTP response bodies, and pipe ends that were previously leaked on certain code paths: - workspace_new.go: Close state file opened via os.Open - file/resource_provisioner.go: Close temp file handle before returning the file path to caller - login.go: Move defer resp.Body.Close() before ioutil.ReadAll so the body is closed even when ReadAll fails - local-exec/resource_provisioner.go: Close the read end of os.Pipe after the copy goroutine completes --------- Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>	4 days ago
Sarah French	820f37b35f	test: Proof of path traversals not being accepted workspaces (#38589)	4 days ago
Sarah French	c56ec2943d	refactor: Move validation of `init`'s `-upgrade` and `-lockfile=readonly` flags to the arguments package. (#38561) ... The `-upgrade` and `-lockfile=readonly` flags are mutually exclusive, and this is now enforced by the arguments package. This refactor has also fixed a historical bug where that validation error was output twice. The getProvidersFromConfig code now depends on the flag validation happening in the calling code. However there is another check in downstream code, in `saveDependencyLockFile` when we overwrite the dependency lock file's contents. There, an error occurs if a diff in the locks is detected during `readonly` mode. This protects against incorrect use of `getProvidersFromConfig` with unvalidated inputs, if that happens in future.	4 days ago
Sarah French	2e5a89ab6f	Update command help text for `state migrate` command (#38571) ... Added details about the default behaviour for the lock-file CLI flags, and made it clearer that the upgrade flag only enables upgrading the provider used for state storage.	4 days ago
Sarah French	adcf9a9cb3	PSS: Make sure to close supplementary instances of a store that are intended to be used temporarily. (#38573) ... * feat : Add Close method to Pluggable struct, use method to close supplementary provider processes that are launched during init.	4 days ago
James Bardin	c29cb25f86	remove old resource phase addressing ... At one point there was an attempt to connect the destroy nodes in the apply graph by using special addressing and manipulating the references for resources. This doesn't work for a few reasons, but in particular, destroy nodes are entirely built from their state, they do not reference anything, and they cannot be referenced.	4 days ago
Daniel Banck	7ac3e2ec19	Return SafeInitActionNotRelevant on empty config	5 days ago
Daniel Banck	94a640a1a5	Add test case for variable value without config	5 days ago
Daniel Banck	74084a7705	Return early during provider installation if there is no config	5 days ago
Sarah French	7a960db553	PSS: Add interactive confirmation of state storage provider trust when initialising a state store for the first time (#38395) ... * refactor: Replace use of prepareInstallerEvents method. This will allow finer control of callbacks when implementing security related features * feat: Users are prompted to approve a provider used for PSS on first use, and only if downloaded via HTTP. Prompts include signer details and key ID data. * test: Users see "Authentication: unauthenticated" in prompt if network mirror doesn't include hashes They'll see authentication data in all other prompt scenarios. There's no auth when using an fs mirror, but when those are in use we trust the providers already and no prompts are raised. * refactor: Simplify how we prepare installation event callbacks by defining reused callbacks * refactor: Remove unused parameters from `getProvidersFromState`	6 days ago
Michael Yocca	a941456484	patch remote-state/cos go.sum	6 days ago
Michael Yocca	ee165f07f1	fix: go.mod syncdeps	6 days ago
Michael Yocca	ffa0a98da1	test: add test case for flag determining	6 days ago
Michael Yocca	5dd7e55d9b	feat: pass generate-config-out to go-tfe client request	6 days ago
Michael Yocca	fb6f6f1c40	fix: update tfe client mocks	6 days ago
Daniel Schmidt	2cd5cacacd	run make syncdeps	7 days ago
Daniel Schmidt	6e8052393c	update go version	7 days ago
Austin Valle	527402d3fe	stackmigrate: Fix recursive provider config resolution for resource instances in deeply nested modules (#38528) ... * stackmigrate: fix recursive provider config resolution for resource instances in deeply nested modules * added additional test for implict provider configs in deeply nested modules * add changelog * move changelog to 1.15	2 weeks ago
Radek Simko	badc70c93d	command/output: Ignore warnings in JSON mode (#38530) ... * command/output: Ignore warnings in JSON mode * add changelog entry	2 weeks ago
Daniel Schmidt	bdcac1b2e4	stacks: add output values to plan component instance change descriptions	2 weeks ago
Daniel Banck	f34ee96558	Remove outdated value source comment	2 weeks ago
Sarah French	6554bda227	refactor: Update `workspace select` and `new` subcommands to use the arguments package for parsing arguments and flags (#38430) ... * refactor: Move method `ValidWorkspaceName` and related const into arguments package, update references This function is primarily used to validate arguments, but it's used once (in (m *Meta) Workspace) in a different context, so I've left the original function signature in the command package. * feat: Add `workspace new`-related code to arguments package * refactor: Update `workspace new` to use the arguments package when parsing arguments Note that this changes the format of errors returned when arg parsing fails - this is now wrapped in a diagnostic so now starts with `\nError: ` and has an extra trailing newline. * feat: Add `workspace select`-related code to arguments package * refactor: Update `workspace select` to use the arguments package when parsing arguments Note that this changes the format of errors returned when arg parsing fails - this is now wrapped in a diagnostic so now starts with `\nError: ` and has an extra trailing newline.	2 weeks ago
Sarah French	dd35f66105	fix: warnings against using `terraform env list` are shown in JSON format when the -json flag is present (#38469)	2 weeks ago
Sarah French	559233329e	Fix: Re-enable using prerelease providers in the new two-step provider download in `init` (#38502) ... * test: Add pre-release to available providers. Existing tests don't use it because the configuration doesn't specify the prerelease as the version constraint. This was the gap in my understanding - prerelease providers are handled differently in the installer logic. I believe it boils down to this: 29863fd2ba/versions/set_released.go (L5-L7) * test: Add failing tests that show expected behaviour when a pre-release of a provider is used * fix: Ensure that any relevant version constraints from the config are available to use when installing providers present in the state * test: Add test defining pre-release download behaviour that was present before v1.15 * test: Update test to reflect that 2 step init is no longer experimental or specific to the PSS project	2 weeks ago
Austin Valle	a316444e23	add test for variable validation transformer	2 weeks ago
Austin Valle	6428b2bdbc	add provider source back to success tests	2 weeks ago
James Bardin	e480b016f8	remove the extra logic to detect prov funcs ... We can't detect why a provider function is missing is all cases, so get rid of the extra logic trying to do that. We also admit here that we need to allow a provider function within a variable validation condition, because that is not the only way these could fail during init, and it's otherwise valid during the next phase.	2 weeks ago
James Bardin	c6b61bf731	simplify error messages for dynamic source ... We can't fully detect why a module source or version might be unknown, so instead use a simpler error that covers all possible reasons. If we do find a way to get more specific in the future, we can extent it then, but the current errors were trying to be specific when they couldn't.	2 weeks ago
Austin Valle	19972a4606	adjust tests	2 weeks ago
Austin Valle	1c88535ac0	add test for validation reference to non-const variable	2 weeks ago
Austin Valle	d2c9214081	prune validate nodes	2 weeks ago
Austin Valle	b8bdde09ca	Merge branch 'main' into provider-defined-function-during-init	3 weeks ago
Daniel Banck	9e08102505	Don't expect an error for undeclared variable values from cloud	3 weeks ago
Daniel Banck	a693cc769c	Use new variable source type in tests	3 weeks ago
Daniel Banck	6c8f46197f	Introduce new source for variables from the cloud backend	3 weeks ago
James Bardin	8f24aa9337	Special handling for empty module expansion ... The cty library requires special handling for empty lists and maps, so we need s separate branch to generate expansion values when expansion results in 0 instances.	3 weeks ago
Sarah French	b7a43b31b0	Comments and changes from pairing ... Co-authored-by: Austin Valle <austinvalle@gmail.com>	3 weeks ago
Radek Simko	e6850a514f	fix: Avoid warnings in `terraform output -raw` (#38487) ... * command/output: Avoid warnings in '-raw' output * command/output: Add regression test Co-authored-by: Daniel Schmidt <danielmschmidt92@gmail.com> * Add changelog entry * Clarify changelog entry --------- Co-authored-by: Daniel Schmidt <danielmschmidt92@gmail.com>	3 weeks ago
Austin Valle	b0539318f1	remove duplicate test	3 weeks ago
Austin Valle	6c783ce1be	add some tests + TODOs	3 weeks ago
Daniel Schmidt	8c5dd3d398	WIP	3 weeks ago
Daniel Schmidt	6f3cf2c219	ignore unknown function errors during init ... we won't have providers during init, so there is no way we can use these to begin with	3 weeks ago
Daniel Banck	5f427cabc5	Return unknown values for non-const variables during init	3 weeks ago
Daniel Banck	4c6f06725b	Update init test case to include a reference	3 weeks ago
Sarah French	bb7491c368	Limit backend block validation in the `validate` command to just backend type (#38468) ... * fix: Limit backend validation to just the backend type. Also, remove similar validation for state stores, which would cause a similar issue in future. * test: Add a new test showing behavior when removed backend types are in a config.	3 weeks ago