541 Commits (f-workspaces2-prototype)

Author	SHA1	Message	Date
Martin Atkins	07f6975ff2	command: Minimal "terraform init" for workspaces2 prototype ... This is just enough to get a functional working directory for a workspaces2 project so that "terraform plan" and "terraform apply" can work.	6 years ago
Martin Atkins	52c1b4e8fc	backend: Minimal support for workspaces2-style operations ... This allows "terraform plan" and "terraform apply" to integrate with the project concepts in a minimal way, showing a rough-and-ready end-to-end of applying multiple inter-dependent workspaces.	6 years ago
Martin Atkins	23c21531f2	command: Make room for project.Workspace objects ... In our existing architecture, workspaces belong to backends and so the command package only deals with workspace _addresses_. With workspaces becoming a project concept, we need to make room for preparing and passing around project.Workspace objects, which requires some renaming to make it clear when we're dealing with actual workspace objects vs. workspace addresses.	6 years ago
Martin Atkins	120c84b1bf	Messy initial plumbing of workspaces into the command package ... This is the crossover point from greenfield development into structural renovation, so things will get messy and awkward from here onwards so that I can patch things out enough to get Terraform to compile without having to complete all of the adaptation work in a single step.	6 years ago
Martin Atkins	b431efea3b	backend/init: Disable all remote state backends ... Under the workspaces2 prototype, "remote state backend" is no longer a concept, so we'll remove these here and then in a later commit adapt these to be remote state storage implementations in providers instead.	6 years ago
Martin Atkins	cc64f5ebe2	backend/atlas: Remove ... This backend is obsolete, because the API it interacts with is EOL.	6 years ago
Martin Atkins	b10f058cbb	backend/remote: Only load variables if we're going to use them ... Some commands don't use variables at all or use them in a way that doesn't require them to all be fully valid and consistent. For those, we don't want to fetch variable values from the remote system and try to validate them because that's wasteful and likely to cause unnecessary error messages. Furthermore, the variables endpoint in Terraform Cloud and Enterprise only works for personal access tokens, so it's important that we don't assume we can _always_ use it. If we do, then we'll see problems when commands are run inside Terraform Cloud and Enterprise remote execution contexts, where the variables map always comes back as empty.	6 years ago
Martin Atkins	a8d01e3940	backend/remote: Report invalid variables only remotely ... The remote backend uses backend.ParseVariableValues locally only to decide if the user seems to be trying to use -var or -var-file options locally, since those are not supported for the remote backend. Other than detecting those, we don't actually have any need to use the results of backend.ParseVariableValues, and so it's better for us to ignore any errors it produces itself and prefer to just send a potentially-invalid request to the remote system and let the remote system be responsible for validating it. This then avoids issues caused by the fact that when remote operations are in use the local system does not have all of the required context: it can't see which environment variables will be set in the remote execution context nor which variables the remote system will set using its own generated -var-file based on the workspace stored variables.	6 years ago
Radek Simko	7860f55e4f	Version tools per Go convention under tools.go	6 years ago
Pam Selle	a5f2f4cbba	Update messaging for .terraformignore	6 years ago
Radek Simko	32f9722d9d	Replace import paths & set UA string where necessary	6 years ago
Martin Atkins	8664749b59	backend: Allow certain commands to opt out of required variable checks ... Terraform Core expects all variables to be set, but for some ancillary commands it's fine for them to just be set to placeholders because the variable values themselves are not key to the command's functionality as long as the terraform.Context is still self-consistent. For such commands, rather than prompting for interactive input for required variables we'll just stub them out as unknowns to reflect that they are placeholders for values that a user would normally need to provide. This achieves a similar effect to how these commands behaved before, but without the tendency to produce a slightly invalid terraform.Context that would fail in strange ways when asked to run certain operations.	6 years ago
Martin Atkins	e21f0fa61e	backend/local: Handle interactive prompts for variables in UI layer ... During the 0.12 work we intended to move all of the variable value collection logic into the UI layer (command package and backend packages) and present them all together as a unified data structure to Terraform Core. However, we didn't quite succeed because the interactive prompts for unset required variables were still being handled _after_ calling into Terraform Core. Here we complete that earlier work by moving the interactive prompts for variables out into the UI layer too, thus allowing us to handle final validation of the variables all together in one place and do so in the UI layer where we have the most context still available about where all of these values are coming from. This allows us to fix a problem where previously disabling input with -input=false on the command line could cause Terraform Core to receive an incomplete set of variable values, and fail with a bad error message. As a consequence of this refactoring, the scope of terraform.Context.Input is now reduced to only gathering provider configuration arguments. Ideally that too would move into the UI layer somehow in a future commit, but that's a problem for another day.	6 years ago
Martin Atkins	39e609d5fd	vendor: switch to HCL 2.0 in the HCL repository ... Previously we were using the experimental HCL 2 repository, but now we'll shift over to the v2 import path within the main HCL repository as part of actually releasing HCL 2.0 as stable. This is a mechanical search/replace to the new import paths. It also switches to the v2.0.0 release of HCL, which includes some new code that Terraform didn't previously have but should not change any behavior that matters for Terraform's purposes. For the moment the experimental HCL2 repository is still an indirect dependency via terraform-config-inspect, so it remains in our go.sum and vendor directories for the moment. Because terraform-config-inspect uses a much smaller subset of the HCL2 functionality, this does still manage to prune the vendor directory a little. A subsequent release of terraform-config-inspect should allow us to completely remove that old repository in a future commit.	6 years ago
Paul Thrasher	f2ef8ef317	slow down tfce polling to 1s ... Signed-off-by: Paul Thrasher <pthrasher@hashicorp.com>	6 years ago
Paul Thrasher	4e308ef362	typos. some code, some text. ... Signed-off-by: Paul Thrasher <pthrasher@hashicorp.com>	6 years ago
Paul Thrasher	d2eaffabea	vendor latest go-tfe ... Signed-off-by: Paul Thrasher <pthrasher@hashicorp.com>	6 years ago
Paul Thrasher	d3fc3dee6e	clean up go mod for go-tfe ... Signed-off-by: Paul Thrasher <pthrasher@hashicorp.com>	6 years ago
Paul Thrasher	e2831b3d1e	tfce test additions ... Signed-off-by: Paul Thrasher <pthrasher@hashicorp.com>	6 years ago
Paul Thrasher	bc2d888b7b	update to go-tfe 0.3.23 ... this fixes the attr types Signed-off-by: Paul Thrasher <pthrasher@hashicorp.com>	6 years ago
Paul Thrasher	39817ac476	cost estimation status polling ... Properly wait for cost estimation to finish running before outputting the results. Waits 500 milliseconds between checks, rather than backing off exponentially, because we are not in a run queue. At the point we're waiting, we expect cost estimation to be run in a timely manner.	6 years ago
Paul Thrasher	979bba0f32	tfce mock fix ... Signed-off-by: Paul Thrasher <pthrasher@hashicorp.com>	6 years ago
Kristin Laemmert	006ef022e6	Merge pull request #22918 from hashicorp/mildwonkey/to-e2e-or-not-e2e ... Sundry fixes to e2e tests	6 years ago
Kristin Laemmert	68dfc3046d	backend/remote-state: etcdv3, oss, and manta acc tests should fail ... faster The acceptance tests for etcdv3, oss and manta were not validating required env variablea, chosing to assume that if one was running acceptance tests they had already configured the credentials. It was not always clear if this was a bug in the tests or the provider, so I opted to make the tests fail faster when required attributes were unset (or "").	6 years ago
Kristin Laemmert	5300f85a79	backend/manta: fix panic when insecure_skip_tls_verify was not set ... The DefaultFunc for insecure_skip_tls_verify was sending an empty string instead of a bool. Fixes to default to `false`.	7 years ago
Paddy	9b24ef7870	Merge pull request #21772 from luis-silva/21680/GCS_OAUTH ... Add OAuth2 token support for GCS backend	7 years ago
Martin Atkins	7e29b9b5d4	core: Warn when creating and applying with -target ... The documentation for the -target option warns that it's intended for exceptional circumstances only and not for routine use, but that's not a very prominent location for that warning and so some users miss it. Here we make the warning more prominent by including it directly in the Terraform output when -target is in use. We first warn during planning that the plan might be incomplete, and then warn again after apply concludes and direct the user to run "terraform plan" to make sure that there are no further changes outstanding. The latter message is intended to reinforce that -target should only be a one-off operation and that you should always run without it soon after to ensure that the workspace is left in a consistent, converged state.	7 years ago
Luis Silva	9ae8eca55d	Merge branch 'master' into 21680/GCS_OAUTH	7 years ago
yanndegat	be5280e4e1	remote-state/pg: add option to skip schema creation (#21607) ... * add `skip_schema_creation` option * add sanity check to avoid situations where postgres users hasn't been granted the "CREATE SCHEMA" right closes #21604 Signed-off-by: yann degat <yann@2kmail.net>	7 years ago
yuanye	b69c0b4199	oss backend support profile	7 years ago
James Bardin	10d94fb764	Merge pull request #21967 from williams-brian/SSE-C_Remote_State ... Add support for SSE-C to S3 backend	7 years ago
Radek Simko	f3357aad45	vendor: Downgrade Azure dependencies ... This is to allow Terraform providers to upgrade to at least one more minor version of the plugin SDK without major UX hiccups. This concludes (unsuccessful) experiments involving upgrades to SDK with https://github.com/Azure/go-autorest/pull/455 Even with that patch all providers still experience broken UX as described in https://github.com/hashicorp/terraform/pull/22490 This downgrade reduces the uncomfort to only a handful of providers from >100s. The affected providers more or less directly depend on Azure SDK(s), which is ~8. Affected providers practically cannot consume Terraform Plugin SDK with this patch (downgraded Azure SDKs) and can just wait for extracted Terraform Plugin SDK which is planned to be released soon. This reverts the following PRs: - https://github.com/hashicorp/terraform/pull/22247 - https://github.com/hashicorp/terraform/pull/22248 - https://github.com/hashicorp/terraform/pull/22524 - https://github.com/hashicorp/terraform/pull/22525 and it is otherwise result of the following commands ``` go get github.com/Azure/azure-sdk-for-go@v21.3.0 go get github.com/hashicorp/go-azure-helpers@166dfd221bb2 go mod tidy ```	7 years ago
Radek Simko	dee450cf8c	vendor: Bump go-azure-helpers to 0.7.0	7 years ago
Roberto Jung Drebes	b459a92575	backend/gcs: Use new endpoints for Google OAuth ... This is a consequence of googleapis/google-cloud-common#260.	7 years ago
Pam Selle	9631e4c73d	Merge pull request #20571 from sergkondr/fix_misspelling ... fix misspelling	7 years ago
Alex Pilon	4bf43efcfd	move hcl2shim package to configs	7 years ago
Chris Marchesi	d43fc71135	modules: update go-azure-helpers to v0.5.0 ... To help address the issues posed on #22087 and #22085.	7 years ago
He Guimin	a490dfa495	backend/oss: Support for assume role config	7 years ago
Kristin Laemmert	412d459292	backend/remote: remove milseading contents from error message (#22148) ... Previously, terraform was returning a potentially-misleading error message in response to anything other than a 404 from the b.client.Workspaces.Read operation. This PR simplifies Terraform's error message with the intent of encouraging those who encounter it to focus on the error message returned from the tfe client. The added test is odd, and a bit hacky, and possibly overkill.	7 years ago
Kristin Laemmert	190ef537ec	backend/remote: notify users when uploading something other than cwd ... When a TFC workspace is configured without a VCS root, and with a working directory, and a user is running `terraform init` from that same directory, TFC uploads the entire configuration directory, not only the user's cwd. This is not obvious to the user, so we are adding a descriptive message explaining what is being uploaded, and why.	7 years ago
Kristin Laemmert	89eeaed0a0	[WIP] backend/enhanced: start with absolute configuration path (#22096) ... * backend/enhanced: start with absolute config path We recently started normalizing the config path before all "command" operations, which was necessary for consistency but had unexpected consequences for remote backend operations, specifically when a vcs root with a working directory are configured. This PR de-normalizes the path back to an absolute path. * Check the error and add a test It turned out all required logic was already present, so I just needed to add a test for this specific use case.	7 years ago
Pam Selle	23a187d85d	Merge pull request #21739 from hasheddan/s3-backend-comment-typo ... s3 backend: minor typo in putMD5 comment	7 years ago
Colin Fowler	cd7bfba141	rebased to terraform master branch	7 years ago
Brian Williams	5e3c3bafb8	Add support for SSE-C to S3 backend ... These changes add support for encrypting terraform remote-state in S3 using customer-supplied encryption keys (SSE-C).	7 years ago
Luis Silva	f6c90c1d96	Add OAuth2 token support for GCS backend	7 years ago
Radek Simko	5b9f2fafc8	Standardise directory name for test data	7 years ago
Daniel Mangum	3bc14620c0	backend/remote-state: remove dead code ... This remote-state adapter is no longer used, because the old remote state mechanism was removed in Terraform v0.12.	7 years ago
hasheddan	961d43142c	s3 backend: minor typo in putMD5 comment ... Signed-off-by: hasheddan <georgedanielmangum@gmail.com>	7 years ago
Mary Cutrali	e44ca40702	update remote apply language to use proper its/it's	7 years ago
Pam Selle	cb593c25aa	Merge pull request #21381 from davidcelis/remove-cost-estimation ... Remove pre-alpha cost estimation logic from remote backend	7 years ago