83 Commits (f-provider-schema-init)

Author	SHA1	Message	Date
Martin Atkins	a1a57189b9	terraform: HCL2-flavored module dependency resolver ... For the moment this is just a lightly-adapted copy of ModuleTreeDependencies named ConfigTreeDependencies, with the goal that the two can live concurrently for the moment while not all callers are yet updated and then we can drop ModuleTreeDependencies and its helper functions altogether in a later commit. This can then be used to make "terraform init" and "terraform providers" work properly with the HCL2-powered configuration loader.	8 years ago
James Bardin	936ad25e9f	update tests to match pre-release constraint rules	8 years ago
Paul Tyng	c868092d2d	Standardize http.Client creation with User-Agent	8 years ago
Masayuki Morita	f440dba137	Standardize on log level "WARN" rather than "WARNING"	8 years ago
James Bardin	6cb4e14cf8	Use pooled http client for fetching providers ... While the TLS handshakes are a fairly small overhead compared to downloading the providers, clients in some situation are failing to complete the TLS handshake in a timely manner. It's unclear if this is because of heavily constrained clients are stalling while doing the major crpto operations, or the edge servers are throttling repeated requests from the same IPs. This should allow reusing the open TLS connection to the release edge servers during init.	8 years ago
Martin Atkins	183833affc	core: terraform.ResourceProvider.GetSchema method ... In order to parse provider, resource and data source configuration from HCL2 config files, we need to know the relevant configuration schema. This new method allows Terraform Core to request these from a provider. This is a breaking change to this interface, so all of its implementers in this package are updated too. This includes concrete implementations of the new method in helper/schema that use the schema conversion code added in an earlier commit to produce a configschema.Block automatically. Plugins compiled against prior versions of helper/schema will not have support for this method, and so calls to them will fail. Callers of this new method will therefore need to sniff for support using the SchemaAvailable field added to both ResourceType and DataSource. This careful handling will need to persist until next time we increment the plugin protocol version, at which point we can make the breaking change of requiring this information to be available.	8 years ago
Martin Atkins	879899d434	plugin/discovery: plugin caching mechanism ... For users that have metered or slow internet connections it is annoying to have Terraform constantly re-downloading the same files when they initialize many separate directories. To help such users, here we add an opt-in mechanism to use a local directory as a read-through cache. When enabled, any plugin download will be skipped if a suitable file already exists in the cache directory. If the desired plugin isn't in the cache, it will be downloaded into the cache for use next time. This mechanism also serves to reduce total disk usage by allowing plugin files to be shared between many configurations, as long as the target system isn't Windows and supports either hardlinks or symlinks.	9 years ago
Martin Atkins	12d6bc8c30	plugin/discovery: ignore non-files when discovering ... If we encounter something that isn't a file -- for example, a dangling symlink whose referent has been deleted -- we'll ignore it so that we can either later produce a "no such plugin" error or auto-install a plugin that will actually work.	9 years ago
James Bardin	3dd0f93aed	Merge pull request #15816 from hashicorp/jbardin/plugin-logger ... specify a logger for go-plugin	9 years ago
James Bardin	714df97a02	specify a logger for go-plugin ... The go-plugin package now uses hclog. The default Logger has a level set to Info, but all plugin output is relayed via Debug. Create a new named logger for plugins with the level set to Trace so that all output comes through.	9 years ago
Radek Simko	28b33c9299	plugin: Display version + source when initializing plugins	9 years ago
Radek Simko	de3015cebf	Remove overly verbose DEBUG log	9 years ago
Martin Atkins	ac250d2792	plugin/discovery: trim off .exe suffix when parsing filenames ... On Windows systems the plugin binaries use a .exe suffix, which we were misparsing as part of either the "v" or "x" parts of the filename. This fixes #15578.	9 years ago
James Bardin	2b84e786e9	allow missing x-terraform-protocol-version ... If the release site is missing the "x-terraform-protocol-version" header, we should fetch the latest spec'ed release. Downloading the wrong protocol version can't do any damage, and the version present is more than likely compatible.	9 years ago
Martin Atkins	610fcb605e	plugin/discovery: allow customizing the OS/arch for auto-install ... Previously we forced only installing for the current GOOS and GOARCH. Now we allow this to be optionally overridden, which allows building tools that can, for example, populate a directory with plugins to run on a Linux server while working on a Mac.	9 years ago
James Bardin	beebd5cee3	improve discovery logging ... Display whether we're looking for a provider or provisioner in the log messages.	9 years ago
James Bardin	e059eb80d1	add test for signature mismatch	9 years ago
James Bardin	2cca6f10fa	return sig error when fetching a plugin ... A signature error was being ignored while fetching a plugin	9 years ago
James Bardin	c10f5caf05	Merge pull request #15345 from hashicorp/jbardin/plugin-sig ... verify automatically downloaded plugins	9 years ago
Martin Atkins	af2111f24e	plugin/discovery: sentinel error values for Get errors ... Some errors from Get are essentially user error, so we want to be able to recognize them and give the user good feedback on how to proceed. Although sentinel values are not an ideal solution to this, it's something reasonably simple we can do to get this done without lots of refactoring.	9 years ago
James Bardin	13d835f996	test signature verification ... use a published provider's checksum file and signature to check the verification.	9 years ago
James Bardin	415d562d36	add signature verification ... Fetch the SHA256SUMS file and verify it's signature before downloading any plugins. This embeds the hashicorp public key in the binary. If the publickey is replaced, new releases will need to be cut anyway. A --verify-plugin=false flag will be added to skip signature verification in these cases.	9 years ago
James Bardin	2e57d284cb	Merge pull request #15323 from hashicorp/jbardin/constraint-suggestion ... remove "~> 0.0" constraint suggestions	9 years ago
James Bardin	ec99b6910b	remove "~> 0.0" constraint suggestions ... Don't suggest constraints when the available plugin isn't versioned. Add zero version const for comparisons.	9 years ago
James Bardin	6faace287d	remove restriction on unversioned plugins ... Discover unversioned plugins regarless of location.	9 years ago
James Bardin	ba5b0dc609	mostly remove OS_ARCH knowledge from discovery ... Since the command package also needs to know about the specific OS_ARCH directories, remove the logic fom the discovery package. This doesn't completely remove the knowledge of the path from discovery, in order to maintain the current behavior of skipping legacy plugin names within a new-style path.	9 years ago
James Bardin	f723270e3e	search the vendor directory for plugins ... The default location for users to manually add plugins will be ./terraform.d/plugins/	9 years ago
Martin Atkins	af4c82d151	plugin/discovery: Installer.PurgeUnused method ... Given a map describing the chosen plugin for each provider name, this method should purge any other plugins present in the local cache directory.	9 years ago
Martin Atkins	f753974bb3	plugin/discovery: Installer interface, and provider implementation ... Previously we had a "getProvider" function type used to implement plugin fetching. Here we replace that with an interface type, initially with just a "Get" function. For now this just simplifies the interface by allowing the target directory and protocol version to be members of the struct rather than passed as arguments. A later change will extend this interface to also include a method to purge unused plugins, so that upgrading frequently doesn't leave behind a trail of unused executable files.	9 years ago
James Bardin	840978b2d5	udpate to plugin name convention ... Names are case-insensitive, using lowercase by default.	9 years ago
James Bardin	1b201e67ea	fix releases path and protocol header ... Last minute change to the location of the binaries	9 years ago
James Bardin	283ae0c7c4	fix comment and add some logging in discovery	9 years ago
James Bardin	ea3d9c86ba	sort constraints for consistent output	9 years ago
Martin Atkins	4ba20f9c1c	command init: show suggested constraints for unconstrained providers ... When running "terraform init" with providers that are unconstrained, we will now produce information to help the user update configuration to constrain for the particular providers that were chosen, to prevent inadvertently drifting onto a newer major release that might contain breaking changes. A ~> constraint is used here because pinning to a single specific version is expected to create dependency hell when using child modules. By using this constraint mode, which allows minor version upgrades, we avoid the need for users to constantly adjust version constraints across many modules, but make major version upgrades still be opt-in. Any constraint at all in the configuration will prevent the display of these suggestions, so users are free to use stronger or weaker constraints if desired, ignoring the recommendation.	9 years ago
James Bardin	dbbafbd43f	clean up plugin fetching ... We can filter the allowed versions and sort them before checking the protocol version, that way we can just return the first one found reducing network requests.	9 years ago
James Bardin	48d37131e0	more tests for fetching providers ... Extend the test reslease server to return the protocol version header and a dummy zip file for the provider. Test filtering the plugins by plugin protocol version and add a full GetProvder test.	9 years ago
James Bardin	5f053a2e64	refactor GetProvider ... Get provider needs to be provided with the plugin protocol version, because it can't be imported here directly. The plugin url types and methods were confusing; replace them with a few functions to format the urls.	9 years ago
James Bardin	8ad67991a5	check protocol version on plugins ... Verify that the plugin we're requesting has a compatible protocol version.	9 years ago
James Bardin	fdeb3d929c	Add Versions.Sort ... Sort versions from newest to oldest.	9 years ago
Martin Atkins	04bcece59c	plugin/discovery: handle the -Xn suffix used by auto-installed plugins ... This is used to mark the plugin protocol version. Currently we actually just ignore this entirely, since only one protocol version exists anyway. Later we will need to add checks here to ensure that we only pay attention to plugins of the right version.	9 years ago
Martin Atkins	e3401947a6	plugin/discovery: PluginRequirements can specify SHA256 digests ... As well as constraining plugins by version number, we also want to be able to pin plugins to use specific executables so that we can detect drift in available plugins between commands. This commit allows such requirements to be specified, but doesn't yet specify any such requirements, nor validate them.	9 years ago
James Bardin	044ad5ef59	rename some Constraints methods per code review	9 years ago
James Bardin	211f5b5d6e	add test for newestVersion	9 years ago
James Bardin	46190590cb	change []*Version to []Version ... Versions are used as values, so don't keep them as pointers here	9 years ago
James Bardin	a547e7c2f0	add releases version listing test	9 years ago
James Bardin	2749946f5c	basic plugin getter ... Add discovery.GetProviders to fetch plugins from the relases site. This is an early version, with no tests, that only (probably) fetches plugins from the default location. The URLs are still subject to change, and since there are no plugin releases, it doesn't work at all yet.	9 years ago
James Bardin	fa49c69793	expose Version.NewerThan ... NewerThan is useful outside of the package	9 years ago
James Bardin	7d2d951f27	Rename VersionSet to Constraints ... VersionSet is a wrapper around version.Contraints, so rename it it as such.	9 years ago
James Bardin	718ede0636	have Meta.Backend use a Config rather than loading ... Instead of providing the a path in BackendOpts, provide a loaded *config.Config instead. This reduces the number of places where configuration is loaded.	9 years ago
Martin Atkins	cfc08ae7e3	plugin/discovery: provide an AllVersions set ... Various implied dependencies will accept all versions, so this is convenient for populating dependency data structures for such implied dependencies.	9 years ago