40 Commits (f-exprstress)

Author	SHA1	Message	Date
Alisdair McDiarmid	7c0ec0107f	backend: Replace ShowDiagnostics with view.Diagnostics	5 years ago
Alisdair McDiarmid	68558ccd54	backend/local: Replace CLI with view instance ... This commit extracts the remaining UI logic from the local backend, and removes access to the direct CLI output. This is replaced with an instance of a `views.Operation` interface, which codifies the current requirements for the local backend to interact with the user. The exception to this at present is interactivity: approving a plan still depends on the `UIIn` field for the backend. This is out of scope for this commit and can be revisited separately, at which time the `UIOut` field can also be removed. Changes in support of this: - Some instances of direct error output have been replaced with diagnostics, most notably in the emergency state backup handler. This requires reformatting the error messages to allow the diagnostic renderer to line-wrap them; - The "in-automation" logic has moved out of the backend and into the view implementation; - The plan, apply, refresh, and import commands instantiate a view and set it on the `backend.Operation` struct, as these are the only code paths which call the `local.Operation()` method that requires it; - The show command requires the plan rendering code which is now in the views package, so there is a stub implementation of a `views.Show` interface there. Other refactoring work in support of migrating these commands to the common views code structure will come in follow-up PRs, at which point we will be able to remove the UI instances from the unit tests for those commands.	5 years ago
Alisdair McDiarmid	2d1976bbda	clistate: Update clistate.Locker for command views ... The clistate package includes a Locker interface which provides a simple way for the local backend to lock and unlock state, while providing feedback to the user if there is a delay while waiting for the lock. Prior to this commit, the backend was responsible for initializing the Locker, passing through direct access to the cli.Ui instance. This structure prevented commands from implementing different implementations of the state locker UI. In this commit, we: - Move the responsibility of creating the appropriate Locker to the source of the Operation; - Add the ability to set the context for a Locker via a WithContext method; - Replace the Locker's cli.Ui and Colorize members with a StateLocker view; - Implement views.StateLocker for human-readable UI; - Update the Locker interface to return detailed diagnostics instead of errors, reducing its direct interactions with UI; - Add a Timeout() method on Locker to allow the remote backend to continue to misuse the -lock-timeout flag to cancel pending runs. When an Operation is created, the StateLocker field must now be populated with an implementation of Locker. For situations where locking is disabled, this can be a no-op locker. This change has no significant effect on the operation of Terraform, with the exception of slightly different formatting of errors when state locking or unlocking fails.	5 years ago
Alisdair McDiarmid	536c80da23	backend: Add per-operation diagnostic rendering ... The enhanced backends (local and remote) need to be able to render diagnostics during operations. Prior to this commit, this functionality was supported with a per-backend `ShowDiagnostics` function pointer. In order to allow users of these backends to control how diagnostics are rendered, this commit moves that function pointer to the `Operation` type. This means that a diagnostic renderer is configured for each operation, rather than once per backend initialization. Some secondary consequences of this change: - The `ReportResult` method on the backend is now moved to the `Operation` type, as it needs to access the `ShowDiagnostics` callback (and nothing else from the backend); - Tests which assumed that diagnostics would be written to the backend's `cli.Ui` instance are migrated to using a new record/playback diags helper function; - Apply, plan, and refresh commands now pass a pointer to the `Meta` struct's `showDiagnostics` method. This commit should not change how Terraform works, and is refactoring in preparation for more changes which move UI code out of the backend.	5 years ago
Alisdair McDiarmid	eee57280f6	backend: Faster remote backend tests ... The remote backend tests spent most of their execution time sleeping in various polling and backoff waits. This is unnecessary when testing against a mock server, so reduce all of these delays when under test to much lower values. Only one remaining test has an artificial delay: verifying the discovery of services against an unknown hostname. This times out at DNS resolution, which is more difficult to fix than seems worth it at this time.	6 years ago
Kristin Laemmert	86e9ba3d65	* backend/local: push responsibility for unlocking state into individual operations ... * unlock the state if Context() has an error, exactly as backend/remote does today * terraform console and terraform import will exit before unlocking state in case of error in Context() * responsibility for unlocking state in the local backend is pushed down the stack, out of backend.go and into each individual state operation * add tests confirming that state is not locked after apply and plan * backend/local: add checks that the state is unlocked after operations This adds tests to plan, apply and refresh which validate that the state is unlocked after all operations, regardless of exit status. I've also added specific tests that force Context() to fail during each operation to verify that locking behavior specifically.	6 years ago
CJ Horton	e1dcae17b7	add sad path tests for the TFP API version check	6 years ago
Martin Atkins	8e1615a802	backend/remote: Handle cost estimation skipped due to targeting ... The remote server might choose to skip running cost estimation for a targeted plan, in which case we'll show a note about it in the UI and then move on, rather than returning an "invalid status" error. This new status isn't yet available in the go-tfe library as a constant, so for now we have the string directly in our switch statement. This is a pragmatic way to expedite getting the "critical path" of this feature in place without blocking on changes to ancillary codebases. A subsequent commit should switch this over to tfe.CostEstimateSkippedDueToTargeting once that's available in a go-tfe release.	6 years ago
Mike Nomitch	650a272a1d	Change message sent to remote backend if -target used	6 years ago
Martin Atkins	16f1f3b739	backend/remote: Support -target on plan and apply ... Previously we did not allow -target to be used with the remote backend because there was no way to send the targets to Terraform Cloud/Enterprise via the API. There is now an attribute in the request for creating a plan that allows us to send target addresses, so we'll remove that restriction and copy the given target addresses into the API request.	6 years ago
Paul Thrasher	d2eaffabea	vendor latest go-tfe ... Signed-off-by: Paul Thrasher <pthrasher@hashicorp.com>	7 years ago
Paul Thrasher	e2831b3d1e	tfce test additions ... Signed-off-by: Paul Thrasher <pthrasher@hashicorp.com>	7 years ago
Kristin Laemmert	412d459292	backend/remote: remove milseading contents from error message (#22148) ... Previously, terraform was returning a potentially-misleading error message in response to anything other than a 404 from the b.client.Workspaces.Read operation. This PR simplifies Terraform's error message with the intent of encouraging those who encounter it to focus on the error message returned from the tfe client. The added test is odd, and a bit hacky, and possibly overkill.	7 years ago
Kristin Laemmert	190ef537ec	backend/remote: notify users when uploading something other than cwd ... When a TFC workspace is configured without a VCS root, and with a working directory, and a user is running `terraform init` from that same directory, TFC uploads the entire configuration directory, not only the user's cwd. This is not obvious to the user, so we are adding a descriptive message explaining what is being uploaded, and why.	7 years ago
Kristin Laemmert	89eeaed0a0	[WIP] backend/enhanced: start with absolute configuration path (#22096) ... * backend/enhanced: start with absolute config path We recently started normalizing the config path before all "command" operations, which was necessary for consistency but had unexpected consequences for remote backend operations, specifically when a vcs root with a working directory are configured. This PR de-normalizes the path back to an absolute path. * Check the error and add a test It turned out all required logic was already present, so I just needed to add a test for this specific use case.	7 years ago
Radek Simko	5b9f2fafc8	Standardise directory name for test data	7 years ago
David Celis	5ccccfb91f	Remove pre-alpha cost estimation logic	7 years ago
Sander van Harmelen	bb12206bca	Fixup the tests	7 years ago
Paul Thrasher	c7a023a95c	update test for new go-tfe version ... Signed-off-by: Paul Thrasher <pthrasher@hashicorp.com>	7 years ago
Sander van Harmelen	01f17fa0ca	backend/remote: exit with 1 when a run is canceled	7 years ago
Sander van Harmelen	aefbec63b1	backend/remote: update the test logic	7 years ago
Sander van Harmelen	3b80f69eec	Merge pull request #20242 from hashicorp/svh/b-scanner-buffer-v0.12 ... backend/remote: fix bufio.Scanner: token too long	7 years ago
Sander van Harmelen	47a00ea34b	backend/remote: cleanup test connections ... Cleanup test connection to prevent file descriptor issues when running the tests on a Mac.	7 years ago
Sander van Harmelen	5249d0fe83	backend/remote: fix bufio.Scanner: token too long	7 years ago
Sander van Harmelen	e08a7e979e	backend/remote: use the correct test operation	8 years ago
Martin Atkins	0c0a437bcb	Move module install functionality over to internal/initwd	8 years ago
Sander van Harmelen	9062d887b8	backend/remote: use entitlements to select backends ... Use the entitlements to a) determine if the organization exists, and b) as a means to select which backend to use (the local backend with remote state, or the remote backend).	8 years ago
Sander van Harmelen	4561c80c1d	Also show policies when there are no changes ... This behavior was recently updated in the TFE UI, so lets follow that behavior here as well.	8 years ago
Sander van Harmelen	a17f317025	Change how to fall back from remote to local backend ... In order to support free organizations, we need a way to load the `remote` backend and then, depending on the used offering/plan, enable or disable remote operations. In other words, we should be able to dynamically fall back to the `local` backend if needed, after first configuring the `remote` backend. To make this works we need to change the way this was done previously when the env var `TF_FORCE_LOCAL_BACKEND` was set. The clear difference of course being that the env var would be available on startup, while the used offering/plan is only known after being able to connect to TFE.	8 years ago
Sander van Harmelen	52a1b22f7a	Implement the remote enhanced backend ... This is a refactored version of the `remote` backend that was initially added to Terraform v0.11.8 which should now be compatible with v0.12.0.	8 years ago
Martin Atkins	541952bb8f	Revert some work that happened since v0.12-dev branched ... This work was done against APIs that were already changed in the branch before work began, and so it doesn't apply to the v0.12 development work. To allow v0.12 to merge down to master, we'll revert this work out for now and then re-introduce equivalent functionality in later commits that works against the new APIs.	8 years ago
Sander van Harmelen	8875fa660f	Make sure we also output policies while planning	8 years ago
Sander van Harmelen	53a8aaaf85	Merge pull request #19022 from hashicorp/f-auto-apply ... backend/remote: properly handle workspaces that auto apply changes	8 years ago
Sander van Harmelen	194863db4e	Properly handle workspaces that auto apply changes ... This commit adds logic to check if a workspace is configured to auto apply changes. And if it does, we make sure we output all steps correctly.	8 years ago
Sander van Harmelen	b1fdbd7db8	Allow enhanced backends to pass custom exit codes ... In some cases this is needed to keep the UX clean and to make sure any remote exit codes are passed through to the local process. The most obvious example for this is when using the "remote" backend. This backend runs Terraform remotely and stream the output back to the local terminal. When an error occurs during the remote execution, all the needed error information will already be in the streamed output. So if we then return an error ourselves, users will get the same errors twice. By allowing the backend to specify the correct exit code, the UX remains the same while preserving the correct exit codes.	8 years ago
Sander van Harmelen	67db9da000	Add checks for all flags we currently don’t support ... For Plan only: -module-depth=n For Plan & Apply -parallelism=m -refresh=false -var “foo=bar” and -var-file=foo	8 years ago
Sander van Harmelen	ffc67a8e90	Prevent running plan or apply without permissions	8 years ago
Sander van Harmelen	53d322ec69	Test lock timeout errors when running a plan	8 years ago
Sander van Harmelen	3cfc83e335	backend/remote: take working directories into account ... In TFE you can configure a workspace to use a custom working directory. When determining which directory that needs to be uploaded to TFE, this working directory should be taken into account to make sure we are uploading the correct root directory for the workspace.	8 years ago
Sander van Harmelen	7fb2d1b8de	Implement the Enterprise enhanced remote backend	8 years ago