28005 Commits (f-debugger)

 

All Branches   

Search

Author	SHA1	Message	Date
Alisdair McDiarmid	a43b035a51	core: Reduce string allocations for addrs Equal ... Generating strings and comparing them to implement Equal is a quick and easy solution. Unfortunately when this code is in the hot path, it becomes very expensive, so this commit changes some of those instances to compare the values directly. Combined with using addr.Equal instead of checking for string equality, this makes Terraform dramatically faster for some operations, such as generating large JSON plans.	5 years ago
Alisdair McDiarmid	3d8b43dfe7	Merge pull request #27944 from hashicorp/alisdair/fix-missing-source-in-diags ... views: Fix missing source in diagnostic output	5 years ago
Alisdair McDiarmid	66f8d1c1c2	functions: Fix defaults mismatched types fallback ... We allow primitive fallback values which have mismatched types, but only if there is a conversion to the target type. Previously we would allow unsafe conversions (e.g. string to bool), but later had no capacity to return an error if the conversion failed due to the value of the fallback being unable to convert to the target type. This commit makes the more conservative requirement that default fallback values must have a safe conversion.	5 years ago
Alisdair McDiarmid	178a9b32d7	functions: Fix defaults null collections panic ... When applying default values to collection types, null collections in the input should result in empty collections in the output.	5 years ago
Omar Ismail	e9c7f37b8c	Enable --auto-approve for Policy checks on Remote Backend (Terraform Cloud) (#27804) ... * Fix auto-approve for soft-policy * Update error handling * update testing string for consistency	5 years ago
Alisdair McDiarmid	86495f93cb	views: Fix missing source in diagnostic output ... The previous implementation of views was copying and embedding the base View struct in each individual view. While this allowed for easy access to the interface of that struct (both in the view and externally), it more importantly completely broke the ability of the diagnostic printer to output source code snippets. This is because the `configSources` field on the base view is lazily set after the config loader is initialized. In the commands ported to use views, this happens after the base View struct is copied, so we are updating the wrong copy of the struct. This commit fixes this with a simple mechanical refactor: keep a pointer to the base View struct instead, and update all of the individual views to explicitly refer to that struct to access its fields and methods. This is not a particularly satisfying solution, but I can't find anything clearly better. It might be worth exploring the alternative approach in the view for the new test command, which explicitly pulls its dependencies out of the base view, rather than retaining a full reference. Maybe there's a third way which is better still.	5 years ago
Martin Atkins	b5adc33075	configs: Accept and minimally validate a "language" argument ... We expect that in order to continue to evolve the language without breaking existing modules we will at some point need to have a way to mark when a particular module is expecting a newer interpretation of the language. Although it's too early to do any deep preparation for that, this commit aims to proactively reserve an argument named "language" inside "terraform" blocks, which currently only accepts the keyword TF2021 that is intended to represent "the edition of the Terraform language as defined in 2021". That argument also defaults to TF2021 if not set, so in practice there's no real reason to set this today, but this minimal validation today is intended to give better feedback to users of older Terraform versions in the event that we introduce a new language edition later and they try to use an module incompatible with their Terraform version.	5 years ago
Martin Atkins	54cc4dadf6	configs: A better error message for custom variable validation ... Our previous message conflated the requirement for a full sentence with the suggestion to write in a style similar to Terraform's built-in error messages, which created a sense that the system would actively reject an error message written in another language. There's no intent here to block writing error messages in other languages, but there is a practical consideration that Terraform's UI output is currently not localized and so consistency with Terraform's other output, if that's important to a module author, will typically mean writing the error message in English.	5 years ago
Aaron Lane	f172585eaa	Fix Kitchen-Terraform language in test experiment ... This isn't incredibly important, but Kitchen-Terraform is written in and requires tests to be written in Ruby.	5 years ago
Alisdair McDiarmid	37fff9336a	Merge pull request #27929 from hashicorp/alisdair/command-views-cleanup ... Some command views cleanup	5 years ago
Alisdair McDiarmid	7c0ec0107f	backend: Replace ShowDiagnostics with view.Diagnostics	5 years ago
James Bardin	1a71cdc132	Merge pull request #27926 from hashicorp/jbardin/apply-plan-config ... check errors before using configSnap	5 years ago
James Bardin	936f597ba1	check errors before using configSnap ... configSnap may be nil if there are errors loading it from the plan file.	5 years ago
Alisdair McDiarmid	3737ee5081	views: Remove outdated comment	5 years ago
Kristin Laemmert	c99d02f326	update arch docs; remove old EvalNode references (#27900) ... * update arch docs; remove old EvalNode and EvalTree references	5 years ago
James Bardin	a0ca99201c	Merge pull request #27918 from hashicorp/jbardin/go-version ... Revert "match terraform-releases expectations"	5 years ago
James Bardin	9ea805f480	Revert "match terraform-releases expectations" ... This reverts commit 270de49ef5.	5 years ago
James Bardin	55fb442578	Merge pull request #27913 from hashicorp/jbardin/go-version ... match terraform-releases expectations	5 years ago
James Bardin	270de49ef5	match terraform-releases expectations	5 years ago
Kristin Laemmert	106bcd3bf0	update to match new default branch name (#27909)	5 years ago
James Bardin	2b252ac677	Merge pull request #27910 from hashicorp/jbardin/remote-provisioners ... remote provisioners require a connection config	5 years ago
James Bardin	47a682141a	remote provisioners require a connection config	5 years ago
Martin Atkins	45b795b3fd	Update CHANGELOG.md	5 years ago
Alisdair McDiarmid	6697245c18	Update CHANGELOG.md	5 years ago
James Bardin	8c9083d880	Merge pull request #27903 from hashicorp/jbardin/plan-valid-computed ... objchange: catch invalidly planned attributes earlier	5 years ago
Alisdair McDiarmid	326583bb6e	Merge pull request #27906 from hashicorp/alisdair/remove-var-args-from-validate ... cli: Remove -var/-var-file flags from validate	5 years ago
James Bardin	b735d80f1f	website: Provider configuration notes for the v0.15 upgrade guide	5 years ago
Martin Atkins	9508ff2630	website: Terraform v0.15 upgrade guide first draft ... As usual, we'll continue to iterate on this based on feedback and questions during the beta period, but this is a first draft intended to help those who are trying out the first beta.	5 years ago
Alisdair McDiarmid	4271b0e11d	cli: Remove -var/-var-file flags from validate ... These flags are not used and have been deprecated since 0.12.11.	5 years ago
Kristin Laemmert	e5a7586559	moduletest: update provider to match recent provider interface changes (#27904) ... this fixes a bad merge on my part	5 years ago
James Bardin	cd7fb9bd5a	catch invalidly planned attributes earlier ... Catch attributes which are planed but not computed separately to provide a clearer error to provider developers. The error conditions were previously caught, however it was unclear from the error text as to _why_ the change was an error. The statements about value inequality would be incorrect when planning no changes for a value which should not have been set in the first place.	5 years ago
Kristin Laemmert	ff05362d51	providers.Interface: rename ValidateDataSourceConfig to ValidateDataResourceConfig (#27874) ... * providers.Interface: rename ValidateDataSourceConfig to ValidateDataResourceConfig This PR came about after renaming ValidateResourceTypeConfig to ValidateResourceConfig: I now understand that we'd called it the former instead of the latter to indicate that the function wasn't necessarily operating on a resource that actually exists. A possibly-more-accurate renaming of both functions might then be ValidateManagedResourceConfig and ValidateDataResourceConfig. The next commit will update the protocol (v6 only) as well; these are in separate commits for reviewers and will get squashed together before merging. * extend renaming to protov6	5 years ago
Antoine Cotten	21d881d4d1	Update "Terraform Core Architecture Summary" doc (#27897) ... * Update Godoc links from godoc.org to pkg.go.dev * Update reference to renamed GraphNodeResource interface Ref hashicorp/terraform#24389 * Update dead links; minor formatting adjustments * Add FIXME item following deprecation of EvalNode	5 years ago
Alisdair McDiarmid	7a03c3153e	Merge pull request #27861 from hashicorp/alisdair/help-global-options ... cli: Add reference to global options to help text	5 years ago
Alisdair McDiarmid	79f855b83b	Merge pull request #27840 from OJFord/docs-27554 ... Document `inline` & `on_failure` behaviour	5 years ago
Rachel Sharp	3cb4918739	Merge pull request #27862 from hashicorp/add-state-learn-tutorial ... Add State Learn tutorial to State docs	5 years ago
Martin Atkins	7597f4791e	Update CHANGELOG.md	5 years ago
James Bardin	c103242bef	Merge pull request #27885 from hashicorp/jbardin/show-json ... jsonstate: indicate schema version mismatch during encoding	5 years ago
Martin Atkins	5f3fb00af5	config: Use Unicode 13 rules for string manipulation ... Although we don't typically do configuration-level string wrangling directly in Terraform, we delegate to several other upstream libraries that do. These upgrades all switch to newer versions that support the latest definitions from Unicode 13, primarily affecting operations such as converting strings to upper/lowercase or splitting strings into component characters (substr, reverse, etc). The tests for the upstream libraries didn't show any regressions from these updates, so the Unicode 13 changes seem to be backward-compatible additions rather than significant breaking changes. (Our go.mod file had also become non-canonical in some ways, and the Go toolchain fixed that as part of this work, causing a few extra style-only diffs here that shouldn't cause any change in behavior.)	5 years ago
Martin Atkins	e3abe9020d	build: Terraform is now built with Go 1.16	5 years ago
James Bardin	c7995b7d4b	update show -json docs	5 years ago
James Bardin	160020a1e1	Merge pull request #27824 from hashicorp/jbardin/proxy-providers ... Provider transformer cleanup	5 years ago
James Bardin	3449a8aa35	don't marshal state with the wrong schema ... Instead of returning an error with no context about unexpected attributes or incorrect types, notify users that the schema stored in the state does not match the current provider. User can only encounter this error if the providers have updated their schemas since the state was stored. This would appears when running `terraform show -json` to display the current state, or `terraform show -json planfile` if that plan was created with `-refresh=false`. In either case, the state must be refreshed in order to properly json encoded.	5 years ago
Alisdair McDiarmid	bf712e55cf	Merge pull request #27864 from hashicorp/alisdair/command-views-plan ... cli: Migrate plan to command views	5 years ago
Alisdair McDiarmid	b7f54b30d5	cli: Fix overly broad auto-approve argument ... The auto-approve argument was part of the arguments.Operation type, which resulted in adding a silent -auto-approve flag to plan and refresh. This was unintended, and is fixed in this commit by moving the flag to the arguments.Apply type and updating the downstream callers.	5 years ago
Alisdair McDiarmid	8d9a08e3a1	cli: Migrate plan to command views	5 years ago
Alisdair McDiarmid	eeb5dfbf76	Merge pull request #27865 from hashicorp/alisdair/command-views-refresh ... cli: Migrate refresh to command views	5 years ago
Martin Atkins	62b4d7b92c	Update CHANGELOG.md	5 years ago
Martin Atkins	8d37a70987	website: Initial docs for the module integration testing experiment ... Since this is still at an early phase and likely to change significantly in future iterations, rather than attempting to guess on a suitable final location for documenting the testing feature I've instead taken the unusual approach of adding a new page that is explicitly about the experiment. My expectation is that once we conclude the experiment we'll replace this new page with a stub that just explains that there was once an experiment and then links to whatever final feature unfolded from the research. The URL for this page is hard-coded into the warning message in the "terraform test" command, so as we continue to evolve this feature in future releases we'll need to update the callout note on the page about which Terraform CLI version it's currently talking about, so users of older versions can clearly see when they'd need to upgrade in order to participate in a later incarnation of the experiment.	5 years ago
Martin Atkins	7f78342953	command: Experimental "terraform test" command ... This is just a prototype to gather some feedback in our ongoing research on integration testing of Terraform modules. The hope is that by having a command integrated into Terraform itself it'll be easier for interested module authors to give it a try, and also easier for us to iterate quickly based on feedback without having to coordinate across multiple codebases. Everything about this is subject to change even in future patch releases. Since it's a CLI command rather than a configuration language feature it's not using the language experiments mechanism, but generates a warning similar to the one language experiments generate in order to be clear that backward compatibility is not guaranteed.	5 years ago