57 Commits (f-debugger)

Author	SHA1	Message	Date
James Bardin	47a682141a	remote provisioners require a connection config	5 years ago
James Bardin	ff30030e4f	builtin provisioners are re-used and not Closed	5 years ago
James Bardin	026ba5b013	ensure context cancel is never nil ... The context used for Stop is more appropriately tied to the lifetime of the provisioner rather than a call to the ProvisionResource method. In some cases Stop can be called before ProvisionResource, causing a panic the provisioner. Rather than adding nil checks to the CancelFunc call for Stop, create a base context to use for cancellation with both Stop and Close methods.	5 years ago
James Bardin	313d3e5c4d	builtin/provisioners/remote-exec: staticcheck	6 years ago
James Bardin	1ec8d921d4	rewrite remote-exec as an internal provisioner	6 years ago
James Bardin	01ac480a58	update provisioners to use legacy types	6 years ago
Alex Pilon	83aa07f907	prune NewResourceConfig and update tests	7 years ago
Radek Simko	5b9f2fafc8	Standardise directory name for test data	7 years ago
James Bardin	e9e4ee4940	Merge pull request #17609 from hashicorp/jbardin/remote-command ... clean up remote.Cmd api	8 years ago
James Bardin	ad8642e2c2	have remote.ExitError format errors and status ... Since all use cases of ExitStatus are just putting it into fmt.Errorf, usually with the command string, have ExitStatus do that for the caller.	8 years ago
James Bardin	56acda00bc	add timeout test to remote-exec ... Add a test to remote-exec to make sure the proper timeout is honored during apply. TODO: we need some test helpers for provisioners, so they can all be verified.	8 years ago
James Bardin	9b4b5f2a72	use correct context for communicator.Retry ... The timeout for a provisioner is expected to only apply to the initial connection. Keep the context for the communicator.Retry separate from the global cancellation context.	8 years ago
James Bardin	3fbdee0777	clean up remote.Cmd api ... Combine the ExitStatus and Err values from remote.Cmd into an error returned by Wait, better matching the behavior of the os/exec package. Non-zero exit codes are returned from Wait as a remote.ExitError. Communicator related errors are returned directly. Clean up all the error handling in the provisioners using a communicator. Also remove the extra copyOutput synchronization that was copied from package to package.	8 years ago
James Bardin	af132a186d	remove timeout from remote-exec command context ... The timeout for the remote command was taken from the wrong config field, and the connection timeout was being used which is 5 min. Any remote command taking more than 5 min would be terminated by disconnecting the communicator. Remove the timeout from the context, and rely on the global timeout provided by terraform. There was no way to get the error from the communicator previously, so the broken connection was silently ignored and the provisioner returned successfully. Now we can use the new cmd.Err() method to retrieve any errors encountered during execution.	8 years ago
James Bardin	0345d960b2	simplify remote-exec runScripts ... There no reason to retry around the execution of remote scripts. We've already established a connection, so the only that could happen here is to continually retry uploading or executing a script that can't succeed. This also simplifies the streaming output from the command, which doesn't need such explicit synchronization. Closing the output pipes is sufficient to stop the copyOutput functions, and they don't close around any values that are accessed again after the command executes.	8 years ago
James Bardin	c1b35ad69b	have the ssh communicator return fatal errors ... This will let the retry loop abort when there are errors which aren't going to ever be corrected.	8 years ago
James Bardin	f5b8091e2c	remove retryFunc ... It's now in the communicator package	8 years ago
James Bardin	db42015342	backoff retries in remote-exec provisioner ... Add a simple backoff to the remote-exec retryFunc. Backoff between tries, up to a 10s max.	9 years ago
Sander van Harmelen	0e422737ba	Fix and refactor the Chef provisioner ... The tests did pass, but that was because they only tested part of the changes. By using the `schema.TestResourceDataRaw` function the schema and config are better tested and so they pointed out a problem with the schema of the Chef provisioner. The `Elem` fields did not have a `*schema.Schema` but a `schema.Schema` and in an `Elem` schema only the `Type` field may (and must) be set. Any other fields like `Optional` are not allowed here. Next to fixing that problem I also did a little refactoring and cleaning up. Mainly making the `ProvisionerS` private (`provisioner`) and removing the deprecated fields.	9 years ago
Vladislav Rassokhin	f5449a62e0	Various built-in provisioners improvements: ... 1. Migrate `chef` provisioner to `schema.Provisioner`: * `chef.Provisioner` structure was renamed to `ProvisionerS`and now it's decoded from `schema.ResourceData` instead of `terraform.ResourceConfig` using simple copy-paste-based solution; * Added simple schema without any validation yet. 2. Support `ValidateFunc` validate function : implemented in `file` and `chef` provisioners.	9 years ago
Jake Champlin	7e5eeb2268	provisioner/remote-exec: Fix panic from remote_exec provisioner ... Fixes panic on `nil` values of `inline` and `scripts` from improper interface casts. Fixes: #13970	9 years ago
James Bardin	197f6cab79	Cannot store multiple types in atomic.Value ... Storing error values to atomic.Value may fail if they have different dynamic types. Wrap error value in a consistent struct type to avoid panics. Make sure we return a nil error on success	9 years ago
Mitchell Hashimoto	640faf18c3	Revert "provisioner/remote-exec: fail on first inline script with bad exit code (#11155)" ... This reverts commit d2047d714e.	9 years ago
Mitchell Hashimoto	142df657c3	provisioners/remote-exec: listen to Stop	9 years ago
Mitchell Hashimoto	487a37b0dd	helper/schema: PromoteSingle for legacy support of "maybe list" types	9 years ago
Mitchell Hashimoto	3c0c81957a	provisioners/remote-exec: switch to helper/schema	9 years ago
Peter McAtominey	d2047d714e	provisioner/remote-exec: fail on first inline script with bad exit code (#11155) ... The provisioner collected all inline commands into a single script which meant only the exit code of the last command was actually checked for an error.	9 years ago
Mitchell Hashimoto	4b1d9cfd7d	communicator/ssh: don't share rand object to guarantee unique values ... Fixes #10463 I'm really surprised this flew under the radar for years... By having unique PRNGs, the SSH communicator could and would generate identical ScriptPaths and two provisioners running in parallel could overwrite each other and execute the same script. This would happen because they're both seeded by the current time which could potentially be identical if done in parallel... Instead, we share the rand now so that the sequence is guaranteed unique. As an extra measure of robustness, we also multiple by the PID so that we're also protected against two processes at the same time.	10 years ago
Paul Hinze	579680cebc	provisioner/remote-exec: Move script cleanup after command wait ... The script cleanup step added in #5577 was positioned before the `cmd.Wait()` call to ensure the command completes. This was causing non-deterministic failures, especially for longer running scripts. Fixes #5699 Fixes #5737	10 years ago
Paul Hinze	96ebf0af0e	provisioner/remote-exec: Clear out scripts after uploading ... Prevents residual script contents from remaining on machine. Fixes #482	10 years ago
Sam Boyer	b82bd0c280	Condense switch fallthroughs into expr lists	11 years ago
Sander van Harmelen	41748003c0	Updated the PR according to the review comments ... * We now return an error when you set the script_path to C:\Windows\Temp explaining this is currently not supported * The fix in PR #1588 is converted to the updated setup in this PR including the unit tests Last thing to do is add a few tests for the WinRM communicator…	11 years ago
Sander van Harmelen	b1c6a3f63f	Few small fixes to make the last tests also pass ... The reason why the shebang is removed from these tests, is because the shebang is only needed for SSH/Linux connections. So in the new setup the shebang line is added in the SSH communicator instead of in the resource provisioner itself…	11 years ago
Sander van Harmelen	c9e9e374bb	Adding some abstractions for the communicators ... This is needed as preperation for adding WinRM support. There is still one error in the tests which needs another look, but other than that it seems like were now ready to start working on the WinRM part…	11 years ago
Mitchell Hashimoto	de8666a5fa	helper/ssh: add random number to script [GH-1545]	11 years ago
Tarrant	05407296c6	Add cleanup function to close SSHAgent	11 years ago
Tarrant	164f303da4	Add SSH Agent support	11 years ago
Mitchell Hashimoto	539eca5ee6	Fix failing tests	12 years ago
Mitchell Hashimoto	a154520ce8	provisioners/remote-exec: output	12 years ago
Mitchell Hashimoto	e5868ebdd9	provisioners/*: new interface	12 years ago
Mitchell Hashimoto	c452579512	provisioners/*: compiling, tests passing	12 years ago
bdd	4a53f38d3a	Update resource_provisioner.go ... Better variable name.	12 years ago
bdd	b2ff49be2e	More descriptive variable names for pipes.	12 years ago
bdd	6da9a2d49d	Use scanner instead of buffer read line ... Supported in Go 1.1 http://golang.org/pkg/bufio/#Scanner	12 years ago
Alex Gaynor	46154ca1d3	Fixed a ton of typos in docs and comments	12 years ago
Mitchell Hashimoto	8720d2465e	builtin/provisioners/*: new API	12 years ago
Armon Dadgar	b84814539f	Refactor shared SSH setup code	12 years ago
Armon Dadgar	2c3e619960	Removing unused constants	12 years ago
Armon Dadgar	8691a3ce91	Refactor helper methods out of provisioner	12 years ago
Armon Dadgar	104b28e19e	terraform: Remove ResourceConnectionInfo, use raw map	12 years ago