12 Commits (f-debugger)

Author	SHA1	Message	Date
Kristin Laemmert	6621501ae3	state: remove deprecated state package (#25490) ... Most of the state package has been deprecated by the states package. This PR replaces all the references to the old state package that can be done simply - the low-hanging fruit. * states: move state.Locker to statemgr The state.Locker interface was a wrapper around a statemgr.Full, so moving this was relatively straightforward. * command: remove unnecessary use of state package for writing local terraform state files * move state.LocalState into terraform package state.LocalState is responsible for managing terraform.States, so it made sense (to me) to move it into the terraform package. * slight change of heart: move state.LocalState into clistate instead of terraform	6 years ago
Justin Downing	1e32ae243c	grammatical updates to comments and docs (#20195)	7 years ago
Martin Atkins	aaf405b662	backend/remote-state: Get all the backend tests building again ... The state manager refactoring in an earlier commit was reflected in the implementations of these backends, but not in their tests. This gets us back to a state where the backend tests will compile, and gets _most_ of them passing again, with a few exceptions that will be addressed in a subsequent commit.	8 years ago
Martin Atkins	5782357c28	backend: Update interface and implementations for new config loader ... The new config loader requires some steps to happen in a different order, particularly in regard to knowing the schema in order to decode the configuration. Here we lean directly on the configschema package, rather than on helper/schema.Backend as before, because it's generally sufficient for our needs here and this prepares us for the helper/schema package later moving out into its own repository to seed a "plugin SDK".	8 years ago
James Bardin	6b700ff1fb	replace lock_table with dynamodb_table in s3 cfg ... Since the DynamoDB table used by the S3 backend is no longer only used for locks, rename it in the config to remove any confusion about it being lock-specific.	9 years ago
James Bardin	e7502454b4	check for nil state in s3 client Get ... The S3 client can return (nil, nil) when the remote state doesn't exist. The caused a nil pointer dereference when checking the payload.MD5 against the expected value. This can happen if the remote state was manually removed, but the digest entry was left in the DynamoDB table.	9 years ago
James Bardin	ef1d53934c	Merge pull request #14746 from hashicorp/jbardin/s3-consistency ... store and verify s3 remote state checksum to avoid consistency issues.	9 years ago
James Bardin	91be40a577	add detailed error message s3 checksum mismatch ... Have the s3 RemoteClient return a detailed error message to the user in the case of a mismatch state checksum.	9 years ago
James Bardin	0022d224e8	store and verify s3 remote state checksum ... Updates to objects in S3 are only eventually consistent. If the RemoteClient has a DynamoDB table available, use that to store a checksum of the last written state, so the object can be verified by the next client to call Get. Terraform currently doesn't have any sort of user feedback around RefreshState/Get, so we poll only for a short time before returning an error.	9 years ago
James Bardin	a2d452acec	failing test to force-unlock a named state in s3 ... The State call attempts to get a lock before determining if a named state exists. This prevents force-unlock, since we need the state to call Unlock.	9 years ago
James Bardin	4980fa20e7	move s3 config from client to backend ... The RemoteClient needs to be configured for the named state, so move the general config to the backend. Rename some fields for consistency.	9 years ago
James Bardin	9f5cf2b105	convert S3 remote state to a backend ... Move the S3 State from a legacy remote state to an official backend. This increases test coverage, uses a set schema for configuration, and will allow new backend features to be implemented for the S3 state, e.g. "environments".	9 years ago