16 Commits (f-debugger)

Author	SHA1	Message	Date
Kristin Laemmert	6621501ae3	state: remove deprecated state package (#25490) ... Most of the state package has been deprecated by the states package. This PR replaces all the references to the old state package that can be done simply - the low-hanging fruit. * states: move state.Locker to statemgr The state.Locker interface was a wrapper around a statemgr.Full, so moving this was relatively straightforward. * command: remove unnecessary use of state package for writing local terraform state files * move state.LocalState into terraform package state.LocalState is responsible for managing terraform.States, so it made sense (to me) to move it into the terraform package. * slight change of heart: move state.LocalState into clistate instead of terraform	6 years ago
James Bardin	10d94fb764	Merge pull request #21967 from williams-brian/SSE-C_Remote_State ... Add support for SSE-C to S3 backend	7 years ago
Brian Williams	5e3c3bafb8	Add support for SSE-C to S3 backend ... These changes add support for encrypting terraform remote-state in S3 using customer-supplied encryption keys (SSE-C).	7 years ago
hasheddan	961d43142c	s3 backend: minor typo in putMD5 comment ... Signed-off-by: hasheddan <georgedanielmangum@gmail.com>	7 years ago
Brian Flad	ed37d07632	backend/s3: Configure AWS Client MaxRetries and provide enhanced S3 NoSuchBucket error message ... The AWS Go SDK automatically provides a default request retryer with exponential backoff that is invoked via setting `MaxRetries` or leaving it `nil` will default to 3. The terraform-aws-provider `config.Client()` sets `MaxRetries` to 0 unless explicitly configured above 0. Previously, we were not overriding this behavior by setting the configuration and therefore not invoking the default request retryer. The default retryer already handles HTTP error codes above 500, including S3's InternalError response, so the extraneous handling can be removed. This will also start automatically retrying many additional cases, such as temporary networking issues or other retryable AWS service responses. Changes: * s3/backend: Add `max_retries` argument * s3/backend: Enhance S3 NoSuchBucket error to include additional information	8 years ago
Masayuki Morita	f440dba137	Standardize on log level "WARN" rather than "WARNING"	9 years ago
James Bardin	b040cd0837	dynamoDB reads are not fully consisten by default ... Use fully consistent reads for backend operations.	9 years ago
James Bardin	611b1ced59	retry on s3 state upload errors ... While #16243 added the ability to retry getting a state from S3, Put can return the same InternalError status. Use the same retry logic when uploading state to S3.	9 years ago
bclodius	fba02f0bea	retry on s3 backend internal errors ... Internal errors from S3 are usually transient, and can be immediately retried. Make 2 attempts at retreiving the state object before returning an error.	9 years ago
James Bardin	6b700ff1fb	replace lock_table with dynamodb_table in s3 cfg ... Since the DynamoDB table used by the S3 backend is no longer only used for locks, rename it in the config to remove any confusion about it being lock-specific.	9 years ago
James Bardin	e7502454b4	check for nil state in s3 client Get ... The S3 client can return (nil, nil) when the remote state doesn't exist. The caused a nil pointer dereference when checking the payload.MD5 against the expected value. This can happen if the remote state was manually removed, but the digest entry was left in the DynamoDB table.	9 years ago
James Bardin	91be40a577	add detailed error message s3 checksum mismatch ... Have the s3 RemoteClient return a detailed error message to the user in the case of a mismatch state checksum.	9 years ago
James Bardin	0022d224e8	store and verify s3 remote state checksum ... Updates to objects in S3 are only eventually consistent. If the RemoteClient has a DynamoDB table available, use that to store a checksum of the last written state, so the object can be verified by the next client to call Get. Terraform currently doesn't have any sort of user feedback around RefreshState/Get, so we poll only for a short time before returning an error.	9 years ago
James Bardin	54aa466b74	initialize the s3 lock path in one place	9 years ago
James Bardin	4980fa20e7	move s3 config from client to backend ... The RemoteClient needs to be configured for the named state, so move the general config to the backend. Rename some fields for consistency.	9 years ago
James Bardin	9f5cf2b105	convert S3 remote state to a backend ... Move the S3 State from a legacy remote state to an official backend. This increases test coverage, uses a set schema for configuration, and will allow new backend features to be implemented for the S3 state, e.g. "environments".	9 years ago