725 Commits (f-debugger)

Author	SHA1	Message	Date
James Bardin	2e3aa96988	Merge pull request #28099 from jasons42/duplicate-default-workspace ... Fix duplicate default state	5 years ago
James Bardin	439bf9a96d	Merge pull request #28097 from jasons42/etcdv3-acceptance-tests ... Fix type conversion panic	5 years ago
James Bardin	1338502c7b	Merge pull request #26924 from remilapeyre/concurrent-locks-pg ... Use a global sequence to create the IDs for each workspace	5 years ago
Jason Smith	188ea61a12	Fix duplicate default state ... The default state is already explicitly added to the result slice. Added a guard to prevent it being added a second time. Fixes https://github.com/hashicorp/terraform/issues/28098	5 years ago
Jason Smith	3e8ebd6f40	Fix type conversion panic ... etcdv3 acceptance tests fail due to attempting to pass slices of strings for the endpoints config to HCL2ValueFromConfigValue() which does not handle that type. Not a pretty solution but a helper function that converts the endpoints to a slice of empty interfaces satisfies the requirements of the HCL2ValueFromConfigValue function. fixes https://github.com/hashicorp/terraform/issues/28096	5 years ago
Alisdair McDiarmid	4b159416ff	backend/remote: Fix new workspace state migration ... When migrating state to a new workspace, the version check would error due to a 404 error on fetching the workspace record. This would result in failed state migration. Instead we should look specifically for a 404 error, and allow migration to continue. If we're just about to create the workspace, there can't be a version incompatibility problem.	5 years ago
Omar Ismail	e9c7f37b8c	Enable --auto-approve for Policy checks on Remote Backend (Terraform Cloud) (#27804) ... * Fix auto-approve for soft-policy * Update error handling * update testing string for consistency	5 years ago
Alisdair McDiarmid	37fff9336a	Merge pull request #27929 from hashicorp/alisdair/command-views-cleanup ... Some command views cleanup	5 years ago
Alisdair McDiarmid	7c0ec0107f	backend: Replace ShowDiagnostics with view.Diagnostics	5 years ago
James Bardin	936f597ba1	check errors before using configSnap ... configSnap may be nil if there are errors loading it from the plan file.	5 years ago
Alisdair McDiarmid	02eb283ad4	backend/remote: Fix broken state lock retry ... When using the -lock-timeout option with the remote backend configured in local operations mode, Terraform would fail to retry acquiring the lock. This was caused by the lock error message having a missing Info field, which the state manager requires to be present in order to attempt retries.	5 years ago
Alisdair McDiarmid	68558ccd54	backend/local: Replace CLI with view instance ... This commit extracts the remaining UI logic from the local backend, and removes access to the direct CLI output. This is replaced with an instance of a `views.Operation` interface, which codifies the current requirements for the local backend to interact with the user. The exception to this at present is interactivity: approving a plan still depends on the `UIIn` field for the backend. This is out of scope for this commit and can be revisited separately, at which time the `UIOut` field can also be removed. Changes in support of this: - Some instances of direct error output have been replaced with diagnostics, most notably in the emergency state backup handler. This requires reformatting the error messages to allow the diagnostic renderer to line-wrap them; - The "in-automation" logic has moved out of the backend and into the view implementation; - The plan, apply, refresh, and import commands instantiate a view and set it on the `backend.Operation` struct, as these are the only code paths which call the `local.Operation()` method that requires it; - The show command requires the plan rendering code which is now in the views package, so there is a stub implementation of a `views.Show` interface there. Other refactoring work in support of migrating these commands to the common views code structure will come in follow-up PRs, at which point we will be able to remove the UI instances from the unit tests for those commands.	5 years ago
Pam Selle	8d2fbd4cd8	Remove deprecation on undeclared variable, docs, and summary adjustment (#27795) ... * Remove deprecation on undeclared variable Remove deprecation and add docs specific to the behavior around undeclared variable values * Limit full warnings to 2 instances, then summary This way, the third warning is a summary, rather than the fourth warning being the summary	5 years ago
Kristin Laemmert	f6505870cc	Mildwonkey/providers interface renaming (#27805) ... * providers.Interface: huge renamification This commit renames a handful of functions in the providers.Interface to match changes made in protocol v6. The following commit implements this change across the rest of the codebase; I put this in a separate commit for ease of reviewing and will squash these together when merging. One noteworthy detail: protocol v6 removes the config from the ValidateProviderConfigResponse, since it's never been used. I chose to leave that in place in the interface until we deprecate support for protocol v5 entirely. Note that none of these changes impact current providers using protocol v5; the protocol is unchanged. Only the translation layer between the proto and terraform have changed.	5 years ago
Matthew Frahry	85b9bdea96	backend/azure: azure state refreshes outside of grabbing the lock #26561	5 years ago
James Bardin	b0094dbf36	Merge pull request #27678 from GreenHedgehog/master ... Fix possible nil pointer dereference in azure sdk	5 years ago
Matthew Frahry	81dc028689	backend/azurerm: updating the dependencies for the Azure Backend #26721	5 years ago
Alisdair McDiarmid	6375c6ce6b	Merge pull request #27787 from hashicorp/alisdair/command-views-state-locker ... clistate: Update clistate.Locker for command views	5 years ago
Alisdair McDiarmid	1ae3d30383	Merge pull request #27760 from hashicorp/alisdair/command-views-ui-hook ... cli: Migrate Terraform UI hook to command views	5 years ago
Alisdair McDiarmid	3257f31aa7	backend/local: Return diag for refresh empty state ... The warning diag added when refreshing an empty state file was never rendered, and instead a custom (and incorrect) warning was output to the UI. This commit fixes the dropped diag and removes the custom warning.	5 years ago
Alisdair McDiarmid	2d1976bbda	clistate: Update clistate.Locker for command views ... The clistate package includes a Locker interface which provides a simple way for the local backend to lock and unlock state, while providing feedback to the user if there is a delay while waiting for the lock. Prior to this commit, the backend was responsible for initializing the Locker, passing through direct access to the cli.Ui instance. This structure prevented commands from implementing different implementations of the state locker UI. In this commit, we: - Move the responsibility of creating the appropriate Locker to the source of the Operation; - Add the ability to set the context for a Locker via a WithContext method; - Replace the Locker's cli.Ui and Colorize members with a StateLocker view; - Implement views.StateLocker for human-readable UI; - Update the Locker interface to return detailed diagnostics instead of errors, reducing its direct interactions with UI; - Add a Timeout() method on Locker to allow the remote backend to continue to misuse the -lock-timeout flag to cancel pending runs. When an Operation is created, the StateLocker field must now be populated with an implementation of Locker. For situations where locking is disabled, this can be a no-op locker. This change has no significant effect on the operation of Terraform, with the exception of slightly different formatting of errors when state locking or unlocking fails.	5 years ago
Alisdair McDiarmid	a7b7cd29fc	cli: Migrate Terraform UI hook to command views ... Move the code which renders Terraform hook callbacks as UI into the views package, backed by a views.View instead of a cli.Ui. Update test setup accordingly. To allow commands to control this hook, we add a hooks member on the backend Operation struct. This supersedes the hooks in the Terraform context, which is not directly controlled by the command logic. This commit should not change how Terraform works, and is refactoring in preparation for more changes which move UI code out of the backend.	5 years ago
Matthew Frahry	cb041053e9	Merge with master	5 years ago
Matthew Frahry	2b42445454	Update client.go	5 years ago
Matthew Frahry	f52a18b134	Update backend/remote-state/azure/client.go ... Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>	5 years ago
Alisdair McDiarmid	536c80da23	backend: Add per-operation diagnostic rendering ... The enhanced backends (local and remote) need to be able to render diagnostics during operations. Prior to this commit, this functionality was supported with a per-backend `ShowDiagnostics` function pointer. In order to allow users of these backends to control how diagnostics are rendered, this commit moves that function pointer to the `Operation` type. This means that a diagnostic renderer is configured for each operation, rather than once per backend initialization. Some secondary consequences of this change: - The `ReportResult` method on the backend is now moved to the `Operation` type, as it needs to access the `ShowDiagnostics` callback (and nothing else from the backend); - Tests which assumed that diagnostics would be written to the backend's `cli.Ui` instance are migrated to using a new record/playback diags helper function; - Apply, plan, and refresh commands now pass a pointer to the `Meta` struct's `showDiagnostics` method. This commit should not change how Terraform works, and is refactoring in preparation for more changes which move UI code out of the backend.	5 years ago
Omar Ismail	4ac095b63f	only print horizontal rule at first attempt	5 years ago
Omar Ismail	d96c90b6af	Cost Estimation CLI output unnecessary	5 years ago
Alisdair McDiarmid	b2ba650c21	cli: Remove deprecated destroy -force flag ... This dramatically simplifies the logic around auto-approve, which is nice. Also add test coverage for the manual approve step, for both apply and destroy, answering both yes and no.	5 years ago
GreenHedgehog	d4db1d1342	fix possible nil pointer dereference in azure sdk	5 years ago
Alisdair McDiarmid	5ca118b4e6	cli: Move resource count code to command package ... CountHook is an implementation of terraform.Hook which is used to calculate how many resources were added, changed, or destroyed during an apply. This hook was previously injected in the local backend code, which means that the apply command code has no access to these counts. This commit moves the CountHook code into the command package, and removes an unused instance of the hook in the plan code path. The goal here is moving UI code into the command package.	5 years ago
Jonathan Hall	49ee3d3ef8	Grammar nit: "setup" as a verb should be spelled "set up"	5 years ago
Nick Fagerlund	ed7f97c34f	Update language docs URLs in code and tests	5 years ago
James Bardin	9f2a6d33be	move remaining helper packages to internal	5 years ago
Martin Atkins	e6a516d87e	backend/local: Use terminal properties to tweak the plan output ... We now require the output to accept UTF-8 and we can determine how wide the terminal (if any) is, so here we begin to make use of that for the "terraform plan" command. The horizontal rule is now made of box drawing characters instead of hyphens and fills the whole terminal width. The paragraphs of text in the output are now also wrapped to fill the terminal width, instead of the hard-wrapping we did before. This is just a start down the road of making better use of the terminal capabilities. Lots of other commands could benefit from updates like these too.	5 years ago
Martin Atkins	d2c3403ab6	command: Use the new terminal.Streams object ... Here we propagate in the initialized terminal.Streams from package main, and then onwards to backends running in CLI mode. This also replaces our use of helper/wrappedstreams to determine whether stdin is a terminal or a pipe. helper/wrappedstreams returns incorrect file descriptors on Windows, causing StdinPiped to always return false on that platform and thus causing one of the odd behaviors discussed in Finally, this includes some wrappers around the ability to look up the number of columns in the terminal in preparation for use elsewhere. These wrappers deal with the fact that our unit tests typically won't populate meta.Streams.	5 years ago
James Bardin	3bc7d77230	update MockProvider usage	5 years ago
James Bardin	e614fb9aed	refresh is expected for destroy ... These tests were not previously running a refresh, and hence did not expect the resources to be read.	5 years ago
Pam Selle	c9f372a62b	Merge pull request #24896 from bendrucker/validate-ignore-empty-provider ... validate: ignore providers with no configuration	5 years ago
Alisdair McDiarmid	7e09cd1228	backend/remote: No version check for local ops ... If the remote backend is connected to a Terraform Cloud workspace in local operations mode, we disable the version check, as the remote Terraform version is meaningless.	5 years ago
Alisdair McDiarmid	619c6727ef	backend/remote: No version check for operations ... Terraform remote version conflicts are not a concern for operations. We are in one of three states: - Running remotely, in which case the local version is irrelevant; - Workspace configured for local operations, in which case the remote version is meaningless; - Forcing local operations with a remote backend, which should only happen in the Terraform Cloud worker, in which case the Terraform versions by definition match. This commit therefore disables the version check for operations (plan and apply), which has the consequence of disabling it in Terraform Cloud and Enterprise runs. In turn this enables Terraform Enterprise runs with bundles which have a version that doesn't exactly match the bundled Terraform version.	5 years ago
Ben Drucker	a39273cfa3	Merge remote-tracking branch 'origin/master' into validate-ignore-empty-provider	5 years ago
James Bardin	7eac9e1d89	set SkipRefresh for plan and apply ... The option is set in the same place for plan and apply.	6 years ago
Alisdair McDiarmid	6e0d8cde91	backend/remote: Fix for "latest" workspace version ... Terraform Cloud/Enterprise support a pseudo-version of "latest" for the configured workspace Terraform version. If this is chosen, we abandon the attempt to verify the versions are compatible, as the meaning of "latest" cannot be predicted. This affects both the StateMgr check (used for commands which execute remotely) and the full version check (for local commands).	6 years ago
Ben Drucker	2549e53aed	add backend refresh test with provider config	6 years ago
Ben Drucker	7e11b97923	Merge remote-tracking branch 'origin/master' into validate-ignore-empty-provider	6 years ago
James Bardin	96436f526a	unused err value and nil context ... Incorrect err assignment had no effect. Never use a nil context.	6 years ago
James Bardin	d2c2d58f09	unused	6 years ago
James Bardin	de5b022a3b	legacy types in backend/local	6 years ago
James Bardin	2635b3b023	update remote state to use legacy types	6 years ago