terraform

Commit Graph

Author	SHA1	Message	Date
Austin Valle	a48e873790	PSS: Adjust `StateRange.End` logic in `ReadStateBytes` and `WriteStateBytes` (#38127 ) * fix usage of StateRange.End * add test for last chunk is single byte	2 weeks ago
Radek Simko	922fdb2382	Implement LockState & UnlockState provider methods (#37711 )	5 months ago
Radek Simko	51fc4c161f	PSS: Implement `ReadStateBytes` + `WriteStateBytes` (#37440 ) * Implement ReadStateBytes + WriteStateBytes * [WIP] - Testing ReadStateBytes and WriteStateBytes (#37464) * Fix nil pointer error * Add WIP test for ReadStateBytes * Move test mock to separate testing file * Update mock to send unexpected EOF when there's a problem returning data and it's not a true EOF * Add test case for when length != expected length * Add test for when trying to read state from a store type that doesn't exist * Change symbol names to lowercase * Add ability to force a diagnostic to be returned from `mockReadStateBytesClient`'s `Recv` method * Add test showing error diagnostics raised by the ReadStateBytes client are returned * Add missing header * Simplify mock by using an embedded type * Rename `mockOpts` to `mockReadStateBytesOpts` * Update existing tests to assert what arguments are passed to the RPC method call * Add mock WriteStateBytesClient which uses `go.uber.org/mock/gomock` to enable assertions about calls to Send * Add a test for WriteStateBytes that makes assertions about calls to the Send method * Update test case to explicitly test writing data smaller than the chunk size * Implement chunking in WriteStateBytes, add test case to assert expected chunking behaviour * Add generated mock for Provider_WriteStateBytesClient in protocol v6 * Update tests to use new `MockProvider_WriteStateBytesClient`, remove handwritten mock * Update code comments in test * Add tests for diagnostics and errors returned during WriteStateBytes * Add generated mock for Provider_ReadStateBytesClient in protocol v6, replace old mock * Add test case for grpc errors in ReadStateBytes, fix how error is returned * Typo in comment * Add missing warning test, rename some test cases * Update proto file definition of Read/WriteStateBytes RPCs (#37529) * Update Read/WriteStateBytes RPCs to match https://github.com/hashicorp/terraform-plugin-go/pull/531 * Run `make protobuf` * Run `make generate` * Update use of `proto.ReadStateBytes_ResponseChunk` in tests * Fix how diagnostics are handled alongside EOF error, update ReadStateBytes test * More fixes - test setup was incorrect I think? I assume that a response would be returned full of zero-values when EOF is encountered. * WIP - avoid crash if chunk is nil * Sarah's updates to radek/pss-read-write (#37642) * Update code to not expect a chunk when EOF encountered * Return early if any grpc errors are encountered during ReadStateBytes * Close the stream with CloseSend once everything's read without error. Add test case about handling grpc errors from CloseSend. * Fix test case about warnings: We would expect to receive a chunk with data alongside the warning and have a normal closing of the stream after EOF * Add log line, remove unneeded type info * Implement configurable state chunk size * handle metadata in WriteStateBytes correctly * validate chunk sizes received from provider * ReadStateBytes: avoid early return on warnings --------- Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>	5 months ago
Daniel Schmidt	871451122f	actions: move schema to single action type and remove linked resources we want to leave the door open to evolve the design in the future based on feedback	5 months ago
James Bardin	3a2409e3dc	generate capability	6 months ago
James Bardin	db98d67774	GenerateResourceConfig protobuf	6 months ago
Daniel Schmidt	176263d936	actions: remove future action types removing them for now, this gives us more flexibility in the future since the schema is not yet locked in	6 months ago
Daniel Schmidt	17e7338b0f	add client capabilites across the board	7 months ago
Austin Valle	184175761b	fix protocol field numbers	7 months ago
Daniel Schmidt	7bf6629ae7	fix protobuf typo	7 months ago
Daniel Schmidt	c11a85493e	mark field 10 as reserved Co-authored-by: Liam Cervante <liam.cervante@hashicorp.com>	7 months ago
Daniel Schmidt	972427d70a	use same attribute mapping as provider protocol	7 months ago
Kristin Laemmert	0374f04424	Add ValidateActionConfig to provider interface, protocol & internal implementations (#37345 ) * Add ValidateActionConfig to provider interface and protocol * Update internal/provider-simple-v6/provider.go Co-authored-by: Daniel Schmidt <danielmschmidt92@gmail.com> --------- Co-authored-by: Daniel Schmidt <danielmschmidt92@gmail.com>	7 months ago
Daniel Schmidt	d0e5c3cc7b	address review feedback	8 months ago
Daniel Schmidt	e6b848d5ab	add actions protobuf definitions	8 months ago
Sarah French	0f8e77a50f	PSS: Add GetStates and DeleteState RPCs to plugin protocol v6 (#37288 ) * Add GetStates RPC method to Plugin Protocol v6 * Add DeleteState RPC method to Plugin Protocol v6 * Add methods to provider-simple * Fix error messages * Apply suggestions from code review Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com> * Change how GetStates RPC returns the list of state names * Change GetStates implementation to use new data type * `make protobuf` to accommodate new code comments --------- Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com>	8 months ago
Samsondeen	79187d579d	Validate list block meta-arguments (#37281 )	8 months ago
Daniel Banck	cb58a15f3d	Implement ListResource RPC (TF-25509) (#37092 ) * Implement ListResource RPC via callbacks * Implement ListResource with iterators * Change `ListResourceResponse` to slice * Turn ListResourceResponse into a struct * Add a limit for ListResource * explicitly cancel stream when listing resources --------- Co-authored-by: Samsondeen Dare <samsondeen.dare@hashicorp.com>	9 months ago
Radek Simko	643266dc90	Add initial state store protocol skeleton (#37197 ) * Add initial state store protocol skeleton Introduce ValidateStateStoreConfig + ConfigureStateStore Update GetProviderSchema + GetMetadata (for mux) * address PR feedback	9 months ago
Radek Simko	dd4bf55dca	docs/plugin-protocol: Clarify use of GetMetadata (#37181 ) * docs/plugin-protocol: Clarify use of GetMetadata * Run `make protobuf` --------- Co-authored-by: Sarah French <sarah.french@hashicorp.com>	9 months ago
Baraa Basata	d8d890f3b2	Minimize text diff between `tfplugin{5,6}.proto` (#37093 ) * Minimize text diff between tfplugin{5,6}.proto This is a no-op change that moves two definitions in tfplugin5.proto to match their relative location in tfplugin6.proto. The effect is to remove an incidental part of the text diff between the two files for easier comparison. * fixup! Minimize text diff between tfplugin{5,6}.proto	9 months ago
Daniel Banck	44ae7da18e	Update Plugin Protocol for List and Implement `ValidateListResourceConfig` (#37007 ) * Minor auto-formatting changes * Add list RPC and schema protobuf definitions * make protobuf * make generate * Add ValidateListResourceConfig implementation	9 months ago
Daniel Banck	dd10cfc048	Cleanup Terraform Plugin Protocol Files (#37005 ) * Rename tfplugin5.9.proto and remove other files * Rename tfplugin6.9.proto and remove other files * Update symlinks * Update protocol related docs	10 months ago
Sarah French	371e625ea9	Update URLs from `www.terraform.io` to `developer.hashicorp.com` (#36792 ) * Update URLs from www.terraform.io to developer.hashicorp.com * More updates to URLs linking to documentation in documentation and user-facing warnings/errors * More updates to URLs linking to documentation, in docs, code, test fixtures * Replace www.terraform.io/community with link to Community Forum * Apply suggestions from code review Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> --------- Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com>	11 months ago
Daniel Banck	5b48de5a4e	Update identity related fields in protocol move request (#36662 ) * Update source identity type in move request * make protobuf * Update type for identity upgrade * make protobuf	12 months ago
Sarah French	4facc97e7c	Add documentation describing how to update the plugin protocol (#36592 ) * Add documentation describing how to update the plugin protocol * Fix typo * Minor edits * Refactor docs to ensure the protocol semver goes up by one minor once per Terraform minor release. * Edit a word	12 months ago
Daniel Banck	857d188308	Add resource identity message to protocol (TF-23178) (#36451 ) * protocol: create new 5.9 and 6.9 protocol versions * protocol: add resource identity messages to 5.9 & 6.9 * make protobuf * make generate * grpcwrap: Add RPC calls skeleton	1 year ago
Daniel Schmidt	e29708c4d9	ephemeral: add WriteOnlyAttributesAllowed client capability to validate resource	1 year ago
Daniel Schmidt	3a962e8e7e	ephemeral: add WriteOnlyAttributesAllowed client capability we allow it for all requests	1 year ago
Daniel Schmidt	50b3732f72	write-only attributes: add to provider schema	1 year ago
James Bardin	5a7a113863	remove state from proto6 ephemeral calls	1 year ago
James Bardin	9899d59a22	add deferrals to ephemeral proto and remove state Add deferrals to the protocol. The renew and close calls had an extra state field which was unneeded.	1 year ago
James Bardin	9c3dc8f73a	ephemeral protocol rename Add `Resource` to all the ephemeral protocol symbols to make them consistent with existing naming conventions.	1 year ago
James Bardin	5ecd6d0854	new proto files for ephemeral resources	1 year ago
Liam Cervante	055dd27e53	deferred actions: implement latest provider protocol changes (#35063 )	2 years ago
Daniel Schmidt	45e9530d12	stacks: remove deferred actions for UpgradeResourceState UpgradeResourceState is offline; it does not need a configured provider therefore it can not be deferred	2 years ago
Daniel Schmidt	71873ec29a	fix comment	2 years ago
Daniel Schmidt	e650c039ef	stacks: add deferred to protobuf	2 years ago
Daniel Schmidt	4e8a8fa883	add new tfplugin version in preparation for adding fields related to deferred actions	2 years ago
James Bardin	300f66b71d	Merge pull request #34603 from hashicorp/jbardin/remove-provider-funtion-warnings provider functions can only return an error	2 years ago
Radek Simko	0c509183d1	ci: Add test for license headers (#34624 ) * ci: Add test for copyright headers * replace GHA workflow with make target (copyright) This makes it reusable for outside of CI, such that anyone cloning the repo locally can still easily verify compliance before raising a PR. * remove go:generate for copywrite This should no longer be needed as we leverage copywrite via a shell script now. * introduce make copyrightfix	2 years ago
James Bardin	a8701f6ddd	provider functions return an error The call site for language functions doesn't currently have a way to handle complex diagnostics, so rather than appear to support them in the protocol we remove the concepts of diagnostics for now. We do however retain the argument index fields, which we can wrap in a function.ArgError and get a little more precise hcl diagnostic from expression.	2 years ago
Brian Flad	c7a44bfc9a	Support Private State with MoveResourceState (#34575 ) This change ensures that providers receive the source private state and can store potentially differing private state as part of a move, rather than always copying the source private state to the target. This functionality has not yet been released and therefore there are no compatibility concerns.	2 years ago
Liam Cervante	7d143388f3	Add support for the cross resource type move operation in the proto schema (#34480 ) * Update proto schema and provider interfaces with support for moved across resource type RPCs * address comments * remove unused functions * remove support for flatmap format	2 years ago
hc-github-team-es-release-engineering	6114ec4390	Merge pull request #34367 from hashicorp/RELPLAT-955-EOY-license-updates [DO NOT MERGE UNTIL EOY] EOY license updates	2 years ago
James Bardin	c439b72599	proto: add provider-defined functions	2 years ago
hc-github-team-es-release-engineering	a90ba0bfe4	update year in license files	2 years ago
CJ Horton	813369f317	stick with go generate check instead	3 years ago
Brian Flad	7094517089	Add GetMetadata RPC to provider protocol (#33739 ) Reference: https://github.com/hashicorp/terraform/pull/33486 This is a followup to the new provider server capability to make the `GetProviderSchema` RPC optional. While this server capability would perform its intended function when directly talking to a single provider server SDK implementation, provider servers using terraform-plugin-mux need a methodology for the mux server to determine the available resource types of each underlying provider server to properly route resource-specific RPCs. Since the only methodology available to the mux server would be calling the `GetProviderSchema` RPC to each of underlying provider servers, any memory optimization of core caching would be lost. The choice of adding a new RPC instead of adjusting the existing `GetProviderSchema` RPC with additional request information, such as "only list the type names and not the schema information in the response", is two-fold: - Prevents the introduction of conditional logic for the existing RPC. - Clearly delineates the purpose of the RPC and can be documented easier. The choice of adding this to the existing provider service is two-fold: - Implementing a separate protocol and/or service only on the provider side of the protocol would be a novel design change. This small of a change does not warrant the potential research and testing effort that would be associated with that implementation. - While the core implementation will not use the new RPC immediately, there is no reason why it should be restricted from doing so in the future if a valid use case surfaces. Other ecosystem tools, beyond terraform-plugin-mux, can also potentially benefit from the lightweight RPC now. This is changing the 5.4 and 6.4 protocol versions following the guidance of this comment in the definition files, since it directly relates to the prior intention of the new minor versions: ```protobuf // Note that only the proto files included in a release tag of Terraform are // official protocol releases. Proto files taken from other commits may include // incomplete changes or features that did not make it into a final release. // In all reasonable cases, plugin developers should take the proto file from // the tag of the most recent release of Terraform, and not from the main // branch or any other development branch. ``` As with any Protocol Buffers definition update, protocol compatibility is guaranteed within a major version, however generated protocol source code compatibility is not guaranteed. In this case, implementing the new RPC method in protocol wrapper types and the moving of the `ServerCapabilities` message to the top namespace are considered acceptable changes.	3 years ago
CJ Horton	c09daa7dc7	update license for provider plugin protocol files	3 years ago

1 2

70 Commits (expanding-moved-blocks)