terraform

Commit Graph

Author	SHA1	Message	Date
Radek Simko	564e8d30ec	providers/mock.go: Remove copyright headers This was probably added accidentally. The removal aligns with this ignore pattern entry in the .copywrite.hcl config: "*/mock.go"	2 months ago
Radek Simko	0fe906fa8c	make copyrightfix	2 months ago
Kristin Laemmert	869058f995	chore: add default events to the MockProvider's InvokeAction response (#37961 )	4 months ago
Sarah French	cf047be4e4	PSS: Use interfaces to configure state stores (#37899 ) * refactor: Move chunk size limit constants to new `chunks` package * refactor: Make `NewPluggable` return a `Pluggable` concrete type, instead of an instance of the `backend.Backend` interface. * refactor: Configure state stores through the backend.Backend interface, instead of directly using methods related to RPCs. This requires changing where we call `SetStateStoreChunkSize`. * docs: Add godocs comment to `StateStoreChunkSizeSetter` interface To summarize, we don't really need the `SetStateStoreChunkSize` method, and instead methods like `(GRPCProvider).ConfigureStateStore` in the `plugin6` package can directly inspect the negotiation process that passes through that code and pull out the chunk size. However that means that that code would also need to implement validation. And that's just `(GRPCProvider).ConfigureStateStore`; what about all the test mocks that are used in different types of test? They would all need to be implemented similarly to GRPCProvider to be good, useful mocks, and then a lot of things that fulfil the provider.Interface interface are coupled to each other. Instead, it's easier to have validation in the `grpcClient` struct's methods in the `remote` package, as that code is common to all scenarios. That code needs a method to 'reach into' the provider.Interface value, so we use the `SetStateStoreChunkSize` method. * chore: Make it clearer that the v6 GRPCProvider implements `SetStateStoreChunkSize` * fix: Remove unnecessary assignment of chunk size I'm surprised that removing this doesn't break E2E tests of PSS that use grpcwrap, but I think there's `plugin6` code that runs in that situation, so maybe chunking is handled elsewhere. * chore: Add panic to try detect unexpected cases when setting chunk size. * feat: Add `providers.StateStoreChunkSizeSetter` implementation to provider-simple-v6 * docs: Update code comments for NewPluggable describing its intended use	5 months ago
Sarah French	4420c4dcc0	PSS: Update the `workspace new` subcommand to work with PSS, add E2E and integration tests for using `workspace` commands with PSS. (#37855 ) * feat: Update the `workspace new` subcommand to work with PSS, add E2E testing * refactor: Replace instances of `ioutil` with `os` while looking at the workspace command * docs: Update code comments in `workspace new` command * test: Update E2E test using PSS with workspace commands to assert state files are created by given commands * test: Include `workspace show` in happy path E2E test using PSS * fix: Allow DeleteState RPC to include the id of the state to delete * test: Include `workspace delete` in happy path E2E test using PSS * fix: Avoid assignment to nil map in mock provider during WriteStateBytes * test: Add integration test for workspace commands when using PSS We still need an E2E test for this, to ensure that the GRPC-related packages pass all the expected data between core and the provider. * test: Update test to reflect changes in the test fixture configuration * docs: Fix code comment * test: Change test to build its own Terraform binary with experiments enabled * refactor: Replace use of `newMeta` with reuse of Meta that we re-set the UI value on	5 months ago
Sarah French	6b73f710f8	PSS: Implement initialisation of new working directory (or use of `-reconfigure` flag) while using `state_store` (#37732 ) * Minor fixes in diagnostics This can only be done once modules have been parsed and the required providers data is available. There are multiple places where config is parsed, into either Config or Module structs, so this needs to be implemented in multiple places. * Rename test to make it specific to use of backend block in config * Update initBackend to accept whole initArgs collection * Only process --backend-config data, when setting up a `backend`, if that data isn't empty * Simplify how mock provider factories are made in tests * Update mock provider's default logic to track and manage existing workspaces * Add `ProviderSchema` method to `Pluggable` structs. This allows calling code to access the provider schema when using provider configuration data. * Add function for converting a providerreqs.Version to a hashicorp/go-version Version. This is needed for using locks when creating the backend state file. * Implement initial version of init new working directories using `stateStore_C_s`. Default to creating the default workspace if no workspaces exist. * Update test fixtures to match the hashicorp/test mock provider used in PSS tests * Allow tests to obtain locks that include `testingOverrides` providers. The `testingOverrides` field will only be set in tests, so this should not impact end users. * Add tests showing TF can initialize a working directory for the first time (and do the same when forced by -reconfigure flag). Remove replaced tests. * Add -create-default-workspace flag, to be used to disable creating the default workspace by default when -input=false (i.e for use in CI). Refactor creation of default workspace logic. Add tests. * Allow reattached providers to be used during init for PSS * Rename variable to `backendHash` so relation to `backend` is clearer * Allow `(m Meta) Backend` to return warning diagnostics Protect against nil testingOverrides in providerFactoriesFromLocks * Add test case seeing what happens if default workspace selected, doesn't exist, but other workspaces do exist. The consequences here are due to using `selectWorkspace` in `stateStore_C_s`, matching what's done in `backend_C_r_s`. * Address code consistency check failure on PR * Refactor use of mock in test that's experiencing EOF error... * Remove test that requires test to supply input for user prompt This test passes when run in isolation but fails when run alongside other tests, even when skipping all other tests using `testStdinPipe`. I don't think the value of this test is great enough to start changing how we test stdin input. * Allow -create-default-workspace to be used regardless of whether input is enabled or disabled * Add TF_SKIP_CREATE_DEFAULT_WORKSPACE environment variable * Responses to feedback, including making testStdinPipe helper log details of errors copying data to stdin. Note: We cannot call t.Fatal from a non-test goroutine. * Use Errorf instead * Allow backend state files to not include version data when a builtin or reattached provider is in use. * Add clarifying comment about re-attached providers when finding the matching entry in required_providers * Report that the default workspace was created to the view * Refactor: use error comparison via `errors.Is` to identify when no workspaces exist. * Move handling of TF_ENABLE_PLUGGABLE_STATE_STORAGE into init's ParseInit func. * Validate that PSS-related flags can only be used when experiments are enabled, enforce coupling of PSS-related flags when in use. * Slight rewording of output message about default workspace * Update test to assert new output about default workspace	6 months ago
Sarah French	17445f6c5f	PSS: Add chunk size negotiation to `savedStateStore` method, update mock provider for tests. (#37726 ) * Add SetStateStoreChunkSize to the mock provider for tests * Implement configurable state chunk size * Add chunk size negotiation to `savedStateStore`, update happy path test to assert it's set * Update `savedStateStore` to return diagnostic if a nil factory is passed in, add unhappy path tests * Fix test error message * Apply suggestions from code review Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com> * Fix rename --------- Co-authored-by: Radek Simko <radek.simko@gmail.com> Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com>	6 months ago
Radek Simko	922fdb2382	Implement LockState & UnlockState provider methods (#37711 )	6 months ago
Radek Simko	51fc4c161f	PSS: Implement `ReadStateBytes` + `WriteStateBytes` (#37440 ) * Implement ReadStateBytes + WriteStateBytes * [WIP] - Testing ReadStateBytes and WriteStateBytes (#37464) * Fix nil pointer error * Add WIP test for ReadStateBytes * Move test mock to separate testing file * Update mock to send unexpected EOF when there's a problem returning data and it's not a true EOF * Add test case for when length != expected length * Add test for when trying to read state from a store type that doesn't exist * Change symbol names to lowercase * Add ability to force a diagnostic to be returned from `mockReadStateBytesClient`'s `Recv` method * Add test showing error diagnostics raised by the ReadStateBytes client are returned * Add missing header * Simplify mock by using an embedded type * Rename `mockOpts` to `mockReadStateBytesOpts` * Update existing tests to assert what arguments are passed to the RPC method call * Add mock WriteStateBytesClient which uses `go.uber.org/mock/gomock` to enable assertions about calls to Send * Add a test for WriteStateBytes that makes assertions about calls to the Send method * Update test case to explicitly test writing data smaller than the chunk size * Implement chunking in WriteStateBytes, add test case to assert expected chunking behaviour * Add generated mock for Provider_WriteStateBytesClient in protocol v6 * Update tests to use new `MockProvider_WriteStateBytesClient`, remove handwritten mock * Update code comments in test * Add tests for diagnostics and errors returned during WriteStateBytes * Add generated mock for Provider_ReadStateBytesClient in protocol v6, replace old mock * Add test case for grpc errors in ReadStateBytes, fix how error is returned * Typo in comment * Add missing warning test, rename some test cases * Update proto file definition of Read/WriteStateBytes RPCs (#37529) * Update Read/WriteStateBytes RPCs to match https://github.com/hashicorp/terraform-plugin-go/pull/531 * Run `make protobuf` * Run `make generate` * Update use of `proto.ReadStateBytes_ResponseChunk` in tests * Fix how diagnostics are handled alongside EOF error, update ReadStateBytes test * More fixes - test setup was incorrect I think? I assume that a response would be returned full of zero-values when EOF is encountered. * WIP - avoid crash if chunk is nil * Sarah's updates to radek/pss-read-write (#37642) * Update code to not expect a chunk when EOF encountered * Return early if any grpc errors are encountered during ReadStateBytes * Close the stream with CloseSend once everything's read without error. Add test case about handling grpc errors from CloseSend. * Fix test case about warnings: We would expect to receive a chunk with data alongside the warning and have a normal closing of the stream after EOF * Add log line, remove unneeded type info * Implement configurable state chunk size * handle metadata in WriteStateBytes correctly * validate chunk sizes received from provider * ReadStateBytes: avoid early return on warnings --------- Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>	7 months ago
Samsondeen	a7504719ef	list: send non-null "config" object to provider when not present in the list block (#37620 )	7 months ago
Daniel Schmidt	871451122f	actions: move schema to single action type and remove linked resources we want to leave the door open to evolve the design in the future based on feedback	7 months ago
James Bardin	1cb7d1859f	Merge pull request #37515 from hashicorp/jbardin/generate-config provider GenerateResourceConfig	7 months ago
Kristin Laemmert	00da430883	very minor fixups for test convenience (#37555 ) * very minor fixups for test convenience * cleanup mock provider's actions	7 months ago
James Bardin	97ebb6cf38	GenerateResourceConfig test	8 months ago
James Bardin	cc74e2eb20	udpate provider mocks	8 months ago
James Bardin	51f870c5b1	extend provider interface for GenerateResourceConfig	8 months ago
Daniel Schmidt	176263d936	actions: remove future action types removing them for now, this gives us more flexibility in the future since the schema is not yet locked in	8 months ago
Kristin Laemmert	4fadc32a9e	Action Validate Graph (#37514 ) * action validation preparation: add NodeAbstractAction I decided to (loosely) follow the NodeResourceAbstract pattern so that, in the next commit, I can configure the validate walk to create a NodeValidatableAction vs the default nodeExpandActionDeclaration. I am putting this in a separate commit for easier review, to show that this did not impact the current implementation.	8 months ago
Daniel Schmidt	17e7338b0f	add client capabilites across the board	8 months ago
Daniel Schmidt	d3f6b721e9	use string for execution order nicer for transfer and debugging	8 months ago
Kristin Laemmert	0374f04424	Add ValidateActionConfig to provider interface, protocol & internal implementations (#37345 ) * Add ValidateActionConfig to provider interface and protocol * Update internal/provider-simple-v6/provider.go Co-authored-by: Daniel Schmidt <danielmschmidt92@gmail.com> --------- Co-authored-by: Daniel Schmidt <danielmschmidt92@gmail.com>	9 months ago
Kristin Laemmert	9256074c43	Actions in plan/changes (#37320 ) * Add actions to the plans and change * jsonplan - ignoring LinkedResources for now, those are not in the MVP * pausing here: we'll work on the plan rendering later	9 months ago
Daniel Schmidt	ac132d1b15	add provider implementation for actions	9 months ago
Sarah French	39f7920387	PSS: Add packages for presenting a provider as an instance of backend.Backend (#37291 ) * Add code to 'wrap' a provider implementation so that it can behave like a backend.Backend * Add code for creating a state manager that will interact with a provider via grpc to interact with state * Remove prototyping code * Update old implementation of PrepareConfig on Pluggable to match new RPC names * Implement Configure method on Pluggable * Implement Workspaces and DeleteWorkspace methods on Pluggable * Prevent construction of a pluggable with missing data, add godoc comment to NewPluggable * Add godoc comment to ConfigSchema * Refactor how we create a state manager for interacting with PSS Now we reuse the remote.State struct and all the pre-existing logic there. We still wrap the provider interface to enable use of gRPC methods, but that's now done using the remote.Client interface. * Rename file * Move file into the remote package * Rename file and package to `pluggable` * Add test for the only method implemented fully on `grpcClient` : Delete * Add tests for `NewPluggable` * Add tests for (Pluggable).ConfigSchema method, make minor fixes * Change mocks: hardcoded response or logic should return before default logic in method. * Add tests for (Pluggable).PrepareConfig method * Add tests for (Pluggable).Configure method * Add tests for (Pluggable).Workspaces method * Add tests for (Pluggable).DeleteWorkspace method * Fix rebase * Run `make syncdeps` * Add headers * Add missing comments * No need to implement ClientForcePusher * Apply feedback from review, make small tweaks to test failure messages	9 months ago
Sarah French	0f8e77a50f	PSS: Add GetStates and DeleteState RPCs to plugin protocol v6 (#37288 ) * Add GetStates RPC method to Plugin Protocol v6 * Add DeleteState RPC method to Plugin Protocol v6 * Add methods to provider-simple * Fix error messages * Apply suggestions from code review Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com> * Change how GetStates RPC returns the list of state names * Change GetStates implementation to use new data type * `make protobuf` to accommodate new code comments --------- Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com>	9 months ago
Samsondeen	79187d579d	Validate list block meta-arguments (#37281 )	9 months ago
Samsondeen	3d3439e00e	Testing list blocks with the gRPC Provider (#37236 )	10 months ago
Samsondeen	f57642d1a6	tf test: parallelize teardown operations (#37220 )	10 months ago
Samsondeen	685ff9f192	Schema representation of list block config and results (#37209 )	10 months ago
Daniel Banck	cb58a15f3d	Implement ListResource RPC (TF-25509) (#37092 ) * Implement ListResource RPC via callbacks * Implement ListResource with iterators * Change `ListResourceResponse` to slice * Turn ListResourceResponse into a struct * Add a limit for ListResource * explicitly cancel stream when listing resources --------- Co-authored-by: Samsondeen Dare <samsondeen.dare@hashicorp.com>	10 months ago
Radek Simko	643266dc90	Add initial state store protocol skeleton (#37197 ) * Add initial state store protocol skeleton Introduce ValidateStateStoreConfig + ConfigureStateStore Update GetProviderSchema + GetMetadata (for mux) * address PR feedback	10 months ago
Samsondeen	a5434b421f	Build and Validate list resource nodes (#37011 )	11 months ago
Daniel Banck	44ae7da18e	Update Plugin Protocol for List and Implement `ValidateListResourceConfig` (#37007 ) * Minor auto-formatting changes * Add list RPC and schema protobuf definitions * make protobuf * make generate * Add ValidateListResourceConfig implementation	11 months ago
James Bardin	29fa9c401f	add separate CheckPriorProvider entry point	11 months ago
James Bardin	d016070564	move function results hashing to lang We need to abstract the function results verification to use internally too, so start by moving it out of the providers code.	11 months ago
Liam Cervante	7fadbe34de	write-only attributes: internal providers should set write-only attributes to null (#36824 ) * write-only attributes: internal providers should set write-only attributes to null * add changelog * fix copywrite headers	1 year ago
Radek Simko	6f8b5e49c9	providers/testing: Remove unused *TypeName fields (#36813 )	1 year ago
Daniel Schmidt	fec6e4b552	send resource identities to provider calls	1 year ago
Daniel Banck	b2b42c0fb4	Store resource identities in state (TF-23255) (#36464 ) * Persist resource identity in Terraform state * make syncdeps * Move identity schema merging closer to the protocol * mock GetResourceIdentitySchemas * Fix identity refresh tests * Add more tests * Change grcpwrap upgrade identity * Review feedback * Remove unnecessary version conversion * Check if GetResourceIdentitySchemas RPC call is implemented * Update function signature docs * Adapt protocol changes * Check unimplemented error for identities in GetSchema	1 year ago
Daniel Banck	10c9b64007	Rename schema.Block to Body (#36629 )	1 year ago
Liam Cervante	408f323efa	test: also allow mock_data and mock_resource blocks to generate data during planning (#36317 )	1 year ago
Sarah French	e5d4a51ee4	Validate write-only attributes returned from providers during the UpgradeResourceState RPC (#36305 ) * Check for non-null WO attrs when a state upgrade takes place * wip: testing new validation * update test and let it pass * Add change file * fix failing test * Add comments about some of the gotchas we encountered * Delete change file * Remove comment --------- Co-authored-by: Radek Simko <radek.simko@gmail.com>	1 year ago
Samsondeen	aec7c3cc89	terraform test: allow computed/mocked values override during planning (#36227 )	1 year ago
Daniel Schmidt	e29708c4d9	ephemeral: add WriteOnlyAttributesAllowed client capability to validate resource	1 year ago
Daniel Schmidt	3a962e8e7e	ephemeral: add WriteOnlyAttributesAllowed client capability we allow it for all requests	1 year ago
Daniel Schmidt	17581e4c48	ephemeral: validate provider responses for write-only attributes	1 year ago
Daniel Schmidt	970ff7f6ec	ephemeral: providers are responsible for setting write-only attributes to null	1 year ago
James Bardin	cca1fd95e5	can't check Close call in mocked ephemeral provider We can't enforce the check of the close flag in mocked ephemeral resources, since multiple instances could call the close method while other instances are running.	1 year ago
James Bardin	0c5fae9e3c	ephemeral e2e test provider	2 years ago
James Bardin	94687676a3	add basic grpc wrapper implemenation	2 years ago

1 2

98 Commits (add-missing-variable-loading)