148 Commits (add-missing-variable-loading)

Author	SHA1	Message	Date
Daniel Schmidt	f14581f27a	implement review feedback	1 month ago
Daniel Schmidt	ddefbdf5e4	Replace static config loading in globalref tests	1 month ago
Daniel Schmidt	8fd8a48a06	use common testing helper in configs	1 month ago
Daniel Banck	4ef9684188	Rework most of the configuration loading ... We previously used a loader -> BuildConfig flow to load configuration. This commit changes most (but not all yet) flows to use the new graph-based approach. Instead of simply recursively loading the modules, we now need to take a stepped approach: 1. Load the root module 2. Collect the variables and their values 3. Build the configuration with the graph-based approach Because this approach relies on different parts from different packages, it can't easliy be done within the `configload` package. So, now we do most of in the backend or command.	1 month ago
James Bardin	7960f60d21	Merge pull request #38160 from hashicorp/jbardin/inline-type-conversion ... inline type conversions	1 month ago
Radek Simko	0fe906fa8c	make copyrightfix	2 months ago
James Bardin	4f97ef67ee	enable use of the convert function ... We add `convert` to our set of functions, and we clean up the duplicate function assignments in this package. The multiple assignments have meant that any function changes are inevitably forgotten from the testing framework, and we shouldn't need to declare the mapping multiple times.	2 months ago
James Bardin	9ce50aa8a6	add convert function ... The convert function allows for inline type conversions within the Terraform language. A custom decoder for the function which allows for type expression literals as the second parameter.	2 months ago
Daniel Schmidt	ce400c93df	GetDeprecationMarks should return other value marks in value	2 months ago
Daniel Schmidt	9cf9235582	track down precise deprecation locations in complex output values	2 months ago
Daniel Schmidt	11e49b983a	only unmark deep once for Validate	2 months ago
Daniel Schmidt	c7bc22ed79	only unmark deep once for ValidateDeep	2 months ago
Daniel Schmidt	e6d969a2eb	we only want to send diagnostics for deeply nested deprecations in certain locations ... Mainly terminal locations for the value where they are used, such as the config of a resource, for_each, outputs. We don't want to evaluate the deprecation deeply when it comes to values where the value is not yet used, e.g. locals This is because if e.g. a deeply nested value is deprecated it should still be ok for the entire object to be in a local whereas the same object should give a warning in e.g. an output	2 months ago
Daniel Schmidt	2f392d904e	deprecation.Validate should only check top-level marks	2 months ago
Daniel Schmidt	75445e1ef8	use a string as deprecation origin to help with indirect references ... We want to be able to give better information if e.g. the entire module is stored in a local and the deprecated value is only later used. Where the diag is emitted we might only see the local and not the true origin of the deprecation A string identifying the source of the deprecation should help	2 months ago
Daniel Schmidt	c9cc64a260	move stray check for deprecation to central location	2 months ago
Daniel Schmidt	ea7f1e3043	add extra origin information for deprecation diagnostics	2 months ago
Daniel Schmidt	958a1ae1e7	variable and output deprecation ... Variables can be deprecated through the `deprecated` attribute. If set the variable will emit a diagnostic if a values is passed to it. This entails both root level and module variables. Outputs can be deprecated through the `deprecated` attribute as well. If set wherever the value is used a diagnostic will be emitted. Root level outputs can not be deprecated. The only acceptable usage of a deprecated output is another deprecated output (forwarding the deprecation to the module user). If modules not under your control have deprecation warnings you can add a `suppress_deprecations_warnigns` attribute to the module call in question to silence any deeply nested warnings.	2 months ago
Daniel Schmidt	93a38f893b	remove deprecation origin for now ... we will add sth like this again when we will be able display a nicer diagnostic with the origin	2 months ago
Daniel Schmidt	d813ad14f7	add deprecation marks	2 months ago
James Bardin	eaf225a871	allow inconsistent function results for providers ... Due to the inherently ephemeral nature of provider configuration, inconsistent function results were tolerated while evaluating provider config. This loophole was found to be used by a number of configurations, which took advantage of it to create the equivalent of ephemeral values before they formally existed in the language. In order to work around this, we create a special evaluation scope just for providers, allowing us to override the results check for filesystem functions. I've opted to not further clutter the EvalContext interface since this is intended to be a temporary workaround, and does not contribute to the testing of that interface (the interface is solely for internal unit tests anyway).	5 months ago
James Bardin	2227441f7d	don't cache unknown function results ... The CheckPrior function results validation did not take into account unknown values, because unknown values were not originally allowed in the plugin protocol from which this check was adapted. The test is simple, in that we can just reverse the check which originally didn't allow this change in value. Provider function return values types are defined by the protocol, and should be validated at that call site. The CheckPrior code paths should only be used for the exact purpose of detecting invalid changes in the return value between successive phases of execution.	6 months ago
Daniel Schmidt	2714cfde69	standardize on marks.Has	6 months ago
Kristin Laemmert	df113486a1	actions: remove references to action types, linked resources (#37616) ... * action renaming * actions: remove references to action types * actions: remove references to linked_resources or action types from the plan proto	7 months ago
Daniel Schmidt	f60da0132a	add oxford comma back in ... Co-authored-by: Liam Cervante <liam.cervante@hashicorp.com>	7 months ago
Daniel Schmidt	7150806334	disallow using self in conditions	7 months ago
Daniel Schmidt	4d57d3488a	support count, each, and self for after_ actions	7 months ago
Daniel Schmidt	7fd7b844d0	use hcl diagnostic ... Co-authored-by: Liam Cervante <liam.cervante@hashicorp.com>	9 months ago
Daniel Schmidt	66001080e6	actions: implement expansion and planning actions ... This implementation is very barebones, but builds the skelleton for all upcoming features in actions. It includes the graph implementation for planning actions including the expansion of actions and dealing with multiple action triggers. We plan all actions as part of their triggering resource for now. All action_triggers depend on the triggering resources plan to determine if an action should run or not, therefore we can plan the actions as part of the triggering resource. This implementation ignores conditions, deferrals, provider arguments and it does not add the actions to the planfile; mostly to enable more people to work on these issues in parallel.	9 months ago
Liam Cervante	2a1b4c3ed4	Update go-cty and HCL for 1.13 release (#37298)	9 months ago
Liam Cervante	e9c2c26427	relevant attributes: strip out invalid relevant attributes from the plan (#37290) ... * relevant attributes: strip out invalid relevant attributes from the plan * validate and fix refs rather than remove invalid * add changelog * copyright headers	9 months ago
Samsondeen	a5434b421f	Build and Validate list resource nodes (#37011)	11 months ago
James Bardin	807e084130	final renaming for function results	11 months ago
James Bardin	f78adc889e	add wrappers to verify file function results ... Create wrappers to inject function results verification into all the filesystem function implementations.	11 months ago
James Bardin	a6ec17cb77	rename function results table ... Remove "provider" from the function results fields since it's not going to be exclusively used for providers any longer.	11 months ago
James Bardin	29fa9c401f	add separate CheckPriorProvider entry point	11 months ago
James Bardin	d016070564	move function results hashing to lang ... We need to abstract the function results verification to use internally too, so start by moving it out of the providers code.	11 months ago
Samsondeen	c0a7ff235b	Apply some new go collection features (#36818)	1 year ago
Liam Cervante	7fadbe34de	write-only attributes: internal providers should set write-only attributes to null (#36824) ... * write-only attributes: internal providers should set write-only attributes to null * add changelog * fix copywrite headers	1 year ago
Daniel Banck	b2b42c0fb4	Store resource identities in state (TF-23255) (#36464) ... * Persist resource identity in Terraform state * make syncdeps * Move identity schema merging closer to the protocol * mock GetResourceIdentitySchemas * Fix identity refresh tests * Add more tests * Change grcpwrap upgrade identity * Review feedback * Remove unnecessary version conversion * Check if GetResourceIdentitySchemas RPC call is implemented * Update function signature docs * Adapt protocol changes * Check unimplemented error for identities in GetSchema	1 year ago
Samsondeen	08fa94c2ed	Return error when the template's single interpolation results in null value (#36658)	1 year ago
Daniel Banck	10c9b64007	Rename schema.Block to Body (#36629)	1 year ago
James Bardin	64c68a0a45	don't add paths multiple times in PathsWithMark ... PathsWithMark was adding the same path multiple times if it had multiple extra marks.	1 year ago
James Bardin	1105f16d35	add marks.RemoveAll ... RemoveAll filters marks from a set of cty.PathValueMarks, removing all instances of the remove parameter in all paths. If a path has no remaining marks, it is removed entirely.	1 year ago
Radek Simko	473e5931ac	lang/funcs/transpose: Avoid crash due to map with `null` values (#36611) ... * lang/funcs/transpose: Avoid crash on nulls in input * add changelog entry	1 year ago
James Bardin	91feab6b5d	use WriteOnlyPaths for validation ... ValidateWriteOnlyAttributes did not properly descent through nested blocks and structural attributes, and would allow invalid values to be returned from the provider. The schema already contains code to walk a value in conjunction with its schema, WriteOnlyAttributes. Now that that method returns the correct paths, we can just directly validate those paths and don't need to recursively walk the value again.	1 year ago
Radek Simko	289a3568da	Address `go vet` 1.24 failures (#36485) ... * address go vet failures * avoid unnecessary .Error()	1 year ago
James Bardin	2244efa506	remove Sprintf from ValueMarks comparison ... We can make the comparison a little more efficient by removing the reflection to create the Sprintf string.	1 year ago
James Bardin	bd0a632f5b	create lang/format package ... Create a single place to generate some common formats, mostly the format of a cty.Path. These were used in the tfdiags package, but need to be split out to prevent import cycles if we want to use them in any core package.	1 year ago
Sarah French	d5efc81427	Use different summaries and details when reporting errors about non-null write-only attribute values (#36274) ... * Use different summaries when reporting errors about non-null write-only attribute values * Refactor `ValidateWriteOnlyAttributes` to use custom details for diagnostics * Update affected unit tests * Add change file	1 year ago