58 Commits (add-missing-variable-loading)

Author	SHA1	Message	Date
Radek Simko	0fe906fa8c	make copyrightfix	2 months ago
Varun Chawla	9cdf1ad3cd	builtin/terraform: provide empty config schema to avoid spurious ERROR log (#38183) ... * builtin/terraform: provide empty config schema to avoid spurious ERROR log The builtin terraform provider returned a nil Body in its provider config schema, which caused AttachSchemaTransformer to emit an ERROR-level log message ("No provider config schema available for provider[terraform.io/ builtin/terraform]") even though the provider works correctly. This is confusing for users who filter logs by severity, especially in CI pipelines. Set the provider config schema to an empty configschema.Block{} so that AttachSchemaTransformer finds a valid (but empty) schema and skips the error log. This matches the maintainer's suggested fix in #34207. Fixes #34207 * Add changelog entry for builtin provider schema fix Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Remove changelog entry per reviewer feedback Not an end-user facing change, so no changelog needed. --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>	2 months ago
Andy Hay	e3263bece0	cleanup: remove stale FIXME in terraform provider (#38031) ... * cleanup: remove stale FIXME in terraform provider Signed-off-by: Andrew Hay <andrew.hay@benchmarkanalytics.com> * chore: add changelog entry Signed-off-by: Andrew Hay <andrew.hay@benchmarkanalytics.com> * chore: fix changelog entry format Signed-off-by: Andrew Hay <andrew.hay@benchmarkanalytics.com> * chore: remove changelog entry (not user facing) Signed-off-by: Andrew Hay <andrew.hay@benchmarkanalytics.com> --------- Signed-off-by: Andrew Hay <andrew.hay@benchmarkanalytics.com>	3 months ago
Sarah French	f2818db795	PSS : Add `fs` and `inmem` state storage implementations to the builtin `simplev6` provider, update `grpcwrap` package, use PSS implementation in E2E test (#37790) ... * feat: Implement `inmem` state store in provider-simple-v6 * feat: Add filesystem state store `fs` in provider-simple-v6, no locking implemented * refactor: Move PSS chunking-related constants into the `pluggable` package, so they can be reused. * feat: Implement PSS-related methods in grpcwrap package * test: Add E2E test checking an init and apply (no plan) workflow is usable with both PSS implementations * fix: Ensure state stores are configured with a suggested chunk size from Core --------- Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com>	5 months ago
Radek Simko	922fdb2382	Implement LockState & UnlockState provider methods (#37711)	6 months ago
Radek Simko	51fc4c161f	PSS: Implement `ReadStateBytes` + `WriteStateBytes` (#37440) ... * Implement ReadStateBytes + WriteStateBytes * [WIP] - Testing ReadStateBytes and WriteStateBytes (#37464) * Fix nil pointer error * Add WIP test for ReadStateBytes * Move test mock to separate testing file * Update mock to send unexpected EOF when there's a problem returning data and it's not a true EOF * Add test case for when length != expected length * Add test for when trying to read state from a store type that doesn't exist * Change symbol names to lowercase * Add ability to force a diagnostic to be returned from `mockReadStateBytesClient`'s `Recv` method * Add test showing error diagnostics raised by the ReadStateBytes client are returned * Add missing header * Simplify mock by using an embedded type * Rename `mockOpts` to `mockReadStateBytesOpts` * Update existing tests to assert what arguments are passed to the RPC method call * Add mock WriteStateBytesClient which uses `go.uber.org/mock/gomock` to enable assertions about calls to Send * Add a test for WriteStateBytes that makes assertions about calls to the Send method * Update test case to explicitly test writing data smaller than the chunk size * Implement chunking in WriteStateBytes, add test case to assert expected chunking behaviour * Add generated mock for Provider_WriteStateBytesClient in protocol v6 * Update tests to use new `MockProvider_WriteStateBytesClient`, remove handwritten mock * Update code comments in test * Add tests for diagnostics and errors returned during WriteStateBytes * Add generated mock for Provider_ReadStateBytesClient in protocol v6, replace old mock * Add test case for grpc errors in ReadStateBytes, fix how error is returned * Typo in comment * Add missing warning test, rename some test cases * Update proto file definition of Read/WriteStateBytes RPCs (#37529) * Update Read/WriteStateBytes RPCs to match https://github.com/hashicorp/terraform-plugin-go/pull/531 * Run `make protobuf` * Run `make generate` * Update use of `proto.ReadStateBytes_ResponseChunk` in tests * Fix how diagnostics are handled alongside EOF error, update ReadStateBytes test * More fixes - test setup was incorrect I think? I assume that a response would be returned full of zero-values when EOF is encountered. * WIP - avoid crash if chunk is nil * Sarah's updates to radek/pss-read-write (#37642) * Update code to not expect a chunk when EOF encountered * Return early if any grpc errors are encountered during ReadStateBytes * Close the stream with CloseSend once everything's read without error. Add test case about handling grpc errors from CloseSend. * Fix test case about warnings: We would expect to receive a chunk with data alongside the warning and have a normal closing of the stream after EOF * Add log line, remove unneeded type info * Implement configurable state chunk size * handle metadata in WriteStateBytes correctly * validate chunk sizes received from provider * ReadStateBytes: avoid early return on warnings --------- Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>	7 months ago
James Bardin	1cb7d1859f	Merge pull request #37515 from hashicorp/jbardin/generate-config ... provider GenerateResourceConfig	7 months ago
Sarah French	8503c45013	Update `backend.Backend`'s `StateMgr` method to return diagnostics instead of primitive errors (#37496) ... * Fix S3 backend test affected by making the Workspaces method return errors via diagnostics * Address diagnostics comparison issues in test by ensuring expected diagnostics are defined in the context of the config they're triggered by * Fix failing test case `TestBackendConfig_EC2MetadataEndpoint/envvar_invalid_mode` by making `diagnosticBase` struct comparable * Add compile-time checks that diagnostic types fulfil interfaces * Stop diagnosticBase implementing ComparableDiagnostic, re-add S3-specific comparer code to s3 package * Update tests to use the S3-specific comparer again * Fix test case missed in refactoring * Update the backend.Backend interface to use diagnostics as return value from StateMgr method * Fix calls to `Fatalf`	7 months ago
James Bardin	831ce244bc	add GenerateResourceConfig to builtin provider	7 months ago
Sarah French	62b3ba590a	Update `backend.Backend` interface to return diagnostics from `Workspaces` and `DeleteWorkspace` methods (#37430) ... * Update Backend interface to use diagnostics for `DeleteWorkspace` and `Workspaces` methods * Update testing helpers in backend package * Update pluggable package to match interface changes * Update builtin terraform provider package to match interface changes * Update code in Meta-related files in command package; update error check logic * Update workspace commands; update error check logic * Update Local backend package to match interface changes * Update Cloud backend to match interface changes * Update Remote backend to match interface changes * Update cos remote-state backend to match interface changes * Update inmem remote-state backend to match interface changes * Update pg remote-state backend to match interface changes * Update http remote-state backend to match interface changes * Update consul remote-state backend to match interface changes * Update oss remote-state backend to match interface changes * Update kubernetes remote-state backend to match interface changes * Update gcs remote-state backend to match interface changes * Update s3 remote-state backend to match interface changes * Update oci remote-state backend to match interface changes * Update azure remote-state backend to match interface changes * Allow warnings from Workspaces and DeleteWorkspace methods to be logged or returned to calling code * Fix defect in inmem backend test * Change how warnings from workspace-related methods are output to view/ui	8 months ago
Kristin Laemmert	0374f04424	Add ValidateActionConfig to provider interface, protocol & internal implementations (#37345) ... * Add ValidateActionConfig to provider interface and protocol * Update internal/provider-simple-v6/provider.go Co-authored-by: Daniel Schmidt <danielmschmidt92@gmail.com> --------- Co-authored-by: Daniel Schmidt <danielmschmidt92@gmail.com>	9 months ago
Daniel Schmidt	ac132d1b15	add provider implementation for actions	9 months ago
Sarah French	0f8e77a50f	PSS: Add GetStates and DeleteState RPCs to plugin protocol v6 (#37288) ... * Add GetStates RPC method to Plugin Protocol v6 * Add DeleteState RPC method to Plugin Protocol v6 * Add methods to provider-simple * Fix error messages * Apply suggestions from code review Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com> * Change how GetStates RPC returns the list of state names * Change GetStates implementation to use new data type * `make protobuf` to accommodate new code comments --------- Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com>	9 months ago
Matej Risek	a9b67a6cdc	stacks: Don't require built-in providers to be listed under required providers. (#37234)	10 months ago
Daniel Banck	cb58a15f3d	Implement ListResource RPC (TF-25509) (#37092) ... * Implement ListResource RPC via callbacks * Implement ListResource with iterators * Change `ListResourceResponse` to slice * Turn ListResourceResponse into a struct * Add a limit for ListResource * explicitly cancel stream when listing resources --------- Co-authored-by: Samsondeen Dare <samsondeen.dare@hashicorp.com>	10 months ago
Radek Simko	643266dc90	Add initial state store protocol skeleton (#37197) ... * Add initial state store protocol skeleton Introduce ValidateStateStoreConfig + ConfigureStateStore Update GetProviderSchema + GetMetadata (for mux) * address PR feedback	10 months ago
Daniel Banck	44ae7da18e	Update Plugin Protocol for List and Implement `ValidateListResourceConfig` (#37007) ... * Minor auto-formatting changes * Add list RPC and schema protobuf definitions * make protobuf * make generate * Add ValidateListResourceConfig implementation	11 months ago
Sarah French	46278dad58	Fix bugs where appended diags are not returned	1 year ago
Sarah French	2d6eda2877	Update comments about backend interfaces, enhanced vs operations, and fix copy-paste inaccuracies (#36716) ... * Fix copy-pasta * Update some comments clarifying backend-related interfaces and "enhanced" versus "operations" * Fix more comments that refer to types and interfaces that have moved into the backendrun package	1 year ago
Daniel Banck	b2b42c0fb4	Store resource identities in state (TF-23255) (#36464) ... * Persist resource identity in Terraform state * make syncdeps * Move identity schema merging closer to the protocol * mock GetResourceIdentitySchemas * Fix identity refresh tests * Add more tests * Change grcpwrap upgrade identity * Review feedback * Remove unnecessary version conversion * Check if GetResourceIdentitySchemas RPC call is implemented * Update function signature docs * Adapt protocol changes * Check unimplemented error for identities in GetSchema	1 year ago
Daniel Banck	10c9b64007	Rename schema.Block to Body (#36629)	1 year ago
James Bardin	179c502ffb	make ephemeral resource work during destroy ... Ephemeral resource behavior is a strange mix of temporary values and existing resource types, and their operation during destroy is going to be more difficult to manage than normal resources. The pruneUnusedNodesTransformer is probably no longer equipped to handle the situation, and will probably need to be build in a different manner, but this minor change allows us to move forward for now.	2 years ago
James Bardin	94687676a3	add basic grpc wrapper implemenation	2 years ago
James Bardin	9c3dc8f73a	ephemeral protocol rename ... Add `Resource` to all the ephemeral protocol symbols to make them consistent with existing naming conventions.	2 years ago
James Bardin	03e1a9835d	add ephemeral validation to existing implementations	2 years ago
James Bardin	f490aae056	add ephemeral to terraform provider	2 years ago
James Bardin	bc750192e4	POC for always using decoded changes in core ... We should not need to encode and decode change values within core, since the encoded version is only technically needed for serialization. This pattern stems from the conversion to current changes system, but back then we did not have easy access to the correct schemas at the time to encode and decode the entire set of changes. Moving the core handling of changes to only use the decoded values will drastically improve evaluation efficiency, removing a round trip through encoded values for every resource reference.	2 years ago
Brian Flad	0cbab0f06a	Support moving from null_resource to terraform_data (#35163) ... This change enables the built-in provider's `terraform_data` managed resource to work with the `moved` configuration block where the `from` address is a `null_resource` managed resource type from the official `hashicorp/null` provider. It produces no plan differences for typical configurations and specifically helps practitioners from re-running provisioners while moving resource types. In addition to the unit testing, this was manually tested with the following configurations and outputs: Initial configuration (no `triggers`): ```terraform terraform { required_providers { null = { source = "hashicorp/null" version = "3.2.2" } } } resource "null_resource" "example" { provisioner "local-exec" { command = "echo 'Hello, World!'" } } ``` Moved configuration (no `triggers`): ```terraform resource "terraform_data" "example" { provisioner "local-exec" { command = "echo 'Hello, World!'" } } moved { from = null_resource.example to = terraform_data.example } ``` Moved output (no `triggers`): ```console $ terraform apply terraform_data.example: Refreshing state... [id=892002337455008838] Terraform will perform the following actions: # null_resource.example has moved to terraform_data.example resource "terraform_data" "example" { id = "892002337455008838" } Plan: 0 to add, 0 to change, 0 to destroy. Do you want to perform these actions? Terraform will perform the actions described above. Only 'yes' will be accepted to approve. Enter a value: yes Apply complete! Resources: 0 added, 0 changed, 0 destroyed. ``` Initial configuration (with `triggers`): ```terraform terraform { required_providers { null = { source = "hashicorp/null" version = "3.2.2" } } } resource "null_resource" "example" { triggers = { examplekey = "examplevalue" } provisioner "local-exec" { command = "echo 'Hello, World!'" } } ``` Moved configuration (with `triggers`): ```terraform resource "terraform_data" "example" { triggers_replace = { examplekey = "examplevalue" } provisioner "local-exec" { command = "echo 'Hello, World!'" } } moved { from = null_resource.example to = terraform_data.example } ``` Moved output (with `triggers`): ```console $ terraform apply terraform_data.example: Refreshing state... [id=1651348367769440250] Terraform will perform the following actions: # null_resource.example has moved to terraform_data.example resource "terraform_data" "example" { id = "1651348367769440250" # (1 unchanged attribute hidden) } Plan: 0 to add, 0 to change, 0 to destroy. Do you want to perform these actions? Terraform will perform the actions described above. Only 'yes' will be accepted to approve. Enter a value: yes Apply complete! Resources: 0 added, 0 changed, 0 destroyed. ```	2 years ago
Daniel Banck	0fe733acf0	provider/terraform: Add description to `encode_tfvars`, `decode_tfvars`, and `encode_expr` (#34891)	2 years ago
Martin Atkins	58b48f4bab	provider/terraform: Use new convention for function names ... When we added these functions we hadn't yet settled on a single convention for how provider-contributed functions ought to be named, and so these followed the convention previously used for Terraform's own built-in functions. We've now decided to use the new provider namespace as an opportunity to partially fix the historical design error of naming functions as all lowercase without any separation between words. This makes the provider functions inconsistent with the built-in functions, but should at least hopefully encourage the provider functions to be consistent with one another, so that the rule for which to use is relatively easy to remember. This also switches the word order because the provider functions convention prefers the verb to come first: encode_tfvars instead of tfvarsencode.	2 years ago
James Bardin	154f9ada90	disconnect remote-exec immediately ... The remote-exec provisioner was not disconnecting immediately after provisioning. The remote exec context was tired to the lifetime of the provisioner, but the provisioner node used to not live long after the remote execution had completed so it was not noticed. Some more recent refactoring extends the lifetime of the node, and causes the provisioner connections to hang around longer when they're not needed. Ensure we disconnect immediately after the remote execution is complete.	2 years ago
Martin Atkins	d86eee6c1f	go.mod: Eliminate github.com/apparentlymart/go-dump ... I originally wrote this library as a stopgap measure because davecgh/go-spew produced a hard-to-read representation of cty.Value due to exposing the raw internals, whereas my "go-dump" instead just pretty-prints whatever fmt.Sprintf("%#v", ...) would return for a given value. However, in the meantime I wrote ctydebug as a more cty-specialized library for this purpose, and we switched to using go-cmp as our primary library for deep-comparing data structures, and so our few remaining uses of apparentlymart/go-dump were vestigial in tests that haven't been updated recently enough to have been updated to our new standards. This commit therefore swaps out all use of that library with combinations of go-cmp and ctydebug, matching our current standards for how to do these sorts of things in tests. This removes our dependency on "go-dump" altogether. At least one of our dependencies is still using go-dump as part of its own test suite, and so the Go toolchain still includes its declared version in our go.sum file. However, this library is no longer linked in to Terraform either in real builds or in test binaries, and so it gets dropped entirely from our go.mod file.	2 years ago
Martin Atkins	573c2db658	provider/terraform: Terraform-specific encoding functions ... Using the new possibility of provider-contributed functions, this introduces three new functions which live in the terraform.io/builtin/terraform provider, rather than being language builtins, due to their Terraform-domain-specific nature. The three new functions are: - tfvarsencode: takes a mapping value and tries to transform it into Terraform CLI's "tfvars" syntax, which is a small subset of HCL that only supports key/value pairs with constant values. - tfvarsdecode: takes a string containing content that could potentially appear in a "tfvars" file and returns an object representing the raw variable values defined inside. - exprencode: takes an arbitrary Terraform value and produces a string that would yield a similar value if parsed as a Terraform expression. All three of these are very specialized, of use only in unusual situations where someone is "gluing together" different Terraform configurations etc when the usual strategies such as data sources are not suitable. There's more information on the motivations for (and limitations of) each function in the included documentation.	2 years ago
Daniel Schmidt	cf4d99a926	if file provisioners source is null throw error instead of panic ... Fixes #34454	2 years ago
Liam Cervante	7d143388f3	Add support for the cross resource type move operation in the proto schema (#34480) ... * Update proto schema and provider interfaces with support for moved across resource type RPCs * address comments * remove unused functions * remove support for flatmap format	2 years ago
James Bardin	2574b899e7	Merge pull request #34385 from hashicorp/jbardin/provider-functions-impl ... client-side implementation of provider functions	2 years ago
Jamie Finnigan	05b0bdac99	adopt hashicorp/cli fork of mitchellh/cli (#34429)	2 years ago
James Bardin	9abaf2f3b0	update provider code to match new rpc methods ... Add the types, methods, and basic framework to use provider defined functions.	2 years ago
Martin Atkins	b0b8d4aa6f	states: Only track root module output values ... For a very long time we've had an annoying discrepancy between the in-memory state model and our state snapshot format where the in-memory format stores output values for all modules whereas the snapshot format only tracks the root module output values because those are all we actually need to preserve between runs. That design wart was a result of us using the state both as an internal and an external artifact, due to having nowhere else to store the transient values of non-root module output values while Terraform Core does its work. We now have namedvals.State to internally track all of the throwaway results from named values that don't need to persist between runs, so now we'll use that for our internal work instead and reserve the states.State model only for the data that we will preserve between runs in state snapshots. The namedvals internal model isn't really designed to support enumerating all of the output values for a particular module call, but our expression evaluator currently depends on being able to do that and so we have a temporary inefficient implementation of that which just scans the entire table of values as a stopgap just to avoid this commit growing even larger than it already is. In a future commit we'll rework the evaluator to support the PartialEval mode and at the same time move the responsiblity for enumerating all of the output values into the evaluator itself, since it should be able to determine what it's expecting by analyzing the configuration rather than just by trusting that earlier evaluation has completed correctly. Because our legacy state string serialization previously included output values for all modules, some of our context tests were accidentally depending on the implementation detail of how those got stored internally. Those tests are updated here to test only the data that is a real part of Terraform Core's result, by ensuring that the relevant data appears somewhere either in a root output value or in a resource attribute.	2 years ago
hashicorp-copywrite[bot]	53c34ff49c	Update copyright file headers to BUSL-1.1	3 years ago
Martin Atkins	691018dd00	builtin/providers/terraform: terraform_data "id" is guaranteed non-null ... The "id" attribute of this resource type is generated by the provider itself and can never be null, so we'll refine the range of its unknown result in case that helps downstream expressions to produce known results even when the exact value hasn't yet been planned.	3 years ago
hashicorp-copywrite[bot]	325d18262e	[COMPLIANCE] Add Copyright and License Headers	3 years ago
James Bardin	3b953d3bd8	allow terraform_data to import ... The terraform provider was panicking on import, because it didn't previously have a resource type which could be imported at all. Add a stub import function for terraform_data as a placeholder to allow the call to complete successfully. While there's no need to actually import a terraform_data resource, users will inevitably use this to construct examples of import actions for learning purposes or bug reports. This still isn't very useful even for examples however, because the state-only nature of the terraform_data resource type means that we can't fill in the state from only the import ID. This means that any value in `trigger_replace` or `input` will cause a change in the next plan. Once configuration data is available during import we can extend this to create a logical final state based on config.	3 years ago
Pooya	6bbb76eca3	Added Quiet value (#32116) ... * Added Quiet value * Added Quiet value * Added Quiet value * Removed comments on 170 171 173 Co-authored-by: itspooya <fallenangel201190@gmail.com>	3 years ago
James Bardin	e09b67bebd	simplify output assignment	3 years ago
James Bardin	e2a6397a06	typed null input should be reflected in output ... The configuration may be supplying a typed null value to the terraform_data.input attribute, which must be reflected in the output to have a valid plan.	3 years ago
James Bardin	d0d6501c1f	s/trigger/triggers_replace/ ... Rename `triggers` to be more descriptive, making it similar to `replace_triggered_by`.	3 years ago
James Bardin	3b73ed3348	new terraform_data managed resource ... Replace and enhance the `null_resource` functionality with a new `terraform_data` managed resource.	3 years ago
Jarrett Spiker	060255a9d5	Use safe or force workspace delete for cloud backend	3 years ago
James Bardin	953c448f9a	add simple error indicating backend removal ... There are no good options for inserting diagnostics into the backend lookup, or creating a backend which reports it's removal because none of the init or GetSchema functions return any errors. Keep a registry of the removed backend so that we can at least notify users that a backend was removed vs an invalid name.	4 years ago