12 Commits (add-missing-variable-loading)

Author	SHA1	Message	Date
Radek Simko	0fe906fa8c	make copyrightfix	3 months ago
Sarah French	6847e763de	Update calls to StateMgr method to use diagnostics more conventionally (#37597) ... * Update call to StateMgr method to use diagnostics more explicitly * Update calling code in remote backend tests * Update calling code in non-test code to handle diags conventionally. * Fix test failure messages from using wrong variable * Additional refactoring	8 months ago
Sarah French	8503c45013	Update `backend.Backend`'s `StateMgr` method to return diagnostics instead of primitive errors (#37496) ... * Fix S3 backend test affected by making the Workspaces method return errors via diagnostics * Address diagnostics comparison issues in test by ensuring expected diagnostics are defined in the context of the config they're triggered by * Fix failing test case `TestBackendConfig_EC2MetadataEndpoint/envvar_invalid_mode` by making `diagnosticBase` struct comparable * Add compile-time checks that diagnostic types fulfil interfaces * Stop diagnosticBase implementing ComparableDiagnostic, re-add S3-specific comparer code to s3 package * Update tests to use the S3-specific comparer again * Fix test case missed in refactoring * Update the backend.Backend interface to use diagnostics as return value from StateMgr method * Fix calls to `Fatalf`	9 months ago
Sarah French	125cf53470	Add acceptance and internal tests for `gcs` backend, add some test helper functions (#35026) ... * Add TF_ACC checks in gcs tests, separate from the bucket setup logic * Add tests for handling of `encryption_key` and `kms_encryption_key` * Refactor `setupBackend` to take config as an argument * Add test that asserts that setting credentials to `""` in the config doesn't affect use of ENV-supplied credentials * Move non-acceptance tests into separate test file * Add comment about `getWantValue` * Fix use of t.Parallel * Make `preCheckTestAcc` skip tests, so that checks can pass in hashicorp/terraform PRs * Add precheck for credentials in test environment. Skip if missing, to let checks pass in hashicorp/terraform repo. * Update new test to use precheck functions Move `TestBackendEncryptionKeyEmptyConflict` test to internal test file * Address feedback about how expected encryption key is supplied to test cases * Change test case * Address missing return	2 years ago
Martin Atkins	660ff86c4c	backendbase: Preserve unset arguments as null when not set by env ... Previously we tried a simplification where any attribute with an "SDK-like default" was guaranteed to never be null, because that seemed like a plausible mimic of the legacy SDK's general aversion to nulls. However, the SDK does still respect the absense of an argument as different to its zero value in one narrow case: when the argument isn't set in the configuration, also isn't set by any environment variables, and has no static fallback default. In that case, the SDK's built-in validation rules such as "ConflictsWith" _do_ treat absent as different from zero-value. To allow backends to continue making such distinctions themselves where that's useful, SDKLikeDefaults now leaves an attribute set to null if it wasn't present in the configuration and none of the environment variables or fallback value cause it to end up being a non-empty string. The backend can then choose to bypass the SDKLikeData API and check the cty.Value directly if it wants to distinguish set from zero even though SDKLikeData is designed to avoid the need to do that. This also updates the gcs backend to make use of the new facility, since it wants to raise an error if two arguments are both set even if they are both set to the empty string. Restoring that original error case is the main motivation for this change.	2 years ago
Martin Atkins	5868f99413	backend/gcs: Stop using legacy helper/schema ... As part of our efforts to remove the large snapshot of the legacy SDK that we've been using, this replaces the uses of that package with our new lightweight "backendbase" package, which is a collection of helpers that can substitute for most of the parts of the legacy SDK that backends tend to use. For this backend for now we'll use the "SDK like" helpers which aim to retain some of the legacy-SDK-specific assumptions that aren't technically true anymore, such as the idea that null and empty string are equivalent. Hopefully one day we'll be able to wean this backend off of that more completely, but this is a pragmatic way to get away from the legacy SDK without a large rewrite. This also drew attention to the fact that this backend was previously relying on the weird context.Context value that the SDK was passing in to the configure method, even though that context isn't connected up to anything particularly useful. In the long run we should change the backend APIs to pass context.Context to each method that might make network requests, but for now we're using context.TODO so that we can more easily find these cases and update them later once there's a real context to use.	2 years ago
Martin Atkins	914618b061	gcs: Adopt the "ReadPathOrContents" helper function ... Package backend previously had a ReadPathOrContents helper that takes a string that could represent either a filename or some literal content, and then reads the given file if it's a filename or just returns the literal content otherwise. We originally used variations of this helper to shim a number of different situations that had originally accepted filenames but later changed to accept literal content, but over time we've eliminated all of those and so the only remaining caller is the gcs backend which uses it to accept GCP credentials either as literal content or as a file containing the credentials. Therefore here we move that helper function to be just an unexported part of the gcs backend package. This is part of an ongoing effort to minimize what each remote state backend depends on (either directly or indirectly) so that we can make gradual progress towards these remote state backends being self-contained enough to move into other codebases. In the short term though, it just puts this helper function closer to its caller so it's easier to maintain them both together if needed.	2 years ago
hashicorp-copywrite[bot]	53c34ff49c	Update copyright file headers to BUSL-1.1	3 years ago
hashicorp-copywrite[bot]	325d18262e	[COMPLIANCE] Add Copyright and License Headers	3 years ago
Sarah French	d43ec0f30f	Add customer-managed encryption key (KMS) support to GCS backend (#31786) ... * Add ability to use customer-managed KMS key to encrypt state, add acceptance tests * Change test names for different encrpytion methods * Commit files updated by `go mod tidy` * Add guard against missing ENVs to `setupKmsKey` func * Update KMS setup function to get credentials from ENVs * Update tests to not include zero-values in config This means that default values are supplied later by TF instead of supplied as config from the user This also avoids issues related to making field conflicts explicit with `ConflictsWith` * Make `encryption_key` & `kms_encryption_key` conflicting fields Removing the Default from `encryption_key` does not appear to be a breaking change when tested manually * Add ability to set `kms_encryption_key` via ENV * Refactor `encryption_key` to use `DefaultFunc` to access ENV, if set * Remove comments * Update `gcs` backend docs & descriptions in schema * Update `gcs` backend docs to include information on encryption methods * Apply technical writing suggestions from code review Co-authored-by: Matthew Garrell <69917312+mgarrell777@users.noreply.github.com> * Update documentation to remove passive voice * Change use of context in tests, add inline comment, update logs * Remove use of `ReadPathOrContents` for new field Co-authored-by: Matthew Garrell <69917312+mgarrell777@users.noreply.github.com>	4 years ago
Martin Atkins	f40800b3a4	Move states/ to internal/states/ ... This is part of a general effort to move all of Terraform's non-library package surface under internal in order to reinforce that these are for internal use within Terraform only. If you were previously importing packages under this prefix into an external codebase, you could pin to an earlier release tag as an interim solution until you've make a plan to achieve the same functionality some other way.	5 years ago
Martin Atkins	73dda868cc	Move backend/ to internal/backend/ ... This is part of a general effort to move all of Terraform's non-library package surface under internal in order to reinforce that these are for internal use within Terraform only. If you were previously importing packages under this prefix into an external codebase, you could pin to an earlier release tag as an interim solution until you've make a plan to achieve the same functionality some other way.	5 years ago