terraform

Commit Graph

Author	SHA1	Message	Date
Daniel Schmidt	a9756b273c	move initwd config loading into terraform otherwise we run into cyclic references	1 month ago
Daniel Banck	4ef9684188	Rework most of the configuration loading We previously used a loader -> BuildConfig flow to load configuration. This commit changes most (but not all yet) flows to use the new graph-based approach. Instead of simply recursively loading the modules, we now need to take a stepped approach: 1. Load the root module 2. Collect the variables and their values 3. Build the configuration with the graph-based approach Because this approach relies on different parts from different packages, it can't easliy be done within the `configload` package. So, now we do most of in the backend or command.	1 month ago
Radek Simko	07b3e3b800	command/init: Merge duplicated PSS logic back into existing codepath (#38227 )	1 month ago
Daniel Schmidt	2424cf6423	make test case more robust to developer environments	2 months ago
Daniel Banck	a39e3bce32	make syncdeps	2 months ago
Sarah French	eab282f617	test: Add `http` backend locking test (#38192 ) * test: Update TestHTTPBackend so it can be created with pre-existing lock info inside it. This will be used for tests that want to assert the lock info returned with lock errors. * test: Add a test asserting data returned in lock errors from the http backend. * chore: Replace use of `io/ioutil` in http backend * chore: Update changelog entry to link to the original PR https://github.com/hashicorp/terraform/pull/38144 * test: Improve test code comments	2 months ago
Nicholas Ngai	5e4cfd42fa	backend/http: Return existing lock info from backend on conflict (#38144 ) * Return existing lock info from http state backend on conflict * Remove info from LockError if failed to read or unmarshal * Add change to .changes	2 months ago
Daniel Schmidt	026c935961	move UnparsedVariableValue from backendrun to arguments This prevents a cyclic dependency and also makes sense semantically. The arguments package will collect the unparsed variable values and the backendrun helpers will work to collect the values and transform them into terraform.InputValue.	2 months ago
Sarah French	817ed318db	chore: Update go version from 1.25 to 1.25.7 (#38185 ) * chore: Update go version from 1.25 to 1.25.7 * chore: make syncdeps	2 months ago
Radek Simko	0fe906fa8c	make copyrightfix	2 months ago
Radek Simko	244443b3e0	make syncdeps	2 months ago
Brandon Croft	1df7030c5a	Revert "make syncdeps" This reverts commit `c42d0006fe`.	2 months ago
Radek Simko	27770ee805	PSS: Migration from a backend to a state store (#38048 ) * backend/inmem: Make it easier to use the backend in tests * cloud: Make the cloud backend testable * command/views: Introduce migration UI messages * command/init: Add 3 tests for migrations from a backend to PSS - TestInit_backend_to_stateStore_singleWorkspace - TestInit_backend_to_stateStore_multipleWorkspaces - TestInit_cloud_to_stateStore * command/init: Implement migration from a backend to PSS * address PR feedback * remove local state after migration	2 months ago
Brandon Croft	c42d0006fe	make syncdeps	2 months ago
Sarah French	02a4ddce1b	fix: Fail an `apply` command if the plan file was generated for a workspace that isn't the selected workspace (#37955 ) * fix: Fail apply command if the plan file was generated for a workspace that isn't the selected workspace. * Add change file * test: Update test helper to include Workspace name in plan representation * fix: Make error message more generic, so is applicable to backend and cloud blocks. * fix: Make error message specific to backend or cloud block * test: Add separate tests for backend/cloud usage * test: Update remaining tests to include a value for Workspace in mocked plans * Apply suggestions from code review Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com> * fix: Panic when a plan file has missing workspace data * test: Update test to match changes in error text --------- Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com>	2 months ago
Jared Baker	35e81db902	Merge pull request #38047 from hashicorp/s3/aws-sdk-go-base-upgrade backend/s3: bump `github.com/hashicorp/aws-sdk-go-base/v2`	3 months ago
Radek Simko	1186262c8c	backend/http: Refresh state earlier (align with other backends) (#38033 ) * correct changelog entry for #38027 * backend/http: Refresh state before returning StateMgr This aligns the http backend with the implementation of StateMgr in other remote backends, which in turn enables easier testing of higher level logic that relies on certain backend behaviours. * backend/http: Refactor TestHTTPBackend to allow custom method implementations * add regression test for PR 38027	3 months ago
Jared Baker	6475423325	backend/s3: bump `github.com/hashicorp/aws-sdk-go-base/v2` Incrementing the `aws-sdk-go-base` dependecy will also pull in the latest version of the AWS SDK for Go V2, which includes support for the newly launched `aws login` authentication method.	3 months ago
Jared Baker	4f53303c12	Merge branch 'main' into fix/s3-backend-fips-env-var-parsing	3 months ago
Radek Simko	213d133d86	command/meta: Enable migration from PSS to a backend (#37949 ) * command/meta: Enable migration from PSS to a backend * Address PR feedback * Update internal/command/meta_backend.go Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com> * meta_backend: Rename stateStore_c_S to stateStore_to_backend --------- Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>	4 months ago
Sarah French	f591872699	PSS: Allow pluggable state store configuration to be stored in a plan file (#37956 ) * refactor: Rename Meta's backendState field to backendConfigState This helps with navigating ambiguity around the word backend. The new name should indicate that the value represents a `backend` block, not a more general interpretation of what a backend is. * fix: Only set backendConfigState to synthetic object if it's nil due to a lack of data. Don't change it if pluggable state storage is in use. * feat: Enable recording a state store's details in an Operation, and using that data when creating a plan file. * fix: Include provider config when writing a plan file using pluggable state storage * fix: Having `backendConfigState` be nil may be valid, but it definitely isn't valid for `stateStoreConfigState` to be nil When backendConfigState is nil it means that an implied local backend is in use, i.e. there is no backend block in the config. * test: Add integration test showing that a plan command creates a plan file with the expected state_store configuration data * refactor: Apply suggestion from @radeksimko Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com> * fix: Allow panics to occur if an unexpected implementation of `backend.Backend` is encountered when managing a state store * docs: Add code comment explaining the current situation with passing backend config state to downstream logic. In future this should be simplified, either via refactoring or changes affecting the implied local backend --------- Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com>	4 months ago
James Pogran	2c075b9f8e	Add component registry source resolution support to Terraform Stacks (#37888 ) * Add component registry source resolution support to Terraform Stacks This change implements the missing component source resolution case in the stack configuration loader, enabling Terraform Stacks to properly handle component registry sources from HCP Terraform and other component registries. The implementation mirrors the existing module registry resolution workflow, where component sources are first resolved to their versioned form using the source bundle's component metadata, then converted to final source addresses that can be used to locate the actual component code. This completes the integration between the terraform-registry-address component parsing capabilities and the go-slug sourcebundle component resolution APIs. * chore: bump go-slug to v0.18.1 * fix: add case for component final source type * chore: rm space * chore: sync module deps * chore: update testdata with separate bundle * fix: manifest file json obj with trailing comma * Add changelog entry to 1.14 --------- Co-authored-by: Michael Yocca <michael.yocca@hashicorp.com>	4 months ago
Sarah French	9fb91c2229	PSS: Refactor Plan struct to reference `Backend` and `StateStore` via pointers, update calling code (#37946 ) * refactor: Update Plan struct's Backend field to be a pointer * fix: Add some refactorings or protections against nil pointers when accessing the Backend field on a Plan struct * refactor: Update Plan struct's StateStore field to be a pointer, update a nil check in calling code.	4 months ago
Sarah French	64015ca6d2	refactor: let panic arise directly if the provider doesn't implement providers.StateStoreChunkSizeSetter (#37942 )	4 months ago
Sarah French	cf047be4e4	PSS: Use interfaces to configure state stores (#37899 ) * refactor: Move chunk size limit constants to new `chunks` package * refactor: Make `NewPluggable` return a `Pluggable` concrete type, instead of an instance of the `backend.Backend` interface. * refactor: Configure state stores through the backend.Backend interface, instead of directly using methods related to RPCs. This requires changing where we call `SetStateStoreChunkSize`. * docs: Add godocs comment to `StateStoreChunkSizeSetter` interface To summarize, we don't really need the `SetStateStoreChunkSize` method, and instead methods like `(GRPCProvider).ConfigureStateStore` in the `plugin6` package can directly inspect the negotiation process that passes through that code and pull out the chunk size. However that means that that code would also need to implement validation. And that's just `(GRPCProvider).ConfigureStateStore`; what about all the test mocks that are used in different types of test? They would all need to be implemented similarly to GRPCProvider to be good, useful mocks, and then a lot of things that fulfil the provider.Interface interface are coupled to each other. Instead, it's easier to have validation in the `grpcClient` struct's methods in the `remote` package, as that code is common to all scenarios. That code needs a method to 'reach into' the provider.Interface value, so we use the `SetStateStoreChunkSize` method. * chore: Make it clearer that the v6 GRPCProvider implements `SetStateStoreChunkSize` * fix: Remove unnecessary assignment of chunk size I'm surprised that removing this doesn't break E2E tests of PSS that use grpcwrap, but I think there's `plugin6` code that runs in that situation, so maybe chunking is handled elsewhere. * chore: Add panic to try detect unexpected cases when setting chunk size. * feat: Add `providers.StateStoreChunkSizeSetter` implementation to provider-simple-v6 * docs: Update code comments for NewPluggable describing its intended use	5 months ago
Kevin Vu	b62d97ac88	fix: parse boolean env vars in S3 backend correctly Fixes #37601	5 months ago
dependabot[bot]	7034a193d9	build(deps): bump golang.org/x/crypto from 0.44.0 to 0.45.0 (#37925 ) * build(deps): bump golang.org/x/crypto from 0.44.0 to 0.45.0 Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.44.0 to 0.45.0. - [Commits](https://github.com/golang/crypto/compare/v0.44.0...v0.45.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.45.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * run syncdeps --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Daniel Banck <daniel@dbanck.de>	5 months ago
Sarah French	1dd8e60f15	chore: Bump golang.org/x/crypto dependency, ignore SA4003 linting errors globally (#37901 ) * chore: Upgrade golang.org/x/crypto - `go get golang.org/x/crypto@v0.44.0` * chore: Upgrade golang.org/x/crypto in submodules - `make syncdeps` * chore: Run `make generate` * chore: Ignore SA4003 linter error globally, as `golang.org/x/tools/cmd/stringer` generates code that breaks this rule when it's used with custom types that have unsigned integers or bytes as the underlying type.	5 months ago
Sarah French	f2818db795	PSS : Add `fs` and `inmem` state storage implementations to the builtin `simplev6` provider, update `grpcwrap` package, use PSS implementation in E2E test (#37790 ) * feat: Implement `inmem` state store in provider-simple-v6 * feat: Add filesystem state store `fs` in provider-simple-v6, no locking implemented * refactor: Move PSS chunking-related constants into the `pluggable` package, so they can be reused. * feat: Implement PSS-related methods in grpcwrap package * test: Add E2E test checking an init and apply (no plan) workflow is usable with both PSS implementations * fix: Ensure state stores are configured with a suggested chunk size from Core --------- Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com>	5 months ago
Sarah French	f4d0ec5136	PSS: Fix hashing without provider version (#37852 ) * Fix panic hashing backend config when a builtin or reattached provider is used for PSS * Add test showing a nil version.Version is tolerated by the Hash method, refactor existing test Protect against provider version data missing when using an un-reattached, un-builtin provider. Add test coverage. * Make reporting errors from reattach.IsProviderReattached more consistent * Run `make syncdeps` * Update tests to show when nil provider data is tolerated	5 months ago
Radek Simko	cbda324977	backend/oss: Bump github.com/aliyun/aliyun-oss-go-sdk to v2.1.1 (#37442 )	6 months ago
Sarah French	6b73f710f8	PSS: Implement initialisation of new working directory (or use of `-reconfigure` flag) while using `state_store` (#37732 ) * Minor fixes in diagnostics This can only be done once modules have been parsed and the required providers data is available. There are multiple places where config is parsed, into either Config or Module structs, so this needs to be implemented in multiple places. * Rename test to make it specific to use of backend block in config * Update initBackend to accept whole initArgs collection * Only process --backend-config data, when setting up a `backend`, if that data isn't empty * Simplify how mock provider factories are made in tests * Update mock provider's default logic to track and manage existing workspaces * Add `ProviderSchema` method to `Pluggable` structs. This allows calling code to access the provider schema when using provider configuration data. * Add function for converting a providerreqs.Version to a hashicorp/go-version Version. This is needed for using locks when creating the backend state file. * Implement initial version of init new working directories using `stateStore_C_s`. Default to creating the default workspace if no workspaces exist. * Update test fixtures to match the hashicorp/test mock provider used in PSS tests * Allow tests to obtain locks that include `testingOverrides` providers. The `testingOverrides` field will only be set in tests, so this should not impact end users. * Add tests showing TF can initialize a working directory for the first time (and do the same when forced by -reconfigure flag). Remove replaced tests. * Add -create-default-workspace flag, to be used to disable creating the default workspace by default when -input=false (i.e for use in CI). Refactor creation of default workspace logic. Add tests. * Allow reattached providers to be used during init for PSS * Rename variable to `backendHash` so relation to `backend` is clearer * Allow `(m Meta) Backend` to return warning diagnostics Protect against nil testingOverrides in providerFactoriesFromLocks * Add test case seeing what happens if default workspace selected, doesn't exist, but other workspaces do exist. The consequences here are due to using `selectWorkspace` in `stateStore_C_s`, matching what's done in `backend_C_r_s`. * Address code consistency check failure on PR * Refactor use of mock in test that's experiencing EOF error... * Remove test that requires test to supply input for user prompt This test passes when run in isolation but fails when run alongside other tests, even when skipping all other tests using `testStdinPipe`. I don't think the value of this test is great enough to start changing how we test stdin input. * Allow -create-default-workspace to be used regardless of whether input is enabled or disabled * Add TF_SKIP_CREATE_DEFAULT_WORKSPACE environment variable * Responses to feedback, including making testStdinPipe helper log details of errors copying data to stdin. Note: We cannot call t.Fatal from a non-test goroutine. * Use Errorf instead * Allow backend state files to not include version data when a builtin or reattached provider is in use. * Add clarifying comment about re-attached providers when finding the matching entry in required_providers * Report that the default workspace was created to the view * Refactor: use error comparison via `errors.Is` to identify when no workspaces exist. * Move handling of TF_ENABLE_PLUGGABLE_STATE_STORAGE into init's ParseInit func. * Validate that PSS-related flags can only be used when experiments are enabled, enforce coupling of PSS-related flags when in use. * Slight rewording of output message about default workspace * Update test to assert new output about default workspace	6 months ago
Dirk Avery	edb3f6487d	Bump go-getter v1.8.2	6 months ago
Liam Cervante	6b17cfe2e5	actions: connect invoke flag with TFC (#37544 ) * actions: connect invoke flag with TFC * use latest go-tfe	6 months ago
Dirk Avery	c5cdbf00c6	sync deps	6 months ago
Dirk Avery	5e3a9fbdf3	Bump aws-sdk-go-base	6 months ago
Samsondeen	ab41592fb7	query: propagate graph node removal to descendants (#37664 )	7 months ago
Sarah French	6847e763de	Update calls to StateMgr method to use diagnostics more conventionally (#37597 ) * Update call to StateMgr method to use diagnostics more explicitly * Update calling code in remote backend tests * Update calling code in non-test code to handle diags conventionally. * Fix test failure messages from using wrong variable * Additional refactoring	7 months ago
Daniel Banck	1ac8497994	Add support for Terraform Search in the cloud backend (TF-25935) (#37479 )	7 months ago
Liam Cervante	551ba2e525	Implement controlling destroy functionality within Terraform Test (#37359 ) * Add ability to parse backend blocks present in a test file's run blocks, validate configuration (#36541) * Add ability to parse backend blocks from a run block * Add validation to avoid multiple backend blocks across run blocks that use the same internal state file. Update tests. * Add validation to avoid multiple backend blocks within a single run block. Update tests. * Remove use of quotes in diagnostic messages * Add validation to avoid backend blocks being used in plan run blocks. Update tests. * Correct local backend blocks in new test fixtures * Add test to show that different test files can use same backend block for same state key. * Add validation to enforce state-storage backend types are used * Remove TODO comment We only need to consider one file at a time when checking if a state_key already has a backend associated with it; parallelism in `terraform test` is scoped down to individual files. * Add validation to assert that the backend block must be in the first apply command for an internal state * Consolidate backend block validation inside a single if statement * Add initial version of validation that ensures a backend isn't re-used within a file * Explicitly set the state_key at the point of parsing the config TODO: What should be done with method (moduletest.Run).GetStateKey? * Update test fixture now that reusing backend configs has been made invalid * Add automated test showing validation of reused configuration blocks * Skip test due to flakiness, minor change to test config naming * Update test so it tolerates non-deterministic order run blocks are evaluated in * Remove unnecessary value assignment to r.StateKey * Replace use of GetStateKey() with accessing the state key that's now set during test config parsing * Fix bug so that run blocks using child modules get the correct state key set at parsing time * Update acceptance test to also cover scenario where root and child module state keys are in use * Update test name * Add newline to regex * Ensure consistent place where repeat backend error is raised from * Write leftover test state(s) to file (#36614) * Add additional validation that the backend used in a run is a supported type (#36648) * Prevent test run when leftover state data is present (#36685) * `test`: Set the initial state for a state files from a backend, allow the run that defines a backend to write state to the backend (#36646) * Allow use of backend block to set initial state for a state key * Note about alternative place to keep 'backend factories' * Allow the run block defining the backend to write state to it * Fix rebase * Change to accessing backend init functions via ContextOpts * Add tests demonstrating how runs containing backend blocks use and update persisted state * Fix test fixture * Address test failure due to trouble opening the state file This problem doesn't happen on MacOS, so I assume is due to the Linux environment of GitHub runners. * Fix issue with paths properly I hope * Fix defect in test assertion * Pivot back to approach introduced in `4afc3d7` * Let failing tests write to persistent state, add test case covering that. I split the acceptance tests into happy/unhappy paths for this, which required some of the helper functions' declarations to be raised up to package-level. * Change how we update internal state files, so that information about the associated backend is never lost * Fix UpdateStateFile * Ensure that the states map set by TestStateTransformer associates a backend with the correct run. * Misc spelling fixes in comments and a log * Replace state get/set functions with existing helpers (#36747) * Replace state get/set functions with existing helpers * Compare to string representation of state * Compare to string representation of state * Terraform Test: Allow skipping cleanup of entire test file or individual run blocks (#36729) * Add validation to enforce skip_cleanup=false cannot be used with backend blocks (#36857) * Integrate use of backend blocks in tests with skip_cleanup feature (#36848) * Fix nil pointer error, update test to not be table-driven * Make using a backend block implicitly set skip_cleanup to true * Stop state artefacts being created when a backend is in use and no cleanup errors have occurred * Return diagnostics so calling code knows if cleanup experienced issues or not * Update tests to show that when cleanup fails a state artefact is created * Add comment about why diag not returned * Bug fix - actually pull in the state from the state manager! * Split and simplify (?) tests to show the backend block can create and/or reuse prior state * Update test to use new fixtures, assert about state artefact. Fix nil pointer * Update test fixture in use, add guardrail for flakiness of forced error during cleanup * Refactor so resource ID set in only one place * Add documentation for using a `backend` block during `test` (#36832) * Add backend as a documented block in a run block * Add documentation about backend blocks in run blocks. * Make the relationship between backends and state keys more clear, other improvements * More test documentation (#36838) * Terraform Test: cleanup command (#36847) * Allow cleanup of states that depend on prior runs outputs (#36902) * terraform test: refactor graph edge calculation * create fake run block nodes during cleanup operation * tidy up TODOs * fix tests * remove old changes * Update internal/moduletest/graph/node_state_cleanup.go Co-authored-by: Samsondeen <40821565+dsa0x@users.noreply.github.com> * Improve diagnostics around skip_cleanup conflicts (#37385) * Improve diagnostics around skip_cleanup conflicts * remove unused dynamic node * terraform test: refactor manifest file for simplicity (#37412) * test: refactor apply and plan functions so no run block is needed * terraform test: write and load state manifest files * Terraform Test: Allow skipping cleanup of entire test file or individual run blocks (#36729) * terraform test: add support for skip_cleanup attr * terraform test: add cleanup command * terraform test: add backend blocks * pause * fix tests * remove commented code * terraform test: make controlling destroy functionality experimental (#37419) * address comments * Update internal/moduletest/graph/node_state_cleanup.go Co-authored-by: Samsondeen <40821565+dsa0x@users.noreply.github.com> --------- Co-authored-by: Samsondeen <40821565+dsa0x@users.noreply.github.com> * add experimental changelog entries --------- Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com> Co-authored-by: Samsondeen <40821565+dsa0x@users.noreply.github.com> Co-authored-by: Samsondeen Dare <samsondeen.dare@hashicorp.com>	7 months ago
Liam Cervante	00d680d819	apply: include sensitive metadata when comparing changed input values (#37582 ) * apply: include sensitive metadata when comparing changed input values * correct changelog entry	7 months ago
Kristin Laemmert	bbb8af989c	deps: bump xz to address bug in previous version (#37573 ) * deps: bump xz, bug in previous version	7 months ago
Dirk Avery	74b0925633	Merge pull request #37567 from hashicorp/dep-bump-go-getter bump: go-getter to 1.8.0	7 months ago
Sarah French	67eb3c9210	s3: Fix tests after changing the interface to return diagnostics (#37571 ) * Fix tests after changing the interface to return diagnostics * Fix curly brace position	7 months ago
Dirk Avery	92bf04ae16	bump: go-getter to 1.8.0	7 months ago
Sarah French	508234892c	Update `remote.Client` interface's methods to return diagnostics instead of primitive errors (#37502 ) * Update remote package's Client interface to use diagnostics instead of errors * Update all implementations of Client interface to match changes, update calling code (incl. tests) to use diags.	7 months ago
Sarah French	8503c45013	Update `backend.Backend`'s `StateMgr` method to return diagnostics instead of primitive errors (#37496 ) * Fix S3 backend test affected by making the Workspaces method return errors via diagnostics * Address diagnostics comparison issues in test by ensuring expected diagnostics are defined in the context of the config they're triggered by * Fix failing test case `TestBackendConfig_EC2MetadataEndpoint/envvar_invalid_mode` by making `diagnosticBase` struct comparable * Add compile-time checks that diagnostic types fulfil interfaces * Stop diagnosticBase implementing ComparableDiagnostic, re-add S3-specific comparer code to s3 package * Update tests to use the S3-specific comparer again * Fix test case missed in refactoring * Update the backend.Backend interface to use diagnostics as return value from StateMgr method * Fix calls to `Fatalf`	7 months ago
Amartya Majumdar	54af16eab9	[IPL-7725] Updating Calls to the Remote HCP Terraform API to Retrieve All Workspace Variables (#37241 ) * [IPL-7725] Resolving merge conflicts * [IPL-7725] Updating go.sum files --------- Co-authored-by: Amartya Majumdar <a.majumdar1041@gmail.com>	7 months ago
zeshan	1baef44036	syncdeps: update x/net to v0.41.0	7 months ago
zeshan	da1a28783a	Fix #36897 : Resolve NO_PROXY recognition issue in oss remote backend	7 months ago

1 2 3 4 5 ...

661 Commits (add-missing-variable-loading)