129 Commits (add-missing-variable-loading)

Author	SHA1	Message	Date
Jake Champlin	8cbef79dbf	Allow specifying ldflags via env vars ... Allows specifying `LD_FLAGS` during development builds. ``` $ LD_FLAGS="-linkmode=external" make dev ``` Since the version of DTrace on macOS Sierra (On the public beta's at least) has been updated, this allows DTrace to run on Terraform during development/debugging. ``` $ sudo dtrace -n 'pid$target::main.main:entry' -c "terraform apply" dtrace: description 'pid$target::main.main:entry' matched 1 probe Apply complete! Resources: 0 added, 0 changed, 0 destroyed. Outputs: foo = bar dtrace: pid 23096 has exited CPU ID FUNCTION:NAME 2 265673 main.main:entry ``` Also redirects the `@which stringer` command inside the `generate` Makefile target to `/dev/null` so we stop echoing the path to the `stringer` binary on every call to `generate`.	10 years ago
John Bowler	922e626b7e	Fix Makefile for consistency	10 years ago
John Bowler	4a84697b7d	Support `make test` if TF itself is vendored	10 years ago
James Nugent	27d21778a2	build: Allow TESTARGS on make core-test	10 years ago
James Nugent	3593ea8b0a	build: Remove format check from plugin-dev ... This is intended to reduce cycle time during provider development.	10 years ago
James Nugent	1b011dedf4	build: Skip running tests on /builtin/bins ... This is time consuming and spams the output of Travis - to run no tests.	10 years ago
James Nugent	8895b567f4	build: Add tools target to Makefile	10 years ago
Martin Atkins	78a9f8bfb4	build: "make fmt" to ignore vendor packages ... Several of our vendered dependencies are not gofmt-compliant, but we don't want to fix that since the vendored code is supposed to exactly match upstream.	10 years ago
James Nugent	0c56144d7f	build: Only build once for core-dev	10 years ago
Chris Bednarski	6360e6c8b6	Implemented internal plugin calls; which allows us to compile plugins into the main terraform binary	10 years ago
Poney baker	03c64b9ba5	fix(Makefile): remove 'updatedeps' from .PHONY	10 years ago
Martin Atkins	a1530855a3	Build release binaries in release mode ... This strips debug information from the binaries, making them slightly smaller.	10 years ago
James Nugent	9c236e7508	build: Remove gofmt check from core-dev target	10 years ago
Joshua Spence	cfc2890310	Remove TF_QUICKDEV environment variable ... This environment variable doesn't seem to be used, the last usage was removed in 6fe2703665.	10 years ago
James Nugent	76f203e7e4	build: Update make core-test for vendoring	10 years ago
Paul Hinze	d21b0897a9	Makefile/docs: Lock in 1.6 req, doc vendored deps ... * Drop Go 1.5 compatibility env vars * Drop `make updatedeps` from `Makefile` and docs * Update README w/ vendored dep instructions	10 years ago
James Nugent	ac957ab329	Run `vet` target on `default` target	10 years ago
Trevor Pounds	ebe5346e8f	Enable all `go vet` warnings.	10 years ago
James Nugent	bc6107508d	Fix additional vet warnings	10 years ago
Trevor Pounds	3eb65f2cbb	Enable `go vet -unusedresult` check and fix warnings.	10 years ago
Trevor Pounds	79742fc367	Enable `go vet -composites` check and fix warnings.	10 years ago
Trevor Pounds	8e6d11fc5e	Do not `go vet` vendor dependencies.	10 years ago
Paul Hinze	6fe2703665	Vendor all dependencies w/ Godep ... * Remove `make updatedeps` from Travis build. We'll follow up with more specific plans around dependency updating in subsequent PRs. * Update all `make` targets to set `GO15VENDOREXPERIMENT=1` and to filter out `/vendor/` from `./...` where appropriate. * Temporarily remove `vet` from the `make test` target until we can figure out how to get it to not vet `vendor/`. (Initial experimentation failed to yield the proper incantation.) Everything is pinned to current master, with the exception of: * Azure/azure-sdk-for-go which is pinned before the breaking change today * aws/aws-sdk-go which is pinned to the most recent tag The documentation still needs to be updated, which we can do in a follow up PR. The goal here is to unblock release.	10 years ago
James Nugent	fc667b6763	core: Add `make core-test` target	10 years ago
James Nugent	c4c5a0c7d4	Increase acceptance test timeout to 120m from 90m	10 years ago
James Nugent	6d6487e288	Make gofmt errors fail build and add `make fmt` ... We may want to consider requiring `gofmt -s` compliance in future builds, but for now we just use `gofmt`.	10 years ago
James Nugent	54ce59ebdd	Remove release target and document cross-compiling ... Also document the `plugin-dev` and `core-dev` targets.	11 years ago
Philipp Preß	a4c62673ee	Remove redundant -build-toolchain for gox ... Running `make release` on the provided Vagrant machine errors with an error. Removing the `-build-toolchain` fixes it.	11 years ago
James Nugent	13548fcaa2	Add `core-dev` target to Makefile ... This is shorthand to build and install the core of terraform, without touching the providers.	11 years ago
Martin Atkins	3af5552b54	Makefile target to build a single plugin for local testing. ... Often when developing a plugin it's only necessary to rebuild that plugin. Here we add a simple Makefile target that makes that easy: make plugin-dev PLUGIN=provider-aws Since it's only building one package and it's only building for the host architecture, this just uses "go install" directly, rather than using gox as we do when installing multiple packages, possibly for multiple architectures.	11 years ago
Florin Patan	a75ca1e25c	Support go get in go 1.5	11 years ago
Paul Hinze	4a65d83741	maint: Codify a Vagrant-based release process ... * update Vagrantfile to modern Consul-style version * add `make release` for a one-shot command to get from fresh vagrant machine to a built release * add RELEASING.md to document details about the release process	11 years ago
Radek Simko	bb864fb527	Increase default timeout for acceptance tests	11 years ago
Paul Hinze	be2ec7a61a	Makefile: make go vet break the build	11 years ago
Chris Bednarski	a1dd906f2e	Move TEST to end of line	11 years ago
Chris Bednarski	106af364b3	Change the example to something that actually works	11 years ago
Chris Bednarski	7e51225ca9	Tweak some of the makefile help messages for clarity	11 years ago
Jeff Mitchell	996e7ff3e4	Add quickdev option; skips getting dependencies to make repeated builds a bit faster and less network-heavy	11 years ago
Mitchell Hashimoto	e60a614a37	Add cover tasks to test code coverage	11 years ago
Patrick Lucas	bcc85be991	Remove 'go get ... vet' from updatedeps target ... This package attempts to install itself to GOROOT which will fail for non-root users. Most users will have already installed the vet tool via a system package, so it shouldn't be necessary to 'go get' here. Moreover, the 'vet' make target already checks that it is installed before running it, running 'go get' if necessary. This is the output when running 'make updatedeps' as a regular user without this change: ``` $ make updatedeps go get -u github.com/mitchellh/gox go get -u golang.org/x/tools/cmd/stringer go get -u golang.org/x/tools/cmd/vet go install golang.org/x/tools/cmd/vet: open /usr/local/go/pkg/tool/linux_amd64/vet: permission denied make: *** [updatedeps] Error 1 ```	11 years ago
Paul Hinze	b8fb0c0838	Makefile: simplify updatedeps; no need for deplist ... After discussing with the very gracious @cespare over at https://github.com/cespare/deplist/pull/2 I now understand that we can pull off the same logic with just `go list`. The logic is now simpler and more consistent: * List out all packages in our repo * For each of those packages, list their dependencies * Filter out any dependencies that already live in this repo * Remove duplicates * And fetch the rest. `go get` will work out all transitive dependencies from there	11 years ago
Paul Hinze	a764adbf1b	Makefile: new deps strategy fixes deps in branches ... Currently when running `make updatedeps` from a branch, the dependency list from master ends up getting used. We tried to work around this in 35490f7812, and got part way there, but here's what was happening: - record the current SHA - run `go get -f -u -v ./...` which ends up checking out master - master is checked out early in the `go get` process, which means all subsequent dependencies are resolved from master - re-checkout the recorded SHA - run tests This works in most cases, except when the branch being tested actually changes the list of dependencies in some way. Here we move away from letting `go get -v` walk through everything in `./...`, instead building our own list of dependencies with the help of `deplist`. We can then filter terraform packages out from the list, so they don't get touched, and safely update the rest. This should solve problems like those observed in #899 and #900. __Note__: had to add a feature to deplist to make this work properly; see 016ef97111 Working on getting it accepted upstream.	11 years ago
Mitchell Hashimoto	703a11ed7e	Comment Makefile	11 years ago
Paul Hinze	bba3890f32	Makefile: bump test timeout from 10s to 30s ... on a slow internet connection, the BitBucket tests were taking over 10s and panicing the test run	11 years ago
Paul Hinze	f69bdb608c	Makefile: roll gox into updatedeps ... No need to have an extra dev bootstrapping step when we can automate it!	11 years ago
Emil Hessman	65878791c0	Makefile: add vet target ... Add a vet target in order to catch suspicious constructs reported by go vet. Vet has successfully detected problems in the past, for example, see 482460c4c8 fc36b1cd94 68a41035a9 7b704fb77d 4f3f85b165 95fa353ee9 4bfe18b40d Some vet flags are noisy. In particular, the following flags reports a large amount of generally unharmful constructs: -assign: check for useless assignments -composites: check that composite literals used field-keyed elements -shadow: check for shadowed variables -shadowstrict: whether to be strict about shadowing -unreachable: check for unreachable code In order to skip running the flags mentioned above, vet is invoked on a directory basis with 'go tool vet .' since package- level type-checking with 'go vet' doesn't accept flags. Hence, each file is vetted in isolation, which is weaker than package-level type-checking. But nevertheless, it might catch suspicious constructs that pose a real problem. The vet target runs the following flags on the entire repo: -asmdecl: check assembly against Go declarations -atomic: check for common mistaken usages of the sync/atomic package -bool: check for mistakes involving boolean operators -buildtags: check that +build tags are valid -copylocks: check that locks are not passed by value -methods: check that canonically named methods are canonically defined -nilfunc: check for comparisons between functions and nil -printf: check printf-like invocations -rangeloops: check that range loop variables are used correctly -shift: check for useless shifts -structtags: check that struct field tags have canonical format and apply to exported fields as needed -unsafeptr: check for misuse of unsafe.Pointer Now and then, it might make sense to check the output of VETARGS=-unreachable make vet manually, just in case it detects several lines of dead code etc.	11 years ago
Mitchell Hashimoto	a7cad594df	update Makefile to better switch to correct branch on updatedeps	11 years ago
Mitchell Hashimoto	35490f7812	updatedeps should checkout the last checked out branch [GH-816]	11 years ago
Sander van Harmelen	d823db5963	Removed obsolete chars	11 years ago
Sander van Harmelen	7013326c06	Let's clean up Go 1.4 checks... ... No need for these as the project will not build without Go 1.4 anyway now…	11 years ago
Mitchell Hashimoto	5abbde3ac9	config: remove unused files	11 years ago
Mitchell Hashimoto	689cbc8b5b	helper/schema: generate strings for ValueType	11 years ago
Mitchell Hashimoto	d1cae92a62	Update Makefile	11 years ago
Sander van Harmelen	4dd3136ed2	Update Makefile for use with Go 1.4 ... `go get -u` now checks that remote repo paths match the ones predicted by the import paths. So if working on TF from a forked repo, you cannot use `updatedeps` as `go get` will complain about the differences between the import and the path to your fork.	11 years ago
Sander van Harmelen	83c760fcb3	core: refactoring the way sets work internally v2 ... This is a refactored solution for PR #616. Functionally this is still the same change, but it’s implemented a lot cleaner with less code and less changes to existing parts of TF.	12 years ago
Joseph Anthony Pasquale Holsten	fc272d5f5a	quote $(CURDIR) to support $GOPATH with spaces	12 years ago
Mitchell Hashimoto	fde151978e	config/module: parallelize some things	12 years ago
Mitchell Hashimoto	ef51880076	Fix phony in Makefile	12 years ago
Mitchell Hashimoto	04975827ac	Remove all traces of libucl	12 years ago
Mitchell Hashimoto	e166f6ac9c	make clean should remove y.go	12 years ago
Jack Pearkes	7387dd4311	makefile: increase acceptance test timeout	12 years ago
Mitchell Hashimoto	abb94de631	Makefile updatedeps requires libucl	12 years ago
Mitchell Hashimoto	b569a5d8b6	scripts: build script	12 years ago
Mitchell Hashimoto	e00aa13938	Use fork of libucl to control what checkout is used	12 years ago
Mitchell Hashimoto	498600d75f	updatedeps should build the parser	12 years ago
Mitchell Hashimoto	bffdcbaede	Makefile: yacc config before make	12 years ago
Mitchell Hashimoto	d257d3623f	testrace won't run acceptance tests	12 years ago
Mitchell Hashimoto	10146a79b1	Explicitly disable acceptance tests for make test	12 years ago
Mitchell Hashimoto	701634ad5c	Makefile	12 years ago
Mitchell Hashimoto	9d3adc07ca	Add "testacc" target for easy acceptance testing	12 years ago
Mitchell Hashimoto	d970cec8eb	Add testrace	12 years ago
Jack Pearkes	d6fa7f2f6d	quiet the make dev task	12 years ago
Mitchell Hashimoto	00aba6ee87	update README	12 years ago
Mitchell Hashimoto	4c71eb35d8	Makefile can have specific test args	12 years ago
Mitchell Hashimoto	4c865a5169	Add `make dev` to make terraform dev bins	12 years ago
Mitchell Hashimoto	e904fca3da	terraform: Diff!	12 years ago
Mitchell Hashimoto	612f335a74	Add curdir to path so libucl.dll is avail on Windows	12 years ago
Mitchell Hashimoto	7e06b45232	Default Makefile task should be to test	12 years ago
Mitchell Hashimoto	ec3f72703c	Initial work on config	12 years ago