Merge pull request #3440 from ggiamarchi/openstack/idempotency

Fix OpenStack provider idempotency bugs

builtin/providers/openstack/resource_openstack_fw_firewall_v1.go

@@ -40,7 +40,7 @@ func resourceFWFirewallV1() *schema.Resource {
 			"admin_state_up": &schema.Schema{
 				Type:     schema.TypeBool,
 				Optional: true,
-				Default:  true,
+				Computed: true,
 			},
 			"tenant_id": &schema.Schema{
 				Type:     schema.TypeString,

builtin/providers/openstack/resource_openstack_lb_monitor_v1.go

@@ -68,6 +68,7 @@ func resourceLBMonitorV1() *schema.Resource {
 				Type:     schema.TypeString,
 				Optional: true,
 				ForceNew: false,
+				Computed: true,
 			},
 		},
 	}

builtin/providers/openstack/resource_openstack_networking_floatingip_v2.go

@@ -37,7 +37,7 @@ func resourceNetworkingFloatingIPV2() *schema.Resource {
 			"port_id": &schema.Schema{
 				Type:     schema.TypeString,
 				Optional: true,
-				Default:  "",
+				Computed: true,
 			},
 		},
 	}

builtin/providers/openstack/resource_openstack_networking_network_v2.go

@@ -32,6 +32,7 @@ func resourceNetworkingNetworkV2() *schema.Resource {
 				Type:     schema.TypeString,
 				Optional: true,
 				ForceNew: false,
+				Computed: true,
 			},
 			"shared": &schema.Schema{
 				Type:     schema.TypeString,

builtin/providers/openstack/resource_openstack_networking_router_v2.go

@@ -32,6 +32,7 @@ func resourceNetworkingRouterV2() *schema.Resource {
 				Type:     schema.TypeBool,
 				Optional: true,
 				ForceNew: false,
+				Computed: true,
 			},
 			"external_gateway": &schema.Schema{
 				Type:     schema.TypeString,