From f8b77030db2ff8ec8d1994f9ce47cc028f33e168 Mon Sep 17 00:00:00 2001 From: James Bardin Date: Mon, 21 May 2018 19:17:24 -0400 Subject: [PATCH] destroy nodes can't be referenced directly Destroy nodes were being referenced by their regular paths, which was causing cycles in the graphs. Destroy nodes can't be referenced directly in any way, so override the inherited method for a referenceable address. --- terraform/node_resource_destroy.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/terraform/node_resource_destroy.go b/terraform/node_resource_destroy.go index 40864a03a1..e56fb9edef 100644 --- a/terraform/node_resource_destroy.go +++ b/terraform/node_resource_destroy.go @@ -71,6 +71,12 @@ func (n *NodeDestroyResourceInstance) ReferenceableName() []addrs.Referenceable } } +// Destroy nodes can't be directly referenced by anything, so we need to +// override the abstract method. +func (n *NodeDestroyResourceInstance) ReferenceableAddrs() []addrs.Referenceable { + return nil +} + // GraphNodeReferencer, overriding NodeAbstractResource func (n *NodeDestroyResourceInstance) References() []*addrs.Reference { // If we have a config, then we need to include destroy-time dependencies