From dbf6d1bd00cc231e66e647fee49c8ed9d24744a1 Mon Sep 17 00:00:00 2001 From: Paul Hinze Date: Fri, 1 May 2015 11:11:16 -0500 Subject: [PATCH] helper/resource: fix accidentaly swallowing of acctest step errors With #1757 I unwittingly reused an err variable, causing all test check errors to be swallowed. -_- --- helper/resource/testing.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/helper/resource/testing.go b/helper/resource/testing.go index d153f93dc6..e1156422eb 100644 --- a/helper/resource/testing.go +++ b/helper/resource/testing.go @@ -235,8 +235,8 @@ func testStep( // Check! Excitement! if step.Check != nil { - if err = step.Check(state); err != nil { - err = fmt.Errorf("Check failed: %s", err) + if err := step.Check(state); err != nil { + return state, fmt.Errorf("Check failed: %s", err) } }