Added some extra tests for the acl-rules

builtin/providers/cloudstack/resource_cloudstack_network_acl_rule_test.go

@@ -21,7 +21,7 @@ func TestAccCloudStackNetworkACLRule_basic(t *testing.T) {
 				Check: resource.ComposeTestCheckFunc(
 					testAccCheckCloudStackNetworkACLRulesExist("cloudstack_network_acl.foo"),
 					resource.TestCheckResourceAttr(
-						"cloudstack_network_acl_rule.foo", "rule.#", "1"),
+						"cloudstack_network_acl_rule.foo", "rule.#", "3"),
 					resource.TestCheckResourceAttr(
 						"cloudstack_network_acl_rule.foo", "rule.3247834462.action", "allow"),
 					resource.TestCheckResourceAttr(
@@ -53,7 +53,7 @@ func TestAccCloudStackNetworkACLRule_update(t *testing.T) {
 				Check: resource.ComposeTestCheckFunc(
 					testAccCheckCloudStackNetworkACLRulesExist("cloudstack_network_acl.foo"),
 					resource.TestCheckResourceAttr(
-						"cloudstack_network_acl_rule.foo", "rule.#", "1"),
+						"cloudstack_network_acl_rule.foo", "rule.#", "3"),
 					resource.TestCheckResourceAttr(
 						"cloudstack_network_acl_rule.foo", "rule.3247834462.action", "allow"),
 					resource.TestCheckResourceAttr(
@@ -76,7 +76,7 @@ func TestAccCloudStackNetworkACLRule_update(t *testing.T) {
 				Check: resource.ComposeTestCheckFunc(
 					testAccCheckCloudStackNetworkACLRulesExist("cloudstack_network_acl.foo"),
 					resource.TestCheckResourceAttr(
-						"cloudstack_network_acl_rule.foo", "rule.#", "2"),
+						"cloudstack_network_acl_rule.foo", "rule.#", "4"),
 					resource.TestCheckResourceAttr(
 						"cloudstack_network_acl_rule.foo", "rule.3247834462.action", "allow"),
 					resource.TestCheckResourceAttr(
@@ -189,6 +189,22 @@ resource "cloudstack_network_acl" "foo" {
 resource "cloudstack_network_acl_rule" "foo" {
   aclid = "${cloudstack_network_acl.foo.id}"
 
+  rule {
+  	action = "allow"
+    source_cidr = "172.18.100.0/24"
+    protocol = "all"
+    traffic_type = "ingress"
+  }
+
+  rule {
+  	action = "allow"
+    source_cidr = "172.18.100.0/24"
+    protocol = "icmp"
+    icmp_type = "-1"
+    icmp_code = "-1"
+    traffic_type = "ingress"
+  }
+
   rule {
     source_cidr = "172.16.100.0/24"
     protocol = "tcp"
@@ -217,6 +233,22 @@ resource "cloudstack_network_acl" "foo" {
 resource "cloudstack_network_acl_rule" "foo" {
   aclid = "${cloudstack_network_acl.foo.id}"
 
+  rule {
+  	action = "deny"
+    source_cidr = "172.18.100.0/24"
+    protocol = "all"
+    traffic_type = "ingress"
+  }
+
+  rule {
+  	action = "deny"
+    source_cidr = "172.18.100.0/24"
+    protocol = "icmp"
+    icmp_type = "-1"
+    icmp_code = "-1"
+    traffic_type = "ingress"
+  }
+
   rule {
 	  action = "allow"
     source_cidr = "172.16.100.0/24"