Merge pull request #4365 from TimeIncOSS/b-ecs-td-fix

provider/aws: Treat INACTIVE ECS TDs as deleted in acc tests

builtin/providers/aws/resource_aws_ecs_task_definition_test.go

@@ -82,17 +82,19 @@ func testAccCheckAWSEcsTaskDefinitionDestroy(s *terraform.State) error {
 			continue
 		}
 
-		out, err := conn.DescribeTaskDefinition(&ecs.DescribeTaskDefinitionInput{
-			TaskDefinition: aws.String(rs.Primary.ID),
-		})
+		input := ecs.DescribeTaskDefinitionInput{
+			TaskDefinition: aws.String(rs.Primary.Attributes["arn"]),
+		}
 
-		if err == nil {
-			if out.TaskDefinition != nil {
-				return fmt.Errorf("ECS task definition still exists:\n%#v", *out.TaskDefinition)
-			}
+		out, err := conn.DescribeTaskDefinition(&input)
+
+		if err != nil {
+			return err
 		}
 
-		return err
+		if out.TaskDefinition != nil && *out.TaskDefinition.Status != "INACTIVE" {
+			return fmt.Errorf("ECS task definition still exists:\n%#v", *out.TaskDefinition)
+		}
 	}
 
 	return nil