From 887839ce2369a5fc06d81f5aa50e8d2cfaa9e93f Mon Sep 17 00:00:00 2001 From: Paul Hinze Date: Thu, 19 Nov 2015 18:36:00 -0600 Subject: [PATCH] provider/digitalocean: remove relative CNAME test Heard back from DO support: > we require it to be a FQDN for a CNAME record in our DNS system. /cc @paystee, the original author here --- .../resource_digitalocean_record_test.go | 37 ------------------- 1 file changed, 37 deletions(-) diff --git a/builtin/providers/digitalocean/resource_digitalocean_record_test.go b/builtin/providers/digitalocean/resource_digitalocean_record_test.go index 94a0616563..7a4123bd60 100644 --- a/builtin/providers/digitalocean/resource_digitalocean_record_test.go +++ b/builtin/providers/digitalocean/resource_digitalocean_record_test.go @@ -104,43 +104,6 @@ func TestAccDigitalOceanRecord_HostnameValue(t *testing.T) { }) } -// This test fails with: -// -// POST https://api.digitalocean.com/v2/domains/foobar-test-terraform.com/records: -// 422 Data needs to end with a dot (.) -// -// Which seems like a behavior change on the DO API side. Opened support ticket -// #826791 to ask DigitalOcean about this, and we'll comment out the test for -// now. --phinze -/* -func TestAccDigitalOceanRecord_RelativeHostnameValue(t *testing.T) { - var record godo.DomainRecord - - resource.Test(t, resource.TestCase{ - PreCheck: func() { testAccPreCheck(t) }, - Providers: testAccProviders, - CheckDestroy: testAccCheckDigitalOceanRecordDestroy, - Steps: []resource.TestStep{ - resource.TestStep{ - Config: testAccCheckDigitalOceanRecordConfig_relative_cname, - Check: resource.ComposeTestCheckFunc( - testAccCheckDigitalOceanRecordExists("digitalocean_record.foobar", &record), - testAccCheckDigitalOceanRecordAttributesHostname("a.b", &record), - resource.TestCheckResourceAttr( - "digitalocean_record.foobar", "name", "terraform"), - resource.TestCheckResourceAttr( - "digitalocean_record.foobar", "domain", "foobar-test-terraform.com"), - resource.TestCheckResourceAttr( - "digitalocean_record.foobar", "value", "a.b"), - resource.TestCheckResourceAttr( - "digitalocean_record.foobar", "type", "CNAME"), - ), - }, - }, - }) -} -*/ - func TestAccDigitalOceanRecord_ExternalHostnameValue(t *testing.T) { var record godo.DomainRecord