don't explicitly specify defaults in argument parsing

internal/command/arguments/state_replace_provider.go

@@ -45,9 +45,7 @@ type StateReplaceProvider struct {
 // interpretation of the arguments.
 func ParseStateReplaceProvider(args []string) (*StateReplaceProvider, tfdiags.Diagnostics) {
 	var diags tfdiags.Diagnostics
-	rp := &StateReplaceProvider{
-		StateLock: true,
-	}
+	rp := &StateReplaceProvider{}
 
 	cmdFlags := defaultFlagSet("state replace-provider")
 	cmdFlags.BoolVar(&rp.AutoApprove, "auto-approve", false, "skip interactive approval of replacements")

internal/command/arguments/state_replace_provider_test.go

@@ -18,27 +18,20 @@ func TestParseStateReplaceProvider_valid(t *testing.T) {
 		"provider addresses only": {
 			[]string{"hashicorp/aws", "acmecorp/aws"},
 			&StateReplaceProvider{
-				AutoApprove:         false,
-				BackupPath:          "-",
-				StateLock:           true,
-				StateLockTimeout:    0,
-				StatePath:           "",
-				IgnoreRemoteVersion: false,
-				FromProviderAddr:    "hashicorp/aws",
-				ToProviderAddr:      "acmecorp/aws",
+				BackupPath:       "-",
+				StateLock:        true,
+				FromProviderAddr: "hashicorp/aws",
+				ToProviderAddr:   "acmecorp/aws",
 			},
 		},
 		"auto approve": {
 			[]string{"-auto-approve", "hashicorp/aws", "acmecorp/aws"},
 			&StateReplaceProvider{
-				AutoApprove:         true,
-				BackupPath:          "-",
-				StateLock:           true,
-				StateLockTimeout:    0,
-				StatePath:           "",
-				IgnoreRemoteVersion: false,
-				FromProviderAddr:    "hashicorp/aws",
-				ToProviderAddr:      "acmecorp/aws",
+				AutoApprove:      true,
+				BackupPath:       "-",
+				StateLock:        true,
+				FromProviderAddr: "hashicorp/aws",
+				ToProviderAddr:   "acmecorp/aws",
 			},
 		},
 		"all options": {