From 4cc46937e8bc0d4f65cd725d283f5352a507628a Mon Sep 17 00:00:00 2001 From: Joe Topjian Date: Tue, 22 Nov 2016 15:27:23 +0000 Subject: [PATCH] provider/openstack: blockstorage volume attach code review updates --- .../resource_openstack_blockstorage_volume_attach_v2.go | 2 +- .../openstack/r/blockstorage_volume_attach_v2.html.markdown | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/builtin/providers/openstack/resource_openstack_blockstorage_volume_attach_v2.go b/builtin/providers/openstack/resource_openstack_blockstorage_volume_attach_v2.go index 48a6a62d9b..82bdecd29d 100644 --- a/builtin/providers/openstack/resource_openstack_blockstorage_volume_attach_v2.go +++ b/builtin/providers/openstack/resource_openstack_blockstorage_volume_attach_v2.go @@ -16,7 +16,6 @@ func resourceBlockStorageVolumeAttachV2() *schema.Resource { return &schema.Resource{ Create: resourceBlockStorageVolumeAttachV2Create, Read: resourceBlockStorageVolumeAttachV2Read, - Update: nil, Delete: resourceBlockStorageVolumeAttachV2Delete, Importer: &schema.ResourceImporter{ State: schema.ImportStatePassthrough, @@ -233,6 +232,7 @@ func blockStorageVolumeAttachV2AttachMode(v string) (volumeactions.AttachMode, e var attachError error switch v { case "": + attachMode = "" case "ro": attachMode = volumeactions.ReadOnly case "rw": diff --git a/website/source/docs/providers/openstack/r/blockstorage_volume_attach_v2.html.markdown b/website/source/docs/providers/openstack/r/blockstorage_volume_attach_v2.html.markdown index a249426a4f..997abae0bf 100644 --- a/website/source/docs/providers/openstack/r/blockstorage_volume_attach_v2.html.markdown +++ b/website/source/docs/providers/openstack/r/blockstorage_volume_attach_v2.html.markdown @@ -53,6 +53,7 @@ The following arguments are supported: * `attach_mode` - (Optional) Specify whether to attach the volume as Read-Only (`ro`) or Read-Write (`rw`). Only values of `ro` and `rw` are accepted. + If left unspecified, the Block Storage API will apply a default of `rw`. ## Attributes Reference