From 4aa7d4f7dbc2415c0ae4636b036a7e63c3dc492e Mon Sep 17 00:00:00 2001 From: edmundcraske Date: Tue, 22 Mar 2016 12:20:47 +0000 Subject: [PATCH] Fail when weight set and set_identifier not set Resolves https://github.com/hashicorp/terraform/issues/5776 --- builtin/providers/aws/resource_aws_route53_record.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/builtin/providers/aws/resource_aws_route53_record.go b/builtin/providers/aws/resource_aws_route53_record.go index 7fa9aae126..6a3b3733da 100644 --- a/builtin/providers/aws/resource_aws_route53_record.go +++ b/builtin/providers/aws/resource_aws_route53_record.go @@ -468,6 +468,9 @@ func resourceAwsRoute53RecordBuildSet(d *schema.ResourceData, zoneName string) ( w := d.Get("weight").(int) if w > -1 { + if _, ok := d.GetOk("set_identifier"); !ok { + return nil, fmt.Errorf(`provider.aws: aws_route53_record: %s: "set_identifier": required field is not set when "weight" is set`, d.Get("name").(string)) + } rec.Weight = aws.Int64(int64(w)) }