terraform: ResourceAddress should output instance type if set

10 years ago · 407be65cc8
parent 4faa6b37e4
commit 407be65cc8
2 changed files with 10 additions and 6 deletions
--- a/terraform/resource_address.go
+++ b/terraform/resource_address.go
@ -52,11 +52,15 @@ func (r *ResourceAddress) String() string {

 	if r.Name != "" {
 		name := r.Name
-		switch r.InstanceType {
-		case TypeDeposed:
-			name += ".deposed"
-		case TypeTainted:
-			name += ".tainted"
+		if r.InstanceTypeSet {
+			switch r.InstanceType {
+			case TypePrimary:
+				name += ".primary"
+			case TypeDeposed:
+				name += ".deposed"
+			case TypeTainted:
+				name += ".tainted"
+			}
 		}

 		if r.Index >= 0 {
--- a/terraform/resource_address_test.go
+++ b/terraform/resource_address_test.go
@ -50,7 +50,7 @@ func TestParseResourceAddress(t *testing.T) {
 				InstanceTypeSet: true,
 				Index:           2,
 			},
-			"aws_instance.foo[2]",
+			"",
 		},
 		"tainted": {
 			"aws_instance.foo.tainted",