From 2b7fad5bee0798cbc632c7a14a76ad3d05808683 Mon Sep 17 00:00:00 2001
From: Martin Atkins <mart@degeneration.co.uk>
Date: Mon, 17 Jul 2023 12:30:04 -0700
Subject: [PATCH] stackruntime: Our fake telemetry span must be passed by
 pointer

Most of our Span actions don't mutate the object because we just
immediately emit messages to the test log, but SetName directly modifies
the span name so we need to pass by pointer so we can honor that rename.
---
 internal/stacks/stackruntime/telemetry_test.go | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/internal/stacks/stackruntime/telemetry_test.go b/internal/stacks/stackruntime/telemetry_test.go
index 421933847f..6667a05bed 100644
--- a/internal/stacks/stackruntime/telemetry_test.go
+++ b/internal/stacks/stackruntime/telemetry_test.go
@@ -178,7 +178,7 @@ func (t *testLogTracer) Start(ctx context.Context, spanName string, opts ...trac
 		TraceID: fakeTraceIDForTesting,
 		SpanID:  spanID,
 	})
-	span := testLogTraceSpan{
+	span := &testLogTraceSpan{
 		name:        spanName,
 		context:     &spanCtx,
 		t:           t.t,
@@ -210,7 +210,7 @@ type testLogTraceSpan struct {
 	embedded.Span
 }
 
-var _ trace.Span = testLogTraceSpan{}
+var _ trace.Span = (*testLogTraceSpan)(nil)
 
 func (s testLogTraceSpan) log(f string, args ...any) {
 	s.t.Helper()
@@ -263,7 +263,7 @@ func (s testLogTraceSpan) SetAttributes(kv ...attribute.KeyValue) {
 }
 
 // SetName implements trace.Span.
-func (s testLogTraceSpan) SetName(name string) {
+func (s *testLogTraceSpan) SetName(name string) {
 	s.t.Helper()
 	s.log("RENAMED to %s", name)
 	s.name = name