From 028117064511c10fd3648c1e25c1eaed295f9756 Mon Sep 17 00:00:00 2001 From: Martin Atkins Date: Thu, 2 Nov 2023 16:58:24 -0700 Subject: [PATCH] stackeval: Remove stale todo about prior state in plans This TODO was noting that an earlier version of this code was not including any prior state information in the "modules runtime" plan. At the time I wrote the comment I was expecting to handle that here as a separate step, but I later refactored this to include the prior state as part of the returned plan, since that's where the modules runtime expects to find it during the apply phase anyway. This comment is therefore now redundant, because no extra work is required in this location to get the prior state populated. --- internal/stacks/stackruntime/internal/stackeval/main_apply.go | 3 --- 1 file changed, 3 deletions(-) diff --git a/internal/stacks/stackruntime/internal/stackeval/main_apply.go b/internal/stacks/stackruntime/internal/stackeval/main_apply.go index 760544051d..add3f4e032 100644 --- a/internal/stacks/stackruntime/internal/stackeval/main_apply.go +++ b/internal/stacks/stackruntime/internal/stackeval/main_apply.go @@ -103,9 +103,6 @@ func ApplyPlan(ctx context.Context, config *stackconfig.Config, rawPlan []*anypb return nil, nil } - // TODO: We should also turn the prior state into the form - // the modules runtime expects and pass that in here, - // instead of an empty prior state. modulesRuntimePlan, err := componentInstPlan.ForModulesRuntime() if err != nil { // Suggests that the state is inconsistent with the