proxysql

History

Rene Cannao e462bb0cb4 fix: address PR review feedback Resolves in-scope review items on PR #5651. Items deemed out of scope for this PR (O(N) admin dispatch lookup, per-plugin mutex, worker backpressure, runtime-reload DDL semantics, E2E tests going through ProxySQL rather than directly to MySQL) are tracked elsewhere; items that were already fixed in earlier commits on this branch (Admin_Handler MYSQLX alias vectors, Admin_Bootstrap PROXYSQL40 gating) are acknowledged as stale. Changes: * .github/workflows/CI-mysqlx.yml: add `include/` and `src/proxysql_global.cpp` to both `sparse-checkout` blocks. The plugin Makefile discovers the repo root via `src/proxysql_global.cpp` and includes headers from `include/`; without these, `make` inside `plugins/mysqlx` climbs up to `/` or fails on missing includes. (coderabbit: "Checkout the files required by the plugin Makefile.") * .github/workflows/CI-mysqlx.yml: `fail-on-cache-miss` now depends on `github.event_name == 'workflow_run'`. Strict behavior is retained for the cache-driven pipeline that CI-trigger populates; manual `workflow_dispatch` runs no longer fail when the SHA-specific cache doesn't exist yet. (coderabbit: "Don't make manual runs depend on a pre-existing build cache.") * plugins/mysqlx/Makefile: replace the unbounded `while [ ! -f ./src/proxysql_global.cpp ]; do cd ..; done` with a bounded upward walk (up to 12 levels) that fails fast with a clear error message when the marker file is missing — e.g. on a sparse checkout that omits `src/proxysql_global.cpp`. Build output no longer appears to hang indefinitely. (coderabbit: "Prevent root discovery from hanging on sparse or invalid checkouts.") * doc/PLUGIN_API.md: update startup sequence from the old three-phase (load → init → start) description to the four-phase chassis lifecycle (load → register_schemas → admin materialize → init → start). Document the `register_schemas` descriptor field and the `abi_version` / `PROXYSQL_PLUGIN_ABI_VERSION` contract. Clarify that `stop()` pairs with `init()` (not `start()`) for teardown symmetry. (coderabbit: "Update plugin lifecycle documentation to reflect four-phase model and ABI versioning.") * plugins/mysqlx/include/mysqlx_session.h: default-initialize every field in `MysqlxCredentials`. `bool x_enabled` was indeterminate for a default-constructed instance, which would let a lookup miss produce a value that silently authenticates. In-class initializers give every field a deterministic default. (coderabbit: "Default- initialize credential fields used by auth decisions.") * plugins/mysqlx/src/mysqlx_backend_session.cpp: close `backend_fd_` when `authenticate_backend()` returns false. Previously `connect()` stored the newly-opened fd in `backend_fd_` and returned the auth result; a retry on the same `MysqlxBackendSession` would then overwrite `backend_fd_` and leak the previous socket. (coderabbit: "Close/reset `backend_fd_` when authentication fails.") * lib/Admin_Bootstrap.cpp: `materialize_plugin_tables()` now runs DDL only for the subset of plugin-declared tables that were freshly inserted into `tables_defs_` (the rest are already materialized). DDL failures are startup-fatal: on `execute()` returning false, log the plugin kind + table name + SQL and `exit(EXIT_FAILURE)`. A partially materialized schema produces opaque runtime errors from the plugin later on, so aborting startup is the right default. (gemini + coderabbit: "Execute DDL only for newly materialized plugin tables" / "add error checking".) Not changed in this commit (deferred / out of scope / stale): CI-mysqlx E2E tests going through ProxySQL (requires plumbing listener + admin config in the CI workflow). * O(N) admin dispatch scan → hash map. * Descriptor build-id hash for libstdc++ compat detection. * Per-plugin mutex on mutable plugin context. * Worker client-fd enqueue backpressure. * Stale plan-doc feedback on docs/superpowers/plans/.md. Verification (clean tree): `unset PROXYSQL; make cleanall && make debug -j$(nproc) && make build_tap_test_debug -j$(nproc)` -- 0 errors. `PROXYSQLGENAI=1 make cleanall && PROXYSQLGENAI=1 make debug -j$(nproc) && PROXYSQLGENAI=1 make build_tap_test_debug -j$(nproc)` -- 0 errors. * Plugin unit tests (PROXYSQL40): 48 + 52 + 26 + 46 + 10 = 182 pass.	1 month ago
..
mysqlx	fix: address PR review feedback	1 month ago

Rene Cannao e462bb0cb4 fix: address PR review feedback

Resolves in-scope review items on PR #5651.  Items deemed out of scope
for this PR (O(N) admin dispatch lookup, per-plugin mutex, worker
backpressure, runtime-reload DDL semantics, E2E tests going through
ProxySQL rather than directly to MySQL) are tracked elsewhere; items
that were already fixed in earlier commits on this branch (Admin_Handler
MYSQLX alias vectors, Admin_Bootstrap PROXYSQL40 gating) are
acknowledged as stale.

Changes:

* .github/workflows/CI-mysqlx.yml: add `include/` and
  `src/proxysql_global.cpp` to both `sparse-checkout` blocks.  The
  plugin Makefile discovers the repo root via
  `src/proxysql_global.cpp` and includes headers from `include/`;
  without these, `make` inside `plugins/mysqlx` climbs up to `/` or
  fails on missing includes.  (coderabbit: "Checkout the files
  required by the plugin Makefile.")

* .github/workflows/CI-mysqlx.yml: `fail-on-cache-miss` now depends on
  `github.event_name == 'workflow_run'`.  Strict behavior is retained
  for the cache-driven pipeline that CI-trigger populates; manual
  `workflow_dispatch` runs no longer fail when the SHA-specific cache
  doesn't exist yet.  (coderabbit: "Don't make manual runs depend on a
  pre-existing build cache.")

* plugins/mysqlx/Makefile: replace the unbounded
  `while [ ! -f ./src/proxysql_global.cpp ]; do cd ..; done` with a
  bounded upward walk (up to 12 levels) that fails fast with a clear
  error message when the marker file is missing — e.g. on a sparse
  checkout that omits `src/proxysql_global.cpp`.  Build output no
  longer appears to hang indefinitely.  (coderabbit: "Prevent root
  discovery from hanging on sparse or invalid checkouts.")

* doc/PLUGIN_API.md: update startup sequence from the old
  three-phase (load → init → start) description to the four-phase
  chassis lifecycle (load → register_schemas → admin materialize →
  init → start).  Document the `register_schemas` descriptor field
  and the `abi_version` / `PROXYSQL_PLUGIN_ABI_VERSION` contract.
  Clarify that `stop()` pairs with `init()` (not `start()`) for
  teardown symmetry.  (coderabbit: "Update plugin lifecycle
  documentation to reflect four-phase model and ABI versioning.")

* plugins/mysqlx/include/mysqlx_session.h: default-initialize every
  field in `MysqlxCredentials`.  `bool x_enabled` was indeterminate
  for a default-constructed instance, which would let a lookup miss
  produce a value that silently authenticates.  In-class initializers
  give every field a deterministic default.  (coderabbit: "Default-
  initialize credential fields used by auth decisions.")

* plugins/mysqlx/src/mysqlx_backend_session.cpp: close
  `backend_fd_` when `authenticate_backend()` returns false.
  Previously `connect()` stored the newly-opened fd in `backend_fd_`
  and returned the auth result; a retry on the same
  `MysqlxBackendSession` would then overwrite `backend_fd_` and
  leak the previous socket.  (coderabbit: "Close/reset `backend_fd_`
  when authentication fails.")

* lib/Admin_Bootstrap.cpp: `materialize_plugin_tables()` now runs DDL
  only for the subset of plugin-declared tables that were freshly
  inserted into `tables_defs_*` (the rest are already materialized).
  DDL failures are startup-fatal: on `execute()` returning false,
  log the plugin kind + table name + SQL and `exit(EXIT_FAILURE)`.
  A partially materialized schema produces opaque runtime errors from
  the plugin later on, so aborting startup is the right default.
  (gemini + coderabbit: "Execute DDL only for newly materialized
  plugin tables" / "add error checking".)

Not changed in this commit (deferred / out of scope / stale):
* CI-mysqlx E2E tests going through ProxySQL (requires plumbing
  listener + admin config in the CI workflow).
* O(N) admin dispatch scan → hash map.
* Descriptor build-id hash for libstdc++ compat detection.
* Per-plugin mutex on mutable plugin context.
* Worker client-fd enqueue backpressure.
* Stale plan-doc feedback on docs/superpowers/plans/*.md.

Verification (clean tree):
* `unset PROXYSQL*; make cleanall && make debug -j$(nproc) &&
  make build_tap_test_debug -j$(nproc)` -- 0 errors.
* `PROXYSQLGENAI=1 make cleanall && PROXYSQLGENAI=1 make
  debug -j$(nproc) && PROXYSQLGENAI=1 make build_tap_test_debug
  -j$(nproc)` -- 0 errors.
* Plugin unit tests (PROXYSQL40): 48 + 52 + 26 + 46 + 10 = 182 pass.

mysqlx

fix: address PR review feedback