proxysql

History

Rene Cannao 76aafdac67 fix(mysqlx): harden check_connect() poll and getsockopt handling Addresses the coderabbitai outside-diff finding originally surfaced on PR #5641: the previous check_connect() conflated poll() errors with timeouts, never retried on EINTR, did not check getsockopt()'s return, and accepted POLLNVAL / POLLERR / POLLHUP as though they were normal "not ready" states. The practical failure mode was slow and misleading: a fatal poll error or a bad descriptor was masked as "not ready yet" until the outer connect_timeout_ms_ (default 10s) elapsed, at which point the session reported a generic "connect failed" reason rather than the actual cause. A concurrent signal (EINTR) would extend that masked window further. Meanwhile, a failing getsockopt() with an uninspected return would leave `err` at its initializer value of 0 and optimistically transition the state machine to AUTHENTICATING, so the very next read or write on the invalid fd would fail in a less diagnostic path. What changed: - poll() is now retried on EINTR. - poll() returning -1 sets ERROR_STATE and returns -1 immediately. - POLLNVAL / POLLERR / POLLHUP in revents are treated as hard errors even if POLLOUT is also set, since the underlying socket is already in a terminal async condition. - getsockopt() return is checked; a nonzero return is now a hard error rather than a silent state advance. Testing: three new assertions in mysqlx_robustness_unit-t.cpp exercise the bad-fd error path, the happy-path connect, and the not-ready timeout path. Plan count 33 → 42. Out of scope: other poll() sites in the mysqlx plugin (the unit test helpers at the top of mysqlx_robustness_unit-t.cpp have their own poll() loops but they aren't on the backend-connect critical path); the connect_timeout_ms_ check itself, which is unchanged. Pre-existing ripple: same Makefile link-gap fix as earlier PRs — adds mysqlx_config_store.cpp to the mysqlx_robustness_unit-t link line so MysqlxConfigStore::resolve_identity() resolves when the binary links.	1 month ago
..
mysqlx	fix(mysqlx): harden check_connect() poll and getsockopt handling	1 month ago

Rene Cannao 76aafdac67 fix(mysqlx): harden check_connect() poll and getsockopt handling

Addresses the coderabbitai outside-diff finding originally surfaced on
PR #5641: the previous check_connect() conflated poll() errors with
timeouts, never retried on EINTR, did not check getsockopt()'s return,
and accepted POLLNVAL / POLLERR / POLLHUP as though they were normal
"not ready" states.

The practical failure mode was slow and misleading: a fatal poll error
or a bad descriptor was masked as "not ready yet" until the outer
connect_timeout_ms_ (default 10s) elapsed, at which point the session
reported a generic "connect failed" reason rather than the actual
cause. A concurrent signal (EINTR) would extend that masked window
further. Meanwhile, a failing getsockopt() with an uninspected return
would leave `err` at its initializer value of 0 and optimistically
transition the state machine to AUTHENTICATING, so the very next read
or write on the invalid fd would fail in a less diagnostic path.

What changed:
- poll() is now retried on EINTR.
- poll() returning -1 sets ERROR_STATE and returns -1 immediately.
- POLLNVAL / POLLERR / POLLHUP in revents are treated as hard errors
  even if POLLOUT is also set, since the underlying socket is already
  in a terminal async condition.
- getsockopt() return is checked; a nonzero return is now a hard error
  rather than a silent state advance.

Testing: three new assertions in mysqlx_robustness_unit-t.cpp exercise
the bad-fd error path, the happy-path connect, and the not-ready
timeout path. Plan count 33 → 42.

Out of scope: other poll() sites in the mysqlx plugin (the unit test
helpers at the top of mysqlx_robustness_unit-t.cpp have their own
poll() loops but they aren't on the backend-connect critical path);
the connect_timeout_ms_ check itself, which is unchanged.

Pre-existing ripple: same Makefile link-gap fix as earlier PRs — adds
mysqlx_config_store.cpp to the mysqlx_robustness_unit-t link line so
MysqlxConfigStore::resolve_identity() resolves when the binary links.

mysqlx

fix(mysqlx): harden check_connect() poll and getsockopt handling