You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Rene Cannao 29402b4a42 docs(plugins/genai): close 3 small gaps from review ... # 1. Real prepared statement in local_proxy_endpoint.cpp read_global_variable's comment claimed "Parameterised lookup via prepared statement" but the implementation did string concatenation: "SELECT variable_value FROM main.global_variables WHERE variable_name='" + std::string(var_name) + "'" Today's only callers pass hardcoded "mysql-interfaces" / "pgsql-interfaces", so the SQL injection surface is zero — but the comment is a footgun for the next caller and we have a working prepare_v2 / bind_text pattern right next door in plugin_main.cpp. Replace with the proper prepared-statement form using proxy_sqlite3_step + proxy_sqlite3_column_text; semantics (empty-string on miss / error) are unchanged. # 2. Concurrency contract on genai_refresh_runtime_components The function (introduced in 9e4244321) tears down and reinitialises GloGATH and GloAI in place — with no rwlock around either global. Today it's called from: 1. genai_start (single-threaded, no traffic) — always safe 2. LOAD GENAI VARIABLES TO RUNTIME admin command — racy with active MCP listener / tool-handler threads 3. LOAD GENAI VARIABLES FROM CONFIG — same as (2) Document the contract honestly in the header: caller must guarantee no concurrent dereference of GloGATH/GloAI; today the practical mitigation is operator-side (quiesce traffic before issuing the LOAD). A proper rwlock around all GloGATH/GloAI consumers is a follow-up — too large for this PR's scope, requires audit of every listener/tool-handler reader. # 3. New plugins/genai/README.md The plugin is now ~30 source files spanning the MCP listener, GenAI worker pool, AI features manager, anomaly detector, schema discovery cache, FTS index, vector storage, LLM bridge, and 9 tool handlers — with no single doc explaining what it owns or how to operate it. Mirror the plugins/mysqlx pattern: a one-page README covering scope, building, loading, lifecycle, admin SQL surface, configuration pointer, observability, concurrency contract, testing, and known gaps. Cross-references doc/MCP/ and doc/LLM_Bridge/ for the deeper subsystem-internal documentation that already exists.		2 months ago
..
AI_Features_Manager.h	feat(plugins/genai): Step 5 — move GenAI/LLM/AI surface into the plugin	2 months ago
AI_Tool_Handler.h	feat(plugins/genai): Step 5 — move GenAI/LLM/AI surface into the plugin	2 months ago
AI_Vector_Storage.h	feat(plugins/genai): Step 6 — move RAG/Vector/discovery surface into the plugin	2 months ago
Admin_Tool_Handler.h	feat(plugins/genai): Step 4.C — move MCP subsystem into the plugin	2 months ago
Anomaly_Detector.h	feat(genai): Step 3 — carve Anomaly_Detector out of core into plugins/genai/	2 months ago
Cache_Tool_Handler.h	feat(plugins/genai): Step 4.C — move MCP subsystem into the plugin	2 months ago
Config_Tool_Handler.h	feat(plugins/genai): Step 4.C — move MCP subsystem into the plugin	2 months ago
Discovery_Schema.h	feat(plugins/genai): Step 6 — move RAG/Vector/discovery surface into the plugin	2 months ago
GenAI_Thread.h	feat(plugins/genai): Step 5 — move GenAI/LLM/AI surface into the plugin	2 months ago
LLM_Bridge.h	feat(plugins/genai): Step 5 — move GenAI/LLM/AI surface into the plugin	2 months ago
MCP_Endpoint.h	feat(plugins/genai): Step 4.C — move MCP subsystem into the plugin	2 months ago
MCP_Thread.h	fix(plugins/genai): blocker fixes from PR-#5701 review	2 months ago
MCP_Tool_Handler.h	feat(plugins/genai): Step 7 — drop PROXYSQLGENAI from core build	2 months ago
MySQL_Catalog.h	feat(plugins/genai): Step 6 — move RAG/Vector/discovery surface into the plugin	2 months ago
MySQL_FTS.h	feat(plugins/genai): Step 4.C — move MCP subsystem into the plugin	2 months ago
MySQL_Tool_Handler.h	feat(plugins/genai): Step 4.C — move MCP subsystem into the plugin	2 months ago
Observe_Tool_Handler.h	feat(plugins/genai): Step 4.C — move MCP subsystem into the plugin	2 months ago
PgSQL_Static_Harvester.h	feat(plugins/genai): Step 6 — move RAG/Vector/discovery surface into the plugin	2 months ago
ProxySQL_MCP_Server.hpp	feat(plugins/genai): Step 4.C — move MCP subsystem into the plugin	2 months ago
Query_Tool_Handler.h	feat(plugins/genai): Step 4.C — move MCP subsystem into the plugin	2 months ago
RAG_Tool_Handler.h	feat(plugins/genai): Step 5 — move GenAI/LLM/AI surface into the plugin	2 months ago
Static_Harvester.h	feat(plugins/genai): Step 6 — move RAG/Vector/discovery surface into the plugin	2 months ago
Stats_Tool_Handler.h	feat(plugins/genai): Step 4.C — move MCP subsystem into the plugin	2 months ago
backend_client.h	feat(plugins/genai): Step 4.B — add backend_client helper for local-proxy connections	2 months ago
genai_plugin.h	docs(plugins/genai): close 3 small gaps from review	2 months ago