proxysql

History

Rene Cannao 638d33bf96 test: fix two false-positive failures unmasked by recent CI Two distinct test bugs, same kind of mistake: assuming the absence of one specific external signal in a fixed time window. Both are purely test-side -- the proxy code under test is correct. 1. reg_test_oversize_first_pkt-t (legacy-g7, mysql84-g7) ----------------------------------------------------- `peer_closed_within()` polled once, recv'd once, and concluded "peer is still talking" if any bytes came back. That works for PgSQL (server stays silent until the client sends StartupMessage) but fails for MySQL: ProxySQL emits its ~80-byte Initial Handshake Packet immediately on accept, so by the time the helper polls the client socket those bytes are already in the recv buffer. recv() returned them with n>0, the helper returned 0 (not closed), and all four MySQL probes failed with closed=0 -- even though the proxysql.log clearly shows the security-fix bound check ("Oversized first packet... Closing fd=...") firing for every probe and shut_soft() being called. Replace the single-shot poll/recv with a drain-and-re-poll loop bounded by a steady_clock deadline. The helper now returns 1 only when it observes EOF (recv == 0) or a non-EAGAIN error (RST). Bytes that arrive without an accompanying close are drained and we keep polling until either close or the deadline. This keeps the test's contract intact (3-second timeout for the peer to close after we send an oversized header) while correctly handling server-initiated greeting traffic that exists in some protocols but not others. 2. pgsql-test_dns_cache-t (legacy-g4) ---------------------------------- Step 8's assertion `MySQL_Monitor_dns_cache_queried` stays unchanged during a 4-5 s PgSQL-only window was ~40% flaky. Root cause: that counter is bumped by the MySQL Monitor's own DNS resolver loop -- mysql-monitor_local_dns_cache_refresh_interval defaults to 60 s and on each tick the loop iterates every hostname in mysql_servers UNION proxysql_servers. A 4-5 s window sometimes catches one tick (counter goes up by N hostnames) and sometimes catches zero (counter stays flat). The failing run showed 407 -> 411 (+4 = one tick covering four hostnames). The substantive isolation guarantee is "PgSQL activity does not mutate MySQL DNS cache state", which is already covered by the sibling assertion on MySQL_Monitor_dns_cache_record_updated (records are not added or refreshed by the background loop unless hostnames actually change). Drop the noisy queried-counter assertion and adjust the plan from 17 to 16. Alternatives considered: (a) disable mysql-monitor_local_dns_cache for the duration of the test -- doesn't reliably remove in-flight resolver-queue items so the race still exists, (b) widen the tolerance -- still timing-dependent. Removing the assertion is the cleanest, and the long comment in the test explains the why so the next reader does not re-add it. Neither fix touches the security fix (GHSA-58ww-865x-grpr) nor any proxy code; the bound checks in lib/mysql_data_stream.cpp:678 and lib/PgSQL_Data_Stream.cpp:547 fire correctly and identically on both protocols. Verified by reading proxysql.log from a failing run -- all 8 "Oversized first packet... Closing fd=" lines are present.		1 month ago
..
deprecated	…
groups	test(groups): swap pp1_unknown_spoof / proclist_use_after_free to fix sort order	1 month ago
noise	…
tap	test(framework): remove skip_all() — fail loudly on missing preconditions	1 month ago
test_helpers	feat(plugins/genai): Step 5 — move GenAI/LLM/AI surface into the plugin	2 months ago
tests	test: fix two false-positive failures unmasked by recent CI	1 month ago
tests_with_deps	fix(test): deprecate_eof_cache-t SIGABRT on Galera + helper ABI bug (#5781 )	2 months ago
Makefile	…
NOISE_TESTING.md	…
README.md	…
constants	…

README.md

Folder structure

tap: Contains TAP helper library for testing, and general utilities used across all tests.
tests: General test folder for either unitary or functional tests.
tests_with_deps: Test folder that holds all the tests that require special dependencies for being build.
tests_grp_*: tap test groups of specific tests with special configs applied via
- pre-tests_grp_*.bash script run before tests
- pre-tests_grp_*.sql script run before tests
- post-tests_grp_*.bash script run after tests
- post-tests_grp_*.sql script run after tests

example test group tests_grp_mytests can be created by

TG='mytests'
mkdir -p test/tap/tests_grp_$TG
cd test/tap/tests_grp_$TG
for T in $(ls -1 ../tests/); do ln -fsT ../tests/$T $T; done
cat > pre-test_grp_$TG-proxysql.sql << EOF
# run this test group with:
SET mysql-multiplexing='false';
LOAD MYSQL VARIABLES TO RUNTIME;
SAVE MYSQL VARIABLES TO DISK;
EOF